Cleanup POLICY-SDK-APP CheckPDP

Fixed sonar issues and added a small amount of code coverage.

CheckPDP was renamed to comply with 2 consecutive capital letters. Various
sonar issues done.
Very difficult to get coverage on remaining area - over 82% anyway.

RESTfulPAPEngine was updated to use the new renamed class and methods.
Sonar issues were taken care of for the most part and added some coverage
by consolidating the JUnit tests.

Added in assertj as we will utilize that more throughout the repo.

Issue-ID: POLICY-2133
Change-Id: Id0a9b050ebe373e155878699366d78df71bd0554
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Use lombok for data objects

Removing lines to see if this will bump coverage. Some sonar
for Junit tests and missing coverage.

My next task will be to re-use some of this duplicate code
for these object types and the controllers.

Trailing spaces for patch #3.

Issue-ID: POLICY-2133
Change-Id: Iaee123c6be4b63bd831172340709fe7597feaa78
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Format java POLICY-SDK-APP"

Format java POLICY-SDK-APP

As a result of doing command maven reformat, these files are
now changed.

Updated licenses.

Issue-ID: POLICY-2133
Change-Id: I19a8dd70eb10c0d879b97635f7780ab7f92a1753
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Remove unused vars and methods

Removed unused variables and unused methods.
Removed empty ';' statements.
Combined if's that had no content.

Not doing any formatting for javascript right now.

Licenses.

Issue-ID: POLICY-2134
Change-Id: Ib5ec178bd34154281509f57ed15f704e26101f05
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Update standalone legacy policy UI recipe

Issue-ID: PORTAL-760
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I02c96873768660403b86db736cb3762d0ff8f5ff
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Use snapshot version of models in policy/engine

Change-Id: I7c8ba1ed700a6a0c9e9017a19ab80ef510719bf4
Issue-ID: POLICY-2065
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump versions in policy/engine master

Also added default branch to .gitreview to facilitate branching in
the future.
Switched internal properties to use snapshot versions of other
repos per review comment.

Change-Id: I23d71e67051d88cfaa07adc15e2d143289269027
Issue-ID: POLICY-2045
Signed-off-by: Jim Hahn <jrh3@att.com>

Release policy/engine 1.5.2

Official El Alto release 1.5.2

Issue-ID: POLICY-2045
Change-Id: I29e5b47530fe6a8e02891b0c5b1f15a09e1d332f
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Upgrade to portal 2.6.0 release

Portal released 2.6.0

Issue-ID: POLICY-2045
Change-Id: I36537fca916be71a76e36f87ede0757397883b4b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Upgrade to released artifacts

Released parent, common and models

Issue-ID: POLICY-2045
Change-Id: If26bd3e22f43396e61a53626b72d0d3e9d6bf5fb
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Change AlertSeverity to Severity in policy/engine"

Merge "Documentation: Legacy APIs"

Documentation: Legacy APIs

Identified the offered apis under platform as legacy

Issue-ID: POLICY-1984

Change-Id: Iee46ded3e506a91181b1c18e1618d4509b8f8f90
Signed-off-by: Saryu Shah <ss3917@att.com>

Change AlertSeverity to Severity in policy/engine

Updated logback xml files, replacing AlertSeverity with Severity.
Also fixed some spacing issues.

Change-Id: I3e4b9163d5d897fe4402028b69c741f497aecfc5
Issue-ID: POLICY-1989
Signed-off-by: Jim Hahn <jrh3@att.com>

Additional Changes for Portal SDK 2.6.0 upgrade

- Modified policyEditor.html to upgrade the angular version to
1.4.13 which is compatible with 2.6.0 SDK
- Created new sql script file for Portal db table upgrades in
2.5.0 and 2.6.0
- Modified top level pom to upgrade springframework version to
4.3.24

Change-Id: I5f6e719a2f57891a1b2b76312f446211b6b60abd
Issue-ID: POLICY-1539
Signed-off-by: Michael Mokry <michael.mokry@att.com>

Portal SDK upgrade to 2.6.0 in policy engine

- Modified poms to upgrade epsdk dependency from 2.4.0 to
2.6.0-SNAPSHOT
        - Work in progress, still needs to be tested in the lab

Change-Id: I5c7df08ed84ef12824d4fdc2ef6f578d6dce7488
Issue-ID: POLICY-1539
Signed-off-by: Michael Mokry <michael.mokry@att.com>

Fix license on updated engine files

Address review comment about license date on updated junits.

Change-Id: I5dd6e47be243d6f0d5a001cb5cfb45e7ac31f9c8
Issue-ID: POLICY-1937
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Remove powermock to increase coverage"

update keystore

Issue-ID: POLICY-1988
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Icb0b5af7aa63516f82917245083834cacd8caed4
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Remove powermock to increase coverage

Removed powermock from the junit tests of these classes to increase
reported sonar coverage:
  RESTfulPAPEngine
  BrmsGateway

Typically added override methods to the classes under test, to replace
the overrides originally provided by powermock.

Also needed to add code to RESTfulPAPEngineTest to clear the XACML
properties before the test ran.  Modified to use the existing
XACMLProperties.reloadProperties() method.

Also modified PolicyNotificationMailTest to use a host/port that
has no listener so that the test runs faster.

Fixed some newly introduced sonar issues.

Change-Id: I65e36b01e9506987032eb21baac808ed3dfd4f47
Issue-ID: POLICY-1937
Signed-off-by: Jim Hahn <jrh3@att.com>

Upgrade elastic search to 6.8.2

Clearing security issues - there are no workarounds.

Issue-ID: POLICY-2005
Change-Id: I4deb0c1a42c507e1af6d99f24f4f973ab40217a1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Updated policy/engine GUI springframework

- Modified springframework dependencies version in poms to 4.3.24.RELEASE in ONAP-SDK-APP and POLICY-SDK-APP

Change-Id: I149ed2454e7a899b929f179bf46b80190b3bc80c
Issue-ID: POLICY-1539
Signed-off-by: Michael Mokry <michael.mokry@att.com>

Merge "Fix issue for policies not loading on GUI push tab"

Fix issue for policies not loading on GUI push tab

- found the problem to be with a line of code to add all the
scopes from the role to a Set of scopes.  when the scopes
attribute in the role object is null it logs an exception and
fails to load policies.  I added a new method to check the value
of the roles.getScopes() for null and only attempt to add the
scope to the set if it is not null

- I created a separate method to do this in order to avoid an
increase in technical debt as it would have added to the
complexity if I kept it in the same method.

- PATCH 4: Added scopes to the method arguments in order to
avoid overwriting scopes that are added in prevous interations
of the loop.

- PATCH 5: removed redundant scopes assignment per Jorge's
review.

Change-Id: Ifcc8775d3db8ecc722ee6806310a58ecb4e15856
Issue-ID: POLICY-1981
Signed-off-by: Michael Mokry <michael.mokry@att.com>

Review maven dependency for snakeyaml

Remove explicit version for snakeyaml maven dependency and inherit it
from integration parent artifact.

Upgrade snakeyaml to latest 1.24 version.

Issue-ID: POLICY-1603
Signed-off-by: Bruno Sakoto <bruno.sakoto@bell.ca>
Change-Id: I93978f963dc37260e0fc4d153c92c7da8db0005d

Bump version of policy/engine

Change-Id: I77e7483bcecbc19d9a5a93087fd4c674aa898b52
Issue-ID: POLICY-1965
Signed-off-by: Jim Hahn <jrh3@att.com>

Add release 1.5.1 file

Issue-ID: POLICY-1953
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ief5e6342b4f24cf594b3bc6456be8a526c214bb8

Update to latest common/models released versions

policy/models: 2.1.2
policy/common: 1.5.1

Change-Id: Ifa72ed573fb7685710c7288da6fd16ffe6ea397f
Issue-ID: POLICY-1953
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Expand AAF_NS to onap.org.osaaf.aaf

Change-Id: I19f284842976ca5e27e5baaa3f21a229ef18ec04
Issue-ID: POLICY-1959
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Add lombok.config to policy/engine

This prevents sonar from checking lombok annotations for code coverage.

Change-Id: Ia0164c0dd1adf746ef5fbac156fc44e17c424ed3
Issue-ID: POLICY-1938
Signed-off-by: Jim Hahn <jrh3@att.com>

Javascript now required for code coverage

For El Alto, it is now required to pull coverage of Javascript
code.

Issue-ID: POLICY-1928
Change-Id: If1c0c2ba795b7a8f5faf69ab32ffbb953c411f78
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Fix policy/engine due to sonar changes in common

Fixed breakages due to changes made in policy/common to satisfy
sonar.

Change-Id: I88090c7549ba19f9eb45fae311e8811e39f30318
Issue-ID: POLICY-1791
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump engine 1.5.1-SNAPSHOT

Released 1.5.0

Fixed compilation issue related with version upgrade of
policy/common.

Issue-ID: POLICY-1737
Change-Id: Ib2f56e8ffcb4b399dbe4a5453b70da10b0f87985
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Adding logging to JUnit"

Fix centos build issue

Seeing this when trying to build in centos:
  10:04:12 [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0,
    Time elapsed: 0.459 s - in
    org.onap.policy.pap.ia.DbAuditCompareEntriesTest
  10:04:12 [INFO]
  10:04:12 [INFO] Results:
  10:04:12 [INFO]
  10:04:12 [ERROR] Failures:
  10:04:12 [ERROR]   XACMLPAPTest.testDummy:907
  10:04:12 [ERROR] Errors:
  10:04:12 [ERROR]   XACMLPAPTest.getDictionary:886 » NullPointer
...

Modified the junit test(s) to create the JPA entities needed
by integrity audit, which is what was causing the above issues.

Change-Id: I405798a1946d377770529a99210a1cc57390667f
Issue-ID: POLICY-1737
Signed-off-by: Jim Hahn <jrh3@att.com>

Adding logging to JUnit

Turning on logging.

Issue-ID: POLICY-1876
Change-Id: I82b04609a07f5d33c88c3e0068959de1e628cb38
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Remove docker scripts

These are no longer needed as we are now doing the docker
maven plugin due to global-jjb changes.

Issue-ID: POLICY-1737
Change-Id: I98e8f2a16a66cfe210ddcdf0c50cb55bdebfd687
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Remove trafficgenerator from dependency.json

This jar does not exist and breaks brmsgw when generating
the amsterdam archetype.

Update the dependency.json for local testing.

Issue-ID: POLICY-1872
Change-Id: I5851462ea39c56693284854b5cd1d2cb5dd1dcdd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Upgrade to released common & models

Released common 1.5.0 and models 2.1.0

Issue-ID: POLICY-1737
Change-Id: Iecbf38e57a71907f320e3c8da55a6921ca371c44
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Upgrade to release 3.0.0 parent"

Upgrade to release 3.0.0 parent

Policy/parent is released

Issue-ID: POLICY-1737
Change-Id: I58d8a74f85a6bbc7499614093e7f0d73c54f95ed
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Improved tests performance

* used mock instead of waiting till dmaap client fails
* creating in memory DB only once

Issue-ID: POLICY-1671
Change-Id: Ia1b6ce7ddad1bce0d17c2dbf14f3d82dd237673b
Signed-off-by: Krysiak Adam <adam.krysiak@nokia.com>

Fix compile issue with guard

Due to sonar changes in policy/models for guard.

Issue-ID: POLICY-1791
Change-Id: I2cdbe6d0e4ee8bad05b9d3bb1a83e82d4851973c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Use io.fabric8:docker-maven-plugin to build and push docker images

Issue-ID: POLICY-969
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: Ic4fcec72d494df0a6e067aa353be49936136518c

Remove nexus staging plugin

Unused

Issue-ID: POLICY-1737
Change-Id: I3e287ecbca9707d04f566295ebc5d0d430980d81
Signed-off-by: pdragosh <pdragosh@research.att.com>

Fix header and remove link

Missing and remove outdated installation instructions.

Issue-ID: POLICY-1676
Change-Id: I8b27752bc05039d43a2fbbf22e7388d55469b5a7
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Reference policy/parent for latest doc

Point to new documentation.

Issue-ID: POLICY-1676
Change-Id: I1a3e9a7f1147885c8de72a725c8637a86cd5eb7c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
(cherry picked from commit 6b6cb44dd9f60df943c31188ec68a25852c0200b)

Bump engine to version 1.5.0

Fixed license date.

Change-Id: I711fb4e91afdb3813bc04b16265f584d80ac8e5d
Issue-ID: POLICY-1747
Signed-off-by: Jim Hahn <jrh3@att.com>

Remove release notes

Now being stored in the policy/parent repo.

Issue-ID: POLICY-1769
Change-Id: Ib6ffc9c94150ef73734afededce37a94463479de
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Document fixed OJSI-184 vulnerability"

Merge "Document fixed OJSI-118 vulnerability"

Merge "Document fixed OJSI-157 vulnerability"

Merge "Document fixed OJSI-117 vulnerability"

Merge "Improve security release notes"

Merge "Updates to Dublin release notes"

Document fixed OJSI-184 vulnerability

Issue-ID: OJSI-184
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I5537c217414f6fa1d0b6659360c53f9cef18097a

Document fixed OJSI-118 vulnerability

Issue-ID: OJSI-118
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I0e8953a7a94bf4c28cc85aa239c2b88d96df18a6

Document fixed OJSI-157 vulnerability

Issue-ID: OJSI-157
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I5ea4c15ad2a91b11619998c61088abc352321c7d

Document fixed OJSI-117 vulnerability

Issue-ID: OJSI-117
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ieda7ccc170a50de63bcbfce311f83002acb4a0cf

Improve security release notes

In order to provide users with more details of project's state in
terms of security let's divide the security release notes into three
sections:

- Fixed Security Issues
  Contains a list of security fixes merged during this
  release (especially those reported via OJSI tickets).

- Known Security Issues
  Contains a list of vulnerabilities detected in project during
  release which have not been fixed yet and thus should be mitigated
  by the user.

- Known Vulnerabilities in Used Modules
  Contains information about NexusIQ scan results

Issue-ID: SECCOM-238
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: I9134ae41c40db83fa3b4870341a8880e2bdcbdda

Updates to Dublin release notes

Updates to Dublin release notes
-------------------------------------------------------------

Change-Id: I085735427ef641799f02576703767dcdcf558af1
Issue-ID: POLICY-1769
Signed-off-by: Saryu Shah <ss3917@att.com>

Bump to 1.4.2-SNAPSHOT

Released 1.4.1

Issue-ID: POLICY-1700
Change-Id: Ied6d06664155ff6e44ede90f1c081ec5bd2ef679
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Update INFO.yaml to add Jim and Ram

Issue-ID: POLICY-1775
Change-Id: I8d2171a23a47428228b52215cfffc71cef49ccb6
Signed-off-by: liamfallon <liam.fallon@est.tech>

Merge "Fix to resolve unpushing(delete) policies issue"

Merge "Dublin Release Notes - initial version"

Fix to resolve unpushing(delete) policies issue

Added code the ONAP-PDP-REST to fix an issue causing the policyName to be null
and fail validation

Updated Changes per Review:
1. re-added the else for "No Policy Scope given"
2. localized the policyName and policyScope declarations to reset to null
each time through the loop
3. Changed to polName check to endsWith per Jim's review

Change-Id: I912511ef362cc79e89adc1c9da93d387e273c32a
Issue-ID: POLICY-1754
Signed-off-by: Michael Mokry <michael.mokry@att.com>

Dublin Release Notes - initial version

Dublin Release Notes - initial version
-------------------------------------------------------------

Change-Id: I706cdfa7879bfe2b9a68aaf93ace22fbb8842151
Issue-ID: POLICY-1769
Signed-off-by: Saryu Shah <ss3917@att.com>

Step snapshot version of policy engine

Issue-ID: POLICY-1630
Change-Id: Iefcaaf1811535e22904367b8d11346a02f5851c1
Signed-off-by: liamfallon <liam.fallon@est.tech>

Upgrade to release policy/models

Release 2.0.0

Issue-ID: POLICY-1630
Change-Id: I8793dc5852102af9cb5773aa40d309547b95d1b4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Upgrade policy/parent & policy/common in engine

Change-Id: Ie068839185d6b9461a1fe6e3a6b7282154a3c404
Issue-ID: POLICY-1630
Signed-off-by: ramverma <ram.krishna.verma@est.tech>

Merge "Fix test files created during execution"

Fix test files created during execution

Change-Id: Idaeaabfb523ca9206077827895c695a122f62101
Issue-ID: POLICY-1706
Signed-off-by: pa834y <pa834y@att.com>

Merge "Policy UI doestn't show left menu or any content:"

Bound wait time for a component's port

This should prevent the 90 minutes timeouts
in CSIT tests.

Change-Id: Ia9491462f4c3b83564584eb9f85551570e3c6342
Issue-ID: POLICY-1712
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Policy UI doestn't show left menu or any content:

Issue-ID: POLICY-1650

Change-Id: Ibf338f52fc260e77b4ac5f49b2f4ce12b4aa509e
Signed-off-by: uj426b <uj426b@att.com>

Add BUILD_VERSION_ENGINE to image

Change-Id: Ie97746ec8f244d52bf3eba94a247810d727fa72a
Issue-ID: INT-995
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

New BUILD_VERSION needed as fixed in parent image

BUILD_VERSION could not be used in ENV variable
as it is cooked in the base image itself.  Need to
create a new one to reflect the drools build to
get by.

Change-Id: Ide67a181e5959c5e0d087345db86baf0cc8169b6
Issue-ID: INT-998
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Manually pull the base alpine images

Add a hack to undo directory creation from parent images
since it causes container initialization to fail.

Change-Id: I99dc404cd56a67a2cc84eb1a3773b028ed533d95
Issue-ID: INT-998
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Rebase image on policy-common-alpine

Fix notes.

Issue-ID: INT-1001
Change-Id: I91c2af3e16032078561e8b0bd5aa4250d449d8d6
Signed-off-by: Dmitry Puzikov <dmitry.puzikov@tieto.com>

Documentation bypassing portal

Change-Id: Id9548a7fdc45dcd4d5055f28403c4125a6f85984
Issue-ID: POLICY-1650
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Upgrade tomcat to 9.0.16

Removes security vulnerability.

Issue-ID: POLICY-1662
Change-Id: I6a90716af561d227265a83c820b1668a99ab1a30
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

One year cert with new component names

Change-Id: I8781b368b3383e4ccc42cc9f034543273cbd5ca4
Issue-ID: POLICY-1580
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Corrections in dependency.json to match models move.

Change-Id: I71f3832c2304b3a1b8eb41a767b1cf6b28cfbdc2
Issue-ID: POLICY-1611
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Support correct dependencies from models.

Change-Id: I526bfa5edf3b036cd709d4500f5953faab7ad47e
Issue-ID: POLICY-1611
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Add the missing field to microservicemodels table

Change-Id: Ib6c42985c8565272f80c19aa358c29e275edbb95
Issue-ID: POLICY-1416
Signed-off-by: pa834y <pa834y@att.com>

Merge "New junits and bug fixes"

New junits and bug fixes

Change-Id: I1716af52ca6cdde93eef1a37f4a32a9f6f3e12f0
Issue-ID: POLICY-1417
Signed-off-by: pa834y <pa834y@att.com>

Merge "Refactor getInnerDecisionApply function"

Merge "fix typo that can lead on bugs"

Merge "Add Additional Junit and fix Sonar new bug."

Merge "Remove duplicated code"

Merge "Clean configPolicy"

Merge "Fix Sonar issues in org.onap.policy.controller pkg"

Add Additional Junit and fix Sonar new bug.

Issue-ID: POLICY-1416

Signed-off-by: uj426b <uj426b@att.com>
Change-Id: Ie4e6e91d555be448caa290bce36eb58075046619
Signed-off-by: uj426b <uj426b@att.com>

Add missing requestAttribute to junits

Change-Id: Ic595e1b5b2807ad02369ff01d72c0864bc2c9153
Issue-ID: POLICY-1418
Signed-off-by: pa834y <pa834y@att.com>

Merge "CLAMP Model policy creation support"

Merge "Make clientAuth header optional and log request"

fix typo that can lead on bugs

string xacmlId doesn t correspond to
anything in DecisionSettings
same for shotname in functionDefinition

Issue-ID: POLICY-1250
Change-Id: I7ac457666f341b50c761dbdabf806fa7efece5a9
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>

Clean configPolicy

small code cleanup of config policy

Issue-ID: POLICY-1250
Change-Id: I5f61d1a2e52cc89cfd4b470d82fe39b9f9a6af0e
Signed-off-by: Matthieu Cauffiez <matthieu.cauffiez@bell.ca>