Surendra Reddy Katam [Tue, 11 Sep 2018 07:21:29 +0000 (12:51 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-ValE32hFUzlqc5zY&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/TransactionServiceImpl.java
Line No- L55 L80
Change-Id: Ic36f843140d320b7e082652c63fdeef7eb553af8
Issue-ID: DMAAP-767
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Tue, 11 Sep 2018 06:21:04 +0000 (11:51 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java
Line No- L140 L144 L151
Change-Id: Ib3e5f8c610c9d66b24fc4cb09cac085c9c1939d5
Issue-ID: DMAAP-765
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Tue, 11 Sep 2018 05:32:24 +0000 (11:02 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vamy32hFUzlqc51Y&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/utils/PropertyReader.java
Line No- L42 L44 L53 L86
Change-Id: Ic1a7aea8b53efa8bfddd0195fa710b1af43c49d2
Issue-ID: DMAAP-724
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Ram Koya [Mon, 10 Sep 2018 13:15:46 +0000 (13:15 +0000)]
Merge changes I36a6c4ee,Id16898c8,Id5d8bc10,Ie1b5bfe9,I013247ca, ...
* changes:
Sonar major issues
Sonar major issues
Sonar major issues
Sonar major issues
Sonar major issues
Sonar major issues
Surendra Reddy Katam [Mon, 10 Sep 2018 10:42:20 +0000 (16:12 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
Line No- L276 L619 L630
Change-Id: I697b1e3503fc1fe80e501ace74782c272faefc10
Issue-ID: DMAAP-763
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Sumapriya Sarvepalli [Mon, 10 Sep 2018 10:22:55 +0000 (15:52 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WhfwGn37JfbyHvc&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPCambriaLimiter.java
Line No:L172 L310
Change-Id: I36a6c4eed0eede46b8198a4d1f988a53f1737184
Issue-ID: DMAAP-762
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Surendra Reddy Katam [Mon, 10 Sep 2018 10:17:21 +0000 (15:47 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
Line No- L514 L524 L579
Change-Id: Ic54488da6e4114e8942e13dfb257e806faeca886
Issue-ID: DMAAP-761
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Mon, 10 Sep 2018 09:54:44 +0000 (15:24 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
Line No- L219 L238
Change-Id: I8101e70e522991ea66dcc0ce142287ee5a5644e8
Issue-ID: DMAAP-759
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Sumapriya Sarvepalli [Mon, 10 Sep 2018 09:50:45 +0000 (15:20 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WilwGn37JfbyHvv&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/UIServiceImpl.java
Line No:L30 L53
Change-Id: Id16898c8300929a25c6bc2cc6fddc7e06982d422
Issue-ID: DMAAP-760
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 10 Sep 2018 07:32:25 +0000 (13:02 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VamI32hFUzlqc5z3&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java
Line No:L58 L73 L81 L93 L132
Change-Id: Id5d8bc10162e7e6dab6f8dacfb4f8dc34fb702a5
Issue-ID: DMAAP-757
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 10 Sep 2018 07:25:19 +0000 (12:55 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WgpwGn37JfbyHt0&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/security/DMaaPAAFAuthenticatorImpl.java
Line No:L49 L60 L73
Change-Id: Ie1b5bfe9d8741140757355fa92525dd92d677d75
Issue-ID: DMAAP-756
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 10 Sep 2018 07:14:43 +0000 (12:44 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vahb32hFUzlqc5t-&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/resources/streamReaders/CambriaJsonStreamReader.java
Line No:L84 L128
Change-Id: I013247ca962a79490cc458a6cac6427612de54f3
Issue-ID: DMAAP-755
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 10 Sep 2018 07:04:54 +0000 (12:34 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VagH32hFUzlqc5r8&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/DMaaPCambriaClientFactory.java
Line No:L392 L412
Change-Id: Ifa4f01adbcb59f31d3a332b8137fb56b3faa551f
Issue-ID: DMAAP-754
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Ram Koya [Fri, 7 Sep 2018 21:14:04 +0000 (21:14 +0000)]
Merge "MemoryMetaBroker.java: Fixed sonar issues"
Arundathi Patil [Fri, 7 Sep 2018 17:19:33 +0000 (22:49 +0530)]
MemoryMetaBroker.java: Fixed sonar issues
Sonar Link : https://sonar.onap.org/project/issues?id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vabv32hFUzlqc5oG&resolved=false&types=CODE_SMELL
Issue-ID: DMAAP-752
Change-Id: I54df6fc0fc73252bba1e3a2a453138d79e23adff
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Ram Koya [Fri, 7 Sep 2018 17:08:47 +0000 (17:08 +0000)]
Merge "KafkaLiveLockAvoider2.java: fixed sonar issues"
Arundathi Patil [Fri, 7 Sep 2018 16:47:35 +0000 (22:17 +0530)]
DMaapCambriaLimiter.java: Fixed sonar issues
Sonar Link : https://sonar.onap.org/code?id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&selected=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr%3Asrc%2Fmain%2Fjava%2Fcom%2Fatt%2Fdmf%2Fmr%2Fbeans%2FDMaaPCambriaLimiter.java
Issue-ID: DMAAP-753
Change-Id: I291ebff9b717ef8fe64bc129eeb17948dbfccd70
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Fri, 7 Sep 2018 16:34:31 +0000 (22:04 +0530)]
KafkaLiveLockAvoider2.java: fixed sonar issues
Sonar Link : https://sonar.onap.org/code?id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&selected=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr%3Asrc%2Fmain%2Fjava%2Fcom%2Fatt%2Fdmf%2Fmr%2Fbackends%2Fkafka%2FKafkaLiveLockAvoider2.java
Issue-ID: DMAAP-751
Change-Id: I7151abc740771e7750c91e5666fc661e4a9aa68a
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Ram Koya [Fri, 7 Sep 2018 15:32:53 +0000 (15:32 +0000)]
Merge "Fix NPE issue in msgrt"
Ram Koya [Fri, 7 Sep 2018 15:31:15 +0000 (15:31 +0000)]
Merge "CambriaApiException.java: Fixed sonar issues"
Ram Koya [Fri, 7 Sep 2018 15:22:23 +0000 (15:22 +0000)]
Merge "Fixed blocker issue in DMaaPResponseBuilder.java"
Ram Koya [Fri, 7 Sep 2018 15:15:39 +0000 (15:15 +0000)]
Merge "Sonar Major issues"
Ram Koya [Fri, 7 Sep 2018 15:15:23 +0000 (15:15 +0000)]
Merge "Sonar Major issues"
Ram Koya [Fri, 7 Sep 2018 14:40:36 +0000 (14:40 +0000)]
Merge "Sonar Major issues"
Surendra Reddy Katam [Fri, 7 Sep 2018 11:20:47 +0000 (16:50 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java
Line No- L97 L106 L109 L136 L161 L217 L237
Change-Id: I7b92585434683454be04663bb8617cde50f99092
Issue-ID: DMAAP-749
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Fri, 7 Sep 2018 10:08:52 +0000 (15:38 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vae832hFUzlqc5rV&resolved=false
Location:
src/main/java/com/att/dmf/mr/listener/CambriaServletContextListener.java
Line No-38
Change-Id: I9669376db119543e281a0a0dc0838dc36359fbd7
Issue-ID: DMAAP-746
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Amaresh Kumar [Fri, 7 Sep 2018 09:34:21 +0000 (15:04 +0530)]
Fixed blocker issue in DMaaPResponseBuilder.java
https://sonar.onap.org/project/issues?id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WfQwGn37JfbyHsq&resolved=false&severities=BLOCKER&types=BUG
Issue-ID: DMAAP-748
Change-Id: Ie21e69a8ff69aab20dcbd1ec0f6db947db55271a
Signed-off-by: Amaresh Kumar <kamaresh@in.ibm.com>
Ram Koya [Fri, 7 Sep 2018 01:26:57 +0000 (01:26 +0000)]
Merge "Sonar Major issues"
Ram Koya [Fri, 7 Sep 2018 01:25:01 +0000 (01:25 +0000)]
Merge "Consumer.java: Fixed sonar issue"
Surendra Reddy Katam [Thu, 6 Sep 2018 12:30:48 +0000 (18:00 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vakw32hFUzlqc5yg&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/MetricsServiceImpl.java
Line No-52
Change-Id: I0290ff94a94cd0dca85eee9c28b53277d74e368d
Issue-ID: DMAAP-739
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Arundathi Patil [Thu, 6 Sep 2018 10:08:19 +0000 (15:38 +0530)]
MemoryConsumerFactory.java: Fixed sonar issues
Fixed sonar code-smells/issues across this file.
Issue-ID: DMAAP-745
Change-Id: Ieefda5f0b36ca23ff2406cf298690a1376fedf06
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Thu, 6 Sep 2018 10:05:04 +0000 (15:35 +0530)]
Consumer.java: Fixed sonar issue
Fixed sonar issue, remove unused import
Issue-ID: DMAAP-744
Change-Id: I17ba87b04fe6caf56374e6cdef00b282b3ad0e5d
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Arundathi Patil [Thu, 6 Sep 2018 10:01:05 +0000 (15:31 +0530)]
CambriaApiException.java: Fixed sonar issues
Fixed sonar code-smells/issues across this file.
Issue-ID: DMAAP-743
Change-Id: I936ae1740eff5b8fccd37eefdc073ad6c56d3cd3
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
Parshad Patel [Thu, 6 Sep 2018 08:29:03 +0000 (17:29 +0900)]
Fix NPE issue in msgrt
Fix NullPointerException related sonar issue
Issue-ID: DMAAP-687
Change-Id: I6a2f32398fdef79d0ea5c1abbbe8b3b803873594
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
sunil unnava [Wed, 5 Sep 2018 21:07:16 +0000 (17:07 -0400)]
Fixes for security voilations
Issue-ID: DMAAP-738
Change-Id: If1bb1885bc10b222b1d105500a2fe4278bb51fac
Signed-off-by: sunil unnava <su622b@att.com>
sunil unnava [Wed, 5 Sep 2018 20:43:09 +0000 (16:43 -0400)]
Fixes for security voilations
Issue-ID: DMAAP-738
Change-Id: I810dad9d71f6518025eb69f9f4c982da15badcbf
Signed-off-by: sunil unnava <su622b@att.com>
Sumapriya Sarvepalli [Wed, 5 Sep 2018 12:27:54 +0000 (17:57 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WlTwGn37JfbyH1f&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/mr/apiServer/metrics/cambria/DMaaPMetricsSender.java
Line No:L89 L182
Change-Id: I86b0fc2c1a831009a3d64f1b80a72c86c135514c
Issue-ID: DMAAP-727
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Wed, 5 Sep 2018 07:21:24 +0000 (12:51 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VanG32hFUzlqc51m&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/mr/filter/ContentLengthFilter.java
Line No:L55 L113
Change-Id: I254a2d30becbf2cbd337c29c49ce35dfb04005fc
Issue-ID: DMAAP-725
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Surendra Reddy Katam [Wed, 5 Sep 2018 05:17:39 +0000 (10:47 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vait32hFUzlqc5vO&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/security/impl/DMaaPOriginalUebAuthenticator.java
Line No- L57 L59 L246 L265 L268 L270 L275 L290 L292
Change-Id: I11f56dc560af2ea5de59b8147c51de2eb96923b6
Issue-ID: DMAAP-723
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Ram Koya [Tue, 4 Sep 2018 13:08:58 +0000 (13:08 +0000)]
Merge changes I8a7dc898,I21d43d36
* changes:
Sonar Major issues
Sonar Major issues
Sumapriya Sarvepalli [Mon, 3 Sep 2018 10:41:11 +0000 (16:11 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VakB32hFUzlqc5wM&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/ApiKeysServiceImpl.java
Line No:L57 L142 L168 L199
Change-Id: I21b259d0be16290668230857adb4b71346af6a6c
Issue-ID: DMAAP-708
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 3 Sep 2018 10:00:21 +0000 (15:30 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WhXwGn37JfbyHux&resolved=false&rules=squid%3ACommentedOutCodeLine&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPKafkaMetaBroker.java
Line No:L53 L88 L92 L125 L129 L136 L141 L238 L244 L260 L268
Change-Id: Ic48d0d0fa4654e62142c274d0ac1fbb34283e178
Issue-ID: DMAAP-706
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Surendra Reddy Katam [Mon, 3 Sep 2018 09:51:59 +0000 (15:21 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WiqwGn37JfbyHwE&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/TopicServiceImpl.java
Line No-L48 L70 L76 L128 L196 L212 L216 L218 L233 L235 L253 L260 L270 L275 L286 L294 L506 L509 L511 L513 L519 L523 L564 L567 L574 L578 L582 L615 L618 L625 L629 L665 L667 L674 L678 L684
Change-Id: I8a7dc8982d54904ddc1fe16a0a7025e3b433c049
Issue-ID: DMAAP-705
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Mon, 3 Sep 2018 06:30:11 +0000 (12:00 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WiVwGn37JfbyHvi&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/AdminServiceImpl.java
Line No-45
Change-Id: I21d43d369ba4304158f771b343da682d76c95abe
Issue-ID: DMAAP-701
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Ram Koya [Fri, 31 Aug 2018 15:21:05 +0000 (15:21 +0000)]
Merge "Fix sonar issues in KafkaConsumerCache.java"
Parshad Patel [Fri, 31 Aug 2018 07:32:14 +0000 (16:32 +0900)]
Fix sonar issues in KafkaConsumerCache.java
Fix use try-with-resources, InterruptedException sonar issues
Issue-ID: DMAAP-687
Change-Id: Ia667169912df87cc77dc6bd78a6de454e6516881
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
Sumapriya Sarvepalli [Fri, 31 Aug 2018 06:39:39 +0000 (12:09 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vahj32hFUzlqc5uN&resolved=false&rules=squid%3ACommentedOutCodeLine&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/resources/streamReaders/CambriaRawStreamReader.java
Line No:L140
Change-Id: I2b70b55a5e369c0b16a9765fab17cbac4357790e
Issue-ID: DMAAP-684
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Wed, 29 Aug 2018 12:31:56 +0000 (18:01 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vab632hFUzlqc5oV&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/memory/MemoryQueue.java
Line No:L46 L105 L172
Change-Id: Ifce2d0206e1a0898aa238a86259de7b41b2c8a23
Issue-ID: DMAAP-672
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Wed, 29 Aug 2018 10:42:37 +0000 (16:12 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vagy32hFUzlqc5sv&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/impl/DMaaPCambriaSimplerBatchPublisher.java
Line No:L309 L329 L340 L348
Change-Id: I7edf1c0b0e59c88d08d9a2b453f0cfb67f3e944a
Issue-ID: DMAAP-671
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Wed, 29 Aug 2018 10:13:18 +0000 (15:43 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41Wk4wGn37JfbyH1F&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaLiveLockAvoider2.java
Line No:L70 L141
Change-Id: I44c5813ff366fafeff141346170c575bc352d160
Issue-ID: DMAAP-670
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Wed, 29 Aug 2018 09:52:18 +0000 (15:22 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VafW32hFUzlqc5ra&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metabroker/Topic.java
Line No:L42 L46 L51
Change-Id: I83778588cab9144217b64c88daf8996621ef14b6
Issue-ID: DMAAP-669
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Ram Koya [Tue, 28 Aug 2018 13:01:00 +0000 (13:01 +0000)]
Merge changes I64225953,If4fc0644
* changes:
Sonar Major issues
Sonar Major issues
Sumapriya Sarvepalli [Tue, 28 Aug 2018 11:51:00 +0000 (17:21 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vaeo32hFUzlqc5rQ&resolved=false&rules=squid%3ACommentedOutCodeLine&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/exception/DMaaPWebExceptionMapper.java
Line No:L38 L55
Change-Id: Iebc8f526462c5a73fa43aade08558f456a24e7e8
Issue-ID: DMAAP-664
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Tue, 28 Aug 2018 11:19:39 +0000 (16:49 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VadQ32hFUzlqc5qR&resolved=false&rules=squid%3ACommentedOutCodeLine&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPMetricsSet.java
Line No:L87 L89
Change-Id: Iae2f16ad47985cbb7401c427ed47ef7c6deaa076
Issue-ID: DMAAP-663
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Surendra Reddy Katam [Tue, 28 Aug 2018 09:31:30 +0000 (15:01 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VagX32hFUzlqc5sH&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/impl/CambriaBaseClient.java
Line No- L34 L56 L60 L88
Change-Id: I642259537b5df7cf4655510535e272d8e2cf555a
Issue-ID: DMAAP-661
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Tue, 28 Aug 2018 07:15:27 +0000 (12:45 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vail32hFUzlqc5vB&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/security/impl/DMaaPMechIdAuthenticator.java
Line No: L28 L68
Change-Id: If4fc0644eb2ac96676f15c3b39ce53dcb151e6bf
Issue-ID: DMAAP-658
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Ram Koya [Mon, 27 Aug 2018 14:59:23 +0000 (14:59 +0000)]
Merge "bumped the pom version"
sunil unnava [Mon, 27 Aug 2018 14:29:04 +0000 (10:29 -0400)]
bumped the pom version
Issue-ID: DMAAP-628
Change-Id: I4514c82fd9a26677bbfe8502922619d11b57be47
Signed-off-by: sunil unnava <su622b@att.com>
Ram Koya [Mon, 27 Aug 2018 14:12:17 +0000 (14:12 +0000)]
Merge changes I093fde71,I2dffd5df,I2ae6fa62
* changes:
Sonar Major issues
Sonar Major issues
Sonar Major issues
Sumapriya Sarvepalli [Mon, 27 Aug 2018 11:13:02 +0000 (16:43 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWVrvBaZxOv3LmQdCiha&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java
Line No:L45 L80 L96
Change-Id: I1ffa790aa3c088d25fe83669b0380dedc33ae234
Issue-ID: DMAAP-655
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 27 Aug 2018 09:58:13 +0000 (15:28 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vaf-32hFUzlqc5rw&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/CambriaPublisherUtility.java
Line No:L98
Change-Id: I027c9225d436fdd99375eb22b4c55468eaa5e705
Issue-ID: DMAAP-653
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Surendra Reddy Katam [Mon, 27 Aug 2018 07:25:35 +0000 (12:55 +0530)]
Sonar Major issues
Replace the type specification in this constructor call with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VadZ32hFUzlqc5qX&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java
Line No- L91 L103
Change-Id: I093fde71871e39a667a943b4f6386fe39769c4b1
Issue-ID: DMAAP-650
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Mon, 27 Aug 2018 06:56:46 +0000 (12:26 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VafD32hFUzlqc5rW&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/listener/DME2EndPointLoader.java
Line No- L54
Change-Id: I2dffd5df21665ed488ac62f54b0cd663b02d88bb
Issue-ID: DMAAP-649
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Mon, 27 Aug 2018 06:33:30 +0000 (12:03 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vafp32hFUzlqc5ro&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/CambriaClient.java
Line No- L24 L28
Change-Id: I2ae6fa62452e936374e41d56609de98ce0d4f203
Issue-ID: DMAAP-648
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Ram Koya [Fri, 24 Aug 2018 15:08:23 +0000 (15:08 +0000)]
Merge changes I6bae63d6,I5bed2ad4,I39e24692
* changes:
Sonar major issues
Sonar major issues
Sonar Major issues
Sumapriya Sarvepalli [Fri, 24 Aug 2018 12:09:55 +0000 (17:39 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WhfwGn37JfbyHvK&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPCambriaLimiter.java
Line No:L68 L115
Change-Id: I6bae63d640729f1785d42e0dcefe0a6e90b96def
Issue-ID: DMAAP-645
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Fri, 24 Aug 2018 11:59:08 +0000 (17:29 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkywGn37JfbyH0l&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java
Line No:L181 184
Change-Id: I5bed2ad41a016229a177db7a4dfaff9bb19fa0f2
Issue-ID: DMAAP-644
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Fri, 24 Aug 2018 09:30:01 +0000 (15:00 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WhOwGn37JfbyHuE&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPKafkaConsumerFactory.java
Line No:L49 L62 L66 L110 L199 L268 L271 L298
Change-Id: I39e2469211cf47642761fafe05e381b6fd1f91cf
Issue-ID: DMAAP-643
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Surendra Reddy Katam [Fri, 24 Aug 2018 06:53:03 +0000 (12:23 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vado32hFUzlqc5ql&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPZkConfigDb.java
Line No- L29 L45
Change-Id: I6326e075cd75e2d0f932ddb073239c9c142ed2b8
Issue-ID: DMAAP-642
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Fri, 24 Aug 2018 06:28:01 +0000 (11:58 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vada32hFUzlqc5qg&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/beans/DMaaPNsaApiDb.java
Line No- L26 L51 L55 L66 L82 L86 L112 L120
Change-Id: Ia68a15432466e0042377d5042968b7b213d15057
Issue-ID: DMAAP-641
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Surendra Reddy Katam [Fri, 24 Aug 2018 05:32:36 +0000 (11:02 +0530)]
Sonar major issues
Replace the type specification in this constructor call with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/memory/MemoryMetaBroker.java
Line No- L49 L51 L93
Change-Id: I7f0e0a4562a91d07969118bd6955bcfac6214f50
Issue-ID: DMAAP-640
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
sunil unnava [Thu, 23 Aug 2018 23:05:59 +0000 (19:05 -0400)]
Fixes for Kafka upgrade issues
Issue-ID: DMAAP-598
Change-Id: I79d269e157c88560ed54b194f449edad07cc96aa
Signed-off-by: sunil unnava <su622b@att.com>
Sumapriya Sarvepalli [Thu, 23 Aug 2018 12:20:44 +0000 (17:50 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkywGn37JfbyH0q&resolved=false&rules=squid%3ACommentedOutCodeLine&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaPublisher.java
Line No:L44 L79 L83 L87 L92 L97 L187 L203 L231 L234
Change-Id: I478277f42a305dfcd604fe4bd40a7377213356da
Issue-ID: DMAAP-635
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Thu, 23 Aug 2018 11:55:27 +0000 (17:25 +0530)]
Sonar Major issues
Use isEmpty to check whether the collection is empty or not
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vagz32hFUzlqc5s-&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/impl/DMaaPCambriaSimplerBatchPublisher.java
Line No:L189 L254 L276
Change-Id: I272279d7db44611b8339f166dcd5884ead4da1b0
Issue-ID: DMAAP-634
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Arindam Mondal [Wed, 22 Aug 2018 01:22:33 +0000 (10:22 +0900)]
Fix msgrtr Sonar violation
Issue-ID: DMAAP-626
Change-Id: Iee10b0e9a9fa14577e796dcd51cdda274dd807a8
Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
Sumapriya Sarvepalli [Tue, 21 Aug 2018 11:21:31 +0000 (16:51 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkgwGn37JfbyHyq&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaConsumerCache.java
Line No:L64 L117 L122 L271 L397 L407 L421 L431 L457 L552 L694 L748
Change-Id: Ib41bd0442e7dd9177f958ee3d7f47e8e9fdc241c
Issue-ID: DMAAP-621
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Mon, 20 Aug 2018 10:32:59 +0000 (16:02 +0530)]
Sonar major issues
Replace with the diamond operator
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkgwGn37JfbyHyq&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/kafka/KafkaConsumerCache.java
Line No:L166 L395 L419 L463
Change-Id: Ie766fa53303bf45a4e028c5a557ce45f8e211f99
Issue-ID: DMAAP-616
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Fri, 17 Aug 2018 10:42:52 +0000 (16:12 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkrwGn37JfbyH0E&resolved=false
Location:
src/main/java/com/att/dmf/mr/backends/kafka/Kafka011Consumer.java
Line No:L45 L64 L129 L142 L261 L269 L283 L289 L363 L368 L377 L385 L399 L401
Change-Id: Id747f017cc0f09694181ce410c697895fcfafafa
Issue-ID: DMAAP-610
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Fri, 17 Aug 2018 06:52:41 +0000 (12:22 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkSwGn37JfbyHyc&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/Publisher.java
Line No:L32 L98
Issue-ID: DMAAP-609
Change-Id: I73b5ac924bc51386a88caac7df23ebb8aaa31eb1
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
Sumapriya Sarvepalli [Thu, 16 Aug 2018 07:00:20 +0000 (12:30 +0530)]
Sonar Major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41WkawGn37JfbyHyj&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/backends/Consumer.java
Line No: L80 L82 L103
Change-Id: I64380e4693373d1f4695c07757f524b021f95e87
Issue-ID: DMAAP-603
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
sunil unnava [Tue, 14 Aug 2018 16:50:37 +0000 (12:50 -0400)]
fix security vulnerabilities
Issue-ID: DMAAP-592
Change-Id: I8555e3633222e3599b29dafd8fd0ec17bb426773
Signed-off-by: sunil unnava <su622b@att.com>
sunil unnava [Tue, 14 Aug 2018 15:13:19 +0000 (11:13 -0400)]
remove tomcat dependencies
Issue-ID: DMAAP-592
Change-Id: I8164b3b8c0e99714d12b52d35c59c8bf37bc1766
Signed-off-by: sunil unnava <su622b@att.com>
sunil unnava [Tue, 14 Aug 2018 13:34:46 +0000 (09:34 -0400)]
update the testcases after the kafka 11 changes
Issue-ID: DMAAP-526
Change-Id: I477a8ee05fb3cdd76af726b6ca0d1a69aa9eef93
Signed-off-by: sunil unnava <su622b@att.com>
Ram Koya [Wed, 9 May 2018 17:56:56 +0000 (17:56 +0000)]
Merge "sonar critical for Conditional Statement"
Ram Koya [Wed, 9 May 2018 17:56:43 +0000 (17:56 +0000)]
Merge "sonar critical for Conditional Statement"
Ram Koya [Wed, 9 May 2018 17:56:16 +0000 (17:56 +0000)]
Merge "sonar critical for Exception handling"
Ram Koya [Wed, 9 May 2018 17:50:31 +0000 (17:50 +0000)]
Merge "Sonar major issues"
Ram Koya [Wed, 9 May 2018 17:50:04 +0000 (17:50 +0000)]
Merge changes I6d43e553,I8e07515b,Ida4d83cd,Id70b6f40,Ic9b25d4f, ...
* changes:
sonar major for commented-out lines
sonar critical for conditional statement
sonar minor issue for unused import
sonar major issue for commented-out lines
sonar major issue for commented-out lines
sonar major issue for 2 statements per line
Sahani Ravindrana Naik [Wed, 9 May 2018 06:49:20 +0000 (12:19 +0530)]
sonar major for commented-out lines
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false
Location:
src/main/java/com/att/nsa/cambria/backends/kafka/KafkaConsumerCache.java
Line No-49
Change-Id: I6d43e55351c18bdbedae87a17fa2eb5f78ebd3a1
Issue-ID: DMAAP-481
Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
Sahani Ravindrana Naik [Wed, 9 May 2018 06:25:42 +0000 (11:55 +0530)]
sonar critical for conditional statement
This line will not be executed conditionally; only the first line of this 2-line block will be. The rest will execute unconditionally
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false
Location:
src/main/java/com/att/nsa/cambria/service/impl/TopicServiceImpl.java
Line No-166
Change-Id: I8e07515bb42960205f7f4982d99184cf946402ac
Issue-ID: DMAAP-480
Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
Ram Koya [Mon, 7 May 2018 17:50:59 +0000 (17:50 +0000)]
Merge "sonar critical for Conditional Statement"
Surendra Reddy Katam [Mon, 7 May 2018 12:07:09 +0000 (17:37 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VaZ732hFUzlqc5lg&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java
Line No-182
Change-Id: Iaaa992fde4da4d74ec9ce8dca2c42909537ea909
Issue-ID: DMAAP-467
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Sahani Ravindrana Naik [Mon, 7 May 2018 11:44:56 +0000 (17:14 +0530)]
sonar minor issue for unused import
Remove this unused import 'com.att.nsa.drumlin.till.nv.rrNvReadable'
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false
Location:
src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java
Line No-43
Change-Id: Ida4d83cde56c0765debc27f6765dce1ad4ef03a4
Issue-ID: DMAAP-468
Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
Surendra Reddy Katam [Mon, 7 May 2018 11:37:22 +0000 (17:07 +0530)]
Sonar major issues
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VaZ732hFUzlqc5lg&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java
Line No-80
Change-Id: I5b5ac4044ae73d963c198a0737f200d2aca261a9
Issue-ID: DMAAP-466
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
Saurabh Kumar26 [Mon, 7 May 2018 11:35:28 +0000 (17:05 +0530)]
sonar critical for Exception handling
Rethrow this exception
Sonar Link:
https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nas/cambria/resources/streamReaders/CambriaRawStreamReader.java
Line No. 131
Change-Id: I27409b296d30d3d2fee459f769b5eb06ec729ecc
Issue-ID: DMAAP-471
Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
Saurabh Kumar26 [Mon, 7 May 2018 11:16:42 +0000 (16:46 +0530)]
sonar critical for Conditional Statement
added '{}' after if statement
Sonar Link:
https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL
Location:
src/main/java/com/att/nsa/cambria/beans/DMaaPKafkaConsumerFactory.java
Line No. 116
Change-Id: Icc24ec635035e9d62486bcd972263c5926d8b4e1
Issue-ID: DMAAP-470
Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
Saurabh Kumar26 [Mon, 7 May 2018 10:59:29 +0000 (16:29 +0530)]
sonar critical for Conditional Statement
added '{}' after if statement
Sonar Link:
https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL
Location:
src/.../att/nsa/cambria/backends/kafka/KafkaConsumerCache.java
Line No. 542
Change-Id: I811432fc77002d49c374f070e3438ed88bc0eb16
Issue-ID: DMAAP-469
Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
Saurabh Kumar26 [Fri, 4 May 2018 08:29:36 +0000 (13:59 +0530)]
sonar critical for Conditional Statement
added '{}' after if statement
Sonar Link:
https://sonar.onap.org/project/issues?assignees=SaurabhKumar26&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false&severities=CRITICAL
Location:
src/.../att/nsa/cambria/backends/kafka/KafkaConsumerCache.java
Line No. 244
Change-Id: I293b0543f1a0ccfc3fcd4633e6ef2b54751f0ab8
Issue-ID: DMAAP-463
Signed-off-by: Saurabh Kumar26 <sk00552209@techmahindra.com>
Sahani Ravindrana Naik [Fri, 4 May 2018 04:22:59 +0000 (09:52 +0530)]
sonar major issue for commented-out lines
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr
Location:
src/main/java/com/att/nsa/cambria/backends/Consumer.java
Line No-78
Change-Id: Id70b6f40b95917690ac78f1cc387cd779cfe3d6a
Issue-ID: DMAAP-459
Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>
Sahani Ravindrana Naik [Thu, 3 May 2018 11:43:31 +0000 (17:13 +0530)]
sonar major issue for commented-out lines
This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=Sahani_Naik&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&resolved=false
Location:
src/main/java/com/att/nsa/apiServer/metrics/cambria/DMaaPMetricsSender.java
Line No-89
Change-Id: Ic9b25d4f38fe8ffb7584a3662895b1488d572da0
Issue-ID: DMAAP-457
Signed-off-by: Sahani Ravindrana Naik <sn00552219@techmahindra.com>