Sonar Major issues 85/64585/1
authorSurendra Reddy Katam <SK00524980@techmahindra.com>
Wed, 5 Sep 2018 05:17:39 +0000 (10:47 +0530)
committerSurendra Reddy Katam <SK00524980@techmahindra.com>
Wed, 5 Sep 2018 05:17:39 +0000 (10:47 +0530)
 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-Vait32hFUzlqc5vO&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/security/impl/DMaaPOriginalUebAuthenticator.java
Line No- L57 L59 L246 L265 L268 L270 L275 L290 L292

Change-Id: I11f56dc560af2ea5de59b8147c51de2eb96923b6
Issue-ID: DMAAP-723
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
src/main/java/com/att/dmf/mr/security/impl/DMaaPOriginalUebAuthenticator.java

index a26c9e7..b1e28e7 100644 (file)
@@ -54,9 +54,9 @@ public class DMaaPOriginalUebAuthenticator<K extends NsaApiKey> implements DMaaP
        public DMaaPOriginalUebAuthenticator(NsaApiDb<K> db, long requestTimeWindowMs) {
                fDb = db;
                fRequestTimeWindowMs = requestTimeWindowMs;
-               //fAuthenticators = new LinkedList<DMaaPAuthenticator<K>>();
+               
 
-               //fAuthenticators.add(new DMaaPOriginalUebAuthenticator<K>(db, requestTimeWindowMs));
+               
 
        }
 
@@ -243,51 +243,51 @@ public class DMaaPOriginalUebAuthenticator<K extends NsaApiKey> implements DMaaP
                    "EEEE, dd-MMM-yy HH:mm:ss zzz",
                };
 
-       /*private static final String kDateFormats[] = {
-                       // W3C date format (RFC 3339).
-                       "yyyy-MM-dd'T'HH:mm:ssz",
+       
+                       
+                       
 
-                       // Preferred HTTP date format (RFC 1123).
-                       "EEE, dd MMM yyyy HH:mm:ss zzz",
+               
+                       
 
-                       // simple unix command line 'date' format
-                       "EEE MMM dd HH:mm:ss z yyyy",
+                       
+                       
 
-                       // Common date format (RFC 822).
-                       "EEE, dd MMM yy HH:mm:ss z", "EEE, dd MMM yy HH:mm z", "dd MMM yy HH:mm:ss z", "dd MMM yy HH:mm z",
+                       
+                       
 
-                       // Obsoleted HTTP date format (ANSI C asctime() format).
-                       "EEE MMM dd HH:mm:ss yyyy",
+                       
+                       
 
-                       // Obsoleted HTTP date format (RFC 1036).
-                       "EEEE, dd-MMM-yy HH:mm:ss zzz", }; */
+                       
+                       
        // logger declaration
-       //private static final Logger log = Logger.getLogger(DMaaPOriginalUebAuthenticator.class.toString());
+       
        private static final EELFLogger log = EELFManager.getInstance().getLogger(DMaaPOriginalUebAuthenticator.class);
        @Override
-//     public K authenticate(DMaaPContext ctx) {
+
                // TODO Auto-generated method stub
-               //return null;
+               
        //}
        
        public K authenticate(DMaaPContext ctx) {
                
-               /*final HttpServletRequest req = ctx.getRequest();
-               for (DMaaPAuthenticator<K> a : fAuthenticators) {
-                       if (a.qualify(req)) {
-                               final K k = a.isAuthentic(req);
-                               if (k != null)
-                                       return k;
-                       }
-                       // else: this request doesn't look right to the authenticator
-               }*/
+               
+               
+                       
+                               
+                               
+                                       
+                       
+                       
+               
                return null;
        }
 
 
        public void addAuthenticator ( DMaaPAuthenticator<K> a )
        {
-               //this.fAuthenticators.add(a);
+               
        }
-       //private final LinkedList<DMaaPAuthenticator<K>> fAuthenticators;
+       
 }
\ No newline at end of file