Sonar major issues

 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VamI32hFUzlqc5z3&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java
Line No:L58 L73 L81 L93 L132

Change-Id: Id5d8bc10162e7e6dab6f8dacfb4f8dc34fb702a5
Issue-ID: DMAAP-757
Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>

diff --git a/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java b/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java
index dd1e4eb..e56a2e4 100644 (file)
--- a/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java
+++ b/src/main/java/com/att/dmf/mr/utils/ConfigurationReader.java
@@ -55,7 +55,7 @@ import com.att.nsa.drumlin.till.nv.rrNvReadable.invalidSettingValue;
 import com.att.nsa.drumlin.till.nv.rrNvReadable.missingReqdSetting;
 import com.att.nsa.limits.Blacklist;
 import com.att.nsa.security.NsaAuthenticatorService;
-//import com.att.nsa.security.authenticators.OriginalUebAuthenticator;
+
 import com.att.nsa.security.db.BaseNsaApiDbImpl;
 import com.att.nsa.security.db.NsaApiDb;
 import com.att.nsa.security.db.NsaApiDb.KeyExistsException;
@@ -70,7 +70,7 @@ import com.att.nsa.security.db.simple.NsaSimpleApiKeyFactory;
 @Component
 public class ConfigurationReader {
 
-//     private rrNvReadable settings;
+
        private Broker1 fMetaBroker;
        private ConsumerFactory fConsumerFactory;
        private Publisher fPublisher;
@@ -78,7 +78,7 @@ public class ConfigurationReader {
        @Autowired
        private DMaaPCambriaLimiter fRateLimiter;
        private NsaApiDb<NsaSimpleApiKey> fApiKeyDb;
-       /* private DMaaPTransactionObjDB<DMaaPTransactionObj> fTranDb; */
+       
        private DMaaPAuthenticator<NsaSimpleApiKey> fSecurityManager;
        private NsaAuthenticatorService<NsaSimpleApiKey> nsaSecurityManager;
        private static CuratorFramework curator;
@@ -90,7 +90,7 @@ public class ConfigurationReader {
        private Emailer fEmailer;
 
        private static final EELFLogger log = EELFManager.getInstance().getLogger(ConfigurationReader.class);
-       //private static final Logger log = Logger.getLogger(ConfigurationReader.class.toString());
+       
 
        /**
         * constructor to initialize all the values
@@ -129,7 +129,7 @@ public class ConfigurationReader {
                        @Qualifier("dMaaPAuthenticatorImpl") DMaaPAuthenticator<NsaSimpleApiKey> fSecurityManager
                        )
                                        throws missingReqdSetting, invalidSettingValue, ServletException, KafkaConsumerCacheException, ConfigDbException {
-               //this.settings = settings;
+               
                this.fMetrics = fMetrics;
                this.zk = zk;
                this.fConfigDb = fConfigDb;