Sonar Major issues 25/63225/1
authorSurendra Reddy Katam <SK00524980@techmahindra.com>
Tue, 28 Aug 2018 09:31:30 +0000 (15:01 +0530)
committerSurendra Reddy Katam <SK00524980@techmahindra.com>
Tue, 28 Aug 2018 09:31:30 +0000 (15:01 +0530)
 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AV4-VagX32hFUzlqc5sH&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/metrics/publisher/impl/CambriaBaseClient.java
Line No- L34 L56 L60 L88

Change-Id: I642259537b5df7cf4655510535e272d8e2cf555a
Issue-ID: DMAAP-661
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
src/main/java/com/att/dmf/mr/metrics/publisher/impl/CambriaBaseClient.java

index 08b2fd1..ebdf3ed 100644 (file)
@@ -31,7 +31,7 @@ import org.json.JSONArray;
 import org.json.JSONException;
 
 import com.att.dmf.mr.constants.CambriaConstants;
-//import org.slf4j.Logger;
+
 //import org.slf4j.LoggerFactory;
 import com.att.eelf.configuration.EELFLogger;
 import com.att.eelf.configuration.EELFManager;
@@ -52,12 +52,12 @@ public class CambriaBaseClient extends HttpClient implements com.att.dmf.mr.metr
 
        public CambriaBaseClient ( Collection<String> hosts, String clientSignature ) throws MalformedURLException
        {
-               /*super ( hosts, CambriaConstants.kStdCambriaServicePort, clientSignature,
-                       CacheUse.NONE, 1, 1, TimeUnit.MILLISECONDS );*/
+               
+                       
                
                super(ConnectionType.HTTP, hosts, CambriaConstants.kStdCambriaServicePort, clientSignature, CacheUse.NONE, 1, 1L, TimeUnit.MILLISECONDS, 32, 32, 600000);
 
-               //fLog = LoggerFactory.getLogger ( this.getClass().getName () );
+               
                fLog = EELFManager.getInstance().getLogger(this.getClass().getName());
                //( this.getClass().getName () );
        }
@@ -85,7 +85,7 @@ public class CambriaBaseClient extends HttpClient implements com.att.dmf.mr.metr
        {
                fLog = log; 
                
-               //replaceLogger ( log );
+               
        }
 
        public EELFLogger  getLog ()