appc.git
6 years agoTest Coverage 67/38467/3
amshegokar [Mon, 26 Mar 2018 09:22:13 +0000 (14:52 +0530)]
Test Coverage

Unit tests for:
1. AaiServiceInternalException.java
2. MissingParameterException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-aai-client-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Faai%2Fclient%2Faai

Change-Id: Ib107309b8b9f3e17f0467801f300a0a0aa0af8ac
Issue-ID: APPC-787
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoChefAdapterImpl junits 75/38575/2
Michal Kabaj [Mon, 26 Mar 2018 14:37:03 +0000 (16:37 +0200)]
ChefAdapterImpl junits

-Add new JUnits to ChefAdapterImplVNFCOperationsTest
-remove unused JSONException catch clause from ChefAdapterImpl,
when there is no jackson lib used

Change-Id: I96b8d6155ca13087b697a19e1fcbba2ee82a8291
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoUnit test coverage 57/38457/2
amshegokar [Mon, 26 Mar 2018 08:26:40 +0000 (13:56 +0530)]
Unit test coverage

Unit test coverage for:
1. Vnfc.java
2. SDCReference.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-sdc-listener-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsdc%2Fartifacts%2Fobject

Change-Id: I34c15904bc0df7c537ad448b748add847ab863bd
Issue-ID: APPC-786
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoCoverage for:org/onap/appc/dao/util/exception 97/38097/3
amshegokar [Fri, 23 Mar 2018 13:46:27 +0000 (19:16 +0530)]
Coverage for:org/onap/appc/dao/util/exception

Unit Tests for:
1) DataAccessException.java
2)DBConnectionPoolException.java
3) JdbcRuntimeException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc-netconf-adapter-bundle&selected=org.onap.appc%3Aappc-data-access-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdao%2Futil%2Fexception

Change-Id: Ie5c44417ca33c73de5577052a01ca5f019adeb1b
Issue-ID: APPC-781
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoUnit test for Messages.java 91/38091/4
amshegokar [Fri, 23 Mar 2018 13:37:03 +0000 (19:07 +0530)]
Unit test for Messages.java

Unit test for Messages.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc-netconf-adapter-bundle&selected=org.onap.appc%3Aappc-data-access-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdao%2Futil%2Fmessage

Change-Id: I2204f296d3d2200eb4aa4f809e0c0dd841b0b93e
Issue-ID: APPC-782
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoCoverage test 89/38089/3
amshegokar [Fri, 23 Mar 2018 13:28:36 +0000 (18:58 +0530)]
Coverage test

Unit Test Coverage for:
1) NetconfConnectionDetails.java
2) NetconfClientType.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-netconf-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fnetconf

Change-Id: I161d7bfe5e780c7c686ae014d87208e3da36b3cd
Issue-ID: APPC-780
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoTest Coverage 85/38085/3
amshegokar [Fri, 23 Mar 2018 13:18:53 +0000 (18:48 +0530)]
Test Coverage

Unit test for:org/onap/appc/adapter/netconf/exception classes
1. DataAccessException.java
2. NetconfDAOException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-netconf-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fnetconf%2Fexception

Change-Id: I9b02c0ddc01b4327135ccc754a6466105b1e18ff
Issue-ID: APPC-779
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoAdd junit coverage to EncryptionTool class 97/38597/2
Lori Keighron [Mon, 26 Mar 2018 15:15:33 +0000 (11:15 -0400)]
Add junit coverage to EncryptionTool class

Introduce junit coverage in design-services class

Issue-ID: APPC-794
Change-Id: Idbf8d02511b478173950a97c10a642486bc0d45f
Signed-off-by: Lori Keighron <lk2924@att.com>
6 years agoUnit test for ProviderResponse.java 31/38531/2
amshegokar [Mon, 26 Mar 2018 12:52:33 +0000 (18:22 +0530)]
Unit test for ProviderResponse.java

Unit test for ProviderResponse.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-sdc-listener-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsdc%2Flistener%2FProviderResponse.java

Change-Id: I85984489a404e3980d962007a677f2a0c016a50d
Issue-ID: APPC-785
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agofix eelf and logback nexus iq issue 89/38189/3
Taka Cho [Fri, 23 Mar 2018 19:57:59 +0000 (15:57 -0400)]
fix eelf and logback nexus iq issue

Change-Id: Id42f77fc86cbbfff28bfde404181938d358515b9
Issue-ID: APPC-784
Signed-off-by: Taka Cho <tc012c@att.com>
6 years agoUpdated APPC Client Library Guide 45/38245/1
Scott Seabolt [Sat, 24 Mar 2018 03:38:20 +0000 (23:38 -0400)]
Updated APPC Client Library Guide

Issue-ID: APPC-374
Change-Id: I7184c91ccb5fa87dd9ba7a22c0de960e7ba28698
Signed-off-by: Scott Seabolt <js9808@att.com>
6 years agoAdd junit coverage to Appc-Domain-model 67/38167/3
Shailendra Borale [Fri, 23 Mar 2018 17:53:50 +0000 (13:53 -0400)]
Add junit coverage to Appc-Domain-model

Introduce junit-tests for Vnf, Vnfc classses
Replaced tabs with spaces.

Change-Id: I45baf5aa20391b375fae667ff7fdeed8cfd845b8
Issue-ID: APPC-783
Signed-off-by: Shailendra Borale <sb8915@att.com>
6 years agoChefAdapterImpl cleanup 47/36447/5
Michal Kabaj [Mon, 19 Mar 2018 08:25:59 +0000 (09:25 +0100)]
ChefAdapterImpl cleanup

- Switched usage of RequestContext class for wrapping the SvcLogicContext
to using the SvcLogicContext directly
- Removed unused RequestContext class

Change-Id: I7376e3d6f5602887cf5a25f1f90ff45805c620b2
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoUnit test coverage 81/38081/3
amshegokar [Fri, 23 Mar 2018 13:07:01 +0000 (18:37 +0530)]
Unit test coverage

Unit test coverage for Constants.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Futils%2FConstants.java

Change-Id: Ied122a1838111897079243f0e444a9eef1b2f162
Issue-ID: APPC-778
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoAdd Junit coverage for ActionIdentifier class 05/38105/3
Neha Sood [Fri, 23 Mar 2018 14:19:28 +0000 (10:19 -0400)]
Add Junit coverage for ActionIdentifier class

Introduce junit tests for ActionIdentifier class

Change-Id: If14abe7b165d310d693d0d3ea04b563c0b68edd4
Issue-ID: APPC-777
Signed-off-by: Neha Sood <ns189k@att.com>
6 years agoChefAdapterImpl junits 95/38095/1
Michal Kabaj [Fri, 23 Mar 2018 13:43:41 +0000 (14:43 +0100)]
ChefAdapterImpl junits

Add new JUnits to ChefAdapterImplVNFCOperationsTest

Change-Id: I243b2f46fdb75ad3c689b7875361fb9a654eaf60
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoChange in DG for the Audit and the Sync 37/37837/3
Sonali Das [Thu, 22 Mar 2018 17:53:07 +0000 (13:53 -0400)]
Change in DG for the Audit and the Sync

Issue-ID: APPC-735
Change-Id: I4e07b07d476b1353388e51ce3b41d245b99c4bb7
Signed-off-by: Sonali Das <sd394g@att.com>
6 years agoSplit sequence generation to classess 77/35677/7
kurczews [Mon, 5 Mar 2018 14:39:47 +0000 (15:39 +0100)]
Split sequence generation to classess

* Delegate original logic to separate clasess
* Introduce InputParamsCollector
* Introduce CapabilitiesDataExtractor
* Add coverage for changes

Change-Id: Ibb35dfb67306f789950c3b77362c5d79a3b6da63
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoCorrected condition to pick region 47/37847/2
Balaji, Ramya (rb111y) [Thu, 22 Mar 2018 18:33:24 +0000 (14:33 -0400)]
Corrected condition to pick region

Fixed condition so that region
can be determined correctly

Issue-ID: APPC-776
Change-Id: Iaf57a4face50d99a56cd4b85c0a318d34632a1e8
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
6 years agoEventHandlerImpl unit tests 85/37785/3
Jakub Dudycz [Thu, 22 Mar 2018 13:54:38 +0000 (14:54 +0100)]
EventHandlerImpl unit tests

Improved code coverage.

Change-Id: Iee626e206b1fc2ef1047fc4d50b030319afe0403
Issue-ID: APPC-753
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoChefAdapterImpl junits 19/36719/3
Michal Kabaj [Wed, 21 Mar 2018 12:26:51 +0000 (13:26 +0100)]
ChefAdapterImpl junits

- Added new Junit class ChefAdapterImplVNFCOperationsTest
- Added unit tests for method vnfcEnvironment
- Small refactor to for exception handling in vnfcEnvironment method to
improve readability and avoid catching and rethrowing same exception

Change-Id: I58a43390ff45598f6d17da48eed3620667008cb7
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoBugfixes for error handling while attaching volume 21/36821/4
Modaboina, Kusumakumari (km583p) [Tue, 20 Mar 2018 17:17:00 +0000 (13:17 -0400)]
Bugfixes for error handling while attaching volume

Change-Id: I103709186eff4fc9e42038b2e1113b010b822528
Issue-ID: APPC-761
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
6 years agoLCM package test classes refactor 61/36461/5
Jakub Dudycz [Mon, 19 Mar 2018 09:25:59 +0000 (10:25 +0100)]
LCM package test classes refactor

Extracted some methods and fields to util class

Change-Id: If2f1f617b53ebfb0cad8e350447aff2177784319
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agomissing a $ in appc-directed-graph pom 51/37551/2
Taka Cho [Wed, 21 Mar 2018 18:09:41 +0000 (14:09 -0400)]
missing a $ in appc-directed-graph pom

Change-Id: I51eaa20c5db47c50e7cc8ffc9f53d7f01bc54c33
Issue-ID: APPC-774
Signed-off-by: Taka Cho <tc012c@att.com>
6 years agoAdd junit coverage to request handler exceptions 55/37555/2
Lori Keighron [Wed, 21 Mar 2018 18:37:21 +0000 (14:37 -0400)]
Add junit coverage to request handler exceptions

Introduce 7 more junit-test files:
DGWorkflowNotFoundExceptionTest.java
LCMOperationsDisabledExceptionTest.java
MultipleRecordsRetrievedExceptionTest.java
NoRecordsRetrievedExceptionTest.java
RequestValidationExceptionTest.java
VNFNotFoundExceptionTest.java
WorkflowNotFoundExceptionTest.java

Issue-ID: APPC-773
Change-Id: I2e962a9614e3b17d77d2685e1055322531d832a1
Signed-off-by: Lori Keighron <lk2924@att.com>
6 years agoGenericProviderOperationsRequestFormatter junits 55/36455/3
Jakub Dudycz [Mon, 19 Mar 2018 09:05:43 +0000 (10:05 +0100)]
GenericProviderOperationsRequestFormatter junits

Improved code coverage.

Change-Id: I8914eae1327c15339034aa0d6905b36d7a252171
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoProviderOperations unit tests 39/36439/3
Jakub Dudycz [Mon, 19 Mar 2018 08:12:01 +0000 (09:12 +0100)]
ProviderOperations unit tests

Improved code coverage.

Change-Id: I04d0afe9799cc9bce5111173031ba8f9baa3e409
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agobugfix for error handling while detaching volumes 87/36887/3
Modaboina, Kusumakumari (km583p) [Tue, 20 Mar 2018 02:09:28 +0000 (22:09 -0400)]
bugfix for error handling while detaching volumes

Change-Id: I96f7d017a63b0741d87666f4608356567932ff77
Issue-ID: APPC-762
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
6 years agoUnit test for YANGGenerationException.java 53/37453/1
shubhada [Wed, 21 Mar 2018 12:25:03 +0000 (17:55 +0530)]
Unit test for YANGGenerationException.java

Unit test for YANGGenerationException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-yang-generator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fyang%2Fexception%2FYANGGenerationException.java

Change-Id: Ic23b9d863da6981090feeaad79cd1afa895b8e24
Issue-ID: APPC-772
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage 15/37415/1
shubhada [Wed, 21 Mar 2018 11:11:07 +0000 (16:41 +0530)]
Unit Test Coverage

Unit Test Coverage for:
1.RequestHandlerInput.java
2.RequestHandlerOutput.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-request-handler-api

Change-Id: I07e6be04fbe4958cd98cb0313e672e2a0098856e
Issue-ID: APPC-771
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage 05/37405/1
shubhada [Wed, 21 Mar 2018 10:29:56 +0000 (15:59 +0530)]
Unit Test Coverage

Unit Tests for:
1. Constants.java
2. DataReaderException.java
3. DgResolverException.java
4. FlowKey.java
5. VnfExecutionInternalException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fimpl

Change-Id: Ib3839ce2eb44b6f2e8b530696f4e4354e61df3d4
Issue-ID: APPC-756
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage 29/37329/1
shubhada [Wed, 21 Mar 2018 06:10:30 +0000 (11:40 +0530)]
Unit Test Coverage

Unit test Coverage for:
1. AppcClientBusinessException.java
2. AppcClientInternalException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-kit%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fclient%2Flcm%2Fexceptions

Change-Id: Ib06721b86b985400f521811ddd5c4f3278ee69c3
Issue-ID: APPC-768
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoAdd junits to request-handler-exception classes 55/37255/1
Lori Keighron [Tue, 20 Mar 2018 21:03:35 +0000 (17:03 -0400)]
Add junits to request-handler-exception classes

Introduce junit-tests for 3 request-handler-excetion classses

Issue-ID: APPC-769
Change-Id: I49f45ba50adccbfcc9725a7e458054e19f0c5efd
Signed-off-by: Lori Keighron <lk2924@att.com>
6 years agoRe-add public declaration 35/36935/2
Patrick Brady [Tue, 20 Mar 2018 05:59:26 +0000 (22:59 -0700)]
Re-add public declaration

The public declaration of setDbLibService was removed as part of this
(https://gerrit.onap.org/r/#/c/35763/) commit. This caused a failure in
karaf and the appc-common bundle failed to come up. This commit re-adds
public.

Change-Id: Ia6fa5d950b17e4f440a1243d071c90eedc9be818
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-731

6 years agoChefAdapterImpl Junits 21/36221/5
Michal Kabaj [Fri, 16 Mar 2018 13:53:36 +0000 (14:53 +0100)]
ChefAdapterImpl Junits

- Added new Unit tests for ChefAdapterImpl checkPushJob method
to class ChefAdapterImplJobPusherTest
- Added param check in implementation method
- Small refactor of nested conditions for improved readability

Change-Id: Id65b897535874eea6aafda66b7ac227832446cf4
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoUnit test for MessageDestination.java 25/36925/2
shubhada [Tue, 20 Mar 2018 05:24:33 +0000 (10:54 +0530)]
Unit test for MessageDestination.java

Unit test for MessageDestination.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2FMessageDestination.java

Change-Id: I17032a622571ce6ed6e6454967edabc2f2ef2d33
Issue-ID: APPC-764
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage 69/37069/1
shubhada [Tue, 20 Mar 2018 11:38:24 +0000 (17:08 +0530)]
Unit Test Coverage

Unit test coverage for InvalidRequestException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-simulator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsimulator%2Fclient%2Fimpl%2FInvalidRequestException.java

Change-Id: I282481303657a4ede2132d04ebe45ab9b18589d7
Issue-ID: APPC-765
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage 67/37067/1
shubhada [Tue, 20 Mar 2018 11:30:17 +0000 (17:00 +0530)]
Unit Test Coverage

Unit Test Coverage for AppcClientException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-kit%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fclient%2Flcm%2Fexceptions%2FAppcClientException.java

Change-Id: I70eb5b92f6c15b8f67a5e179be58d6f4f2565c47
Issue-ID: APPC-767
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoAdded junit coverage to CoreException class 05/36805/2
Lori Keighron [Mon, 19 Mar 2018 16:24:47 +0000 (12:24 -0400)]
Added junit coverage to CoreException class

Introduce junit-tests for CoreException class

Issue-ID: APPC-752
Change-Id: Ic5c8c2c83ce99d488e9e79a8fb72e7ad5fcf2ad3
Signed-off-by: Lori Keighron <lk2924@att.com>
6 years agoCode changes to fix Exception 97/36797/1
Balaji, Ramya (rb111y) [Mon, 19 Mar 2018 16:50:52 +0000 (12:50 -0400)]
Code changes to fix Exception

Reverted changes to method name in Transaction.java
to getuId() as this caused incorrect attributes
to be added to the generated JSON. Added unit test
to ensure this works as expected in the future.

Issue-ID: APPC-760
Change-Id: I07adcda0b5f04bd00efc113b94c68f48af13ad78
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
6 years agoUnit Test Coverage 65/36465/2
amshegokar [Mon, 19 Mar 2018 09:47:53 +0000 (15:17 +0530)]
Unit Test Coverage

Unit Tests for APPC Dispatcher Common - Domain Model Lib classes Part:2
1.ActionLevel.java
2.RequestModes.java
3.RequestStatus.java
4.ExternalActionStatus.java
5.VNFOperation.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm

Change-Id: I8f870e43d6f847cd9800a6178e1020ba26f0e211
Issue-ID: APPC-749
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoUnit tests for appc-ssh-adapter-api classes 11/36711/2
shubhada [Mon, 19 Mar 2018 12:52:39 +0000 (18:22 +0530)]
Unit tests for appc-ssh-adapter-api classes

Unit Tests for:
1. SshDataAccessException.java
2. SshException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh

Change-Id: I7c927a5319143e5df051d008f8f5dbb546699b99
Issue-ID: APPC-759
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit test for DependencyTypes.java 91/36691/2
shubhada [Mon, 19 Mar 2018 11:54:04 +0000 (17:24 +0530)]
Unit test for DependencyTypes.java

Unit test for DependencyTypes.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-dependency-model%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fobjects%2FDependencyTypes.java

Change-Id: I163105492a11a8f9e9657562812e829f17fc149e
Issue-ID: APPC-758
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit test for DependencyModelNotFound.java 45/36645/2
shubhada [Mon, 19 Mar 2018 11:03:14 +0000 (16:33 +0530)]
Unit test for DependencyModelNotFound.java

Unit test for DependencyModelNotFound.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-dependency-model%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fdependencymanager%2Fexception%2FDependencyModelNotFound.java

Change-Id: I17f2b9bb34ad161ea0c4b9eb902b0c0437970e37
Issue-ID: APPC-757
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage for Constants.java 63/36463/2
shubhada [Mon, 19 Mar 2018 09:45:08 +0000 (15:15 +0530)]
Unit Test Coverage for Constants.java

Unit test coverage for Constants.java

Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fimpl%2FConstants.java

Change-Id: Ic44430e25c429f420c667e51c5d5eb7b6feb8fe5
Issue-ID: APPC-755
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit test for:org/onap/appc/dg/aai/objects classes 37/36437/2
shubhada [Mon, 19 Mar 2018 08:00:42 +0000 (13:30 +0530)]
Unit test for:org/onap/appc/dg/aai/objects classes

Unit test Coverage for:
1.AAIQueryResult.java
2.Relationship.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fobjects

Change-Id: Ia4bb63454b5150e99cc38b12f867450da7ceae54
Issue-ID: APPC-754
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoResponseStatus unit tests 49/36249/4
Jakub Dudycz [Fri, 16 Mar 2018 16:06:29 +0000 (17:06 +0100)]
ResponseStatus unit tests

Improved code coverage.

Change-Id: I4f522d57b3e6e8d64d42c5e8b957db5a4a1bf07a
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoInputBody and OutputBody unit tests 43/36243/4
Jakub Dudycz [Fri, 16 Mar 2018 15:44:51 +0000 (16:44 +0100)]
InputBody and OutputBody unit tests

Improved code coverage.

Change-Id: I8b083f3281f0057d14cdfa9ae3c47eb3da99614e
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoDmaapMessage and its subclasses unit tests 41/36241/4
Jakub Dudycz [Fri, 16 Mar 2018 15:06:41 +0000 (16:06 +0100)]
DmaapMessage and its subclasses unit tests

Improved code coverage.

Change-Id: Iaa8496ce5c7aa5a8fc7ca203baf07ab8b7e55e5d
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoCommonHeader unit tests 39/36239/4
Jakub Dudycz [Fri, 16 Mar 2018 14:32:32 +0000 (15:32 +0100)]
CommonHeader unit tests

Improved code coverage.

Change-Id: Ic215cbd9ab6999f8e1d51c2f4d79d0d550057f04
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoActionIdentifiers unit tests 37/36237/3
Jakub Dudycz [Fri, 16 Mar 2018 14:18:32 +0000 (15:18 +0100)]
ActionIdentifiers unit tests

Improved code coverage.

Change-Id: I3d65411f5f746850a4e83c34f3ef349653e3bc3f
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoWorkerImpl unit tests 03/36203/3
Jakub Dudycz [Fri, 16 Mar 2018 11:12:01 +0000 (12:12 +0100)]
WorkerImpl unit tests

Improved code coverage.

Change-Id: I1a5170d16d64e95b759a576b56689164036370c1
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoUnit test for MDSALStoreException.java 81/36181/2
shubhada [Fri, 16 Mar 2018 07:42:09 +0000 (13:12 +0530)]
Unit test for MDSALStoreException.java

Unit test for MDSALStoreException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-mdsal-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fmdsal%2Fexception

Change-Id: Ia8f8a1e35fd8426389b7e036574e0bddd3a17974
Issue-ID: APPC-751
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit test coverage for domainmodel-lib classes 67/36167/2
shubhada [Fri, 16 Mar 2018 04:46:50 +0000 (10:16 +0530)]
Unit test coverage for domainmodel-lib classes

Unit test Coverage for:
1.Vnf.java
2.Vnfc.java
3.Vserver.java

Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-domain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel

Change-Id: I7a77a992a1957020a066bcd5676c9a63cc7cd328
Issue-ID: APPC-720
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoChefAdapterImpl Junits 09/36009/3
Michal Kabaj [Thu, 15 Mar 2018 13:37:19 +0000 (14:37 +0100)]
ChefAdapterImpl Junits

-Added new Unit tests for ChefAdapterImpl pushJob method
-Added new Junit class ChefAdapterImplJobPusher
-Some minor construction refactor in other junits

Change-Id: Id6fbcba2c5f5e11bfad2c7dccf6c06f777756a47
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoChefAdapterImpl- checkInfo junits 89/35989/4
Tomasz Gwozdecki [Thu, 15 Mar 2018 12:33:00 +0000 (08:33 -0400)]
ChefAdapterImpl- checkInfo junits

-Added junit tests for checkInfo method to verify if input params are present
-Support for Michal Kabaj as part of APPC-437

Change-Id: I29758f29f32354439ea0471e1afa3df6bb8184b9
Issue-ID: APPC-437
Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
6 years agoAdd Junit for ConnectionDetails class 41/36041/3
Neha Sood [Thu, 15 Mar 2018 16:29:36 +0000 (12:29 -0400)]
Add Junit for ConnectionDetails class

Change-Id: Ie0c7348583d6e99397374602c0b2cb804cda8d85
Issue-ID: APPC-734
Signed-off-by: Neha Sood <ns189k@att.com>
6 years agoHexHelper unit tests 73/35973/3
Jakub Dudycz [Thu, 15 Mar 2018 11:37:36 +0000 (12:37 +0100)]
HexHelper unit tests

Improved code coverage.

Change-Id: Ic3503ae79199767f3162c861f13ff1ecc889e1ec
Issue-ID: APPC-742
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoAdd junit coverage to EncryptionTool class 11/35811/4
Lori Keighron [Wed, 14 Mar 2018 17:37:42 +0000 (13:37 -0400)]
Add junit coverage to EncryptionTool class

Introduce junit-tests for EncryptionTool class

Change-Id: Iced5222f99d4af8b8ae5d0a75885c075a7291190
Issue-ID: APPC-726
Signed-off-by: Lori Keighron <lk2924@att.com>
6 years agoConverter unit tests 27/36027/2
Jakub Dudycz [Thu, 15 Mar 2018 14:49:36 +0000 (15:49 +0100)]
Converter unit tests

Improved code coverage.

Change-Id: Ieff8e92f907a9c45e4c810754d6e3d86e2c5bd0c
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoAbstractListener unit tests 15/36015/2
Jakub Dudycz [Thu, 15 Mar 2018 13:46:35 +0000 (14:46 +0100)]
AbstractListener unit tests

Improved code coverage.

Change-Id: I131f8bbbc72e0587572baa340d10fb56f6a1c5bc
Issue-ID: APPC-747
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoEncryptionTool unit tests 69/35969/2
Jakub Dudycz [Thu, 15 Mar 2018 10:52:18 +0000 (11:52 +0100)]
EncryptionTool unit tests

Improved code coverage.

Change-Id: I8882a9fd274b4ce03ef784aac89cdfbb786af4fe
Issue-ID: APPC-742
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoUnit Test for NoTransitionDefinedException.java 31/35931/2
shubhada [Thu, 15 Mar 2018 08:54:51 +0000 (14:24 +0530)]
Unit Test for NoTransitionDefinedException.java

Test Coverage for NoTransitionDefinedException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-lifecycle-management-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flifecyclemanager%2Fobjects%2FNoTransitionDefinedException.java

Change-Id: If5e9101a27473cfa7716669049518d4b5f04be2b
Issue-ID: APPC-739
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoCoverage for org.onap.appc.licmgr.exception class 65/35665/2
amshegokar [Wed, 14 Mar 2018 06:28:16 +0000 (11:58 +0530)]
Coverage for org.onap.appc.licmgr.exception class

Coverage for org.onap.appc.licmgr.exception class
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-license-manager-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flicmgr%2Fexception

Change-Id: Iefe4243fa12b2abb799db807ade2895c3d282a70
Issue-ID: APPC-729
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoUnit test for AAIQueryException.java 71/35971/2
shubhada [Thu, 15 Mar 2018 10:58:10 +0000 (16:28 +0530)]
Unit test for AAIQueryException.java

Unit Test for AAIQueryException.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fexception

Change-Id: Ia1674d459c3c2c1d89de8930ed8a5e749890dd02
Issue-ID: APPC-741
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoUnit Test Coverage 17/36017/2
amshegokar [Thu, 15 Mar 2018 13:59:52 +0000 (19:29 +0530)]
Unit Test Coverage

Unit test Coverage for:
org/onap/appc/executor/objects classes
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-command-executor-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fexecutor%2Fobjects

Change-Id: I692ed8e4fc6d3789fdcff24a4fc231320f5a23e3
Issue-ID: APPC-746
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoTest coverage for LifecycleException.java 49/35949/2
amshegokar [Thu, 15 Mar 2018 09:25:56 +0000 (14:55 +0530)]
Test coverage for LifecycleException.java

Test coverage for LifecycleException.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-lifecycle-management-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flifecyclemanager%2Fobjects%2FLifecycleException.java

Change-Id: If1f161a60221697423dffa1fd1984012a2fb5d04
Issue-ID: APPC-738
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoRemove ECOMP trademark 03/36003/2
Skip Wonnell [Thu, 15 Mar 2018 13:20:51 +0000 (08:20 -0500)]
Remove ECOMP trademark

Remove ECOMP trademark line from License.txt files at root directory

Issue-ID: APPC-737
Change-Id: I2bab0d6bcd9d1ead09fe20466648d9566f293b92
Signed-off-by: Skip Wonnell <skip@att.com>
6 years agoUnit tests for Dispatcher:lockmanager-api classes 33/35733/2
shubhada [Wed, 14 Mar 2018 10:09:52 +0000 (15:39 +0530)]
Unit tests for Dispatcher:lockmanager-api classes

Unit Test Coverage for:
1)LockException.java
2)LockRuntimeException

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Alock-manager-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flockmanager%2Fapi

Change-Id: Ic8407e10bbe49c868963bc4fb5c0125d4c8f29a2
Issue-ID: APPC-732
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoAaiService sonar fixes 03/32503/7
Jakub Dudycz [Thu, 22 Feb 2018 11:57:01 +0000 (12:57 +0100)]
AaiService sonar fixes

Change-Id: Ic0056db2aa02a41cfbdf66c2b60a978eac1114a4
Issue-ID: APPC-660
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoClientLib Support For Multiple Controllers 07/35807/2
vidhyasree [Wed, 14 Mar 2018 18:31:16 +0000 (14:31 -0400)]
ClientLib Support For Multiple Controllers

-APPC client library should support multiple controllers
-To support MSO added string controllerType

Issue-ID: APPC-683
Change-Id: Ief8416cb0912acc26015cb8271432de92a0af7dd
Signed-off-by: vidhyasree <sn141y@att.com>
6 years agoUnit test for SshConnectionDetails.java 71/34771/4
Patrick Brady [Wed, 14 Mar 2018 19:18:35 +0000 (15:18 -0400)]
Unit test for SshConnectionDetails.java

Unit test for SshConnectionDetails.java

Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh%2FSshConnectionDetails.java

Change-Id: I0be7e83bac3be615a664f3c1089dae299c8d3858
Issue-ID: APPC-715
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoAdd INFO.yaml file 77/33077/4
Jessica Wagantall [Tue, 27 Feb 2018 06:18:32 +0000 (22:18 -0800)]
Add INFO.yaml file

Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information

Change-Id: Ie42724d8a40acc7ec5a8797c88bbe7103d4eb264
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Signed-off-by: Patrick Brady <pb071s@att.com>
6 years agoMetadataServiceImplTest unit tests 63/35763/6
Jakub Dudycz [Wed, 14 Mar 2018 13:54:38 +0000 (14:54 +0100)]
MetadataServiceImplTest unit tests

Improved code coverage.

Change-Id: I20a0af3050bc78b470377486f7493d72f8ba0f78
Issue-ID: APPC-731
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoDirected Graph & Associated code changes 19/35619/3
Balaji, Ramya (rb111y) [Tue, 13 Mar 2018 20:58:23 +0000 (16:58 -0400)]
Directed Graph & Associated code changes

Changes to DGs for A&AI processing and
for formatting controller template id
if passed in input.

Issue-ID: APPC-690, APPC-691
Change-Id: I3019d093f8327839aa286a5784fcc96bde0fb0d6
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
6 years agoUnit Test Coverage 71/35671/1
shubhada [Wed, 14 Mar 2018 06:52:04 +0000 (12:22 +0530)]
Unit Test Coverage

Unit Test Coverage for:
1)LCMResponse.java
2)VNFOperationOutcome.java

Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-lifecycle-management-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flifecyclemanager%2Fobjects

Change-Id: I1296cad32cd750297557888ba0fcfd63d61d2b69
Issue-ID: APPC-728
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoStringHelper unit tests 13/35513/5
Jakub Dudycz [Tue, 13 Mar 2018 15:26:00 +0000 (16:26 +0100)]
StringHelper unit tests

Improved code coverage + some test class refactor

Change-Id: I5211d69369d0d3aff0ebe5ee603545f171dfd07a
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoStreamHelper unit tests 43/35443/9
Jakub Dudycz [Tue, 13 Mar 2018 11:06:08 +0000 (12:06 +0100)]
StreamHelper unit tests

Improved code coverage

Change-Id: Ie0dcf723e73890aa24b761fb3b46e2739d239040
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoPathContext unit tests 29/35429/6
Jakub Dudycz [Tue, 13 Mar 2018 10:51:24 +0000 (11:51 +0100)]
PathContext unit tests

Improved code coverage

Change-Id: I8b7d1fe8a033bd1c4df34bdd74efc011dc130a46
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoCoverage for org.onap.appc.adapter.ssh classes 75/35475/2
amshegokar [Tue, 13 Mar 2018 13:25:12 +0000 (18:55 +0530)]
Coverage for org.onap.appc.adapter.ssh classes

Coverage for org.onap.appc.adapter.ssh classes
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-tests%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh

Change-Id: Icd1dde27c8588f217b6cca83f1cde3a8b24a41c3
Issue-ID: APPC-725
Signed-off-by: amshegokar<AS00500801@techmahindra.com>
6 years agoMessageFormatter unit tests 45/35245/7
Jakub Dudycz [Mon, 12 Mar 2018 15:05:57 +0000 (16:05 +0100)]
MessageFormatter unit tests

Improved code coverage

Change-Id: I8ef81c6c8efaa796d62d8913e7dfbf160bf3c02d
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoCode changes for A&AI add/update 39/35339/3
Balaji, Ramya (rb111y) [Tue, 13 Mar 2018 01:14:03 +0000 (21:14 -0400)]
Code changes for A&AI add/update

Code and Unit Test updates
to updating vnfc records when vf module
is provided in request.

Issue-ID: APPC-622
Change-Id: I76903eb8bfa6910e3fb2f6e404504d2b9b5fb477
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
6 years agoJsonUtil unit tests 39/35239/8
Jakub Dudycz [Mon, 12 Mar 2018 14:24:40 +0000 (15:24 +0100)]
JsonUtil unit tests

Improved code coverage + some test class refactor

Change-Id: Ie69f4a699f7f924438eda24014c44fe54643e707
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoImprove coverage FlowControlNode #8 95/35395/3
kurczews [Fri, 2 Mar 2018 13:44:03 +0000 (14:44 +0100)]
Improve coverage FlowControlNode #8

* refactor & test dependency info method
* extract get flow sequence method

Change-Id: I6c9ab49676b6c325196ec179e863038550b5dad6
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoChefAdapterImpl Junits 47/35447/1
Michal Kabaj [Tue, 13 Mar 2018 11:18:08 +0000 (12:18 +0100)]
ChefAdapterImpl Junits

-Added new Unit tests for ChefAdapterImpl#trigger method
-Refactored ChefAdapterFactory to allow mock injection
-Added new create() method to ChefApiClientFactory which does not set
any Chef specific headers for the purpose of trigger method
-Cleaned up the trigger method - simplified usage, removed useless doFailure
method and inlined its logic and unified HttClient usage -> HttpClient is not
used directly but through existing ChefApiClient
-removed redundant TestChefAdapterImpl tests which have already been rewritten

Change-Id: I830d203877224aa2c5e1b0dff39d1171f1f2f0ef
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoEncryptionTool unit tests 23/35223/2
Jakub Dudycz [Mon, 12 Mar 2018 12:53:32 +0000 (13:53 +0100)]
EncryptionTool unit tests

Improved code coverage + some test class refactor.

Change-Id: I7e3637c07b580acea383d1ccfd6a0608f69109fe
Issue-ID: APPC-722
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
6 years agoDecouple ChefApiClientImpl from header creation 37/35237/2
Michal Kabaj [Mon, 12 Mar 2018 14:04:50 +0000 (15:04 +0100)]
Decouple ChefApiClientImpl from header creation

Introduce new FunctionalInterface HttpHeaderFactory to allow customization of
http header providers when creating ChefApiClientImpl using ChefApiClientFactory
This allows for better encapsulation of header specific values such as:
userId,organizations,pemPath.

Change-Id: Iec2c7cff8e664a18e15d7e973920152fdb158c98
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoImprove coverage FlowControlNode #7 33/35133/2
kurczews [Fri, 2 Mar 2018 13:10:26 +0000 (14:10 +0100)]
Improve coverage FlowControlNode #7

* refactor & test capabilities data method

Change-Id: I523d07e283a347a4ad16f3babc8a25e0dd5a6acc
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoUnit Test Coverage for ConnectionDetails.java 59/35059/2
amshegokar [Sun, 11 Mar 2018 13:47:42 +0000 (19:17 +0530)]
Unit Test Coverage for ConnectionDetails.java

Unit Test Coverage for ConnectionDetails.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fobjects%2FConnectionDetails.java

Change-Id: Ia253f7cea39d980f966f0afc5ab1b64d1e3f527e
Issue-ID: APPC-718
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoUnit test Coverage for BundleInfo.java 57/35057/2
amshegokar [Sun, 11 Mar 2018 13:42:30 +0000 (19:12 +0530)]
Unit test Coverage for BundleInfo.java

Unit test Coverage for BundleInfo.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-mdsal-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fmdsal%2Fobjects%2FBundleInfo.java

Change-Id: I3d0e08b15f362bc00fc8fbbd4d809e88ddc6f792
Issue-ID: APPC-719
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
6 years agoAdding APPC CDT Guide 89/34989/2
Scott Seabolt [Fri, 9 Mar 2018 20:33:13 +0000 (15:33 -0500)]
Adding APPC CDT Guide
Initial Draft

Issue-ID: APPC-375
Change-Id: I79f453f0451c10fbbe352cf88687eed100f83d65
Signed-off-by: Scott Seabolt <js9808@att.com>
6 years agoChefAdapterImpl JUnits 29/34529/3
Michal Kabaj [Wed, 7 Mar 2018 14:08:52 +0000 (15:08 +0100)]
ChefAdapterImpl JUnits

-Added unit tests for chefXXX methods - extracted new test class
-Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits
-New Factory class ChefAdapterFactory for ChefAdapterImpl construction
-Fixed potential bug with wrong String being assigned in iniSvcLogic method

Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
6 years agoUnit test for Workflow Management API classes 09/34909/2
shubhada [Fri, 9 Mar 2018 07:17:12 +0000 (12:47 +0530)]
Unit test for Workflow Management API classes

Unit test for Workflow Management API classes

Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-workflow-management-api

Change-Id: I641d4b14d213f8369d0b07c92feee49dadbcf70f
Issue-ID: APPC-716
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoImprove coverage FlowControlNode #6 47/34447/4
kurczews [Fri, 2 Mar 2018 12:32:30 +0000 (13:32 +0100)]
Improve coverage FlowControlNode #6

* Extract InventoryInfoExtractor as util class
* Add test coverage

Change-Id: I24f16feddacb6a9898e9c81aa036ba3eafed2967
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
6 years agoupgrade httpclient from 4.5 to 4.5.3 15/34615/3
Taka Cho [Thu, 8 Mar 2018 00:52:42 +0000 (19:52 -0500)]
upgrade httpclient from 4.5 to 4.5.3

this comes from com.att.nsa.cambriaClient

Change-Id: Ib451837526fd6de2a411c530fd3131a26d36473a
Issue-ID: APPC-711
Signed-off-by: Taka Cho <tc012c@att.com>
6 years agoupgrade bcprov to 1.56 81/34581/3
Taka Cho [Wed, 7 Mar 2018 21:39:55 +0000 (16:39 -0500)]
upgrade bcprov to 1.56

there are two versions: 1.55 and 1.47 to be upgraded to 1.56

Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38
Issue-ID: APPC-708
Signed-off-by: Taka Cho <tc012c@att.com>
6 years agoupgrade httpclient from 4.5.1 to 4.5.3 51/34551/2
Taka Cho [Wed, 7 Mar 2018 16:42:59 +0000 (11:42 -0500)]
upgrade httpclient from 4.5.1 to 4.5.3

Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2
Issue-ID: APPC-703
Signed-off-by: Taka Cho <tc012c@att.com>
6 years agoCoverage for yang-generator object class 73/34673/1
shubhada [Thu, 8 Mar 2018 06:15:41 +0000 (11:45 +0530)]
Coverage for yang-generator object class

Unit Test Coverage for Leaf.java

Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-yang-generator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fyang%2Fobjects

Change-Id: I133ffe9688e7b63024d154a8bef2c5559fb546df
Issue-ID: APPC-704
Signed-off-by: shubhada <SV00449682@techmahindra.com>
6 years agoJUnits for sftp methods 91/33191/3
Tomek Kaminski [Tue, 27 Feb 2018 15:40:35 +0000 (16:40 +0100)]
JUnits for sftp methods

implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java

Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10
Issue-ID: APPC-676
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
6 years agoupgrade httpclient from 4.4.1 to 4.5.3 45/34345/3
Taka Cho [Tue, 6 Mar 2018 19:23:11 +0000 (14:23 -0500)]
upgrade httpclient from 4.4.1 to 4.5.3

Change-Id: I2f8657097c432e2017ae1287fecc366cb8559076
Issue-ID: APPC-699
Signed-off-by: Taka Cho <tc012c@att.com>