shubhada [Wed, 21 Mar 2018 11:11:07 +0000 (16:41 +0530)]
Unit Test Coverage
Unit Test Coverage for:
1.RequestHandlerInput.java
2.RequestHandlerOutput.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-request-handler-api
Change-Id: I07e6be04fbe4958cd98cb0313e672e2a0098856e
Issue-ID: APPC-771
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Wed, 21 Mar 2018 10:29:56 +0000 (15:59 +0530)]
Unit Test Coverage
Unit Tests for:
1. Constants.java
2. DataReaderException.java
3. DgResolverException.java
4. FlowKey.java
5. VnfExecutionInternalException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fimpl
Change-Id: Ib3839ce2eb44b6f2e8b530696f4e4354e61df3d4
Issue-ID: APPC-756
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Wed, 21 Mar 2018 06:10:30 +0000 (11:40 +0530)]
Unit Test Coverage
Unit test Coverage for:
1. AppcClientBusinessException.java
2. AppcClientInternalException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-kit%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fclient%2Flcm%2Fexceptions
Change-Id: Ib06721b86b985400f521811ddd5c4f3278ee69c3
Issue-ID: APPC-768
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Lori Keighron [Tue, 20 Mar 2018 21:03:35 +0000 (17:03 -0400)]
Add junits to request-handler-exception classes
Introduce junit-tests for 3 request-handler-excetion classses
Issue-ID: APPC-769
Change-Id: I49f45ba50adccbfcc9725a7e458054e19f0c5efd
Signed-off-by: Lori Keighron <lk2924@att.com>
Patrick Brady [Tue, 20 Mar 2018 05:59:26 +0000 (22:59 -0700)]
Re-add public declaration
The public declaration of setDbLibService was removed as part of this
(https://gerrit.onap.org/r/#/c/35763/) commit. This caused a failure in
karaf and the appc-common bundle failed to come up. This commit re-adds
public.
Change-Id: Ia6fa5d950b17e4f440a1243d071c90eedc9be818
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-731
Michal Kabaj [Fri, 16 Mar 2018 13:53:36 +0000 (14:53 +0100)]
ChefAdapterImpl Junits
- Added new Unit tests for ChefAdapterImpl checkPushJob method
to class ChefAdapterImplJobPusherTest
- Added param check in implementation method
- Small refactor of nested conditions for improved readability
Change-Id: Id65b897535874eea6aafda66b7ac227832446cf4
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
shubhada [Tue, 20 Mar 2018 05:24:33 +0000 (10:54 +0530)]
Unit test for MessageDestination.java
Unit test for MessageDestination.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2FMessageDestination.java
Change-Id: I17032a622571ce6ed6e6454967edabc2f2ef2d33
Issue-ID: APPC-764
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Tue, 20 Mar 2018 11:38:24 +0000 (17:08 +0530)]
Unit Test Coverage
Unit test coverage for InvalidRequestException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-simulator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsimulator%2Fclient%2Fimpl%2FInvalidRequestException.java
Change-Id: I282481303657a4ede2132d04ebe45ab9b18589d7
Issue-ID: APPC-765
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Tue, 20 Mar 2018 11:30:17 +0000 (17:00 +0530)]
Unit Test Coverage
Unit Test Coverage for AppcClientException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-kit%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fclient%2Flcm%2Fexceptions%2FAppcClientException.java
Change-Id: I70eb5b92f6c15b8f67a5e179be58d6f4f2565c47
Issue-ID: APPC-767
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Lori Keighron [Mon, 19 Mar 2018 16:24:47 +0000 (12:24 -0400)]
Added junit coverage to CoreException class
Introduce junit-tests for CoreException class
Issue-ID: APPC-752
Change-Id: Ic5c8c2c83ce99d488e9e79a8fb72e7ad5fcf2ad3
Signed-off-by: Lori Keighron <lk2924@att.com>
Balaji, Ramya (rb111y) [Mon, 19 Mar 2018 16:50:52 +0000 (12:50 -0400)]
Code changes to fix Exception
Reverted changes to method name in Transaction.java
to getuId() as this caused incorrect attributes
to be added to the generated JSON. Added unit test
to ensure this works as expected in the future.
Issue-ID: APPC-760
Change-Id: I07adcda0b5f04bd00efc113b94c68f48af13ad78
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
amshegokar [Mon, 19 Mar 2018 09:47:53 +0000 (15:17 +0530)]
Unit Test Coverage
Unit Tests for APPC Dispatcher Common - Domain Model Lib classes Part:2
1.ActionLevel.java
2.RequestModes.java
3.RequestStatus.java
4.ExternalActionStatus.java
5.VNFOperation.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I8f870e43d6f847cd9800a6178e1020ba26f0e211
Issue-ID: APPC-749
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
shubhada [Mon, 19 Mar 2018 12:52:39 +0000 (18:22 +0530)]
Unit tests for appc-ssh-adapter-api classes
Unit Tests for:
1. SshDataAccessException.java
2. SshException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh
Change-Id: I7c927a5319143e5df051d008f8f5dbb546699b99
Issue-ID: APPC-759
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 11:54:04 +0000 (17:24 +0530)]
Unit test for DependencyTypes.java
Unit test for DependencyTypes.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-dependency-model%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fobjects%2FDependencyTypes.java
Change-Id: I163105492a11a8f9e9657562812e829f17fc149e
Issue-ID: APPC-758
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 11:03:14 +0000 (16:33 +0530)]
Unit test for DependencyModelNotFound.java
Unit test for DependencyModelNotFound.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-dependency-model%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fdependencymanager%2Fexception%2FDependencyModelNotFound.java
Change-Id: I17f2b9bb34ad161ea0c4b9eb902b0c0437970e37
Issue-ID: APPC-757
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 09:45:08 +0000 (15:15 +0530)]
Unit Test Coverage for Constants.java
Unit test coverage for Constants.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fimpl%2FConstants.java
Change-Id: Ic44430e25c429f420c667e51c5d5eb7b6feb8fe5
Issue-ID: APPC-755
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 08:00:42 +0000 (13:30 +0530)]
Unit test for:org/onap/appc/dg/aai/objects classes
Unit test Coverage for:
1.AAIQueryResult.java
2.Relationship.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fobjects
Change-Id: Ia4bb63454b5150e99cc38b12f867450da7ceae54
Issue-ID: APPC-754
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Fri, 16 Mar 2018 16:06:29 +0000 (17:06 +0100)]
ResponseStatus unit tests
Improved code coverage.
Change-Id: I4f522d57b3e6e8d64d42c5e8b957db5a4a1bf07a
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 15:44:51 +0000 (16:44 +0100)]
InputBody and OutputBody unit tests
Improved code coverage.
Change-Id: I8b083f3281f0057d14cdfa9ae3c47eb3da99614e
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 15:06:41 +0000 (16:06 +0100)]
DmaapMessage and its subclasses unit tests
Improved code coverage.
Change-Id: Iaa8496ce5c7aa5a8fc7ca203baf07ab8b7e55e5d
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 14:32:32 +0000 (15:32 +0100)]
CommonHeader unit tests
Improved code coverage.
Change-Id: Ic215cbd9ab6999f8e1d51c2f4d79d0d550057f04
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 14:18:32 +0000 (15:18 +0100)]
ActionIdentifiers unit tests
Improved code coverage.
Change-Id: I3d65411f5f746850a4e83c34f3ef349653e3bc3f
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 11:12:01 +0000 (12:12 +0100)]
WorkerImpl unit tests
Improved code coverage.
Change-Id: I1a5170d16d64e95b759a576b56689164036370c1
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
shubhada [Fri, 16 Mar 2018 07:42:09 +0000 (13:12 +0530)]
Unit test for MDSALStoreException.java
Unit test for MDSALStoreException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-mdsal-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fmdsal%2Fexception
Change-Id: Ia8f8a1e35fd8426389b7e036574e0bddd3a17974
Issue-ID: APPC-751
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Fri, 16 Mar 2018 04:46:50 +0000 (10:16 +0530)]
Unit test coverage for domainmodel-lib classes
Unit test Coverage for:
1.Vnf.java
2.Vnfc.java
3.Vserver.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-domain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel
Change-Id: I7a77a992a1957020a066bcd5676c9a63cc7cd328
Issue-ID: APPC-720
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Michal Kabaj [Thu, 15 Mar 2018 13:37:19 +0000 (14:37 +0100)]
ChefAdapterImpl Junits
-Added new Unit tests for ChefAdapterImpl pushJob method
-Added new Junit class ChefAdapterImplJobPusher
-Some minor construction refactor in other junits
Change-Id: Id6fbcba2c5f5e11bfad2c7dccf6c06f777756a47
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Tomasz Gwozdecki [Thu, 15 Mar 2018 12:33:00 +0000 (08:33 -0400)]
ChefAdapterImpl- checkInfo junits
-Added junit tests for checkInfo method to verify if input params are present
-Support for Michal Kabaj as part of APPC-437
Change-Id: I29758f29f32354439ea0471e1afa3df6bb8184b9
Issue-ID: APPC-437
Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>
Neha Sood [Thu, 15 Mar 2018 16:29:36 +0000 (12:29 -0400)]
Add Junit for ConnectionDetails class
Change-Id: Ie0c7348583d6e99397374602c0b2cb804cda8d85
Issue-ID: APPC-734
Signed-off-by: Neha Sood <ns189k@att.com>
Jakub Dudycz [Thu, 15 Mar 2018 11:37:36 +0000 (12:37 +0100)]
HexHelper unit tests
Improved code coverage.
Change-Id: Ic3503ae79199767f3162c861f13ff1ecc889e1ec
Issue-ID: APPC-742
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Lori Keighron [Wed, 14 Mar 2018 17:37:42 +0000 (13:37 -0400)]
Add junit coverage to EncryptionTool class
Introduce junit-tests for EncryptionTool class
Change-Id: Iced5222f99d4af8b8ae5d0a75885c075a7291190
Issue-ID: APPC-726
Signed-off-by: Lori Keighron <lk2924@att.com>
Jakub Dudycz [Thu, 15 Mar 2018 14:49:36 +0000 (15:49 +0100)]
Converter unit tests
Improved code coverage.
Change-Id: Ieff8e92f907a9c45e4c810754d6e3d86e2c5bd0c
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Mar 2018 13:46:35 +0000 (14:46 +0100)]
AbstractListener unit tests
Improved code coverage.
Change-Id: I131f8bbbc72e0587572baa340d10fb56f6a1c5bc
Issue-ID: APPC-747
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Mar 2018 10:52:18 +0000 (11:52 +0100)]
EncryptionTool unit tests
Improved code coverage.
Change-Id: I8882a9fd274b4ce03ef784aac89cdfbb786af4fe
Issue-ID: APPC-742
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
shubhada [Thu, 15 Mar 2018 08:54:51 +0000 (14:24 +0530)]
Unit Test for NoTransitionDefinedException.java
Test Coverage for NoTransitionDefinedException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-lifecycle-management-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flifecyclemanager%2Fobjects%2FNoTransitionDefinedException.java
Change-Id: If5e9101a27473cfa7716669049518d4b5f04be2b
Issue-ID: APPC-739
Signed-off-by: shubhada <SV00449682@techmahindra.com>
amshegokar [Wed, 14 Mar 2018 06:28:16 +0000 (11:58 +0530)]
Coverage for org.onap.appc.licmgr.exception class
Coverage for org.onap.appc.licmgr.exception class
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-license-manager-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flicmgr%2Fexception
Change-Id: Iefe4243fa12b2abb799db807ade2895c3d282a70
Issue-ID: APPC-729
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
shubhada [Thu, 15 Mar 2018 10:58:10 +0000 (16:28 +0530)]
Unit test for AAIQueryException.java
Unit Test for AAIQueryException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fexception
Change-Id: Ia1674d459c3c2c1d89de8930ed8a5e749890dd02
Issue-ID: APPC-741
Signed-off-by: shubhada <SV00449682@techmahindra.com>
amshegokar [Thu, 15 Mar 2018 13:59:52 +0000 (19:29 +0530)]
Unit Test Coverage
Unit test Coverage for:
org/onap/appc/executor/objects classes
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-command-executor-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fexecutor%2Fobjects
Change-Id: I692ed8e4fc6d3789fdcff24a4fc231320f5a23e3
Issue-ID: APPC-746
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Thu, 15 Mar 2018 09:25:56 +0000 (14:55 +0530)]
Test coverage for LifecycleException.java
Test coverage for LifecycleException.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-lifecycle-management-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flifecyclemanager%2Fobjects%2FLifecycleException.java
Change-Id: If1f161a60221697423dffa1fd1984012a2fb5d04
Issue-ID: APPC-738
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Skip Wonnell [Thu, 15 Mar 2018 13:20:51 +0000 (08:20 -0500)]
Remove ECOMP trademark
Remove ECOMP trademark line from License.txt files at root directory
Issue-ID: APPC-737
Change-Id: I2bab0d6bcd9d1ead09fe20466648d9566f293b92
Signed-off-by: Skip Wonnell <skip@att.com>
shubhada [Wed, 14 Mar 2018 10:09:52 +0000 (15:39 +0530)]
Unit tests for Dispatcher:lockmanager-api classes
Unit Test Coverage for:
1)LockException.java
2)LockRuntimeException
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Alock-manager-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flockmanager%2Fapi
Change-Id: Ic8407e10bbe49c868963bc4fb5c0125d4c8f29a2
Issue-ID: APPC-732
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Thu, 22 Feb 2018 11:57:01 +0000 (12:57 +0100)]
AaiService sonar fixes
Change-Id: Ic0056db2aa02a41cfbdf66c2b60a978eac1114a4
Issue-ID: APPC-660
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
vidhyasree [Wed, 14 Mar 2018 18:31:16 +0000 (14:31 -0400)]
ClientLib Support For Multiple Controllers
-APPC client library should support multiple controllers
-To support MSO added string controllerType
Issue-ID: APPC-683
Change-Id: Ief8416cb0912acc26015cb8271432de92a0af7dd
Signed-off-by: vidhyasree <sn141y@att.com>
Patrick Brady [Wed, 14 Mar 2018 19:18:35 +0000 (15:18 -0400)]
Unit test for SshConnectionDetails.java
Unit test for SshConnectionDetails.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh%2FSshConnectionDetails.java
Change-Id: I0be7e83bac3be615a664f3c1089dae299c8d3858
Issue-ID: APPC-715
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Signed-off-by: Patrick Brady <pb071s@att.com>
Jessica Wagantall [Tue, 27 Feb 2018 06:18:32 +0000 (22:18 -0800)]
Add INFO.yaml file
Add INFO.yaml to list:
- Project description
- Properties
- PTL information
- Meeting information
- Committer information
Change-Id: Ie42724d8a40acc7ec5a8797c88bbe7103d4eb264
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Signed-off-by: Patrick Brady <pb071s@att.com>
Jakub Dudycz [Wed, 14 Mar 2018 13:54:38 +0000 (14:54 +0100)]
MetadataServiceImplTest unit tests
Improved code coverage.
Change-Id: I20a0af3050bc78b470377486f7493d72f8ba0f78
Issue-ID: APPC-731
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Balaji, Ramya (rb111y) [Tue, 13 Mar 2018 20:58:23 +0000 (16:58 -0400)]
Directed Graph & Associated code changes
Changes to DGs for A&AI processing and
for formatting controller template id
if passed in input.
Issue-ID: APPC-690, APPC-691
Change-Id: I3019d093f8327839aa286a5784fcc96bde0fb0d6
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
shubhada [Wed, 14 Mar 2018 06:52:04 +0000 (12:22 +0530)]
Unit Test Coverage
Unit Test Coverage for:
1)LCMResponse.java
2)VNFOperationOutcome.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-lifecycle-management-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flifecyclemanager%2Fobjects
Change-Id: I1296cad32cd750297557888ba0fcfd63d61d2b69
Issue-ID: APPC-728
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Tue, 13 Mar 2018 15:26:00 +0000 (16:26 +0100)]
StringHelper unit tests
Improved code coverage + some test class refactor
Change-Id: I5211d69369d0d3aff0ebe5ee603545f171dfd07a
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 13 Mar 2018 11:06:08 +0000 (12:06 +0100)]
StreamHelper unit tests
Improved code coverage
Change-Id: Ie0dcf723e73890aa24b761fb3b46e2739d239040
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 13 Mar 2018 10:51:24 +0000 (11:51 +0100)]
PathContext unit tests
Improved code coverage
Change-Id: I8b7d1fe8a033bd1c4df34bdd74efc011dc130a46
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
amshegokar [Tue, 13 Mar 2018 13:25:12 +0000 (18:55 +0530)]
Coverage for org.onap.appc.adapter.ssh classes
Coverage for org.onap.appc.adapter.ssh classes
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-tests%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh
Change-Id: Icd1dde27c8588f217b6cca83f1cde3a8b24a41c3
Issue-ID: APPC-725
Signed-off-by: amshegokar<AS00500801@techmahindra.com>
Jakub Dudycz [Mon, 12 Mar 2018 15:05:57 +0000 (16:05 +0100)]
MessageFormatter unit tests
Improved code coverage
Change-Id: I8ef81c6c8efaa796d62d8913e7dfbf160bf3c02d
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Balaji, Ramya (rb111y) [Tue, 13 Mar 2018 01:14:03 +0000 (21:14 -0400)]
Code changes for A&AI add/update
Code and Unit Test updates
to updating vnfc records when vf module
is provided in request.
Issue-ID: APPC-622
Change-Id: I76903eb8bfa6910e3fb2f6e404504d2b9b5fb477
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Jakub Dudycz [Mon, 12 Mar 2018 14:24:40 +0000 (15:24 +0100)]
JsonUtil unit tests
Improved code coverage + some test class refactor
Change-Id: Ie69f4a699f7f924438eda24014c44fe54643e707
Issue-ID: APPC-724
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Fri, 2 Mar 2018 13:44:03 +0000 (14:44 +0100)]
Improve coverage FlowControlNode #8
* refactor & test dependency info method
* extract get flow sequence method
Change-Id: I6c9ab49676b6c325196ec179e863038550b5dad6
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Michal Kabaj [Tue, 13 Mar 2018 11:18:08 +0000 (12:18 +0100)]
ChefAdapterImpl Junits
-Added new Unit tests for ChefAdapterImpl#trigger method
-Refactored ChefAdapterFactory to allow mock injection
-Added new create() method to ChefApiClientFactory which does not set
any Chef specific headers for the purpose of trigger method
-Cleaned up the trigger method - simplified usage, removed useless doFailure
method and inlined its logic and unified HttClient usage -> HttpClient is not
used directly but through existing ChefApiClient
-removed redundant TestChefAdapterImpl tests which have already been rewritten
Change-Id: I830d203877224aa2c5e1b0dff39d1171f1f2f0ef
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Jakub Dudycz [Mon, 12 Mar 2018 12:53:32 +0000 (13:53 +0100)]
EncryptionTool unit tests
Improved code coverage + some test class refactor.
Change-Id: I7e3637c07b580acea383d1ccfd6a0608f69109fe
Issue-ID: APPC-722
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Michal Kabaj [Mon, 12 Mar 2018 14:04:50 +0000 (15:04 +0100)]
Decouple ChefApiClientImpl from header creation
Introduce new FunctionalInterface HttpHeaderFactory to allow customization of
http header providers when creating ChefApiClientImpl using ChefApiClientFactory
This allows for better encapsulation of header specific values such as:
userId,organizations,pemPath.
Change-Id: Iec2c7cff8e664a18e15d7e973920152fdb158c98
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
kurczews [Fri, 2 Mar 2018 13:10:26 +0000 (14:10 +0100)]
Improve coverage FlowControlNode #7
* refactor & test capabilities data method
Change-Id: I523d07e283a347a4ad16f3babc8a25e0dd5a6acc
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
amshegokar [Sun, 11 Mar 2018 13:47:42 +0000 (19:17 +0530)]
Unit Test Coverage for ConnectionDetails.java
Unit Test Coverage for ConnectionDetails.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fobjects%2FConnectionDetails.java
Change-Id: Ia253f7cea39d980f966f0afc5ab1b64d1e3f527e
Issue-ID: APPC-718
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Sun, 11 Mar 2018 13:42:30 +0000 (19:12 +0530)]
Unit test Coverage for BundleInfo.java
Unit test Coverage for BundleInfo.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-mdsal-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fmdsal%2Fobjects%2FBundleInfo.java
Change-Id: I3d0e08b15f362bc00fc8fbbd4d809e88ddc6f792
Issue-ID: APPC-719
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Scott Seabolt [Fri, 9 Mar 2018 20:33:13 +0000 (15:33 -0500)]
Adding APPC CDT Guide
Initial Draft
Issue-ID: APPC-375
Change-Id: I79f453f0451c10fbbe352cf88687eed100f83d65
Signed-off-by: Scott Seabolt <js9808@att.com>
Michal Kabaj [Wed, 7 Mar 2018 14:08:52 +0000 (15:08 +0100)]
ChefAdapterImpl JUnits
-Added unit tests for chefXXX methods - extracted new test class
-Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits
-New Factory class ChefAdapterFactory for ChefAdapterImpl construction
-Fixed potential bug with wrong String being assigned in iniSvcLogic method
Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
shubhada [Fri, 9 Mar 2018 07:17:12 +0000 (12:47 +0530)]
Unit test for Workflow Management API classes
Unit test for Workflow Management API classes
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-workflow-management-api
Change-Id: I641d4b14d213f8369d0b07c92feee49dadbcf70f
Issue-ID: APPC-716
Signed-off-by: shubhada <SV00449682@techmahindra.com>
kurczews [Fri, 2 Mar 2018 12:32:30 +0000 (13:32 +0100)]
Improve coverage FlowControlNode #6
* Extract InventoryInfoExtractor as util class
* Add test coverage
Change-Id: I24f16feddacb6a9898e9c81aa036ba3eafed2967
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Taka Cho [Thu, 8 Mar 2018 00:52:42 +0000 (19:52 -0500)]
upgrade httpclient from 4.5 to 4.5.3
this comes from com.att.nsa.cambriaClient
Change-Id: Ib451837526fd6de2a411c530fd3131a26d36473a
Issue-ID: APPC-711
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Wed, 7 Mar 2018 21:39:55 +0000 (16:39 -0500)]
upgrade bcprov to 1.56
there are two versions: 1.55 and 1.47 to be upgraded to 1.56
Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38
Issue-ID: APPC-708
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Wed, 7 Mar 2018 16:42:59 +0000 (11:42 -0500)]
upgrade httpclient from 4.5.1 to 4.5.3
Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2
Issue-ID: APPC-703
Signed-off-by: Taka Cho <tc012c@att.com>
shubhada [Thu, 8 Mar 2018 06:15:41 +0000 (11:45 +0530)]
Coverage for yang-generator object class
Unit Test Coverage for Leaf.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-yang-generator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fyang%2Fobjects
Change-Id: I133ffe9688e7b63024d154a8bef2c5559fb546df
Issue-ID: APPC-704
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Tomek Kaminski [Tue, 27 Feb 2018 15:40:35 +0000 (16:40 +0100)]
JUnits for sftp methods
implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java
Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10
Issue-ID: APPC-676
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
Taka Cho [Tue, 6 Mar 2018 19:23:11 +0000 (14:23 -0500)]
upgrade httpclient from 4.4.1 to 4.5.3
Change-Id: I2f8657097c432e2017ae1287fecc366cb8559076
Issue-ID: APPC-699
Signed-off-by: Taka Cho <tc012c@att.com>
Balaji, Ramya (rb111y) [Tue, 6 Mar 2018 20:20:22 +0000 (15:20 -0500)]
Code changes to processing new group notation type
Code and Unit Test cases to proces for
group notation type existing-value
Issue-ID: APPC-621
Change-Id: I8446f5f66c7b240018b0bee00d8b28c6baf673df
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Michal Kabaj [Mon, 5 Mar 2018 12:42:17 +0000 (13:42 +0100)]
ChefAdapterImpl JUnits
-Added unit testcases for retrieveData method - extracted new test class
-Added unit test for combineStrings method
Change-Id: I8adcc9d2dc17e4ebf305fc2a8139095d5841a445
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Taka Cho [Tue, 6 Mar 2018 02:01:48 +0000 (21:01 -0500)]
upgrade httpclient from 4.5.2 to 4.5.3
Change-Id: I2cd2eb825a22c48807464d7f7185788fde975981
Issue-ID: APPC-689
Signed-off-by: Taka Cho <tc012c@att.com>
vidhyasree [Mon, 5 Mar 2018 21:34:20 +0000 (16:34 -0500)]
Adding ConfigScaleOut To APP-C Client Library
Updating the client library for new action configscaleout
based on the updated LCM API Yang model
Issue-ID: APPC-478
Change-Id: Ic32f433658be5442e1a5d238a317de85e54fb425
Signed-off-by: vidhyasree <sn141y@att.com>
kurczews [Thu, 1 Mar 2018 09:52:36 +0000 (10:52 +0100)]
Improve coverage FlowControlNode #5
* cleanup formatting
shorten constants
*
Change-Id: Iddc632ae9c3893622c1ba0ce937c2971b792fe37
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Dilip kumar Pampana [Mon, 5 Mar 2018 21:41:37 +0000 (16:41 -0500)]
Aai Test cases added
junits were missed in the code contributions for Beijing for appc-outbound/appc-aai-client
Issue-ID: APPC-692
Change-Id: I9bde9cc48e7fa396f2b4ac3af3b181ae03b84143
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
amshegokar [Mon, 5 Mar 2018 09:22:28 +0000 (14:52 +0530)]
Unit Test Coverage Part:2
Unit Test Coverage for:
1. Snapshot.java
2. Volume.java
3. Volume_.java
4. Template.java
5. SnapshotRestoreResponse.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel
Change-Id: I18ecc259973bbd3934f9ccd4cc20d897444d9d76
Issue-ID: APPC-686
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Balaji, Ramya (rb111y) [Fri, 2 Mar 2018 21:39:47 +0000 (16:39 -0500)]
Code changes to retrieve template-id
Functionality to retrieve vf-module
and associated model information
from A&AI
Issue-ID: APPC-623
Change-Id: I9d2e12748641978c689566756a6301808e41b69a
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Balaji, Ramya (rb111y) [Thu, 1 Mar 2018 02:01:47 +0000 (21:01 -0500)]
ConfigScaleOut flow changes
Code changes and unit test cases
to include template id when
retrieving vnfc reference data and artifacts
from tables. Cleaned up Unit Tests.
Issue-ID: APPC-619,APPC-620
Change-Id: I8db08be19b9fa094a07e5c5597c45327824cfb01
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Tomek Kaminski [Mon, 26 Feb 2018 14:45:24 +0000 (15:45 +0100)]
Unit tests for send methods
Covered functionality of 4 send methods with JUnits
Change-Id: I21de5eab799e52899959cf61199a4d185a47268c
Issue-ID: APPC-591
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
Scott Seabolt [Fri, 2 Mar 2018 03:38:25 +0000 (22:38 -0500)]
Correct Issue ID APPC LCM Guide
Previsou submit included an incorrect Issue Id
Issue-ID: APPC-657
Change-Id: I11a4a3cd64f52a3c49fa439ee27320b48c6a93bb
Signed-off-by: Scott Seabolt <js9808@att.com>
Balaji, Ramya (rb111y) [Thu, 1 Mar 2018 19:58:56 +0000 (14:58 -0500)]
Added missed code to appc-dg-common bundle
Issue-ID: APPC-688
Change-Id: I7cfb5a90005f046336bf7858aa94001bdc5b6b32
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Taka Cho [Fri, 2 Mar 2018 01:57:52 +0000 (20:57 -0500)]
security issue jackson-mapper 1.9.12
Change-Id: I89266f7a8dde8bc409f4edc8bdf91195c4249515
Issue-ID: APPC-675
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Tue, 27 Feb 2018 20:16:21 +0000 (15:16 -0500)]
move powermockito to mocktio appc-client
Change-Id: I51439e787d3da3d6a785ef6d60712fa71bdb0125
Issue-ID: APPC-677
Signed-off-by: Taka Cho <tc012c@att.com>
vidhyasree [Thu, 22 Feb 2018 22:41:31 +0000 (17:41 -0500)]
Testcases for Configscaleout action
Junit testcases for ONAP scaleout feature
Issue-ID: APPC-544
Change-Id: I43e211f00e7568cb98e564b1cbf60f96b27c5dfa
Signed-off-by: vidhyasree <sn141y@att.com>
shubhada [Thu, 1 Mar 2018 06:46:11 +0000 (12:16 +0530)]
Unit test Coverage
Unit Test Coverage for:
1. EventHeader.java
2. EventStatus.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2Fevent
Change-Id: I6b48fa3ac5af489b24d212ca52bdc1a51b388dbc
Issue-ID: APPC-680
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Thu, 1 Mar 2018 10:39:41 +0000 (16:09 +0530)]
Unit Test Coverage
Unit Test Coverage for:
1. Data.java
2. CreateSnapshotParams.java
3. Properties.java
4. ResourceData.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel
Change-Id: I0eeef6216f536483c6b7a45d0847688d6d84fd2f
Issue-ID: APPC-685
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Michal Kabaj [Tue, 27 Feb 2018 10:27:48 +0000 (11:27 +0100)]
ChefAdapterImpl JUnits
-Added new ChefAdapterImplTest class for new ChefAdapterImpl JUnits
-Added test for nodeObjectBuilder method - JSON Format is now verified using JSONObject
-Unified ChefAdapterImpl construction - removed unused constructors
Change-Id: I63f96bac0129b5f13d34efd3a173784e0b1d8a5d
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
wejs [Fri, 23 Feb 2018 14:59:31 +0000 (15:59 +0100)]
Fixes in "appc-dmaap-adapter-bundle"
Correction of Sonar and CheckStyle issues
Added JUnit test coverage.
Change-Id: I119c7555e33e09c87b572ff0b63f55e2884be75f
Issue-ID: APPC-646
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 15:11:04 +0000 (16:11 +0100)]
appc-dg-common sonar fixes part 2
Sonar fixes in whole module
Change-Id: I9d2d7f092fc44217c794ea3a4d4b12b1ad641ff0
Issue-ID: APPC-673
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Tue, 27 Feb 2018 07:55:57 +0000 (08:55 +0100)]
Improve coverage flow/controller/node #4
Issue-ID: APPC-440
Change-Id: Iee74ce27c3978d265fccc79dacaf8df965768a36
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Michal Kabaj [Tue, 27 Feb 2018 11:25:52 +0000 (12:25 +0100)]
Add missing mockito-core dependency
TestAppcDmaapListenerActivator in appc-event-listener-bundle
has compilationissues in development environment due to missing
mockito-core test dependency.
Change-Id: I1e46bd4866b5c02b06eb71fef9aba08e2b7f1012
Issue-ID: APPC-678
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
kjaniak [Mon, 26 Feb 2018 13:52:50 +0000 (14:52 +0100)]
Extraction of try catch in ConfigurationFactory
Try catch block placed in new private method getClonedDefaultConfiguration,
minor changes added, UT for class added.
Change-Id: Ic908e6d3a8fe179a2a38d922d10e24cff76a21da
Issue-ID: APPC-674
Signed-off-by: kjaniak <kornel.janiak@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 13:33:58 +0000 (14:33 +0100)]
appc-dg-common sonar fixes part 1
Initial code refactor and imports rearrangement
Change-Id: I4b96f82a4ebc30539872d9678cd5c2badc994256
Issue-ID: APPC-673
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka Cho [Wed, 28 Feb 2018 17:22:45 +0000 (12:22 -0500)]
roll back the logback version
Change-Id: I34661e29c605b7731c92412d9c0c57c91583e8a4
Issue-ID: APPC-684
Signed-off-by: Taka Cho <tc012c@att.com>
Patrick Brady [Fri, 23 Feb 2018 17:35:46 +0000 (12:35 -0500)]
Code fix for attach and detach volumes
Cherry-picked to split up commit https://gerrit.onap.org/r/#/c/31149/
into individual jira tickets.
open stack consumes cdp-pal openstack jars to connect to cinder,
this fix retrives set of volumes from volumeservice provider
and performs attach or detach through compute service.
Change-Id: I59bce60d9f79ba9285f284fe1f56945e63d0bcba
Signed-off-by: Patrick Brady <pb071s@att.com>
Signed-off-by: kusuma kumari M <km583p@att.com>
Issue-ID: APPC-448
Taka Cho [Sat, 24 Feb 2018 02:30:06 +0000 (21:30 -0500)]
security issue: commons-collections
Change-Id: I74a56640065ae6c6a470835ab1022ed0f266fc09
Issue-ID: APPC-665
Signed-off-by: Taka Cho <tc012c@att.com>
Michal Kabaj [Mon, 26 Feb 2018 09:28:25 +0000 (10:28 +0100)]
Add assertj artifact test dependency
Add new assertion libraries for writing improved unit test assertions in
a fluent style manner:
- assertj-core
- assertj-guava
Change-Id: Ifca841a88f91219c13b50f7b80c7e0fe660bea19
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 12:47:24 +0000 (13:47 +0100)]
appc-network-client-provider sonar fixes part 2
Sonar fixes in whole module
Change-Id: If36f6b7762c0caa1ccd4f5c9efa57c08f97a2c87
Issue-ID: APPC-672
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Code Review / appc.git / log