amshegokar [Sun, 11 Mar 2018 13:47:42 +0000 (19:17 +0530)]
Unit Test Coverage for ConnectionDetails.java
Unit Test Coverage for ConnectionDetails.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fobjects%2FConnectionDetails.java
Change-Id: Ia253f7cea39d980f966f0afc5ab1b64d1e3f527e
Issue-ID: APPC-718
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Sun, 11 Mar 2018 13:42:30 +0000 (19:12 +0530)]
Unit test Coverage for BundleInfo.java
Unit test Coverage for BundleInfo.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-mdsal-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fmdsal%2Fobjects%2FBundleInfo.java
Change-Id: I3d0e08b15f362bc00fc8fbbd4d809e88ddc6f792
Issue-ID: APPC-719
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Scott Seabolt [Fri, 9 Mar 2018 20:33:13 +0000 (15:33 -0500)]
Adding APPC CDT Guide
Initial Draft
Issue-ID: APPC-375
Change-Id: I79f453f0451c10fbbe352cf88687eed100f83d65
Signed-off-by: Scott Seabolt <js9808@att.com>
Michal Kabaj [Wed, 7 Mar 2018 14:08:52 +0000 (15:08 +0100)]
ChefAdapterImpl JUnits
-Added unit tests for chefXXX methods - extracted new test class
-Moved privateKeyCheck method to new class PrivateKeyChecker + JUnits
-New Factory class ChefAdapterFactory for ChefAdapterImpl construction
-Fixed potential bug with wrong String being assigned in iniSvcLogic method
Change-Id: I27badfd01bfaa807b8ecb9b4a4c13e7f026e34af
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
shubhada [Fri, 9 Mar 2018 07:17:12 +0000 (12:47 +0530)]
Unit test for Workflow Management API classes
Unit test for Workflow Management API classes
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-workflow-management-api
Change-Id: I641d4b14d213f8369d0b07c92feee49dadbcf70f
Issue-ID: APPC-716
Signed-off-by: shubhada <SV00449682@techmahindra.com>
kurczews [Fri, 2 Mar 2018 12:32:30 +0000 (13:32 +0100)]
Improve coverage FlowControlNode #6
* Extract InventoryInfoExtractor as util class
* Add test coverage
Change-Id: I24f16feddacb6a9898e9c81aa036ba3eafed2967
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Taka Cho [Thu, 8 Mar 2018 00:52:42 +0000 (19:52 -0500)]
upgrade httpclient from 4.5 to 4.5.3
this comes from com.att.nsa.cambriaClient
Change-Id: Ib451837526fd6de2a411c530fd3131a26d36473a
Issue-ID: APPC-711
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Wed, 7 Mar 2018 21:39:55 +0000 (16:39 -0500)]
upgrade bcprov to 1.56
there are two versions: 1.55 and 1.47 to be upgraded to 1.56
Change-Id: Ib12c5798e4a53b2c75be448f0e855d61bf168a38
Issue-ID: APPC-708
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Wed, 7 Mar 2018 16:42:59 +0000 (11:42 -0500)]
upgrade httpclient from 4.5.1 to 4.5.3
Change-Id: I951cc53b6f319bdb9eba25ecdeaffaae5702fbc2
Issue-ID: APPC-703
Signed-off-by: Taka Cho <tc012c@att.com>
shubhada [Thu, 8 Mar 2018 06:15:41 +0000 (11:45 +0530)]
Coverage for yang-generator object class
Unit Test Coverage for Leaf.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-yang-generator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fyang%2Fobjects
Change-Id: I133ffe9688e7b63024d154a8bef2c5559fb546df
Issue-ID: APPC-704
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Tomek Kaminski [Tue, 27 Feb 2018 15:40:35 +0000 (16:40 +0100)]
JUnits for sftp methods
implement unit tests to cover functionality of sftp put and get methods in SshJcraftWrapper.java
Change-Id: I238eb1e0816210176da1a1a7874151a624cdbf10
Issue-ID: APPC-676
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
Taka Cho [Tue, 6 Mar 2018 19:23:11 +0000 (14:23 -0500)]
upgrade httpclient from 4.4.1 to 4.5.3
Change-Id: I2f8657097c432e2017ae1287fecc366cb8559076
Issue-ID: APPC-699
Signed-off-by: Taka Cho <tc012c@att.com>
Balaji, Ramya (rb111y) [Tue, 6 Mar 2018 20:20:22 +0000 (15:20 -0500)]
Code changes to processing new group notation type
Code and Unit Test cases to proces for
group notation type existing-value
Issue-ID: APPC-621
Change-Id: I8446f5f66c7b240018b0bee00d8b28c6baf673df
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Michal Kabaj [Mon, 5 Mar 2018 12:42:17 +0000 (13:42 +0100)]
ChefAdapterImpl JUnits
-Added unit testcases for retrieveData method - extracted new test class
-Added unit test for combineStrings method
Change-Id: I8adcc9d2dc17e4ebf305fc2a8139095d5841a445
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Taka Cho [Tue, 6 Mar 2018 02:01:48 +0000 (21:01 -0500)]
upgrade httpclient from 4.5.2 to 4.5.3
Change-Id: I2cd2eb825a22c48807464d7f7185788fde975981
Issue-ID: APPC-689
Signed-off-by: Taka Cho <tc012c@att.com>
vidhyasree [Mon, 5 Mar 2018 21:34:20 +0000 (16:34 -0500)]
Adding ConfigScaleOut To APP-C Client Library
Updating the client library for new action configscaleout
based on the updated LCM API Yang model
Issue-ID: APPC-478
Change-Id: Ic32f433658be5442e1a5d238a317de85e54fb425
Signed-off-by: vidhyasree <sn141y@att.com>
kurczews [Thu, 1 Mar 2018 09:52:36 +0000 (10:52 +0100)]
Improve coverage FlowControlNode #5
* cleanup formatting
shorten constants
*
Change-Id: Iddc632ae9c3893622c1ba0ce937c2971b792fe37
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Dilip kumar Pampana [Mon, 5 Mar 2018 21:41:37 +0000 (16:41 -0500)]
Aai Test cases added
junits were missed in the code contributions for Beijing for appc-outbound/appc-aai-client
Issue-ID: APPC-692
Change-Id: I9bde9cc48e7fa396f2b4ac3af3b181ae03b84143
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
amshegokar [Mon, 5 Mar 2018 09:22:28 +0000 (14:52 +0530)]
Unit Test Coverage Part:2
Unit Test Coverage for:
1. Snapshot.java
2. Volume.java
3. Volume_.java
4. Template.java
5. SnapshotRestoreResponse.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel
Change-Id: I18ecc259973bbd3934f9ccd4cc20d897444d9d76
Issue-ID: APPC-686
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Balaji, Ramya (rb111y) [Fri, 2 Mar 2018 21:39:47 +0000 (16:39 -0500)]
Code changes to retrieve template-id
Functionality to retrieve vf-module
and associated model information
from A&AI
Issue-ID: APPC-623
Change-Id: I9d2e12748641978c689566756a6301808e41b69a
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Balaji, Ramya (rb111y) [Thu, 1 Mar 2018 02:01:47 +0000 (21:01 -0500)]
ConfigScaleOut flow changes
Code changes and unit test cases
to include template id when
retrieving vnfc reference data and artifacts
from tables. Cleaned up Unit Tests.
Issue-ID: APPC-619,APPC-620
Change-Id: I8db08be19b9fa094a07e5c5597c45327824cfb01
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Tomek Kaminski [Mon, 26 Feb 2018 14:45:24 +0000 (15:45 +0100)]
Unit tests for send methods
Covered functionality of 4 send methods with JUnits
Change-Id: I21de5eab799e52899959cf61199a4d185a47268c
Issue-ID: APPC-591
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
Scott Seabolt [Fri, 2 Mar 2018 03:38:25 +0000 (22:38 -0500)]
Correct Issue ID APPC LCM Guide
Previsou submit included an incorrect Issue Id
Issue-ID: APPC-657
Change-Id: I11a4a3cd64f52a3c49fa439ee27320b48c6a93bb
Signed-off-by: Scott Seabolt <js9808@att.com>
Balaji, Ramya (rb111y) [Thu, 1 Mar 2018 19:58:56 +0000 (14:58 -0500)]
Added missed code to appc-dg-common bundle
Issue-ID: APPC-688
Change-Id: I7cfb5a90005f046336bf7858aa94001bdc5b6b32
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Taka Cho [Fri, 2 Mar 2018 01:57:52 +0000 (20:57 -0500)]
security issue jackson-mapper 1.9.12
Change-Id: I89266f7a8dde8bc409f4edc8bdf91195c4249515
Issue-ID: APPC-675
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Tue, 27 Feb 2018 20:16:21 +0000 (15:16 -0500)]
move powermockito to mocktio appc-client
Change-Id: I51439e787d3da3d6a785ef6d60712fa71bdb0125
Issue-ID: APPC-677
Signed-off-by: Taka Cho <tc012c@att.com>
vidhyasree [Thu, 22 Feb 2018 22:41:31 +0000 (17:41 -0500)]
Testcases for Configscaleout action
Junit testcases for ONAP scaleout feature
Issue-ID: APPC-544
Change-Id: I43e211f00e7568cb98e564b1cbf60f96b27c5dfa
Signed-off-by: vidhyasree <sn141y@att.com>
shubhada [Thu, 1 Mar 2018 06:46:11 +0000 (12:16 +0530)]
Unit test Coverage
Unit Test Coverage for:
1. EventHeader.java
2. EventStatus.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2Fevent
Change-Id: I6b48fa3ac5af489b24d212ca52bdc1a51b388dbc
Issue-ID: APPC-680
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Thu, 1 Mar 2018 10:39:41 +0000 (16:09 +0530)]
Unit Test Coverage
Unit Test Coverage for:
1. Data.java
2. CreateSnapshotParams.java
3. Properties.java
4. ResourceData.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fopenstack%2Fheat%2Fmodel
Change-Id: I0eeef6216f536483c6b7a45d0847688d6d84fd2f
Issue-ID: APPC-685
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Michal Kabaj [Tue, 27 Feb 2018 10:27:48 +0000 (11:27 +0100)]
ChefAdapterImpl JUnits
-Added new ChefAdapterImplTest class for new ChefAdapterImpl JUnits
-Added test for nodeObjectBuilder method - JSON Format is now verified using JSONObject
-Unified ChefAdapterImpl construction - removed unused constructors
Change-Id: I63f96bac0129b5f13d34efd3a173784e0b1d8a5d
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
wejs [Fri, 23 Feb 2018 14:59:31 +0000 (15:59 +0100)]
Fixes in "appc-dmaap-adapter-bundle"
Correction of Sonar and CheckStyle issues
Added JUnit test coverage.
Change-Id: I119c7555e33e09c87b572ff0b63f55e2884be75f
Issue-ID: APPC-646
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 15:11:04 +0000 (16:11 +0100)]
appc-dg-common sonar fixes part 2
Sonar fixes in whole module
Change-Id: I9d2d7f092fc44217c794ea3a4d4b12b1ad641ff0
Issue-ID: APPC-673
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Tue, 27 Feb 2018 07:55:57 +0000 (08:55 +0100)]
Improve coverage flow/controller/node #4
Issue-ID: APPC-440
Change-Id: Iee74ce27c3978d265fccc79dacaf8df965768a36
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Michal Kabaj [Tue, 27 Feb 2018 11:25:52 +0000 (12:25 +0100)]
Add missing mockito-core dependency
TestAppcDmaapListenerActivator in appc-event-listener-bundle
has compilationissues in development environment due to missing
mockito-core test dependency.
Change-Id: I1e46bd4866b5c02b06eb71fef9aba08e2b7f1012
Issue-ID: APPC-678
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
kjaniak [Mon, 26 Feb 2018 13:52:50 +0000 (14:52 +0100)]
Extraction of try catch in ConfigurationFactory
Try catch block placed in new private method getClonedDefaultConfiguration,
minor changes added, UT for class added.
Change-Id: Ic908e6d3a8fe179a2a38d922d10e24cff76a21da
Issue-ID: APPC-674
Signed-off-by: kjaniak <kornel.janiak@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 13:33:58 +0000 (14:33 +0100)]
appc-dg-common sonar fixes part 1
Initial code refactor and imports rearrangement
Change-Id: I4b96f82a4ebc30539872d9678cd5c2badc994256
Issue-ID: APPC-673
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka Cho [Wed, 28 Feb 2018 17:22:45 +0000 (12:22 -0500)]
roll back the logback version
Change-Id: I34661e29c605b7731c92412d9c0c57c91583e8a4
Issue-ID: APPC-684
Signed-off-by: Taka Cho <tc012c@att.com>
Patrick Brady [Fri, 23 Feb 2018 17:35:46 +0000 (12:35 -0500)]
Code fix for attach and detach volumes
Cherry-picked to split up commit https://gerrit.onap.org/r/#/c/31149/
into individual jira tickets.
open stack consumes cdp-pal openstack jars to connect to cinder,
this fix retrives set of volumes from volumeservice provider
and performs attach or detach through compute service.
Change-Id: I59bce60d9f79ba9285f284fe1f56945e63d0bcba
Signed-off-by: Patrick Brady <pb071s@att.com>
Signed-off-by: kusuma kumari M <km583p@att.com>
Issue-ID: APPC-448
Taka Cho [Sat, 24 Feb 2018 02:30:06 +0000 (21:30 -0500)]
security issue: commons-collections
Change-Id: I74a56640065ae6c6a470835ab1022ed0f266fc09
Issue-ID: APPC-665
Signed-off-by: Taka Cho <tc012c@att.com>
Michal Kabaj [Mon, 26 Feb 2018 09:28:25 +0000 (10:28 +0100)]
Add assertj artifact test dependency
Add new assertion libraries for writing improved unit test assertions in
a fluent style manner:
- assertj-core
- assertj-guava
Change-Id: Ifca841a88f91219c13b50f7b80c7e0fe660bea19
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 12:47:24 +0000 (13:47 +0100)]
appc-network-client-provider sonar fixes part 2
Sonar fixes in whole module
Change-Id: If36f6b7762c0caa1ccd4f5c9efa57c08f97a2c87
Issue-ID: APPC-672
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 11:59:33 +0000 (12:59 +0100)]
appc-network-client-provider sonar fixes part 1
Initial code reformat and imports rearrangement
Change-Id: Iacc8f3b4313415da2fb7215dd4a529c1f06de039
Issue-ID: APPC-672
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 11:38:53 +0000 (12:38 +0100)]
appc-config-generator-provider sonar fixes part 2
Sonar fixes in whole module
Change-Id: I55856a6ce73a73098dadb2c5b9428437349ed8a8
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 10:43:19 +0000 (11:43 +0100)]
appc-config-generator-provider sonar fixes part 1
Initial code reformat and import rearrangement
Change-Id: I0a808bc3043d8558d96f15e0b695fddf5333bab1
Issue-ID: APPC-671
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 10:28:58 +0000 (11:28 +0100)]
CompareNode sonar fixes
Change-Id: Ia467508aa17737caa056b5ed0b6dd28ee4c01a35
Issue-ID: APPC-670
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 26 Feb 2018 09:52:09 +0000 (10:52 +0100)]
PropertyDefinitionNode sonar fixes
Change-Id: Ibc198788f20a8555628d75c785ebcc60908b39db
Issue-ID: APPC-664
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Fri, 23 Feb 2018 14:43:45 +0000 (15:43 +0100)]
Fix Sonar Bug
Fix for: https://sonar.onap.org/project/issues?id=org.onap.appc%3Aappc&issues=AWGYEYwt8TZzbCgU6gOm&open=AWGYEYwt8TZzbCgU6gOm
Change-Id: I632c21efb8e69c04fc346841900d98d4908b360e
Issue-ID: APPC-668
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
kurczews [Fri, 23 Feb 2018 13:40:08 +0000 (14:40 +0100)]
Improve coverage flow/controller/node #3
Issue-ID: APPC-440
Change-Id: I3ffea4577747f5de3e4eb74a91d4485442474441
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 14:28:55 +0000 (15:28 +0100)]
DbServiceUtil sonar fixes
Change-Id: Iaeca67ccb70134ba2bac0fe04e045592d8d9efcc
Issue-ID: APPC-661
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka Cho [Thu, 22 Feb 2018 20:30:45 +0000 (15:30 -0500)]
fix logback jar security issue
Change-Id: I51e0fec8131db5f5283182c1fc70a4f5b023dbb1
Issue-ID: APPC-652
Signed-off-by: Taka Cho <tc012c@att.com>
Taka Cho [Thu, 22 Feb 2018 14:22:47 +0000 (09:22 -0500)]
Migrate powermock to mockito for providerlcm
Change-Id: I66f70a1dcb4ea1d4f6f8ca6149c1291a76f84e32
Issue-ID: APPC-649
Signed-off-by: Taka Cho <tc012c@att.com>
Michal Kabaj [Fri, 16 Feb 2018 10:37:35 +0000 (11:37 +0100)]
ChefApiClient Package Reorganization and cleanup
-Reorganize ChefApiClient classes according to their usage, construction
and implementation.
-Introduce api and impl packages.
-Extract interface from ChefApiClient impl
-Remove unused old chefapi.* classes
Change-Id: Ic1ddbdcfd0e1bbc0830b923da5aac5b68ac44a2f
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
RY303T [Wed, 21 Feb 2018 21:42:18 +0000 (16:42 -0500)]
modify listeners to only start when props present
Change-Id: If4ba1552eb6bc78a95f1b53292752181bc29cb2d
Issue-ID: APPC-564
Signed-off-by: RY303T <RY303T@att.com>
Jakub Dudycz [Wed, 21 Feb 2018 14:24:46 +0000 (15:24 +0100)]
DGXML classes refactoring
Did some refactor in org.onap.sdnc.dg.loader package in order to reduce code duplication
Change-Id: I5c063487046c7ff72042d067213ea3d639a37227
Issue-ID: APPC-655
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 10:57:32 +0000 (11:57 +0100)]
AAIResourceNode sonar fixes
Change-Id: I1e7a6442b041138b0261973acc4181b56904c80e
Issue-ID: APPC-659
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 20 Feb 2018 15:29:13 +0000 (16:29 +0100)]
AAIPluginImpl sonar fixes
Change-Id: Ifa07addb19b34a1f1a2f546c5eb21c2ac0bb3e1a
Issue-ID: APPC-651
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Thu, 22 Feb 2018 15:51:03 +0000 (16:51 +0100)]
EELF logging with error codes
Introduced error codes in error logging for compilancy with ONAP logging guidelines
Change-Id: If0418a1ea8d91ea84be251df10ca81402fb78b41
Issue-ID: APPC-428
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
vidhyasree [Wed, 21 Feb 2018 16:19:33 +0000 (11:19 -0500)]
Task to add ConfigScaleOut to LCM API, Yang Model.
A new action ConfigScaleOut is added to LCM API and Yang model.
Removed old action item configscaleout supporting VM action level
which is no longer needed.
Issue-ID: APPC-479
Change-Id: Ie5452f4d5625fc3be6b66c0f403d12baa64fa096
Signed-off-by: vidhyasree <sn141y@att.com>
Jakub Dudycz [Wed, 21 Feb 2018 13:54:51 +0000 (14:54 +0100)]
DGXMLActivate sonar fixes
Change-Id: I7d09a91d66d491b5942214d1df36c188c4e9cda6
Issue-ID: APPC-654
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 14:49:20 +0000 (15:49 +0100)]
Dme2Client sonar fixes
Change-Id: I0617290c2674398f3c483f2e0df7f74702bc62cf
Issue-ID: APPC-662
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 22 Feb 2018 15:05:19 +0000 (16:05 +0100)]
InstarClientNode sonar fixes
Change-Id: I3c61219c989fc2fdb17719babd06487da0f7032b
Issue-ID: APPC-663
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Tue, 20 Feb 2018 14:56:58 +0000 (15:56 +0100)]
ArtifactHandlerClient sonar fixes
Change-Id: Ic43b1e4748c753e696ffff1deb89f2b73a8cb9ce
Issue-ID: APPC-650
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 19 Feb 2018 14:29:43 +0000 (15:29 +0100)]
ConfigComponentAdaptor sonar fixes part 2
Change-Id: I1eab3df281f394337fe33c0df07ff26da4302cbd
Issue-ID: APPC-648
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 19 Feb 2018 12:56:31 +0000 (13:56 +0100)]
ConfigComponentAdaptor sonar fixes part 1
Change-Id: I8fdd18225315a936df393fd7e900e9ef2e499122
Issue-ID: APPC-648
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Mon, 19 Feb 2018 08:05:47 +0000 (09:05 +0100)]
Improve coverage flow/controller/node #2
* Extract TransactionHandler util class
* Minor cleanup
Issue-ID: APPC-440
Change-Id: I73d2ced81713daf36523e6b9d7de3bf19c98c9a1
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Mon, 12 Feb 2018 13:47:37 +0000 (14:47 +0100)]
DBService sonar fixes
Change-Id: I6c58803ab47ff411d7ff29097a7e64a489dfed03
Issue-ID: APPC-605
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Takamune Cho [Tue, 20 Feb 2018 13:18:45 +0000 (08:18 -0500)]
migrate powermock to mockito appc provider
Change-Id: I15bd86d2d96ecf4070f1b6eafaf8b9ba9612b9cf
Issue-ID: APPC-647
Signed-off-by: Taka Cho <tc012c@att.com>
Skip Wonnell [Tue, 20 Feb 2018 20:42:34 +0000 (14:42 -0600)]
Update license text part 3
Issue-ID: APPC-637
Change-Id: I361c457acd27099294365f8ee3aeb167cd7fcafd
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Thu, 15 Feb 2018 17:22:53 +0000 (11:22 -0600)]
Update .gitignore with license text
Update .gitignore with license text
Remove IDE generated files from repository
Update .gitignore to ignore IDE Generated files
Issue-ID: APPC-637
Change-Id: Ie650e2c6d46d55d06dcc54877533cb3e14be66d6
Signed-off-by: Skip Wonnell <skip@att.com>
Skip Wonnell [Mon, 19 Feb 2018 21:09:15 +0000 (15:09 -0600)]
Update .properties and .xml files with license
Change-Id: I551f9e9033de2f13028f28ad434003d61102d54f
Issue-ID: APPC-637
Signed-off-by: Skip Wonnell <skip@att.com>
Jakub Dudycz [Fri, 16 Feb 2018 13:34:58 +0000 (14:34 +0100)]
DGXMLLoadNActivate sonar fixes
Change-Id: Id94274756541b1b64892f68ece4fa9cead46d945
Issue-ID: APPC-643
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Feb 2018 13:05:43 +0000 (14:05 +0100)]
DGXMLLoad sonar fixes
Change-Id: I1e9965c8e5bd74f17fec1e47448af245b9b339c8
Issue-ID: APPC-642
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Mon, 12 Feb 2018 00:29:18 +0000 (19:29 -0500)]
Unit Test for ansibleActivator
Change-Id: I56279239cdae934116e4d3ac8d257f593e641064
Issue-ID: APPC-600
Signed-off-by: Taka <tc012c@att.com>
Michal Kabaj [Wed, 14 Feb 2018 11:36:17 +0000 (12:36 +0100)]
ChefApiClient JUnits
Add(fix) JUnits for ChefApiClient + refactor.
Junits work on mocked HttpClient instead of attempting to make real calls.
All ChefApiClient methods are now tested.
Improve readability and refactored the ChefApiClient flow (simplified).
Heavily improved SRP in both ChefApiClient and Api request creation.
Change-Id: I997490bf269e7d78b741baf7f8d5d7bf64f6b99a
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Taka [Sun, 11 Feb 2018 19:31:37 +0000 (14:31 -0500)]
refactor LookupServer for nesting try
Change-Id: Id27025cd6d4f5a4f8ba9653b656d263585edb24e
Issue-ID: APPC-599
Signed-off-by: Taka <tc012c@att.com>
wejs [Fri, 16 Feb 2018 15:08:04 +0000 (16:08 +0100)]
Sonar fixes in "appc-dmaap-adapter-bundle"
Also CheckStyle fixes.
No major refactoring.
Change-Id: Icf5e7221ecee2611f77bb3212c24d1fad9a27b96
Issue-ID: APPC-646
Signed-off-by: wejs <maciej.wejs@nokia.com>
Taka [Sun, 11 Feb 2018 03:17:44 +0000 (22:17 -0500)]
refactor EvacuateServer for nesting try
Change-Id: I4b114e6f2f41c755cf7e346a120e50441a1209dd
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-598
Taka [Sat, 10 Feb 2018 23:13:14 +0000 (18:13 -0500)]
refactor CreateSnapshot for nesting try
Change-Id: Ia66842fe6b680fd5f6eb74e8ddebf09f89c6c1d0
Signed-off-by: Taka <tc012c@att.com>
Issue-ID: APPC-597
Jakub Dudycz [Fri, 16 Feb 2018 14:32:28 +0000 (15:32 +0100)]
Added @FunctionalInterface annotation where needed
Change-Id: Ica7171f6314f10ff51979c2bdd07e293ded695e4
Issue-ID: APPC-644
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
kurczews [Thu, 15 Feb 2018 13:51:07 +0000 (14:51 +0100)]
Improve coverage in flow/controller/node
* Extract separate class for property loading
* Extract separate class for extracting uri
* Add coverage for changes above
Change-Id: Ibffa09c96aef2764188cba69bf8cb559c8a9c10e
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Jakub Dudycz [Fri, 16 Feb 2018 11:53:49 +0000 (12:53 +0100)]
DGXMLGenerator sonar fixes
Change-Id: Id365b40f298bb9dc15e1f80b57112c2f991595c9
Issue-ID: APPC-641
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
shubhada [Fri, 16 Feb 2018 10:15:24 +0000 (15:45 +0530)]
Unit test coverage
Unit test coverage for
1.CommonHeader.java
2.Flags.java
3.RequestContext.java
4.ResponseContext.java
5.RuntimeContext.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I275495faa8c34f4b2174e93a56071298450c354b
Issue-ID: APPC-640
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Wed, 14 Feb 2018 10:20:18 +0000 (11:20 +0100)]
ExecuteNodeActionImpl sonar fixes
Change-Id: I269cc5a76251b94134734cbe9ef13a6a7f885b23
Issue-ID: APPC-628
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Wed, 14 Feb 2018 15:11:24 +0000 (10:11 -0500)]
Junit Test for dmaap adapter
Change-Id: I2dbe1375a23fcbd5e2974f9d112a162d4fbea328
Issue-ID: APPC-626
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Thu, 15 Feb 2018 19:40:33 +0000 (20:40 +0100)]
SdcConfig sonar fixes
Change-Id: Ia947837f00401b1c9da900dc2db3b6931fb682fb
Issue-ID: APPC-639
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Feb 2018 18:05:38 +0000 (19:05 +0100)]
AbstractResolverDateReader sonar fixes
Change-Id: I78c4cf8318e1051cd3ea5850b502677ea8708794
Issue-ID: APPC-638
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 15 Feb 2018 11:28:40 +0000 (12:28 +0100)]
JSONTool sonar fixes
Change-Id: I457ac55fa17475a19a2e511a6e7813070ffd6d2e
Issue-ID: APPC-634
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Wed, 14 Feb 2018 09:37:45 +0000 (10:37 +0100)]
StringHelper sonar fixes
Change-Id: I52e083bc7729529059f365dc76278044ed4a909d
Issue-ID: APPC-629
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Thu, 8 Feb 2018 15:07:42 +0000 (16:07 +0100)]
ArtifactHandlerNode sonar fixes
Change-Id: I4cc803bc6c5d88b569405ea0af918a6c340fce9d
Issue-ID: APPC-581
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 9 Feb 2018 12:36:55 +0000 (13:36 +0100)]
FlowControlDBService sonar fixes
Change-Id: I522d6e9e4f581687ce36bf7873c4fb4643f33244
Issue-ID: APPC-592
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Ramya Balaji [Mon, 12 Feb 2018 20:31:38 +0000 (15:31 -0500)]
Artifact Handler code changes
Refactored code for storing reference data
and added unit test cases
Issue-ID: APPC-543
Change-Id: I60ed5e327324403409ec0d9725c5880038a3e186
Signed-off-by: Ramya Balaji <rb111y@att.com>
Taka [Tue, 13 Feb 2018 21:02:05 +0000 (16:02 -0500)]
UnitTest for Rest Healthcheck activator
Change-Id: I214f14cc0dbc735d87bcbf5b59cf286d41dc826b
Issue-ID: APPC-624
Signed-off-by: Taka <tc012c@att.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:59:20 +0000 (12:59 +0100)]
MergeNode sonar fixes
Change-Id: I436feb6a4b42c9a1a5a5c887204e745bd09928f1
Issue-ID: APPC-632
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka [Mon, 12 Feb 2018 17:26:34 +0000 (12:26 -0500)]
Unit test for iaas provider activator
Change-Id: I7e7ec6d977625406b9d4dee19d974492e1a5f4cc
Issue-ID: APPC-615
Signed-off-by: Taka <tc012c@att.com>
wejs [Tue, 13 Feb 2018 15:43:59 +0000 (16:43 +0100)]
CheckStyle corrections only
Files from module:
appc-config-flow-controller-provider
Change-Id: I8eb7b99642b8b7f58ceda384593b750344c79392
Issue-ID: APPC-618
Signed-off-by: wejs <maciej.wejs@nokia.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:45:29 +0000 (12:45 +0100)]
ConvertNode sonar fixes
Change-Id: I1b8f19f57e90c1be5cec2bdd37d7db4216221710
Issue-ID: APPC-631
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
wejs [Tue, 13 Feb 2018 12:49:55 +0000 (13:49 +0100)]
Sonar fixes - appc-config-flow-controller-provider
Fixes inlude changes in:
DefaultResponseHandler
EncryptionTool
EscapeUtils
FlowControllerConstants
FlowControllerActivator
Change-Id: Ic22db7a53697f1869da248a0351593edf9bdf187
Issue-ID: APPC-618
Signed-off-by: wejs <maciej.wejs@nokia.com>
RY303T [Wed, 14 Feb 2018 17:00:00 +0000 (12:00 -0500)]
Upgrade CDP-PAL to the latest version
Change-Id: I42d09c1878dcdcc2ed28d11a8e28613ecf9eba06
Issue-ID: APPC-573
Signed-off-by: RY303T <RY303T@att.com>
Jakub Dudycz [Wed, 14 Feb 2018 11:31:25 +0000 (12:31 +0100)]
TopologyService sonar fixes
Change-Id: I6839fada1f1acb31927eec4050dbefad5d84aca5
Issue-ID: APPC-630
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Tomek Kaminski [Thu, 8 Feb 2018 11:38:56 +0000 (12:38 +0100)]
JUnits for receiveUntil method
Test for fonctionallity of receiveUntil method in SshJcraftWrapper.java
Issue-ID: APPC-560
Change-Id: Ifb23b5cbc8b74ddea77ab9cfd5eb26f84c521a92
Signed-off-by: Tomek Kaminski <tomasz.kaminski@nokia.com>
Code Review / appc.git / log