test_environment_file_parameters check for environment violation is checking the wrong variable.
Also doesn't handle environment files with no parameters gracefully.
Issue-ID: VVP-267
Signed-off-by: stark, steven <steven.stark@att.com>
Change-Id: I9fbedbb5af4c045037131a7e7a7ca7f6c8febb14
env_yaml = environment_pair.get("eyml")
parameters = env_yaml.get("parameters", {})
in_env = False
- for param, value in parameters.items():
- if re.match(parameter, parameter):
- in_env = True
- break
+ if parameters: # env file can be just parameters:
+ for param, value in parameters.items():
+ if re.match(parameter, param):
+ in_env = True
+ break
# confusing return. This function is looking for a violation.
return not persistent == in_env