Technical debt and fix JUnit test

* One statement per line
* private constructor for class with statics
* Fix silly JUnit test

Issue-ID: POLICY-474
Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

diff --git a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java
index ed7383e..a453736 100644 (file)
--- a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java
+++ b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java
@@ -33,19 +33,6 @@ import static org.junit.Assert.*;
  * @version $Revision: 1.0 $
  */
 public class NotificationStoreTest {
-       /**
-        * Run the NotificationStore() constructor test.
-        *
-        * @generatedBy CodePro at 6/1/16 1:40 PM
-        */
-       @Test
-       public void testNotificationStore_1()
-               throws Exception {
-               NotificationStore result = new NotificationStore();
-               assertNotNull(result);
-               // add additional test code here
-       }
-
        /**
         * Run the void recordNotification(StdPDPNotification) method test.
         *

diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java
index 47b2360..24e1263 100644 (file)
--- a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java
+++ b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java
@@ -40,7 +40,7 @@ public class NotificationStore {
 
     private static StdPDPNotification notificationRecord = new StdPDPNotification();
 
-    public NotificationStore () {
+    private NotificationStore () {
        // Sonar prefers that we have an empty public constructor
        // as opposed to an implicit public constructor.
     }

diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java
index c058a79..0f38232 100644 (file)
--- a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java
+++ b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java
@@ -194,7 +194,9 @@ public class PolicyUtils {
             return false;
         }
         for (char c : number.toCharArray()){
-            if (!Character.isDigit(c)) return false;
+            if (!Character.isDigit(c)) {
+               return false;
+            }
         }
         return true;
     }