From fa97f50cf4d6395b49ec2ad275722db81a30953d Mon Sep 17 00:00:00 2001 From: Pamela Dragosh Date: Mon, 5 Feb 2018 12:50:06 -0500 Subject: [PATCH] Technical debt and fix JUnit test * One statement per line * private constructor for class with statics * Fix silly JUnit test Issue-ID: POLICY-474 Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd Signed-off-by: Pamela Dragosh --- .../org/onap/policy/std/test/NotificationStoreTest.java | 13 ------------- .../main/java/org/onap/policy/std/NotificationStore.java | 2 +- .../src/main/java/org/onap/policy/utils/PolicyUtils.java | 4 +++- 3 files changed, 4 insertions(+), 15 deletions(-) diff --git a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java index ed7383e1a..a453736ec 100644 --- a/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java +++ b/PolicyEngineAPI/src/test/java/org/onap/policy/std/test/NotificationStoreTest.java @@ -33,19 +33,6 @@ import static org.junit.Assert.*; * @version $Revision: 1.0 $ */ public class NotificationStoreTest { - /** - * Run the NotificationStore() constructor test. - * - * @generatedBy CodePro at 6/1/16 1:40 PM - */ - @Test - public void testNotificationStore_1() - throws Exception { - NotificationStore result = new NotificationStore(); - assertNotNull(result); - // add additional test code here - } - /** * Run the void recordNotification(StdPDPNotification) method test. * diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java index 47b23605d..24e126386 100644 --- a/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java +++ b/PolicyEngineUtils/src/main/java/org/onap/policy/std/NotificationStore.java @@ -40,7 +40,7 @@ public class NotificationStore { private static StdPDPNotification notificationRecord = new StdPDPNotification(); - public NotificationStore () { + private NotificationStore () { // Sonar prefers that we have an empty public constructor // as opposed to an implicit public constructor. } diff --git a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java index c058a7997..0f38232e1 100644 --- a/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java +++ b/PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java @@ -194,7 +194,9 @@ public class PolicyUtils { return false; } for (char c : number.toCharArray()){ - if (!Character.isDigit(c)) return false; + if (!Character.isDigit(c)) { + return false; + } } return true; } -- 2.16.6