Nelson, Thomas (tn1381) [Wed, 26 Jun 2019 15:54:59 +0000 (11:54 -0400)]
Update Netty Library version
Issue-ID: MUSIC-406
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Change-Id: I088f6e727ad10971e245508ba862272d43170080
Thomas Nelson [Tue, 25 Jun 2019 14:31:10 +0000 (14:31 +0000)]
Merge "Some bug fixes and Minor Chages."
Nelson, Thomas (tn1381) [Tue, 25 Jun 2019 13:06:58 +0000 (09:06 -0400)]
Clean up some unneded files.
Added a missed file.
Issue-ID: MUSIC-415
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Change-Id: I5dac9778b975529dc5b34b1e771de0a046b925da
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Thomas Nelson [Tue, 25 Jun 2019 13:39:22 +0000 (13:39 +0000)]
Merge "added file to test MusicReponse.java"
Thomas Nelson [Tue, 25 Jun 2019 13:25:03 +0000 (13:25 +0000)]
Merge "added file to test AuthorisationError.java"
Thomas Nelson [Tue, 25 Jun 2019 13:24:50 +0000 (13:24 +0000)]
Merge "added file to test PreparedQueryObject"
Thomas Nelson [Tue, 25 Jun 2019 13:23:39 +0000 (13:23 +0000)]
Merge "added test case to JsonInsertTest.java"
Thomas Nelson arthudent3 [Wed, 19 Jun 2019 22:19:10 +0000 (22:19 +0000)]
Some bug fixes and Minor Chages.
Remove some Commented out code.
Cleaned up Variables.
Encryption of passwords added
Updated Test Cases
Fixed some errors in how they were reported.
Reduced Logging clutter
Some Vulnerability fixes.
Change-Id: I64c7935d167d4a976681b5a18fd51aa667d0cd95
Issue-ID: MUSIC-413
Signed-off-by: Thomas Nelson arthudent3 <nelson24@att.com>
Sandeep J [Tue, 25 Jun 2019 10:31:45 +0000 (16:01 +0530)]
added file to test AuthorisationError.java
to increase code coverage
Issue-ID: MUSIC-412
Change-Id: I524de3158652b485bc50963313e6bbbf10fa8540
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Tue, 25 Jun 2019 10:06:03 +0000 (15:36 +0530)]
added file to test PreparedQueryObject
to increase code coverage
Issue-ID: MUSIC-412
Change-Id: Id231f3b0f122d9b9e95988a45eb8cd18ecdb0136
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Nelson, Thomas (tn1381) [Wed, 19 Jun 2019 21:24:19 +0000 (17:24 -0400)]
Fix missed Log output
Issue-ID: MUSIC-406
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Change-Id: I5a835b1bec73764b77b2e354284be98b7e87f919
Thomas Nelson [Wed, 19 Jun 2019 14:37:14 +0000 (14:37 +0000)]
Merge "Update Version to Snapshot and"
Thomas Nelson [Wed, 19 Jun 2019 13:41:03 +0000 (13:41 +0000)]
Merge "added test cases to JsonResponseTest.java"
Nelson, Thomas (tn1381) [Mon, 17 Jun 2019 15:02:28 +0000 (15:02 +0000)]
Update Version to Snapshot and
Update lbcrypt library to new versionZ
Issue-ID: MUSIC-406
Change-Id: I14a81b89287c90a2c91a0f4ef09675a348aef67a
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Sandeep J [Mon, 17 Jun 2019 08:05:43 +0000 (13:35 +0530)]
added test case to JsonOnboardTest.java
to increase code coverage
Issue-ID: MUSIC-412
Change-Id: If3cea8de2e00fea19a5636e47fde9a30c2a395a8
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 17 Jun 2019 08:20:03 +0000 (13:50 +0530)]
added file to test MusicReponse.java
to increase code coverage
Issue-ID: MUSIC-412
Change-Id: I42f00d6d2379a56c2a8559872c41978aa886d64f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 17 Jun 2019 07:58:21 +0000 (13:28 +0530)]
added test case to JsonInsertTest.java
to increase code coverage
Issue-ID: MUSIC-412
Change-Id: I83d1d2f5d70ff5b73119f5c4e0d27e512de0f261
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Sandeep J [Mon, 17 Jun 2019 07:49:05 +0000 (13:19 +0530)]
added test cases to JsonResponseTest.java
to increase code coverage
Issue-ID: MUSIC-412
Change-Id: Ia4e9c7772326e0011d0e63968f4dec9ce07249a9
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
Arindam Mondal [Wed, 12 Jun 2019 04:11:56 +0000 (13:11 +0900)]
Use logger to log exception
Issue-ID: MUSIC-410
Change-Id: Ief175a400c2c336eeb03807d71c4ef7a05a1b748
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
Tschaen, Brendan [Thu, 6 Jun 2019 15:09:32 +0000 (11:09 -0400)]
Dublin Release Notes
Change-Id: Ifa6615aa9cc0d9279250c49a8c9062137531b384
Issue-ID: MUSIC-409
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Nelson, Thomas (tn1381) [Tue, 4 Jun 2019 16:49:02 +0000 (12:49 -0400)]
Fix vulnerability in code where password is
being exposed in logs.
Issue-ID: MUSIC-406
Signed-off-by: Nelson, Thomas (tn1381) <tn1381@att.com>
Change-Id: I5af16bf25a967ae27875b8c42cf746c3fa857a27
Brendan Tschaen [Mon, 3 Jun 2019 16:53:28 +0000 (16:53 +0000)]
Merge "Bug Fix for Empty Body."
Tschaen, Brendan [Sun, 2 Jun 2019 23:00:24 +0000 (19:00 -0400)]
AuthUtil tests added
Change-Id: I78a13b43c85cb208c217841ed85eaf0284aad930
Issue-ID: MUSIC-405
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Sun, 2 Jun 2019 17:56:14 +0000 (13:56 -0400)]
Increase MusicUtil Code Coverage
Change-Id: I99bdec64d00a3822e4f40ed75b496c591b070057
Issue-ID: MUSIC-405
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Sun, 2 Jun 2019 01:26:25 +0000 (21:26 -0400)]
Update unit tests for holders api
Change-Id: Ib4d6ce287cdacc2c0aad36c2936075087a9e6f49
Issue-ID: MUSIC-405
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Nelson, Thomas (arthurdent3) [Tue, 28 May 2019 04:18:08 +0000 (04:18 +0000)]
Bug Fix for Empty Body.
Updated a few missing checks for this.
Update api name, add properties to be more forgiving for lock type
Change-Id: I4743110bdc654e4346052bd0e045270fd4925417
Issue-ID: MUSIC-398
Signed-off-by: Nelson, Thomas (arthurdent3) <nelson24@att.com>
Brendan Tschaen [Fri, 17 May 2019 14:49:51 +0000 (14:49 +0000)]
Merge "Update junit test"
Nelson, Thomas (arthurdent3) [Tue, 14 May 2019 20:23:59 +0000 (20:23 +0000)]
CADI and a few small updates.
- Include CADI and remove Admin API and admin
code.
- A few Sonar Fixes.
- Properties File Clean up.
- Read/Write Locking API.
- Various whitespace fixes.
Issue-ID: MUSIC-394
Change-Id: I58e1b64b71796bb6bda1c97ea688f434a836d3c7
Signed-off-by: Nelson, Thomas (arthurdent3) <nelson24@att.com>
Nelson, Thomas (arthurdent3) [Wed, 15 May 2019 17:59:33 +0000 (17:59 +0000)]
Update junit test
Change-Id: I1c39d008958cebed0454b5a1f980e3c88082c876
Issue-ID: MUSIC-395
Signed-off-by: Nelson, Thomas (arthurdent3) <nelson24@att.com>
Nelson, Thomas (arthurdent3) [Thu, 9 May 2019 14:16:37 +0000 (14:16 +0000)]
Changes Listed below:
- Added build version API
- Updated Keyspace active to use Properties setting
- Update Libraries Netty,jbcrypt,Jackson Databind and log4j
- Removed some irrelivant files
- Updated some usint tests to ignore some tests(This will be updated soon)
- Bugfixes
- Missing Values, inform user.
- Respond with proper error
- Fix Locking Contention issue.
- Add locking retry for atomic calls.
Change-Id: Ie218dd92edb0c20e4a0efe33eeaaec84e5293c44
Issue-ID: MUSIC-393
Signed-off-by: Nelson, Thomas (arthurdent3) <nelson24@att.com>
Jessica Wagantall [Thu, 2 May 2019 02:15:57 +0000 (19:15 -0700)]
Update oparent version
Update oparent version to 2.0.0 which supports
global-jjb maven-stage job.
Change-Id: I14f32e240505dd9fd1ecd6708560a191e420e67f
Issue-ID: CIMAN-234
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Bharath Balasubramanian [Wed, 10 Apr 2019 20:48:49 +0000 (20:48 +0000)]
Merge "Log stack traces with logger"
Thomas Nelson [Wed, 10 Apr 2019 12:36:23 +0000 (12:36 +0000)]
Merge "Log exceptions from CachingUtil.java"
Tschaen, Brendan [Thu, 4 Apr 2019 17:33:59 +0000 (13:33 -0400)]
Removing failing trigger job
Change-Id: Ibe27bfd3bc152b09db4363bfb2151dbb7da25645
Issue-ID: MUSIC-375
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
r.bogacki [Tue, 19 Mar 2019 13:27:16 +0000 (14:27 +0100)]
Log stack traces with logger
Fixed critical sonar issues:
-"Either log or rethrow this exception"
Change-Id: I99a550f2cf40bd6c34a0f8ca1893c964669c76de
Issue-ID: MUSIC-367
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Bharath Balasubramanian [Mon, 25 Mar 2019 23:12:05 +0000 (23:12 +0000)]
Merge "Respond error codes responses for wrong urls"
Tschaen, Brendan [Wed, 20 Mar 2019 17:53:28 +0000 (13:53 -0400)]
Respond error codes responses for wrong urls
Change-Id: I7fddb09af825755394b0f75e993bc9ea64a8c82d
Issue-ID: MUSIC-368
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
r.bogacki [Tue, 19 Mar 2019 09:26:32 +0000 (10:26 +0100)]
Log exceptions from CachingUtil.java
Fixed critical sonar issues:
-log exceptions stack traces
-fixed imports.
Change-Id: I4fc3c79852cd0c483abef975bcd7e535f3de48f3
Issue-ID: MUSIC-366
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Bharath Balasubramanian [Mon, 18 Mar 2019 13:34:20 +0000 (13:34 +0000)]
Merge "Update logbax.xml and create test resources."
Nelson,Thomas(tn1381)(arthurdent3) [Sun, 17 Mar 2019 05:15:13 +0000 (01:15 -0400)]
Update logbax.xml and create test resources.
Also update pom to reflect that test resources are located in a
different dir.
Issue-ID: MUSIC-365
Change-Id: Ie118621dfdea9819403d3adf4f9d54cd2571ecdc
Signed-off-by: Nelson,Thomas(tn1381)(arthurdent3) <tn1381@att.com>
Jessica Wagantall [Fri, 15 Mar 2019 01:21:14 +0000 (18:21 -0700)]
Update INFO.yaml file
Update missing information blocks and
indentation to pass verify job.
Change-Id: Id022875a769806aff7f130c289230dca3312b2f0
Issue-ID: CIMAN-134
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Bharath Balasubramanian [Mon, 11 Mar 2019 20:40:34 +0000 (20:40 +0000)]
Merge "update version of jackson datatype"
Thomas Nelson [Fri, 8 Mar 2019 21:31:42 +0000 (21:31 +0000)]
Merge "Unit test coverage lines for MusicUtil.java"
Thomas Nelson [Fri, 8 Mar 2019 21:30:31 +0000 (21:30 +0000)]
Merge "Sonar Fixes - MusicDataStoreHandle.java"
Thomas Nelson [Fri, 8 Mar 2019 21:30:09 +0000 (21:30 +0000)]
Merge "CassaLockStore.java - Sonar Fixes"
Thomas Nelson [Fri, 8 Mar 2019 21:29:35 +0000 (21:29 +0000)]
Merge "RestMusicQAPI.java - Sonar Fixes"
Thomas Nelson [Fri, 8 Mar 2019 21:28:20 +0000 (21:28 +0000)]
Merge "Remove unused property file"
Thomas Nelson [Fri, 8 Mar 2019 21:27:57 +0000 (21:27 +0000)]
Merge "Remove straggling zookeper references"
Nelson,Thomas(tn1381)(arthurdent3) [Fri, 8 Mar 2019 21:07:52 +0000 (16:07 -0500)]
update version of jackson datatype
this is to resolve a vulnerbility.
Issue-ID: MUSIC-363
Change-Id: Ieef2f72adc8cb3258e334cc454475d764f7ee52f
Signed-off-by: Nelson,Thomas(tn1381)(arthurdent3) <tn1381@att.com>
Tschaen, Brendan [Thu, 7 Mar 2019 22:00:20 +0000 (17:00 -0500)]
Remove unused property file
Change-Id: Iaf96335db0ddf6d719ce00ca0dafb7df420419ac
Issue-ID: MUSIC-361
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Thu, 7 Mar 2019 21:43:47 +0000 (16:43 -0500)]
Remove straggling zookeper references
Issue-ID: MUSIC-361
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Change-Id: I4faac78bc898b07902ce97ac6112f0dcd4a3729a
Tschaen, Brendan [Thu, 7 Mar 2019 21:02:44 +0000 (16:02 -0500)]
Update voting app with basic auth
Change-Id: Ia9ec983950faa651d31b07fe19934cf4fe389421
Issue-ID: MUSIC-360
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Thu, 28 Feb 2019 18:57:51 +0000 (13:57 -0500)]
Complete new authentication across REST APIs
Change-Id: I0d8ae84bdebbad986d557f722047318d5b72b591
Issue-ID: MUSIC-345
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Wed, 27 Feb 2019 21:44:36 +0000 (16:44 -0500)]
Admin api tests w/ mocked authorization
Change-Id: I2069a4c1e9e6985615fce77cfb2a255fc9e322f3
Issue-ID: MUSIC-341
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Tue, 26 Feb 2019 22:35:35 +0000 (17:35 -0500)]
Test for wrong user, missing required inputs
Change-Id: If7625349ea0cbb9bedf15554ca72d29dbaa1ba0d
Issue-ID: MUSIC-341
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Mon, 25 Feb 2019 22:31:00 +0000 (17:31 -0500)]
Remove zookeeper reference
Test cachingUtil, and other test coverage increase
Remove unused code
Rebased ontop of authentication changes
Change-Id: I795a9a90d0863b03cc2a4917d4ff13a0a6fca1cc
Issue-ID: MUSIC-341
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Thomas Nelson [Mon, 25 Feb 2019 22:38:33 +0000 (22:38 +0000)]
Merge "Sonar Fixes - CadiAuthFilter.java"
Thomas Nelson [Mon, 25 Feb 2019 22:37:37 +0000 (22:37 +0000)]
Merge "Caching util test cases"
Driptaroop Das [Sun, 24 Feb 2019 18:06:40 +0000 (23:36 +0530)]
RestMusicQAPI.java - Sonar Fixes
RestMusicQAPI.java - Sonar Fixes
Issue-ID: MUSIC-347
Change-Id: I165a64bb498b8f59e84538fd293fbea4ccd913e4
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Driptaroop Das [Sun, 24 Feb 2019 17:58:20 +0000 (23:28 +0530)]
CassaLockStore.java - Sonar Fixes
CassaLockStore.java - Sonar Fixes
Issue-ID: MUSIC-346
Change-Id: If26ec9ccaa8bf1b1cbd2aa2d848ad08b634cc611
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Tschaen, Brendan [Fri, 22 Feb 2019 15:41:19 +0000 (10:41 -0500)]
Create authentication interface
Change-Id: I2172870be0056d6b050eb73c9a53c12f05360d79
Issue-ID: MUSIC-345
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Thu, 21 Feb 2019 21:00:27 +0000 (16:00 -0500)]
Caching util test cases
And cleaning up of other tests
Issue-ID: MUSIC-341
Change-Id: Ida4ee49b2a923c64a2ce66c310db9b0dd502b8d7
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Thomas Nelson [Thu, 21 Feb 2019 14:16:45 +0000 (14:16 +0000)]
Merge "Sonar vulnerability fixes in MusicDataStoreHandle"
Thomas Nelson [Thu, 21 Feb 2019 14:14:10 +0000 (14:14 +0000)]
Merge "Fixed major Sonar issues in JsonDelete"
Tschaen, Brendan [Thu, 21 Feb 2019 00:31:04 +0000 (19:31 -0500)]
Conditional test cases
Additional coverage for other tests.
Remove unused Benchmark api
Change-Id: Ib091f1827a226a4a50e3427b20af4c8b12c363c3
Issue-ID: MUSIC-341
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Tschaen, Brendan [Wed, 20 Feb 2019 19:35:04 +0000 (14:35 -0500)]
Update MUSIC test cases.
Fix some old test cases that were expecting incorrect output
Refactor to REST API suite to re-use cassandra instance
Change-Id: I9400b3e1e3ce35114e587336f0841207493c9680
Issue-ID: MUSIC-341
Signed-off-by: Tschaen, Brendan <ctschaen@att.com>
Thomas Nelson [Wed, 20 Feb 2019 18:55:43 +0000 (18:55 +0000)]
Merge "MusicHealthCheck.java - Multiple Sonar Fixes"
Driptaroop Das [Tue, 19 Feb 2019 19:08:32 +0000 (00:38 +0530)]
Sonar Fixes - MusicDataStoreHandle.java
Sonar Fixes - MusicDataStoreHandle.java
Issue-ID: MUSIC-340
Change-Id: I693e1bc924df35e173036b0df34cd1d17d36a1c8
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
r.bogacki [Tue, 19 Feb 2019 10:24:29 +0000 (11:24 +0100)]
Fixed major Sonar issues in JsonDelete
Removed unnecessary imports.
Changed return type from ArrayList to List.
Change-Id: I9a17c9848b33be9f6ca5a2d51ee4b3f18abfcc38
Issue-ID: MUSIC-338
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Mon, 18 Feb 2019 09:42:11 +0000 (10:42 +0100)]
Sonar vulnerability fixes in MusicDataStoreHandle
Removed unnecessary imports.
Added private constructor for static
utility class.
Change-Id: I2e41ba263194dbb3e7e6ae70074c85bfd69b7ab1
Issue-ID: MUSIC-335
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Bharath [Thu, 14 Feb 2019 17:46:34 +0000 (12:46 -0500)]
Testing gerrit flow for Issue-ID: MUSIC-294
Change-Id: I1563ecc92214472333d457116a19b1beadfb2d52
Signed-off-by: Bharath <bharathb@research.att.com>
Thomas Nelson [Thu, 14 Feb 2019 17:18:49 +0000 (17:18 +0000)]
Merge "Introduced local variable"
Thomas Nelson [Thu, 14 Feb 2019 17:14:51 +0000 (17:14 +0000)]
Merge "Fixed Sonar issues in ZkStatelessLockService"
Thomas Nelson [Thu, 14 Feb 2019 17:12:12 +0000 (17:12 +0000)]
Merge "Added test case to improve code coverage"
Thomas Nelson [Thu, 14 Feb 2019 16:55:46 +0000 (16:55 +0000)]
Merge "Removed Duplicate logger statements"
Driptaroop Das [Thu, 14 Feb 2019 12:44:16 +0000 (18:14 +0530)]
Unit test coverage lines for MusicUtil.java
Unit test coverage lines for MusicUtil.java
Issue-ID: MUSIC-332
Change-Id: I26afea2e78a1bf23cfa61f413cae48c80d187f3c
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
r.bogacki [Tue, 12 Feb 2019 09:19:11 +0000 (10:19 +0100)]
Fixed Sonar issues in ZkStatelessLockService
Fixed potential NullPointerException.
Added restoring of the interrupted state.
Removed unnecessary imports.
Added missing loggers.
Change-Id: I62bb8ef2b4893c60c1cea7dcd4ba29f2908b4d05
Issue-ID: MUSIC-329
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Bharath Balasubramanian [Wed, 13 Feb 2019 13:47:17 +0000 (13:47 +0000)]
Merge "Sonar code duplicates moved to MusicUtil.java"
Bharath Balasubramanian [Wed, 13 Feb 2019 13:46:44 +0000 (13:46 +0000)]
Merge "Sonar Vulnerability Fixes: CachingUtil.java"
Bharath Balasubramanian [Wed, 13 Feb 2019 13:46:38 +0000 (13:46 +0000)]
Merge "Added unit test case"
Bharath Balasubramanian [Wed, 13 Feb 2019 13:46:24 +0000 (13:46 +0000)]
Merge "added local variable instead of using method args"
Bharath Balasubramanian [Wed, 13 Feb 2019 13:46:18 +0000 (13:46 +0000)]
Merge "Sonar vulnerability fixes in CronJobManager"
Bharath Balasubramanian [Wed, 13 Feb 2019 13:46:11 +0000 (13:46 +0000)]
Merge "Cleaning up Sonar issues in JerseyConfig"
Bharath Balasubramanian [Wed, 13 Feb 2019 13:46:01 +0000 (13:46 +0000)]
Merge "Fix for code Vulnerability,reported by Sonar"
Jegadeesh Babu [Mon, 11 Feb 2019 13:53:52 +0000 (19:23 +0530)]
Added test case to improve code coverage
Added test case to improve code coverage
Issue-ID: MUSIC-324
Change-Id: I0bec3c6a1d890cd920fe9a21de7e75590114f48d
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Tue, 12 Feb 2019 13:39:19 +0000 (19:09 +0530)]
Removed Duplicate logger statements
Used logger statements as per convention
Issue-ID: MUSIC-330
Change-Id: Iaea377861e1b2c5ea0724a664de2ef2db88d76cd
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Tue, 12 Feb 2019 13:21:08 +0000 (18:51 +0530)]
Introduced local variable
Introduced local variable instead of using method args
Issue-ID: MUSIC-323
Change-Id: I670c49e2b28ba280d3446868ac042dfdae2b6c16
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Jegadeesh Babu [Thu, 7 Feb 2019 10:56:42 +0000 (16:26 +0530)]
Fix for code Vulnerability,reported by Sonar
Removed and printStackTrace and added logger
Issue-ID: MUSIC-314
Change-Id: Ieeb33d6e58ec469c6fb540d943bae97b703ebbda
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
r.bogacki [Tue, 12 Feb 2019 07:44:03 +0000 (08:44 +0100)]
Removed sub-expressions from RestMusicDataAPI
Fixed critical Sonar issue related to identical sub-expressions
on both sides of operator.
Added more details to error logger.
Change-Id: I421c4ac3894c08b6b174fdaeb6e68be50e024e63
Issue-ID: MUSIC-328
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Mon, 11 Feb 2019 09:41:24 +0000 (10:41 +0100)]
Cleaning up Sonar issues in JerseyConfig
Unnecessary imports have been removed.
Formatting done according to ONAP and Google Java Style.
Issue-ID: MUSIC-321
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I04ed46d1cb5daa601713e1a4ee0e024b7d1ad55d
Jegadeesh Babu [Mon, 11 Feb 2019 12:44:35 +0000 (18:14 +0530)]
added local variable instead of using method args
Added local variable sonar bug fix
Issue-ID: MUSIC-322
Change-Id: I73c90d2fbfea4bd91f767bbb67eb1774a75ce3f1
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
r.bogacki [Mon, 11 Feb 2019 08:08:38 +0000 (09:08 +0100)]
Sonar vulnerability fixes in CronJobManager
Change-Id: I16133a60013cc63dd389a1aa14ddda693441570b
Issue-ID: MUSIC-320
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Fri, 8 Feb 2019 12:32:43 +0000 (13:32 +0100)]
Sonar code duplicates moved to MusicUtil.java
Change-Id: I08e089171e94c78c8977d20aea29b0eb97f57a74
Issue-ID: MUSIC-317
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
r.bogacki [Thu, 7 Feb 2019 14:26:57 +0000 (15:26 +0100)]
Sonar Vulnerability Fixes: CachingUtil.java
Replaced prinStackTrace with logger
Change-Id: I5c42dd8c4f1f5add0b66b11e21b964787d5f3348
Issue-ID: MUSIC-316
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Driptaroop Das [Wed, 6 Feb 2019 18:36:25 +0000 (00:06 +0530)]
Sonar Fixes - CadiAuthFilter.java
Sonar Fixes - CadiAuthFilter.java
Issue-ID: MUSIC-313
Change-Id: I8c9b3197cc72b331201f2b8742b036be58fea616
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
Jegadeesh Babu [Wed, 6 Feb 2019 09:57:59 +0000 (15:27 +0530)]
Added unit test case
Added unit test case to reach min coverage limit
Issue-ID: MUSIC-308
Change-Id: I4b96218d977c176285abe1903bf570e3525a9ce2
Signed-off-by: Jegadeesh Babu <jegabab1@in.ibm.com>
Thomas Nelson [Tue, 5 Feb 2019 18:10:43 +0000 (18:10 +0000)]
Merge changes from topic 'sudars_19_music_291_1'
* changes:
MusicServiceException-Junit test cases added
MusicQueryException - Junit Test Case Added
Thomas Nelson [Tue, 5 Feb 2019 18:10:29 +0000 (18:10 +0000)]
Merge "MusicPolicyVoilationException-Junit TestCase added"
Thomas Nelson [Tue, 5 Feb 2019 17:47:12 +0000 (17:47 +0000)]
Merge "MusicLockingExceptionTest - Junit test cases"
Thomas Nelson [Mon, 4 Feb 2019 16:32:55 +0000 (16:32 +0000)]
Merge "Updated:Typo"
Code Review / music.git / log