Sonar Major issues 03/68403/1
authorSurendra Reddy Katam <SK00524980@techmahindra.com>
Fri, 21 Sep 2018 11:15:49 +0000 (16:45 +0530)
committerSurendra Reddy Katam <SK00524980@techmahindra.com>
Fri, 21 Sep 2018 11:15:49 +0000 (16:45 +0530)
 This block of commented-out lines of code should be removed
Sonar Link:
https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41Wi2wGn37JfbyHxf&resolved=false&severities=MAJOR
Location:
src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java
Line No:L613 L623 L639

Change-Id: I0c880e87896a94a4bf15df439f03b48cee083f71
Issue-ID: DMAAP-813
Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java

index a889103..73a373e 100644 (file)
@@ -610,7 +610,7 @@ public class EventsServiceImpl implements EventsService {
                SimpleDateFormat sdf = new SimpleDateFormat("dd/MM/yyyy HH:mm:ss.SS");
 
                // LOG.warn("Batch Start Id: " +
-               // Utils.getFromattedBatchSequenceId(batchId));
+       
                try {
                        // for each message...
                        batchId = DMaaPContext.getBatchID();
@@ -620,13 +620,13 @@ public class EventsServiceImpl implements EventsService {
                        while ((m = events.next()) != null) {
 
                                // LOG.warn("Batch Start Id: " +
-                               // Utils.getFromattedBatchSequenceId(batchId));
+                               
 
                                addTransactionDetailsToMessage(m, topic, ctx.getRequest(), requestTime, messageSequence, batchId,
                                                transactionEnabled);
                                messageSequence++;
 
-                               // add the message to the batch
+                       
                                batch.add(m);
 
                                responseTransactionId = m.getLogDetails().getTransactionId();
@@ -636,7 +636,7 @@ public class EventsServiceImpl implements EventsService {
                                jsonObject.put("transactionId", responseTransactionId);
                                // final KeyedMessage<String, String> data = new
                                // KeyedMessage<String, String>(topic, m.getKey(),
-                               // jsonObject.toString());
+                       
                                // kms.add(data);
                                final ProducerRecord<String, String> data = new ProducerRecord<String, String>(topic, m.getKey(),
                                                m.getMessage());