From: Surendra Reddy Katam Date: Fri, 21 Sep 2018 11:15:49 +0000 (+0530) Subject: Sonar Major issues X-Git-Tag: 1.1.10~11 X-Git-Url: https://gerrit.onap.org/r/gitweb?p=dmaap%2Fmessagerouter%2Fmsgrtr.git;a=commitdiff_plain;h=a35521d1390b109e754aaab5b2d45d427a070165 Sonar Major issues This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.dmaap.messagerouter.msgrtr%3Amsgrtr&open=AWU41Wi2wGn37JfbyHxf&resolved=false&severities=MAJOR Location: src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java Line No:L613 L623 L639 Change-Id: I0c880e87896a94a4bf15df439f03b48cee083f71 Issue-ID: DMAAP-813 Signed-off-by: Surendra Reddy Katam --- diff --git a/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java b/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java index a889103..73a373e 100644 --- a/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java +++ b/src/main/java/com/att/dmf/mr/service/impl/EventsServiceImpl.java @@ -610,7 +610,7 @@ public class EventsServiceImpl implements EventsService { SimpleDateFormat sdf = new SimpleDateFormat("dd/MM/yyyy HH:mm:ss.SS"); // LOG.warn("Batch Start Id: " + - // Utils.getFromattedBatchSequenceId(batchId)); + try { // for each message... batchId = DMaaPContext.getBatchID(); @@ -620,13 +620,13 @@ public class EventsServiceImpl implements EventsService { while ((m = events.next()) != null) { // LOG.warn("Batch Start Id: " + - // Utils.getFromattedBatchSequenceId(batchId)); + addTransactionDetailsToMessage(m, topic, ctx.getRequest(), requestTime, messageSequence, batchId, transactionEnabled); messageSequence++; - // add the message to the batch + batch.add(m); responseTransactionId = m.getLogDetails().getTransactionId(); @@ -636,7 +636,7 @@ public class EventsServiceImpl implements EventsService { jsonObject.put("transactionId", responseTransactionId); // final KeyedMessage data = new // KeyedMessage(topic, m.getKey(), - // jsonObject.toString()); + // kms.add(data); final ProducerRecord data = new ProducerRecord(topic, m.getKey(), m.getMessage());