appc.git
5 years agoFix for artifact handler rpc error 67/65567/2
Patrick Brady [Mon, 10 Sep 2018 15:39:45 +0000 (08:39 -0700)]
Fix for artifact handler rpc error

Change over to using blueprint for rpc registration

Change-Id: Ie647472eb3e42eb7e878c526b13acbfffd1bc18f
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1185

5 years agoremove logback 1.1.2 security issue 81/65081/2
Taka Cho [Thu, 6 Sep 2018 20:38:21 +0000 (16:38 -0400)]
remove logback 1.1.2 security issue

under provider, we need to specify logback
artifact to remove the issue

Change-Id: Idb85bac263983447cc4b0d3d8e828371d1c7b2b4
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoFix for provider rpc error 85/65285/8
Patrick Brady [Fri, 7 Sep 2018 18:38:32 +0000 (11:38 -0700)]
Fix for provider rpc error

Change over to using blueprint for rpc registration

Tests cases will need to be modified and uncommented

Change-Id: I6535c2d9d141406ac29dc8bb2b769fea3bdbf53f
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1185

5 years agoadded test case to SshJcraftWrapperTest 03/65403/2
Sandeep J [Sun, 9 Sep 2018 20:09:35 +0000 (01:39 +0530)]
added test case to SshJcraftWrapperTest

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic40b87f63f4b14b70870fa717bcf01f206dc982f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoMisleading err msg failed to rebuild for snapshot. 97/65297/1
Modaboina, Kusumakumari (km583p) [Fri, 7 Sep 2018 19:32:46 +0000 (15:32 -0400)]
Misleading err msg failed to rebuild for snapshot.

Issue-ID: APPC-1196
Change-Id: I017528097939c89794afb8753db429886269c7c8
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
5 years agoAPI doc issue fix 01/64501/2
Balaji, Ramya (rb111y) [Tue, 4 Sep 2018 18:32:42 +0000 (14:32 -0400)]
API doc issue fix

Removed code that saves yang
in md-sal to prevent API doc
issues.

Issue-ID: APPC-1187
Change-Id: I30e3485f6e07660eedf3329bb1666eaa31e3e580
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agocovered cases for NetconfAdaptor2 15/63915/2
Ganesh Chandrasekaran [Thu, 30 Aug 2018 23:57:24 +0000 (08:57 +0900)]
covered cases for NetconfAdaptor2

Issue-ID: APPC-1182

Change-Id: Ib3e96b5869ce95299cf6e83a6f25ad04f7373382
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoCode Coverage for XinterfaceServices.java 81/64481/2
Dilip kumar Pampana [Tue, 4 Sep 2018 17:15:13 +0000 (13:15 -0400)]
Code Coverage for XinterfaceServices.java

Junit test for code covergae for XinerfaceServices.java in design
services

Issue-ID: APPC-1190
Change-Id: I8b23975eb1c9d19200b5d0d115763168e48c53b9
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoincrease coverage for restAdaptor HTTP_POST 55/63755/3
Ganesh Chandrasekaran [Thu, 30 Aug 2018 09:00:27 +0000 (18:00 +0900)]
increase coverage for restAdaptor HTTP_POST

Issue-ID: APPC-1181

Change-Id: If92c903fa520e1a609d4e4558241709a2b3f6439
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoincrease coverage for restAdaptor HTTP_GET 53/63753/3
Ganesh Chandrasekaran [Thu, 30 Aug 2018 08:59:06 +0000 (17:59 +0900)]
increase coverage for restAdaptor HTTP_GET

Issue-ID: APPC-1181

Change-Id: Iac9a6be49bc3e4ed2461a337e9b892b821a8d518
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoincrease coverage for restAdaptor HTTP_DELETE 51/63751/3
Ganesh Chandrasekaran [Thu, 30 Aug 2018 08:57:18 +0000 (17:57 +0900)]
increase coverage for restAdaptor HTTP_DELETE

Issue-ID: APPC-1181

Change-Id: I50eead8d40c692cd9674fdc2f1f3ed63c9f9031a
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agorefactor restAdaptor and add test for HTTP-PUT 49/63749/3
Ganesh Chandrasekaran [Thu, 30 Aug 2018 08:55:34 +0000 (17:55 +0900)]
refactor restAdaptor and add test for HTTP-PUT

Issue-ID: APPC-1181

Change-Id: Ibd70b03db906343c5e9c27439e2da541a54672e2
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoFixed error message for rebuild 89/64489/1
Balaji, Ramya (rb111y) [Tue, 4 Sep 2018 17:17:17 +0000 (13:17 -0400)]
Fixed error message for rebuild

Corrected code to ensure that all errors
in retrieving images do not result in a misleading
error message attributed to bootable volumes.
Instead, a generic error message processing has
been added.

Issue-ID: APPC-1189
Change-Id: Ic4dc917e86429a3ab7bce4432796083f0741c637
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
5 years agoupgrade netty-handler from 4.0.27 to 4.1.22 19/63319/2
Taka Cho [Tue, 28 Aug 2018 19:21:54 +0000 (15:21 -0400)]
upgrade netty-handler from 4.0.27 to 4.1.22

excluded cassandra from sdc tosca
and upgrade cassandra to 3.0.8

Change-Id: I725329e35746a9ed62aa9eda59ecbaefdaf8575b
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agofix the wrong LCM in doc 05/64105/2
Taka Cho [Sun, 2 Sep 2018 17:43:49 +0000 (13:43 -0400)]
fix the wrong LCM in doc

fix the outdated LCM API in APPC LCM API
document

Change-Id: I089540ce70fb311718a0ad1651cc1a86c19a544b
Issue-ID: APPC-1184
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agofix com.fasterxml.jackson.core 2.8.1 09/64109/3
Taka Cho [Sun, 2 Sep 2018 19:16:51 +0000 (15:16 -0400)]
fix com.fasterxml.jackson.core 2.8.1

Group: com.fasterxml.jackson.core
Artifact: jackson-core Version: 2.8.1
to
Version: 2.8.6

Change-Id: Ibe2b61a4ce2062372d98f88741e101e77b2d652c
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agofix com.fasterxml.jackson.core 2.8.4 07/64107/2
Taka Cho [Sun, 2 Sep 2018 19:09:25 +0000 (15:09 -0400)]
fix com.fasterxml.jackson.core 2.8.4

Group:  com.fasterxml.jackson.core
Artifact:  jackson-core
Version:  2.8.4
to
Version:        2.8.6

Change-Id: Id691ab4da8d5a5f205cff02acee70719952ef956
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoRemove excess feature files 65/64065/2
Patrick Brady [Fri, 31 Aug 2018 20:11:04 +0000 (13:11 -0700)]
Remove excess feature files

These feature stub files were accidently created, they
should not be in these projects.

Change-Id: Ib710d4d9be3d2f323ba2e4cfca31b2951777825f
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1185

5 years agorefactored code in ExecuteNodeActionImpl.java 45/61545/4
Sandeep J [Tue, 21 Aug 2018 11:18:38 +0000 (16:48 +0530)]
refactored code in ExecuteNodeActionImpl.java

created a method a called getVserverRelations(SvcLogicContext vnfCtx,
SvcLogicContext ctx) having the logic for looping through relationship-list
data, to get vserver relations. This piece of code was earlier not
covered by test cases. By putting this logic in a separate method, we
will be able to write a specific test case for this logic and will be
able to increase the code coverage by a big amount.

Issue-ID: APPC-1086
Change-Id: Iffa2a4f04a1fd2b93edc4bcdfef8625f196a305e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoJunit for code coverage in artifact-handler 91/60391/5
Dilip kumar Pampana [Mon, 13 Aug 2018 19:48:47 +0000 (15:48 -0400)]
Junit for code coverage in artifact-handler

Junit Test cases for checking Exceptions part and also for isUpdate in
DBService.java file

Issue-ID: APPC-1140
Change-Id: Ibbfe9daf5465f4efcc8d42e8ed508d0b5e5129bb
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoupgrade bcprov 1.59 to 1.60 to fix security issue 77/63277/2
Taka Cho [Tue, 28 Aug 2018 14:32:40 +0000 (10:32 -0400)]
upgrade bcprov 1.59 to 1.60 to fix security issue

on chef-adapter, I added a dependency to resolve bcprov-1.59
security issue from Nexus IQ report

Change-Id: I238664499becf3a969a7c88ac5a0e7cd2da2aa61
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoresolved SONAR issue in MetricActivator.java 81/61281/4
Sandeep J [Fri, 24 Aug 2018 11:01:05 +0000 (16:31 +0530)]
resolved SONAR issue in MetricActivator.java

resolved SONAR issue

Issue-ID: APPC-1163
Change-Id: I1d91fbebb938480f5470055768d9cff9e5902a57
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremoved redundant object assignment 17/62317/2
Sandeep J [Fri, 24 Aug 2018 12:22:19 +0000 (17:52 +0530)]
removed redundant object assignment

removed PropertyDefinition object creation dependency. The object is
already defined in the setUp method.

Issue-ID: APPC-1086
Change-Id: Icb7e791109a409af1b646b07052bc43517d09dc5
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRemove old appc-common 91/62191/5
Ryan Young [Thu, 23 Aug 2018 17:35:03 +0000 (13:35 -0400)]
Remove old appc-common

Issue-ID: APPC-1159
Change-Id: I65f1bc07fe0088df0624266e6158296ac73884a6
Signed-off-by: Ryan Young <ry303t@att.com>
5 years agoFix request handler class error 15/62215/2
Patrick Brady [Thu, 23 Aug 2018 22:46:43 +0000 (15:46 -0700)]
Fix request handler class error

Change-Id: I8e46de98f1a319452a9133835d0fe0b1430303ca
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1158

5 years agoadd test case to TestRequestContext.java 35/62035/2
Sandeep J [Thu, 23 Aug 2018 09:57:16 +0000 (15:27 +0530)]
add test case to TestRequestContext.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I6d6319321f930bd736c85f42676f448c4f44b48a
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestDmaapProducerImpl.java 31/62031/2
Sandeep J [Thu, 23 Aug 2018 09:45:25 +0000 (15:15 +0530)]
added test case to TestDmaapProducerImpl.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I39e99b4036ca7668bd739a9fa17cb850c5bea330
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPropertyDefinitionNode.java 29/62029/3
Sandeep J [Thu, 23 Aug 2018 09:29:35 +0000 (14:59 +0530)]
added test case to TestPropertyDefinitionNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I7a07ce47115eff276217addc92baf1df15bdb06e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdd dependencies for appc-sdc bundle 13/61913/2
Patrick Brady [Wed, 22 Aug 2018 21:12:25 +0000 (14:12 -0700)]
Add dependencies for appc-sdc bundle

Theses dependencies are needed for the
sdc-distribution-client. They existed as
embedded dependencies, but had no maven
dependency entry.

Change-Id: I1ba65dbd202ee8226351120480b0806394a2867d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1158

5 years agoAdd versions needed for appc-sdc 11/61911/2
Patrick Brady [Wed, 22 Aug 2018 21:06:29 +0000 (14:06 -0700)]
Add versions needed for appc-sdc

Change-Id: I381e941c65a71e12d7f007c0c57842712d8327bc
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1158

5 years agoadded test case to TestPropertyDefinitionNode.java 31/61531/2
Sandeep J [Tue, 21 Aug 2018 10:16:29 +0000 (15:46 +0530)]
added test case to TestPropertyDefinitionNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3c5b31a1127a364512b7787e28b1cdc7191a9138
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoRevert "resolving logback-classic 1.13" 77/61777/1
Patrick Brady [Wed, 22 Aug 2018 06:23:03 +0000 (23:23 -0700)]
Revert "resolving logback-classic 1.13"

Temporary revert to fix failing bundles.

This reverts commit 76b6ff1ce84d4c2ab4518dd5f154083b91680245.

Change-Id: Ibce5eee91ad8f1bec9b458a52a7f5d25ada85da9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1018
Signed-off-by: Patrick Brady <pb071s@att.com>
5 years agoRevert "remove logback 1.1.2 security issue" 75/61775/1
Patrick Brady [Wed, 22 Aug 2018 06:21:16 +0000 (23:21 -0700)]
Revert "remove logback 1.1.2 security issue"

Temporary revert to fix failing bundles.

This reverts commit 9922c9250a5419c726be6fae9ffb083e365d49e0.

Change-Id: I148f5b2add6b247b56ff1a3169d69458b363a4de
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1018

5 years agoadded test case to TestDmaapProducerImpl.java 95/61195/3
Sandeep J [Sun, 19 Aug 2018 20:28:56 +0000 (01:58 +0530)]
added test case to TestDmaapProducerImpl.java

to increase code coveraje

Issue-ID: APPC-1086
Change-Id: I2e507c2df03776fab33b023de6033cdd15e3a6ee
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed few sonar issues in AAIResourceNode.java 13/61313/3
Sandeep J [Mon, 20 Aug 2018 13:53:47 +0000 (19:23 +0530)]
fixed few sonar issues in AAIResourceNode.java

fixed few Sonar issues

Issue-ID: APPC-1166
Change-Id: Idc11b37bb22105750146c2bccd84f173f086c61f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed SONAR issue in AppcAaiClientActivator.java 99/61299/2
Sandeep J [Mon, 20 Aug 2018 12:46:36 +0000 (18:16 +0530)]
fixed SONAR issue in AppcAaiClientActivator.java

fixed SONAR issue

Issue-ID: APPC-1165
Change-Id: Iadc79265f18c4d6a61367a48d31ea6b70ce0178e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestRequestContext.java 53/61553/2
Sandeep J [Tue, 21 Aug 2018 11:42:18 +0000 (17:12 +0530)]
added test cases to TestRequestContext.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I32fc17823608fb0c79f11b3385379e34f6eb49cc
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestAnsibleMessageParser.java 95/61095/4
Sandeep J [Fri, 17 Aug 2018 12:56:07 +0000 (18:26 +0530)]
added test case to TestAnsibleMessageParser.java

to increase code coverage. Also, formatted the code.

Issue-ID: APPC-1086
Change-Id: I3b7bf6c70f20b0e42326f2fe3b642742f3fcd524
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoCorrect missing bundle 17/61417/5
Patrick Brady [Mon, 20 Aug 2018 17:30:28 +0000 (10:30 -0700)]
Correct missing bundle

The appc-config-params feature requries a bundle
which is not already added to the installation zip
automatically.

Change-Id: I2e256b0e28024e4b59ff002b2297447c5e3f9d12
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1158

5 years agoformatted the code and added test case 57/61257/2
Sandeep J [Mon, 20 Aug 2018 10:35:16 +0000 (16:05 +0530)]
formatted the code and added test case

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I2b1c1308adba0966172b1897a4d8815f80451beb
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test to cover catch portion of exception 47/61247/2
Sandeep J [Mon, 20 Aug 2018 10:13:34 +0000 (15:43 +0530)]
added test to cover catch portion of exception

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I91dcb8497ad2d5fe88238f1979f413584803d000
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremoved try catch from test case & formatted code 63/61263/3
Sandeep J [Mon, 20 Aug 2018 10:46:29 +0000 (16:16 +0530)]
removed try catch from test case & formatted code

replaced try catch with @Test(expected=JAXBException.class)

Issue-ID: APPC-1086
Change-Id: Ie3ec5a60b4ac09797ce2a8e5ed2f79b2979875c1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUpdate versions for odl sr3 55/60955/2
Patrick Brady [Thu, 16 Aug 2018 18:19:34 +0000 (11:19 -0700)]
Update versions for odl sr3

Change-Id: I4f27d566c714ca8ce8240f5a956515623e14c031
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1158

5 years agoresolving logback-classic 1.13 from security issue 61/61161/4
Taka Cho [Sat, 18 Aug 2018 19:56:57 +0000 (15:56 -0400)]
resolving logback-classic 1.13 from security issue

cdp-pal and eelf are the jar using logback-classic 1.1.3.
need to use exclusions option in pom file

Issue-ID: APPC-1018
Change-Id: I00b41f9c366a5ead3f4205cd6fa6b9eb74599767
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agofixing common-collection 3.2.1 security issue 99/61199/2
Taka Cho [Mon, 20 Aug 2018 00:46:00 +0000 (20:46 -0400)]
fixing common-collection 3.2.1 security issue

changed pom.xml and features.xml to keep common-collection to 3.2.2

Change-Id: I3ccd44d61f2e58edae9de6d7042cdb752bbd73cb
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test case to TestVnfc.java 13/60513/8
Sandeep J [Tue, 14 Aug 2018 08:53:43 +0000 (14:23 +0530)]
added test case  to TestVnfc.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I67c5f3aa03ee7b5fdd333bda71008605bcc71d6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupgrade bcprov to 1.60 93/60993/2
Taka Cho [Fri, 17 Aug 2018 01:42:10 +0000 (21:42 -0400)]
upgrade bcprov to 1.60

upgrade bcprov to 1.60 to avoid security issue

Change-Id: I10b20adbcceed68a74ac49dec7a6ade64d34d33c
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test xml data to xml_data.xml 81/61081/3
Sandeep J [Fri, 17 Aug 2018 10:36:00 +0000 (16:06 +0530)]
added test xml data to xml_data.xml

the code coverage for isXML method in CheckDataTool.java in
appc-config-generator was failing because there was no data in
xml_data.xml. So, added some test data. Now the coverage is happening
properly.

Issue-ID: APPC-1086
Change-Id: Iab203d502b145a83e7479dfaabfe8474ec629d90
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestXSLTTransformerNode.java 25/59825/7
Sandeep J [Thu, 9 Aug 2018 09:55:36 +0000 (15:25 +0530)]
added test cases to TestXSLTTransformerNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If07e899b03ba416b94675dfdcf1e45c5c365822d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case and formatted code 85/61085/2
Sandeep J [Fri, 17 Aug 2018 10:57:24 +0000 (16:27 +0530)]
added test case and formatted code

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I1f763c635cad7830cea4fbb55c864992bd04a184
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestVnf.java 73/61073/4
Sandeep J [Fri, 17 Aug 2018 10:00:35 +0000 (15:30 +0530)]
added test case to TestVnf.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I19bb65887308029ec991074175e64bc151962677
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoChanged Mockito jar scope to test 87/61087/1
Lathish [Fri, 17 Aug 2018 10:56:06 +0000 (11:56 +0100)]
Changed Mockito jar scope to test

Change-Id: I43cdb39233efe947b41d6638547767850b5df32a
Issue-ID: APPC-1157
Signed-off-by: Lathish <lathishbabu.ganesan@ericsson.com>
5 years agoadded test case to TestFileWriterNode.java 31/59831/6
Sandeep J [Thu, 9 Aug 2018 10:03:34 +0000 (15:33 +0530)]
added test case to TestFileWriterNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4665f2da142c4f5aaf01af8275ae480542a84cec
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPropertyDefinitionNode.java 41/60141/4
Sandeep J [Sun, 12 Aug 2018 13:13:11 +0000 (18:43 +0530)]
added test case to TestPropertyDefinitionNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If07e7542e7f9eeebd4d7956227128106d77457cb
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremove logback 1.1.2 security issue 15/60815/2
Taka Cho [Thu, 16 Aug 2018 01:17:32 +0000 (21:17 -0400)]
remove logback 1.1.2 security issue

under provider, we need to specify logback artifact to remove the issue

Change-Id: I1ab858558a9217fc2859fe663a9befe7884bb65a
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test case to TestVnf.java 55/60155/3
Sandeep J [Sun, 12 Aug 2018 14:23:06 +0000 (19:53 +0530)]
added test case to TestVnf.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I08abe39eeb7e2f94115c6cd54c7310c16189c1ec
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to JSONUtilTest.java 51/60151/3
Sandeep J [Sun, 12 Aug 2018 14:05:18 +0000 (19:35 +0530)]
added test case to JSONUtilTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I7fdf23f7692cd57e6a736307e038696431a25eb1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to JsonDgUtilImplTest.java 45/60145/3
Sandeep J [Sun, 12 Aug 2018 13:46:17 +0000 (19:16 +0530)]
added test case to JsonDgUtilImplTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5da9bfca629b3fa99f2b6fa85b2664828e844d69
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix incorrect groupid 33/60733/1
Patrick Brady [Wed, 15 Aug 2018 15:03:10 +0000 (08:03 -0700)]
Fix incorrect groupid

Change-Id: If87d33a94f96f82ddb07d7afc23798b39e3753d9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1028

5 years agoKaraf 4 for appc-provider 11/60411/4
Ryan Young [Tue, 14 Aug 2018 02:37:11 +0000 (22:37 -0400)]
Karaf 4 for appc-provider

Change-Id: Id0f8f51426a5595f51943e8b9d1bb62ed8ee1c8d
Issue-ID: APPC-1028
Signed-off-by: Ryan Young <ry303t@att.com>
5 years agoUndo change to fix parent build 39/60639/1
Patrick Brady [Tue, 14 Aug 2018 23:39:21 +0000 (16:39 -0700)]
Undo change to fix parent build

The parent has build, now we can start building
everything again.

Change-Id: Ibbed5adc3074d70f12eb7a756eb034bb05cb188d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoUpdate odl versions 31/60631/3
Patrick Brady [Tue, 14 Aug 2018 22:20:15 +0000 (15:20 -0700)]
Update odl versions

Change-Id: I78dae22d44c7b681f7fb73d98a903b7875c57b46
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoFix to build parent poms 35/60635/1
Patrick Brady [Tue, 14 Aug 2018 23:25:50 +0000 (16:25 -0700)]
Fix to build parent poms

Change-Id: I93a740112277d3896c2d7cacf793980faea886a1
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoKaraf 4 for appc-inbound 23/60623/5
Patrick Brady [Tue, 14 Aug 2018 05:38:26 +0000 (22:38 -0700)]
Karaf 4 for appc-inbound

Change-Id: I94f8b31e509d0e231e36b8b8d2871ad10bdf02f8
Issue-ID: APPC-1148
Signed-off-by: Patrick Brady <pb071s@att.com>
5 years agocorrect odl versions 31/60431/1
Patrick Brady [Tue, 14 Aug 2018 05:38:26 +0000 (22:38 -0700)]
correct odl versions

Change-Id: Icc84b968abaa9d4822b6257131b57db109723a81
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoKaraf 4 for appc outbound 29/60429/1
Patrick Brady [Mon, 13 Aug 2018 17:00:29 +0000 (10:00 -0700)]
Karaf 4 for appc outbound

Change-Id: I4aceffe33748a8e157bc1cac118de1e6b431378b
Issue-ID: APPC-1146
Signed-off-by: Patrick Brady <pb071s@att.com>
5 years agoKaraf 4 for appc-config 89/60089/5
Patrick Brady [Fri, 10 Aug 2018 22:30:58 +0000 (15:30 -0700)]
Karaf 4 for appc-config

Change-Id: I3059bf9bca4320d29432b749df6c55aecbdb22e9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1144

5 years agoKaraf 4 for 2 features 87/60087/6
Patrick Brady [Fri, 10 Aug 2018 22:14:38 +0000 (15:14 -0700)]
Karaf 4 for 2 features

appc-ansible-adaptor and appc-sequence-generator

Change-Id: I1f2e8727f899486df84c75350737a7a91bbb1039
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1142

5 years agoKaraf 4 for appc-iaas-adapter 41/60041/5
Patrick Brady [Fri, 10 Aug 2018 16:24:50 +0000 (09:24 -0700)]
Karaf 4 for appc-iaas-adapter

Change-Id: Ic6eb6f8025f2521b1b5b0a7df926ecc9bca582ac
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1022

5 years agoKaraf 4 for appc-oam 23/59923/9
Patrick Brady [Thu, 9 Aug 2018 20:43:54 +0000 (13:43 -0700)]
Karaf 4 for appc-oam

Change-Id: Id729265145dc4996a2a3ccb2457d66b7a8f2d6bd
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1139

5 years agoKaraf 4 for appc-sdc-listener 21/59921/7
Patrick Brady [Thu, 9 Aug 2018 20:42:38 +0000 (13:42 -0700)]
Karaf 4 for appc-sdc-listener

Change-Id: If3dabdd96403d1d197b0ac021912a8cd2b8ce772
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1138

5 years agoKaraf 4 for appc-dg features 13/59913/6
Patrick Brady [Thu, 9 Aug 2018 19:05:53 +0000 (12:05 -0700)]
Karaf 4 for appc-dg features

Including appc-dg-util, appc-dg-shared, and appc-ssh-adapter

Change-Id: Ia137a87c560438d23f7858e0f4068717891be076
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1137

5 years agoUpgrade appc-dispatcher features to karaf4 07/59707/4
Patrick Brady [Wed, 8 Aug 2018 17:25:15 +0000 (10:25 -0700)]
Upgrade appc-dispatcher features to karaf4

Change-Id: I9d2ea6e968a214f0b141d7a3fad7e09dd07eb6d3
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1136

5 years agoKaraf4 for license and lifecycle 09/59509/4
Patrick Brady [Tue, 7 Aug 2018 18:44:12 +0000 (11:44 -0700)]
Karaf4 for license and lifecycle

Change-Id: I392affa978507eae64583e0b5d6fd85111b39c97
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1122

5 years agoKaraf 4 for first few features 99/58099/7
Patrick Brady [Mon, 30 Jul 2018 21:35:31 +0000 (14:35 -0700)]
Karaf 4 for first few features

appc-metric
appc-dmaap-adapter
appc-chef-adapter
appc-netconf-adapter
appc-rest-adapter

Change-Id: I1d5a8e39cac7be74b05a0782f0971f8d08c8162d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1029

5 years agoParent updates for Karaf 4 07/60207/2
Patrick Brady [Mon, 13 Aug 2018 06:49:46 +0000 (23:49 -0700)]
Parent updates for Karaf 4

Change-Id: I1c368b64d5916adae980221ad0a639dfa8bee11c
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoRemove all powermock(ito) usages in appc-dg-util 83/57183/5
Michal Kabaj [Mon, 23 Jul 2018 16:05:35 +0000 (18:05 +0200)]
Remove all powermock(ito) usages in appc-dg-util

- Replace powermock usage with mockito.
- Introduce AAIServiceFactory for fetching AAIService from bundle
- Using blueprint.xml DI to pass factory into ExecuteNodeActionImpl
  during construction
- removed powermock(ito) deps from pom

Change-Id: I54450580c68c7d4992cb412192ca6dd4741398fc
Issue-ID: APPC-1008
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
5 years agoUpdate appc-common to Karaf 4 43/55543/7
Ryan Young [Thu, 28 Jun 2018 21:22:47 +0000 (17:22 -0400)]
Update appc-common to Karaf 4

update appc-common to karaf 4 feature

Change-Id: Ib0ce37032e63ffc61bef94345701f3ab58785153
Signed-off-by: Ryan Young <ry303t@att.com>
Issue-ID: APPC-1022

5 years agoadded test case to testDataTool.java 65/59665/2
Sandeep J [Wed, 8 Aug 2018 12:20:54 +0000 (17:50 +0530)]
added test case to testDataTool.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If736ff2d7cd30f6762ecb6bdc267b4a7c7f51c07
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoImprove LicenseManagerImpl implementation 43/57443/5
Joanna Jeremicz [Mon, 23 Jul 2018 10:10:41 +0000 (12:10 +0200)]
Improve LicenseManagerImpl implementation

- Use STAX API for XML processing instead of parsing it manually
- Rearrange code for clarity and testing
- Adjust JUnits accordingly

Issue-ID: APPC-1024
Change-Id: I9d655b581adb401b0c20bc29eda6a2bce1f2ef89
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
5 years agoadded test case to TestSignal.java 21/59821/2
Sandeep J [Thu, 9 Aug 2018 09:36:36 +0000 (15:06 +0530)]
added test case to TestSignal.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iacc5d38bacc946cf203d690cbe5a174e6dab15e2
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPatternNode.java 61/59661/4
Sandeep J [Wed, 8 Aug 2018 12:09:08 +0000 (17:39 +0530)]
added test case to TestPatternNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4d035ffb81367fd4de4004d4aefa8a6433e4fd7d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestMergeNode.java 59/59659/3
Sandeep J [Wed, 8 Aug 2018 12:04:04 +0000 (17:34 +0530)]
added test case to TestMergeNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If9a93361b275df98412dc23410a2094e340b7c9c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestConvertNode.java 57/59657/4
Sandeep J [Wed, 8 Aug 2018 11:52:02 +0000 (17:22 +0530)]
added test case to TestConvertNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If2320397a735dd4f510350802df631cb132145e8
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestDGGeneralDBService.java 11/59411/3
Sandeep J [Tue, 7 Aug 2018 10:15:05 +0000 (15:45 +0530)]
added test cases to TestDGGeneralDBService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I309985d0b7d9cbfa60d3e1082afd84aaf9631ef1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestSignal.java 43/59143/6
Sandeep J [Mon, 6 Aug 2018 10:22:34 +0000 (15:52 +0530)]
added test case to TestSignal.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ief0a74d2132295258c1a198309e310c235cad923
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadd property to skip karaf feature test 31/59531/2
Ryan Young [Tue, 7 Aug 2018 22:33:24 +0000 (18:33 -0400)]
add property to skip karaf feature test

SingleFeatureTest results in ClassNotFoundException: ResolutionException
(no security manage: RMI class loader disabled)

Change-Id: I58ac5947557276ccc0c7add7cb4c9394418cfa26
Signed-off-by: Ryan Young <ry303t@att.com>
Issue-ID: APPC-1045

5 years agoupdated existing test in TransactionTest.java 39/59439/2
Sandeep J [Tue, 7 Aug 2018 11:51:05 +0000 (17:21 +0530)]
updated existing test in TransactionTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I2a16e144489647a011735bad462665690eeba368
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdded test cases to ConfigResourceNodeTest.java 15/59415/2
Sandeep J [Tue, 7 Aug 2018 10:32:18 +0000 (16:02 +0530)]
Added test cases to ConfigResourceNodeTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iebffd1a614c286f50fca9b3159107d6e08a06670
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestEncryptionTool.java 29/59429/1
Sandeep J [Tue, 7 Aug 2018 11:09:45 +0000 (16:39 +0530)]
added test case to TestEncryptionTool.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Icf3522dee487c4ab876e11f201ad160c6be3831d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to DefaultConfigurationTest.java 27/58927/2
Sandeep J [Fri, 3 Aug 2018 11:44:35 +0000 (17:14 +0530)]
added test case to DefaultConfigurationTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4b0f1f352fa8b90810b7efc145e83edebff913da
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to PoolTest.java 33/58933/2
Sandeep J [Fri, 3 Aug 2018 12:23:53 +0000 (17:53 +0530)]
added test case to PoolTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ibbafa33ed726dff65cbc3528bf09d9cf68d97eb3
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupdated existing test case to increase coverage 67/59167/2
Sandeep J [Mon, 6 Aug 2018 11:11:37 +0000 (16:41 +0530)]
updated existing test case to increase coverage

updated existing test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3cec480ee68d5dc1aefd1aa8760ca70b485845b4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestStructuredPropertyHelper 57/59157/3
Sandeep J [Mon, 6 Aug 2018 10:57:51 +0000 (16:27 +0530)]
added test case to TestStructuredPropertyHelper

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I27a84f312fcdaed2ff85c686d2fa2e39884b6224
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoJunits for inbound/InterfaceServices 53/59253/4
Dilip kumar Pampana [Mon, 6 Aug 2018 17:44:56 +0000 (13:44 -0400)]
Junits for inbound/InterfaceServices

Code Coverage for appc-Inbound/InterfaceServices

Issue-ID: APPC-1132
Change-Id: Idd36429115f2d324fded4ab4106226cfad33bb65
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoRevert query changes 45/59245/5
Patrick Brady [Mon, 6 Aug 2018 16:19:22 +0000 (09:19 -0700)]
Revert query changes

The changes between patch 3 and patch 4 of this commit
https://gerrit.onap.org/r/#/c/55093, where the parameters
are sent to the SvcLogicContext instead of values, breaks
the save functionality in cdt. When SvcLogicContext is
allowed to subsitute the values, the StringUtils.isEmpty
functions are skipped over.

Although it appears this change is changing a parameterized
query to a static statement query, in fact the query is not
parameterized in its current form either. In its current form,
SvcLogicContext is just subsituting the values into a static
statement query. SvcLogicContext does perform a simple single
quote escape, which could be duplicated here.

Change-Id: If3ffceed5ad147c402355ffef17a8abf0752d5b1
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1107

5 years agoadded test case to ConfigResourceNodeTest.java 77/59177/1
Sandeep J [Mon, 6 Aug 2018 11:37:16 +0000 (17:07 +0530)]
added test case to ConfigResourceNodeTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ie87a796113a818a2454f8f2e339563ac062ee627
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestAaiService.java 97/58497/3
Sandeep J [Wed, 1 Aug 2018 19:39:04 +0000 (01:09 +0530)]
added test case to TestAaiService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5af628ec75f5dc16eac289fcaae4d62456b3edb0
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPropertyDefinitionNode.java 45/58945/3
Sandeep J [Fri, 3 Aug 2018 13:41:30 +0000 (19:11 +0530)]
added test case to TestPropertyDefinitionNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I74760fd2d97c4ef429e5f9d6f6eff0297ccec17e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestStructuredPropertyHelper 39/58939/3
Sandeep J [Fri, 3 Aug 2018 13:06:41 +0000 (18:36 +0530)]
added test case to TestStructuredPropertyHelper

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I00237d24ef2fac893e7c1867e4aa38ba026e9a16
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>