appc.git
5 years agoadded test to cover catch portion of exception 47/61247/2
Sandeep J [Mon, 20 Aug 2018 10:13:34 +0000 (15:43 +0530)]
added test to cover catch portion of exception

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I91dcb8497ad2d5fe88238f1979f413584803d000
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremoved try catch from test case & formatted code 63/61263/3
Sandeep J [Mon, 20 Aug 2018 10:46:29 +0000 (16:16 +0530)]
removed try catch from test case & formatted code

replaced try catch with @Test(expected=JAXBException.class)

Issue-ID: APPC-1086
Change-Id: Ie3ec5a60b4ac09797ce2a8e5ed2f79b2979875c1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoUpdate versions for odl sr3 55/60955/2
Patrick Brady [Thu, 16 Aug 2018 18:19:34 +0000 (11:19 -0700)]
Update versions for odl sr3

Change-Id: I4f27d566c714ca8ce8240f5a956515623e14c031
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1158

5 years agoresolving logback-classic 1.13 from security issue 61/61161/4
Taka Cho [Sat, 18 Aug 2018 19:56:57 +0000 (15:56 -0400)]
resolving logback-classic 1.13 from security issue

cdp-pal and eelf are the jar using logback-classic 1.1.3.
need to use exclusions option in pom file

Issue-ID: APPC-1018
Change-Id: I00b41f9c366a5ead3f4205cd6fa6b9eb74599767
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agofixing common-collection 3.2.1 security issue 99/61199/2
Taka Cho [Mon, 20 Aug 2018 00:46:00 +0000 (20:46 -0400)]
fixing common-collection 3.2.1 security issue

changed pom.xml and features.xml to keep common-collection to 3.2.2

Change-Id: I3ccd44d61f2e58edae9de6d7042cdb752bbd73cb
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test case to TestVnfc.java 13/60513/8
Sandeep J [Tue, 14 Aug 2018 08:53:43 +0000 (14:23 +0530)]
added test case  to TestVnfc.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I67c5f3aa03ee7b5fdd333bda71008605bcc71d6b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupgrade bcprov to 1.60 93/60993/2
Taka Cho [Fri, 17 Aug 2018 01:42:10 +0000 (21:42 -0400)]
upgrade bcprov to 1.60

upgrade bcprov to 1.60 to avoid security issue

Change-Id: I10b20adbcceed68a74ac49dec7a6ade64d34d33c
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test xml data to xml_data.xml 81/61081/3
Sandeep J [Fri, 17 Aug 2018 10:36:00 +0000 (16:06 +0530)]
added test xml data to xml_data.xml

the code coverage for isXML method in CheckDataTool.java in
appc-config-generator was failing because there was no data in
xml_data.xml. So, added some test data. Now the coverage is happening
properly.

Issue-ID: APPC-1086
Change-Id: Iab203d502b145a83e7479dfaabfe8474ec629d90
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestXSLTTransformerNode.java 25/59825/7
Sandeep J [Thu, 9 Aug 2018 09:55:36 +0000 (15:25 +0530)]
added test cases to TestXSLTTransformerNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If07e899b03ba416b94675dfdcf1e45c5c365822d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case and formatted code 85/61085/2
Sandeep J [Fri, 17 Aug 2018 10:57:24 +0000 (16:27 +0530)]
added test case and formatted code

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I1f763c635cad7830cea4fbb55c864992bd04a184
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestVnf.java 73/61073/4
Sandeep J [Fri, 17 Aug 2018 10:00:35 +0000 (15:30 +0530)]
added test case to TestVnf.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I19bb65887308029ec991074175e64bc151962677
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoChanged Mockito jar scope to test 87/61087/1
Lathish [Fri, 17 Aug 2018 10:56:06 +0000 (11:56 +0100)]
Changed Mockito jar scope to test

Change-Id: I43cdb39233efe947b41d6638547767850b5df32a
Issue-ID: APPC-1157
Signed-off-by: Lathish <lathishbabu.ganesan@ericsson.com>
5 years agoadded test case to TestFileWriterNode.java 31/59831/6
Sandeep J [Thu, 9 Aug 2018 10:03:34 +0000 (15:33 +0530)]
added test case to TestFileWriterNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4665f2da142c4f5aaf01af8275ae480542a84cec
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPropertyDefinitionNode.java 41/60141/4
Sandeep J [Sun, 12 Aug 2018 13:13:11 +0000 (18:43 +0530)]
added test case to TestPropertyDefinitionNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If07e7542e7f9eeebd4d7956227128106d77457cb
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoremove logback 1.1.2 security issue 15/60815/2
Taka Cho [Thu, 16 Aug 2018 01:17:32 +0000 (21:17 -0400)]
remove logback 1.1.2 security issue

under provider, we need to specify logback artifact to remove the issue

Change-Id: I1ab858558a9217fc2859fe663a9befe7884bb65a
Issue-ID: APPC-1018
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test case to TestVnf.java 55/60155/3
Sandeep J [Sun, 12 Aug 2018 14:23:06 +0000 (19:53 +0530)]
added test case to TestVnf.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I08abe39eeb7e2f94115c6cd54c7310c16189c1ec
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to JSONUtilTest.java 51/60151/3
Sandeep J [Sun, 12 Aug 2018 14:05:18 +0000 (19:35 +0530)]
added test case to JSONUtilTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I7fdf23f7692cd57e6a736307e038696431a25eb1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to JsonDgUtilImplTest.java 45/60145/3
Sandeep J [Sun, 12 Aug 2018 13:46:17 +0000 (19:16 +0530)]
added test case to JsonDgUtilImplTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5da9bfca629b3fa99f2b6fa85b2664828e844d69
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoFix incorrect groupid 33/60733/1
Patrick Brady [Wed, 15 Aug 2018 15:03:10 +0000 (08:03 -0700)]
Fix incorrect groupid

Change-Id: If87d33a94f96f82ddb07d7afc23798b39e3753d9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1028

5 years agoKaraf 4 for appc-provider 11/60411/4
Ryan Young [Tue, 14 Aug 2018 02:37:11 +0000 (22:37 -0400)]
Karaf 4 for appc-provider

Change-Id: Id0f8f51426a5595f51943e8b9d1bb62ed8ee1c8d
Issue-ID: APPC-1028
Signed-off-by: Ryan Young <ry303t@att.com>
5 years agoUndo change to fix parent build 39/60639/1
Patrick Brady [Tue, 14 Aug 2018 23:39:21 +0000 (16:39 -0700)]
Undo change to fix parent build

The parent has build, now we can start building
everything again.

Change-Id: Ibbed5adc3074d70f12eb7a756eb034bb05cb188d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoUpdate odl versions 31/60631/3
Patrick Brady [Tue, 14 Aug 2018 22:20:15 +0000 (15:20 -0700)]
Update odl versions

Change-Id: I78dae22d44c7b681f7fb73d98a903b7875c57b46
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoFix to build parent poms 35/60635/1
Patrick Brady [Tue, 14 Aug 2018 23:25:50 +0000 (16:25 -0700)]
Fix to build parent poms

Change-Id: I93a740112277d3896c2d7cacf793980faea886a1
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoKaraf 4 for appc-inbound 23/60623/5
Patrick Brady [Tue, 14 Aug 2018 05:38:26 +0000 (22:38 -0700)]
Karaf 4 for appc-inbound

Change-Id: I94f8b31e509d0e231e36b8b8d2871ad10bdf02f8
Issue-ID: APPC-1148
Signed-off-by: Patrick Brady <pb071s@att.com>
5 years agocorrect odl versions 31/60431/1
Patrick Brady [Tue, 14 Aug 2018 05:38:26 +0000 (22:38 -0700)]
correct odl versions

Change-Id: Icc84b968abaa9d4822b6257131b57db109723a81
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoKaraf 4 for appc outbound 29/60429/1
Patrick Brady [Mon, 13 Aug 2018 17:00:29 +0000 (10:00 -0700)]
Karaf 4 for appc outbound

Change-Id: I4aceffe33748a8e157bc1cac118de1e6b431378b
Issue-ID: APPC-1146
Signed-off-by: Patrick Brady <pb071s@att.com>
5 years agoKaraf 4 for appc-config 89/60089/5
Patrick Brady [Fri, 10 Aug 2018 22:30:58 +0000 (15:30 -0700)]
Karaf 4 for appc-config

Change-Id: I3059bf9bca4320d29432b749df6c55aecbdb22e9
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1144

5 years agoKaraf 4 for 2 features 87/60087/6
Patrick Brady [Fri, 10 Aug 2018 22:14:38 +0000 (15:14 -0700)]
Karaf 4 for 2 features

appc-ansible-adaptor and appc-sequence-generator

Change-Id: I1f2e8727f899486df84c75350737a7a91bbb1039
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1142

5 years agoKaraf 4 for appc-iaas-adapter 41/60041/5
Patrick Brady [Fri, 10 Aug 2018 16:24:50 +0000 (09:24 -0700)]
Karaf 4 for appc-iaas-adapter

Change-Id: Ic6eb6f8025f2521b1b5b0a7df926ecc9bca582ac
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1022

5 years agoKaraf 4 for appc-oam 23/59923/9
Patrick Brady [Thu, 9 Aug 2018 20:43:54 +0000 (13:43 -0700)]
Karaf 4 for appc-oam

Change-Id: Id729265145dc4996a2a3ccb2457d66b7a8f2d6bd
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1139

5 years agoKaraf 4 for appc-sdc-listener 21/59921/7
Patrick Brady [Thu, 9 Aug 2018 20:42:38 +0000 (13:42 -0700)]
Karaf 4 for appc-sdc-listener

Change-Id: If3dabdd96403d1d197b0ac021912a8cd2b8ce772
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1138

5 years agoKaraf 4 for appc-dg features 13/59913/6
Patrick Brady [Thu, 9 Aug 2018 19:05:53 +0000 (12:05 -0700)]
Karaf 4 for appc-dg features

Including appc-dg-util, appc-dg-shared, and appc-ssh-adapter

Change-Id: Ia137a87c560438d23f7858e0f4068717891be076
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1137

5 years agoUpgrade appc-dispatcher features to karaf4 07/59707/4
Patrick Brady [Wed, 8 Aug 2018 17:25:15 +0000 (10:25 -0700)]
Upgrade appc-dispatcher features to karaf4

Change-Id: I9d2ea6e968a214f0b141d7a3fad7e09dd07eb6d3
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1136

5 years agoKaraf4 for license and lifecycle 09/59509/4
Patrick Brady [Tue, 7 Aug 2018 18:44:12 +0000 (11:44 -0700)]
Karaf4 for license and lifecycle

Change-Id: I392affa978507eae64583e0b5d6fd85111b39c97
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1122

5 years agoKaraf 4 for first few features 99/58099/7
Patrick Brady [Mon, 30 Jul 2018 21:35:31 +0000 (14:35 -0700)]
Karaf 4 for first few features

appc-metric
appc-dmaap-adapter
appc-chef-adapter
appc-netconf-adapter
appc-rest-adapter

Change-Id: I1d5a8e39cac7be74b05a0782f0971f8d08c8162d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1029

5 years agoParent updates for Karaf 4 07/60207/2
Patrick Brady [Mon, 13 Aug 2018 06:49:46 +0000 (23:49 -0700)]
Parent updates for Karaf 4

Change-Id: I1c368b64d5916adae980221ad0a639dfa8bee11c
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoRemove all powermock(ito) usages in appc-dg-util 83/57183/5
Michal Kabaj [Mon, 23 Jul 2018 16:05:35 +0000 (18:05 +0200)]
Remove all powermock(ito) usages in appc-dg-util

- Replace powermock usage with mockito.
- Introduce AAIServiceFactory for fetching AAIService from bundle
- Using blueprint.xml DI to pass factory into ExecuteNodeActionImpl
  during construction
- removed powermock(ito) deps from pom

Change-Id: I54450580c68c7d4992cb412192ca6dd4741398fc
Issue-ID: APPC-1008
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
5 years agoUpdate appc-common to Karaf 4 43/55543/7
Ryan Young [Thu, 28 Jun 2018 21:22:47 +0000 (17:22 -0400)]
Update appc-common to Karaf 4

update appc-common to karaf 4 feature

Change-Id: Ib0ce37032e63ffc61bef94345701f3ab58785153
Signed-off-by: Ryan Young <ry303t@att.com>
Issue-ID: APPC-1022

5 years agoadded test case to testDataTool.java 65/59665/2
Sandeep J [Wed, 8 Aug 2018 12:20:54 +0000 (17:50 +0530)]
added test case to testDataTool.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If736ff2d7cd30f6762ecb6bdc267b4a7c7f51c07
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoImprove LicenseManagerImpl implementation 43/57443/5
Joanna Jeremicz [Mon, 23 Jul 2018 10:10:41 +0000 (12:10 +0200)]
Improve LicenseManagerImpl implementation

- Use STAX API for XML processing instead of parsing it manually
- Rearrange code for clarity and testing
- Adjust JUnits accordingly

Issue-ID: APPC-1024
Change-Id: I9d655b581adb401b0c20bc29eda6a2bce1f2ef89
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
5 years agoadded test case to TestSignal.java 21/59821/2
Sandeep J [Thu, 9 Aug 2018 09:36:36 +0000 (15:06 +0530)]
added test case to TestSignal.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iacc5d38bacc946cf203d690cbe5a174e6dab15e2
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPatternNode.java 61/59661/4
Sandeep J [Wed, 8 Aug 2018 12:09:08 +0000 (17:39 +0530)]
added test case to TestPatternNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4d035ffb81367fd4de4004d4aefa8a6433e4fd7d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestMergeNode.java 59/59659/3
Sandeep J [Wed, 8 Aug 2018 12:04:04 +0000 (17:34 +0530)]
added test case to TestMergeNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If9a93361b275df98412dc23410a2094e340b7c9c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestConvertNode.java 57/59657/4
Sandeep J [Wed, 8 Aug 2018 11:52:02 +0000 (17:22 +0530)]
added test case to TestConvertNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: If2320397a735dd4f510350802df631cb132145e8
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestDGGeneralDBService.java 11/59411/3
Sandeep J [Tue, 7 Aug 2018 10:15:05 +0000 (15:45 +0530)]
added test cases to TestDGGeneralDBService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I309985d0b7d9cbfa60d3e1082afd84aaf9631ef1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestSignal.java 43/59143/6
Sandeep J [Mon, 6 Aug 2018 10:22:34 +0000 (15:52 +0530)]
added test case to TestSignal.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ief0a74d2132295258c1a198309e310c235cad923
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadd property to skip karaf feature test 31/59531/2
Ryan Young [Tue, 7 Aug 2018 22:33:24 +0000 (18:33 -0400)]
add property to skip karaf feature test

SingleFeatureTest results in ClassNotFoundException: ResolutionException
(no security manage: RMI class loader disabled)

Change-Id: I58ac5947557276ccc0c7add7cb4c9394418cfa26
Signed-off-by: Ryan Young <ry303t@att.com>
Issue-ID: APPC-1045

5 years agoupdated existing test in TransactionTest.java 39/59439/2
Sandeep J [Tue, 7 Aug 2018 11:51:05 +0000 (17:21 +0530)]
updated existing test in TransactionTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I2a16e144489647a011735bad462665690eeba368
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdded test cases to ConfigResourceNodeTest.java 15/59415/2
Sandeep J [Tue, 7 Aug 2018 10:32:18 +0000 (16:02 +0530)]
Added test cases to ConfigResourceNodeTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iebffd1a614c286f50fca9b3159107d6e08a06670
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestEncryptionTool.java 29/59429/1
Sandeep J [Tue, 7 Aug 2018 11:09:45 +0000 (16:39 +0530)]
added test case to TestEncryptionTool.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Icf3522dee487c4ab876e11f201ad160c6be3831d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to DefaultConfigurationTest.java 27/58927/2
Sandeep J [Fri, 3 Aug 2018 11:44:35 +0000 (17:14 +0530)]
added test case to DefaultConfigurationTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I4b0f1f352fa8b90810b7efc145e83edebff913da
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to PoolTest.java 33/58933/2
Sandeep J [Fri, 3 Aug 2018 12:23:53 +0000 (17:53 +0530)]
added test case to PoolTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ibbafa33ed726dff65cbc3528bf09d9cf68d97eb3
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupdated existing test case to increase coverage 67/59167/2
Sandeep J [Mon, 6 Aug 2018 11:11:37 +0000 (16:41 +0530)]
updated existing test case to increase coverage

updated existing test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: I3cec480ee68d5dc1aefd1aa8760ca70b485845b4
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestStructuredPropertyHelper 57/59157/3
Sandeep J [Mon, 6 Aug 2018 10:57:51 +0000 (16:27 +0530)]
added test case to TestStructuredPropertyHelper

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I27a84f312fcdaed2ff85c686d2fa2e39884b6224
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoJunits for inbound/InterfaceServices 53/59253/4
Dilip kumar Pampana [Mon, 6 Aug 2018 17:44:56 +0000 (13:44 -0400)]
Junits for inbound/InterfaceServices

Code Coverage for appc-Inbound/InterfaceServices

Issue-ID: APPC-1132
Change-Id: Idd36429115f2d324fded4ab4106226cfad33bb65
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoRevert query changes 45/59245/5
Patrick Brady [Mon, 6 Aug 2018 16:19:22 +0000 (09:19 -0700)]
Revert query changes

The changes between patch 3 and patch 4 of this commit
https://gerrit.onap.org/r/#/c/55093, where the parameters
are sent to the SvcLogicContext instead of values, breaks
the save functionality in cdt. When SvcLogicContext is
allowed to subsitute the values, the StringUtils.isEmpty
functions are skipped over.

Although it appears this change is changing a parameterized
query to a static statement query, in fact the query is not
parameterized in its current form either. In its current form,
SvcLogicContext is just subsituting the values into a static
statement query. SvcLogicContext does perform a simple single
quote escape, which could be duplicated here.

Change-Id: If3ffceed5ad147c402355ffef17a8abf0752d5b1
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1107

5 years agoadded test case to ConfigResourceNodeTest.java 77/59177/1
Sandeep J [Mon, 6 Aug 2018 11:37:16 +0000 (17:07 +0530)]
added test case to ConfigResourceNodeTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ie87a796113a818a2454f8f2e339563ac062ee627
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestAaiService.java 97/58497/3
Sandeep J [Wed, 1 Aug 2018 19:39:04 +0000 (01:09 +0530)]
added test case to TestAaiService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I5af628ec75f5dc16eac289fcaae4d62456b3edb0
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestPropertyDefinitionNode.java 45/58945/3
Sandeep J [Fri, 3 Aug 2018 13:41:30 +0000 (19:11 +0530)]
added test case to TestPropertyDefinitionNode.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I74760fd2d97c4ef429e5f9d6f6eff0297ccec17e
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestStructuredPropertyHelper 39/58939/3
Sandeep J [Fri, 3 Aug 2018 13:06:41 +0000 (18:36 +0530)]
added test case to TestStructuredPropertyHelper

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I00237d24ef2fac893e7c1867e4aa38ba026e9a16
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestSignal.java 21/58921/3
Sandeep J [Fri, 3 Aug 2018 11:03:46 +0000 (16:33 +0530)]
added test case to TestSignal.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iba603fd695d9f5e2a70fa08f07272e407d0db00c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoChanged Code and DGs to return detailed response. 73/58773/3
Shailendra Borale [Thu, 2 Aug 2018 20:00:22 +0000 (16:00 -0400)]
Changed Code and DGs to return detailed response.

Added comment and used String instead of Integer.toString

Change-Id: I07a0a7752b225fbf50d761b489b9320b47fcc71d
Issue-ID: APPC-1013
Signed-off-by: sb8915 <sb8915@att.com>
5 years agoadded test case to TestValidatorService.java 15/58415/3
Sandeep J [Wed, 1 Aug 2018 12:18:43 +0000 (17:48 +0530)]
added test case to TestValidatorService.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id3d7d93fb02d62be8288ae7065b69b22ce1d8c2f
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupdated existing test case to increase coverage 07/58407/2
Sandeep J [Wed, 1 Aug 2018 11:04:54 +0000 (16:34 +0530)]
updated existing test case to increase coverage

updated existing test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iea8d0a833872cec864436300c4bcbc9e55cd3316
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupdated test case to increase coverage 71/58271/4
Sandeep J [Tue, 31 Jul 2018 19:40:12 +0000 (01:10 +0530)]
updated test case to increase coverage

updated test to cover getAppcTimeStampResponse method in
DbResponseProcessor.java

Issue-ID: APPC-1086
Change-Id: I6333683181498857aa58ca7ccb404329574513ff
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestWorkFlowRequest.java 21/58221/3
Sandeep J [Tue, 31 Jul 2018 11:19:51 +0000 (16:49 +0530)]
added test cases to TestWorkFlowRequest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ic13af8abd0b984111cec2b8b4c822ea0f85c6286
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agofixed failing test cases in TimeTest.java 03/58203/3
Sandeep J [Tue, 31 Jul 2018 09:41:50 +0000 (15:11 +0530)]
fixed failing test cases in TimeTest.java

fixed the issue APPC-1112, where few test cases where failing because of
platform dependency. Removed assertEquals and replaced it with
assertNotNull and assertTrue, so that coverage is not affected and the
test case also passes succesfully. Cant use asserEquals here as the
value timestamp is platform dependent.

Issue-ID: APPC-1112
Change-Id: I4b9f786eaa61835765ffdadd0beb9092bc9beb17
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestMessages.java 27/58227/4
Sandeep J [Tue, 31 Jul 2018 11:47:33 +0000 (17:17 +0530)]
added test cases to TestMessages.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I230ad0e38a1507e0619d490a3786b97fa6d5db32
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestWorkFlowResponse.java 25/58225/3
Sandeep J [Tue, 31 Jul 2018 11:24:37 +0000 (16:54 +0530)]
added test case to TestWorkFlowResponse.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I99d9a92e458a1e4066c7abe2d6595d1ce6c7b946
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years ago GetTemplateConfigAnsible DG Bug 73/57973/2
Ganesh Chandrasekaran [Mon, 30 Jul 2018 08:12:27 +0000 (17:12 +0900)]
 GetTemplateConfigAnsible DG Bug

Please refer to Jira page for more details

Issue-ID: APPC-1115

Change-Id: I0f56009a44b37e0f30942da533f8bc08766de602
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years ago GetTemplateConfigChef DG Bug 71/57971/2
Ganesh Chandrasekaran [Mon, 30 Jul 2018 07:58:14 +0000 (16:58 +0900)]
 GetTemplateConfigChef DG Bug

Please refer to the Jira page for more information.

Issue-ID: APPC-1114

Change-Id: I6c0f033594371c33efd9ab224873c7f9cbec0f2e
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoadded test case to TestTransactionRecord.java 13/58213/2
Sandeep J [Tue, 31 Jul 2018 10:40:11 +0000 (16:10 +0530)]
added test case to TestTransactionRecord.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I35d44cf74166edd126b918b0624a99ebc0396b07
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoJunits for Inbound/designServices 89/58089/9
Dilip kumar Pampana [Mon, 30 Jul 2018 20:41:19 +0000 (16:41 -0400)]
Junits for Inbound/designServices

Added new test class files for code coverage of DesignDBServices and
removed version for mockito-core as it is overriding existing one in
pom.xml file in design services provide.

Issue-ID: APPC-1117
Change-Id: I9eddf30c7e3c72467f4bf5f5850c22c083f51a9f
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoignoring testFetch as it is long time to execute 05/58205/1
Sandeep J [Tue, 31 Jul 2018 09:58:47 +0000 (15:28 +0530)]
ignoring testFetch as it is long time to execute

ignoring the testFetch method as it is taking 130 sec to execute, as
reported by Patrick in the issue APPC-1111.

Issue-ID: APPC-1111
Change-Id: I7bef0719a04b5d3dd9d52a1c2608f16f16d76c5d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoIncrease coverage for sshdDataAccessDervice 55/57955/2
Ganesh Chandrasekaran [Mon, 30 Jul 2018 00:39:17 +0000 (09:39 +0900)]
Increase coverage for sshdDataAccessDervice

Issue-ID: APPC-1113

Change-Id: If7f466c6e6c205c220ae020c3e4ce24e1088f7f3
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoadded test cases to TestResponseContext.java 41/57741/4
Sandeep J [Thu, 26 Jul 2018 18:27:04 +0000 (23:57 +0530)]
added test cases to TestResponseContext.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ia82129b891a518e6dfa1809ab94f308775d29a9c
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestRuntimeContext.java 45/57745/2
Sandeep J [Thu, 26 Jul 2018 18:42:44 +0000 (00:12 +0530)]
added test cases to TestRuntimeContext.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iaca5e351a38e37bd6310e191c3515d2d24789858
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestTransactionRecord.java 79/57879/2
Sandeep J [Fri, 27 Jul 2018 15:18:29 +0000 (20:48 +0530)]
added test cases to TestTransactionRecord.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ib1327bea47d5feb6fa7d5a2ad5bdb136642661b1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestResponseHandlerOutput.java 11/57911/2
Sandeep J [Fri, 27 Jul 2018 20:47:54 +0000 (02:17 +0530)]
added test case to TestResponseHandlerOutput.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I7cb23c2e389a8c0d8d153cb241b726360a759f03
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoupdatd test in RequestValidationExceptionTest.java 17/57917/2
Sandeep J [Fri, 27 Jul 2018 21:00:52 +0000 (02:30 +0530)]
updatd test in RequestValidationExceptionTest.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id2a2f7f2476f4a6d2f917c713af374cd0d02f682
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestRequestHandlerInput.java 09/57909/2
Sandeep J [Fri, 27 Jul 2018 20:41:30 +0000 (02:11 +0530)]
added test case to TestRequestHandlerInput.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ie0a570c7b20d236d8203d57f1351f34e0b7466d1
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestLCMCommandStatus.java 95/57695/2
Sandeep J [Thu, 26 Jul 2018 11:55:23 +0000 (17:25 +0530)]
added test case to TestLCMCommandStatus.java

addes test case to increase code-coverage

Issue-ID: APPC-1086
Change-Id: Ie36b332e947900990d62a11723070a5ae8e53a99
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestCommonHeader.java 99/57699/6
Sandeep J [Thu, 26 Jul 2018 12:17:55 +0000 (17:47 +0530)]
added test case to TestCommonHeader.java

to increase code coverage

Issue-ID: APPC-1086
Change-Id: I9ddee44a33daa768a73e7575ac5901b13e87237b
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TestRequestContext.java 03/57703/2
Sandeep J [Thu, 26 Jul 2018 13:33:38 +0000 (19:03 +0530)]
added test case to TestRequestContext.java

to increase code-coverage

Issue-ID: APPC-1086
Change-Id: Iabee69884c983ff3391d682d185524a22ea08ab0
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAPI to support getConnection with SSH KeyFile 15/57015/10
Ganesh Chandrasekaran [Fri, 20 Jul 2018 07:32:46 +0000 (16:32 +0900)]
API to support getConnection with SSH KeyFile

Issue-ID: APPC-1097

Change-Id: Ic9baa3e43be55bc20aa974898c164cc8a590a78a
Signed-off-by: Ganesh Chandrasekaran <ganesh.c@samsung.com>
5 years agoadded test case to TestCommandExecuterInput.java 39/57539/4
Sandeep J [Wed, 25 Jul 2018 13:06:49 +0000 (18:36 +0530)]
added test case to TestCommandExecuterInput.java

added test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: Iad87297e2f52c7a14bfa178ab6be4a841604715d
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadd new reboot LCM API 55/57755/1
Taka Cho [Thu, 26 Jul 2018 19:42:32 +0000 (15:42 -0400)]
add new reboot LCM API

In R3, AT&T contributes a new lcm api: reboot

this is for adding reboot LCM API into readdoc

Change-Id: I3bb9e338d78424005aa6b1584073db101ae7f337
Issue-ID: APPC-1034
Signed-off-by: Taka Cho <tc012c@att.com>
5 years agoadded test case to JsonDgutilImplTest.java 33/57533/4
Sandeep J [Wed, 25 Jul 2018 12:27:51 +0000 (17:57 +0530)]
added test case to JsonDgutilImplTest.java

added test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ib2bb400348ebde7200d46e1f05775be6fbe298cd
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test case to TransactionTest.java 51/57451/5
Sandeep J [Wed, 25 Jul 2018 10:04:25 +0000 (15:34 +0530)]
added test case to TransactionTest.java

added test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: Ib02211122e9d662387858c70876f3784e65ec0ce
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded some more test cases to TimeTest.java 11/57311/3
Sandeep J [Tue, 24 Jul 2018 11:49:34 +0000 (17:19 +0530)]
added some more test cases to TimeTest.java

added some more test cases to increase code coverage

Issue-ID: APPC-1086
Change-Id: I8f4458ddcc70d360eae71e41d1608d0529ed2269
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoChange appc-parent to new odl 79/57379/2
Patrick Brady [Tue, 24 Jul 2018 19:27:35 +0000 (12:27 -0700)]
Change appc-parent to new odl

Changing the parent ccsdk version of the appc-parent
pom files so they will use the new ODL version.

Change-Id: Ia573a707f2c73899c415d7c2015362f7506f1f1d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-939

5 years agoFix query statements in DBService 77/57377/3
Mei Su [Tue, 24 Jul 2018 19:01:37 +0000 (15:01 -0400)]
Fix query statements in DBService

Fix query statements related to url in DBService

Issue-ID: APPC-1107
Change-Id: I2f8e2bc77c04a4b96160af00bdc9d3debe4395c3
Signed-off-by: Mei Su <ms6523@att.com>
5 years agoadded test case to PreCheckTest.java 23/57323/3
Sandeep J [Tue, 24 Jul 2018 12:31:51 +0000 (18:01 +0530)]
added test case to PreCheckTest.java

added test case to increase code coverage

Issue-ID: APPC-1086
Change-Id: I51aff34afc47db330c773431d59a5e30cea74d79
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded few test cases to TestSQLSaveQuery.java 83/57283/3
Sandeep J [Tue, 24 Jul 2018 10:06:31 +0000 (15:36 +0530)]
added few test cases to TestSQLSaveQuery.java

added few test cases to increase code coverage

Issue-ID: APPC-1086
Change-Id: Id895923e0df4b55c7705534e971d67b972514e50
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoadded test cases to TestCompareNodeJson.java 53/57153/4
Sandeep J [Mon, 23 Jul 2018 11:23:34 +0000 (16:53 +0530)]
added test cases to TestCompareNodeJson.java

added few test cases to increase code coverage

Issue-ID: APPC-1086
Change-Id: I64fcbae96f7627469900f9c67e52b3ef3ce6e5f3
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
5 years agoAdd parent to appc-parent aggregator 67/57367/3
Patrick Brady [Tue, 24 Jul 2018 17:58:08 +0000 (10:58 -0700)]
Add parent to appc-parent aggregator

The parent is required to supply the distributionManagement
properties for deployment.

Change-Id: I3c66552a9563db88701e5a8b8a087652073fe87b
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-1045

5 years agoadded test case to TestCompareNodeCli.java 49/57149/5
Sandeep J [Mon, 23 Jul 2018 11:02:19 +0000 (16:32 +0530)]
added test case to TestCompareNodeCli.java

added test case to increase code coverage. A part of the else block in
compare method of CompareNode.java was not being covered. Getting
covered now with this test case.

Issue-ID: APPC-1086
Change-Id: I2821ec0c5d9203f5c76e6a091c6734f41333d638
Signed-off-by: Sandeep Jha<sandeejh@in.ibm.com>
5 years agoFix ssh adapter compilation issues. 21/56521/3
David Crosson [Mon, 16 Jul 2018 15:52:06 +0000 (17:52 +0200)]
Fix ssh adapter compilation issues.

Apache sshd library updated to 2.0.0

Issue-ID: APPC-835
Change-Id: Idfbc396291c3d05a47e4dceb45d06bc8084c054d
Signed-off-by: David Crosson <david.crosson@orange.com>
5 years agoJunit Test cases for Ansible adapter 87/57187/2
Dilip kumar Pampana [Mon, 23 Jul 2018 16:25:01 +0000 (12:25 -0400)]
Junit Test cases for Ansible adapter

Junits test cases for ansibleMessageParser in Ansible Adapter

Issue-ID: APPC-1106
Change-Id: I9ef0664fb613d80f3275637413f0d2fae76b0186
Signed-off-by: Dilip kumar Pampana <dilip.kumar.pampana@ibm.com>
5 years agoadded few more test cases to TimeTest.java 45/57045/4
Sandeep J [Fri, 20 Jul 2018 11:35:39 +0000 (17:05 +0530)]
added few more test cases to TimeTest.java

added few more test cases to TimeTest.java to increase code coverage

Issue-ID: APPC-1086
Change-Id: I910a5ab4420cc38d9c27fc2a206ac96b5377e225
Signed-off-by: Sandeep J <sandeejh@in.ibm.com>