Irwin Dunietz [Mon, 9 Apr 2018 21:24:29 +0000 (17:24 -0400)]
Add junit coverage to RequestInfoBuilder class
Introduce junit-tests for RequestInfoBuilder class
Change-Id: Iffbe36a0de850f3346b754a8ec7ced092e960f01
Issue-ID: APPC-840
Signed-off-by: Irwin Dunietz <id1681@att.com>
Zihmin Hoover [Mon, 9 Apr 2018 16:13:15 +0000 (12:13 -0400)]
Add junit coverage to CmdLine class
Introduce junit-tests for CmdLine class
Change-Id: I23394ad80882a667dd8189ee9f91441dcf0e31b4
Issue-ID: APPC-838
Signed-off-by: Zihmin Hoover <zh4590@att.com>
Irwin Dunietz [Mon, 9 Apr 2018 18:09:11 +0000 (14:09 -0400)]
Add junit coverage to ActionIdentifierModel class
Introduce junit-tests for ActionIdentifierModel class
Change-Id: I792c6787e94b4aeaec992720c359c0f740b44485
Issue-ID: APPC-839
Signed-off-by: Irwin Dunietz <id1681@att.com>
Ryan Young [Fri, 6 Apr 2018 21:32:41 +0000 (17:32 -0400)]
Enhance DMaaP Adapter Configuration
Change-Id: I5385cf2710fc33a85da9a67d5f4d31dce1e460aa
Signed-off-by: Ryan Young <ry303t@att.com>
Issue-ID: APPC-658
amshegokar [Tue, 3 Apr 2018 11:57:11 +0000 (17:27 +0530)]
Unit test for EventMessage.java
Unit test for EventMessage.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2Fevent%2FEventMessage.java
Change-Id: If6a84cb1de99e719c6b286559bf899da349b4a57
Issue-ID: APPC-823
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
John McClung [Mon, 9 Apr 2018 14:25:27 +0000 (10:25 -0400)]
Add junit coverage to UnmodifiableProperties class
Introduce junit-tests for EncryptionTool class
Change-Id: Ia6a727ae5b224c152d2615a32f1b91aaeeb2eb60
Issue-ID: APPC-836
Signed-off-by: John McClung <jm1364@att.com>
Mei Su [Fri, 6 Apr 2018 21:08:06 +0000 (17:08 -0400)]
Add junit coverage to TimedOutException class
Introduce junit-tests for TimedOutException class
Issue-ID: APPC-834
Change-Id: If4ba78735064106391d9354b0a7036bd8dd060e6
Signed-off-by: Mei Su <ms6523@att.com>
vidhyasree [Fri, 6 Apr 2018 19:29:27 +0000 (15:29 -0400)]
code fix to resolve duplct data in prop file
Code changes to Dbservice.java in artifact-handler
Issue-ID: APPC-821
Change-Id: I805a16e90866e946ca2e8d331b2c63b3ef209f71
Signed-off-by: vidhyasree <sn141y@att.com>
vidhyasree [Wed, 4 Apr 2018 20:54:27 +0000 (16:54 -0400)]
Dg changes to fix methodnotfound exception
APPC_chef.json is updated with vnfc instead of Vnfc
to allow the method callouts and to sinkup with
the method names in chefAdapterImpl.java
Issue-ID: APPC-829
Change-Id: I04bd9c720869117962c4dbe731abb22945fc03ee
Signed-off-by: vidhyasree <sn141y@att.com>
Michal Kabaj [Fri, 6 Apr 2018 14:14:56 +0000 (16:14 +0200)]
ChefAdapterImpl junits
-Add new JUnits to ChefAdapterImplVNFCOperationsTest
Change-Id: Idd4cd456d6409a499e569c7175d97642fc3607d2
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Sam Ollo [Thu, 5 Apr 2018 19:12:53 +0000 (15:12 -0400)]
Add junit coverage to XmlUtil class
Add junit-tests for XmlUtil class
Change-Id: I8711f7c0acd8888cbcd869732a7000fdbb168b0e
Issue-ID: APPC-832
Signed-off-by: Sam Ollo <so1938@att.com>
Ryan Young [Wed, 4 Apr 2018 22:26:52 +0000 (18:26 -0400)]
Revert logback.version to 1.1.1
Change-Id: I37ec9d2bd568c27df6887c2df275d6007726b64b
Signed-off-by: Ryan Young <ry303t@att.com>
Issue-ID: APPC-830
kurczews [Wed, 4 Apr 2018 11:35:41 +0000 (13:35 +0200)]
Unit test for ProviderOperationFactory
Change-Id: I239784f5acc6647e1ed4f2962de4504901b62108
Issue-ID: APPC-828
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Balaji, Ramya (rb111y) [Wed, 4 Apr 2018 02:30:22 +0000 (22:30 -0400)]
Restoring to previous known working version
Discovered muliple issues in the refactored code in these files
that has caused failure in existing flow and blocks regression
and new feature testing.Reverted class files and UT case files.
Issue-ID: APPC-827
Change-Id: I2bdd7f54ab919d0e16c79820ebe0ee4e13dbba03
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Irwin Dunietz [Tue, 3 Apr 2018 22:18:58 +0000 (18:18 -0400)]
Fix junit-test robustness for RequestContext class
Alter a junit test for a RequestContext class to succeed more reliably
Change-Id: I93f3ffdb846aca1daaa690e4c6b4a822c514a88b
Issue-ID: APPC-826
Signed-off-by: Irwin Dunietz <id1681@att.com>
Mei Su [Tue, 3 Apr 2018 20:31:10 +0000 (16:31 -0400)]
Add junit tests RequestFailedExceptionTest class
Add junit-tests RequestFailedExceptionTest class
Issue-ID: APPC-825
Change-Id: I54b46f6e3025f89bbd52017248c408641095fe46
Signed-off-by: Mei Su <ms6523@att.com>
Irwin Dunietz [Tue, 3 Apr 2018 17:02:14 +0000 (13:02 -0400)]
Add junit coverage for 2 RequestContext classes
Introduce junit-tests for 2 similar RequestContext classes
Change-Id: If8a80e983c24214eccd16f8ad7432e98de61d528
Issue-ID: APPC-824
Signed-off-by: Irwin Dunietz <id1681@att.com>
Arnel Pajarillo [Mon, 2 Apr 2018 12:59:46 +0000 (08:59 -0400)]
Add junit for more APPC client-lib classes
Test coverage for CoreRegisty, TaskQueue, TaskQueueManager classes in client-lib.
Change-Id: Id601c4736b51ea256de392fb8fcd91c3a49a55cc
Issue-ID: APPC-819
Signed-off-by: Arnel Pajarillo <ap1541@att.com>
Dilip kumar Pampana [Fri, 30 Mar 2018 20:34:33 +0000 (16:34 -0400)]
Changes made to Inbound/Design-Services
Error Displayed in CDT while saving the artifacts to APPC DB using SAVE ALL TO APPC though the artifacts are saved in DB
Issue-ID: APPC-817
Change-Id: I748dd099b3df2ace95b9930aec2fcf1de3f6d148
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
kurczews [Fri, 30 Mar 2018 07:53:02 +0000 (09:53 +0200)]
Added tests for appc.flow.Response
Issue-ID: APPC-442
Change-Id: Ie42cf7a2ec83ceeed94f567874cf4a634e6bb8c9
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Arnel Pajarillo [Sat, 31 Mar 2018 15:12:28 +0000 (11:12 -0400)]
Add junit coverage to TimerServiceImpl class.
Introduce junit test for client-lib's TimerService.java.
Change-Id: I3f8947cd526dc6a62ddcd2ced189565a401c6353
Issue-ID: APPC-815
Signed-off-by: Arnel Pajarillo <ap1541@att.com>
Balaji, Ramya (rb111y) [Mon, 2 Apr 2018 23:51:17 +0000 (19:51 -0400)]
Corrections to DGs for ConfigScaleOut
Issue-ID: APPC-822
Change-Id: I2a0e9efbc67890ad5792ed10295dd76b4e2bd253
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Modaboina, Kusumakumari (km583p) [Mon, 2 Apr 2018 21:25:57 +0000 (17:25 -0400)]
modifying improper conditions to update properties
Change-Id: I51b2c7755ffe5841fe3f87439ccb35b1e37765fa
Issue-ID: APPC-821
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
kurczews [Fri, 30 Mar 2018 09:19:55 +0000 (11:19 +0200)]
Added tests for appc.flow.Transaction
Change-Id: Ia28c21c0d93229ddd71c2c48f756cd325136e59d
Issue-ID: APPC-442
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
kurczews [Fri, 30 Mar 2018 08:03:59 +0000 (10:03 +0200)]
Added tests for appc.flow.ResponseAction
Change-Id: I9f4d39c609ff2069edb1634a13b10e96f08bfd7b
Issue-ID: APPC-442
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
kurczews [Fri, 30 Mar 2018 09:31:03 +0000 (11:31 +0200)]
Added tests for appc.flow.Transactions
Change-Id: I00a683484f8a6e8a97e661a421382dafeb0e8237
Issue-ID: APPC-442
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
amshegokar [Mon, 2 Apr 2018 11:52:37 +0000 (17:22 +0530)]
Unit test for RequestFailedException.java
Unit test for RequestFailedException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-rest-healthcheck-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2FrestHealthcheck%2Fimpl%2FRequestFailedException.java
Change-Id: I7626b968a757d2dd6c99500fbae7a6150a7a613e
Issue-ID: APPC-818
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
John McClung [Mon, 2 Apr 2018 19:30:49 +0000 (15:30 -0400)]
Add junit coverage to UnmodifiableProperties class
Introduce junit-tests for UnmodifiableProperties class
Change-Id: I51f44c676a0cd8fef808ca2e33fea8afc7e52453
Issue-ID: APPC-820
Signed-off-by: John McClung <jm1364@att.com>
George, Lina (lg941u) [Fri, 30 Mar 2018 16:16:21 +0000 (12:16 -0400)]
Changes to get properties from southbound propfile
Issue-ID: APPC-816
Change-Id: If08eb895526ba3998faf059be9b9c595b0f82b4d
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
shubhada [Thu, 29 Mar 2018 09:22:54 +0000 (14:52 +0530)]
Unit Test Coverage
Unit Test for TransactionRecorderServiceNotFoundException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-workflow-management-core%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fworkflow%2Factivator%2FTransactionRecorderServiceNotFoundException.java
Change-Id: I3568cbd8260a061d81c910622866c04cacb6424e
Issue-ID: APPC-811
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Patrick Brady [Thu, 29 Mar 2018 05:16:17 +0000 (22:16 -0700)]
Change sdc client version
Change-Id: Ica83120cde1cfc82b8f0c4d533a42e75acebd35d
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-13
amshegokar [Thu, 29 Mar 2018 07:57:29 +0000 (13:27 +0530)]
Coverage for DmaapOutgoingMessage.java
Coverage for DmaapOutgoingMessage.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-oam-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Foam%2Fmessageadapter%2FDmaapOutgoingMessage.java
Change-Id: Id7a7d8d76ad4bfce2e79ab9b62f39113dc4a8acb
Issue-ID: APPC-797
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Shailendra Borale [Thu, 29 Mar 2018 02:33:37 +0000 (22:33 -0400)]
Add junit coverage to Time class
Introduce junit-tests for Time class, corrected license
Change-Id: If5c3771325d4945f6f1135cfb4df8e923d0a0663
Issue-ID: APPC-809
Signed-off-by: Shailendra Borale <sb8915@att.com>
shubhada [Thu, 29 Mar 2018 08:59:51 +0000 (14:29 +0530)]
Unit test for RequestFailedException.java
Unit test for RequestFailedException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-rest-healthcheck-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2FrestHealthcheck%2Fimpl%2FRequestFailedException.java
Change-Id: Ife89776181fe803d4d02feb7909bc450b6b0e9ed
Issue-ID: APPC-810
Signed-off-by: shubhada <SV00449682@techmahindra.com>
amshegokar [Thu, 29 Mar 2018 06:58:41 +0000 (12:28 +0530)]
Unit test for SdcArtifactHandlerConstants.java
Unit test for SdcArtifactHandlerConstants.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-artifact-handler-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fartifact%2Fhandler%2Futils%2FSdcArtifactHandlerConstants.java
Change-Id: I21e97b7afcd58196ea064be4c4e8e9dc38cf487b
Issue-ID: APPC-793
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Shailendra Borale [Wed, 28 Mar 2018 19:53:42 +0000 (15:53 -0400)]
Add junit coverage to dg-common
Introduced junit-tests for dg-common
Removed tabs and extra spaces
Added the input.json file, renamed files
Change-Id: I89b6ddd70cc83f2eeb1a094977ffbe38463be6c0
Issue-ID: APPC-808
Signed-off-by: Shailendra Borale <sb8915@att.com>
YOUNG [Wed, 28 Mar 2018 21:31:18 +0000 (17:31 -0400)]
Add org.w3c.* to import-package
Adding org.w3c.* to import package to resolve exception caused by
org.w3c.dom.Node not found
Change-Id: If130d4310e67759c9257c7ced6f14a258376233d
Issue-ID: APPC-431
Signed-off-by: Ryan Young <ry303t@att.com>
George, Lina (lg941u) [Wed, 28 Mar 2018 18:51:22 +0000 (14:51 -0400)]
Fix healthcheck rest and ansible to set the paylod
Issue-ID: APPC-805
Change-Id: I0c4a8181149a8326d88bec7a4bc45f5323b9e5cd
Signed-off-by: George, Lina (lg941u) <lg941u@att.com>
Skip Wonnell [Wed, 28 Mar 2018 21:08:52 +0000 (16:08 -0500)]
Fix package name for RestConfCallNode
Issue-ID: APPC-800
Change-Id: Ic45cbcd25971b437a634204949a9825902b8c82c
Signed-off-by: Skip Wonnell <skip@att.com>
Dan McMillan [Wed, 28 Mar 2018 19:34:16 +0000 (19:34 +0000)]
Add junit coverage to LoggingUtils class
Introduce junit-tests for LoggingUtils class
Change-Id: Ieb4a14fb258abbef77e9b67398851317e3f08098
Issue-ID: APPC-802
Signed-off-by: Dan McMillan <dm3821@att.com>
Neha Sood [Wed, 28 Mar 2018 19:36:02 +0000 (15:36 -0400)]
Add junit coverage for three classes
Issue-ID: APPC-806
Change-Id: I5dc4da5fcd2325c6915b86a7f1c26d3a0f69cf9b
Signed-off-by: Neha Sood <ns189k@att.com>
amshegokar [Wed, 28 Mar 2018 07:43:41 +0000 (13:13 +0530)]
Restore removed license text lines
Restored below license text:
* Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
* Copyright (C) 2017 Amdocs
Change-Id: If79dbea73111552773092fda8dcd62d9569c70e3
Issue-ID: APPC-801
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Tue, 27 Mar 2018 07:36:21 +0000 (13:06 +0530)]
Test Coverage for Constants.java
Test Coverage for Constants.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-license-manager-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Flicmgr%2FConstants.java
Change-Id: I8da7e415fa724993e974b1d8af6061241cb67ce1
Issue-ID: APPC-796
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Dilip kumar Pampana [Tue, 27 Mar 2018 15:53:00 +0000 (11:53 -0400)]
Fix for config not able to save in DB
Did changes in DG's for getRunningConfig not able to save in Db
Issue-ID: APPC-800
Change-Id: I67722f6eafe045b63edf1922430b425c4f6ee755
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
amshegokar [Tue, 27 Mar 2018 07:04:46 +0000 (12:34 +0530)]
Test Coverage for MessageService.java
Test Coverage for MessageService.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-factory%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Ffactory%2FMessageService.java
Change-Id: I3a7314dd1e4a35baa4430b5e90afa979014f95c4
Issue-ID: APPC-795
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Dilip kumar Pampana [Tue, 27 Mar 2018 15:28:25 +0000 (11:28 -0400)]
Fix for EELF Logging in appc Common
VM-level Start succeeds in starting the VM, but there are EELF Logging Errors
Issue-ID: APPC-799
Change-Id: I67d76466a2ca6ff79cf1e6514b592a3877c59b92
Signed-off-by: Dilip kumar Pampana <dp583p@att.com>
amshegokar [Tue, 27 Mar 2018 04:52:00 +0000 (10:22 +0530)]
Unit Test Coverage for ExecutorException.java
Unit Test Coverage for ExecutorException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-interfaces-service-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Finterfaces%2Fservice%2Fexecutor%2FExecutorException.java
Change-Id: Id40401081af528248c20acc48b0bdbc60f480663
Issue-ID: APPC-790
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 26 Mar 2018 11:34:40 +0000 (17:04 +0530)]
Unit test coverage for DBException.java
Unit test coverage for DBException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-artifact-handler-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fartifact%2Fhandler%2Fdbservices%2FDBException.java
Change-Id: Iae0c5a90358f61560c8e164fa506a0e3e75857f5
Issue-ID: APPC-791
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 26 Mar 2018 11:27:05 +0000 (16:57 +0530)]
Coverage for ArtifactHandlerInternalException
Unit test for ArtifactHandlerInternalException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-artifact-handler-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fartifact%2Fhandler%2Fnode%2FArtifactHandlerInternalException.java
Change-Id: I887613bc793256be84e288ca432d11c45d320cfc
Issue-ID: APPC-792
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 26 Mar 2018 11:14:52 +0000 (16:44 +0530)]
Coverage for ResourceNodeInternalException.java
Unit test coverage for ResourceNodeInternalException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-aai-client-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Faai%2Fclient%2Fnode%2FResourceNodeInternalException.java
Change-Id: Ic037a2490ac00d1d5e7334b483039352e9da4aa2
Issue-ID: APPC-788
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 26 Mar 2018 11:02:30 +0000 (16:32 +0530)]
Unit test coverage for ServiceConstants.java
Unit test coverage for ServiceConstants.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-interfaces-service-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Finterfaces%2Fservice%2Futils%2FServiceConstants.java
Change-Id: I1ad3aea2018e82436fed97d97d72904477b74b28
Issue-ID: APPC-789
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Mon, 26 Mar 2018 09:22:13 +0000 (14:52 +0530)]
Test Coverage
Unit tests for:
1. AaiServiceInternalException.java
2. MissingParameterException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-aai-client-provider%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Faai%2Fclient%2Faai
Change-Id: Ib107309b8b9f3e17f0467801f300a0a0aa0af8ac
Issue-ID: APPC-787
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Michal Kabaj [Mon, 26 Mar 2018 14:37:03 +0000 (16:37 +0200)]
ChefAdapterImpl junits
-Add new JUnits to ChefAdapterImplVNFCOperationsTest
-remove unused JSONException catch clause from ChefAdapterImpl,
when there is no jackson lib used
Change-Id: I96b8d6155ca13087b697a19e1fcbba2ee82a8291
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
amshegokar [Mon, 26 Mar 2018 08:26:40 +0000 (13:56 +0530)]
Unit test coverage
Unit test coverage for:
1. Vnfc.java
2. SDCReference.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-sdc-listener-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsdc%2Fartifacts%2Fobject
Change-Id: I34c15904bc0df7c537ad448b748add847ab863bd
Issue-ID: APPC-786
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Fri, 23 Mar 2018 13:46:27 +0000 (19:16 +0530)]
Coverage for:org/onap/appc/dao/util/exception
Unit Tests for:
1) DataAccessException.java
2)DBConnectionPoolException.java
3) JdbcRuntimeException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc-netconf-adapter-bundle&selected=org.onap.appc%3Aappc-data-access-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdao%2Futil%2Fexception
Change-Id: Ie5c44417ca33c73de5577052a01ca5f019adeb1b
Issue-ID: APPC-781
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Fri, 23 Mar 2018 13:37:03 +0000 (19:07 +0530)]
Unit test for Messages.java
Unit test for Messages.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc-netconf-adapter-bundle&selected=org.onap.appc%3Aappc-data-access-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdao%2Futil%2Fmessage
Change-Id: I2204f296d3d2200eb4aa4f809e0c0dd841b0b93e
Issue-ID: APPC-782
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Fri, 23 Mar 2018 13:28:36 +0000 (18:58 +0530)]
Coverage test
Unit Test Coverage for:
1) NetconfConnectionDetails.java
2) NetconfClientType.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-netconf-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fnetconf
Change-Id: I161d7bfe5e780c7c686ae014d87208e3da36b3cd
Issue-ID: APPC-780
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
amshegokar [Fri, 23 Mar 2018 13:18:53 +0000 (18:48 +0530)]
Test Coverage
Unit test for:org/onap/appc/adapter/netconf/exception classes
1. DataAccessException.java
2. NetconfDAOException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-netconf-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fnetconf%2Fexception
Change-Id: I9b02c0ddc01b4327135ccc754a6466105b1e18ff
Issue-ID: APPC-779
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Lori Keighron [Mon, 26 Mar 2018 15:15:33 +0000 (11:15 -0400)]
Add junit coverage to EncryptionTool class
Introduce junit coverage in design-services class
Issue-ID: APPC-794
Change-Id: Idbf8d02511b478173950a97c10a642486bc0d45f
Signed-off-by: Lori Keighron <lk2924@att.com>
amshegokar [Mon, 26 Mar 2018 12:52:33 +0000 (18:22 +0530)]
Unit test for ProviderResponse.java
Unit test for ProviderResponse.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-sdc-listener-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsdc%2Flistener%2FProviderResponse.java
Change-Id: I85984489a404e3980d962007a677f2a0c016a50d
Issue-ID: APPC-785
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Taka Cho [Fri, 23 Mar 2018 19:57:59 +0000 (15:57 -0400)]
fix eelf and logback nexus iq issue
Change-Id: Id42f77fc86cbbfff28bfde404181938d358515b9
Issue-ID: APPC-784
Signed-off-by: Taka Cho <tc012c@att.com>
Scott Seabolt [Sat, 24 Mar 2018 03:38:20 +0000 (23:38 -0400)]
Updated APPC Client Library Guide
Issue-ID: APPC-374
Change-Id: I7184c91ccb5fa87dd9ba7a22c0de960e7ba28698
Signed-off-by: Scott Seabolt <js9808@att.com>
Shailendra Borale [Fri, 23 Mar 2018 17:53:50 +0000 (13:53 -0400)]
Add junit coverage to Appc-Domain-model
Introduce junit-tests for Vnf, Vnfc classses
Replaced tabs with spaces.
Change-Id: I45baf5aa20391b375fae667ff7fdeed8cfd845b8
Issue-ID: APPC-783
Signed-off-by: Shailendra Borale <sb8915@att.com>
Michal Kabaj [Mon, 19 Mar 2018 08:25:59 +0000 (09:25 +0100)]
ChefAdapterImpl cleanup
- Switched usage of RequestContext class for wrapping the SvcLogicContext
to using the SvcLogicContext directly
- Removed unused RequestContext class
Change-Id: I7376e3d6f5602887cf5a25f1f90ff45805c620b2
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
amshegokar [Fri, 23 Mar 2018 13:07:01 +0000 (18:37 +0530)]
Unit test coverage
Unit test coverage for Constants.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-iaas-adapter-bundle%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Futils%2FConstants.java
Change-Id: Ied122a1838111897079243f0e444a9eef1b2f162
Issue-ID: APPC-778
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
Neha Sood [Fri, 23 Mar 2018 14:19:28 +0000 (10:19 -0400)]
Add Junit coverage for ActionIdentifier class
Introduce junit tests for ActionIdentifier class
Change-Id: If14abe7b165d310d693d0d3ea04b563c0b68edd4
Issue-ID: APPC-777
Signed-off-by: Neha Sood <ns189k@att.com>
Michal Kabaj [Fri, 23 Mar 2018 13:43:41 +0000 (14:43 +0100)]
ChefAdapterImpl junits
Add new JUnits to ChefAdapterImplVNFCOperationsTest
Change-Id: I243b2f46fdb75ad3c689b7875361fb9a654eaf60
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Sonali Das [Thu, 22 Mar 2018 17:53:07 +0000 (13:53 -0400)]
Change in DG for the Audit and the Sync
Issue-ID: APPC-735
Change-Id: I4e07b07d476b1353388e51ce3b41d245b99c4bb7
Signed-off-by: Sonali Das <sd394g@att.com>
kurczews [Mon, 5 Mar 2018 14:39:47 +0000 (15:39 +0100)]
Split sequence generation to classess
* Delegate original logic to separate clasess
* Introduce InputParamsCollector
* Introduce CapabilitiesDataExtractor
* Add coverage for changes
Change-Id: Ibb35dfb67306f789950c3b77362c5d79a3b6da63
Issue-ID: APPC-440
Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
Balaji, Ramya (rb111y) [Thu, 22 Mar 2018 18:33:24 +0000 (14:33 -0400)]
Corrected condition to pick region
Fixed condition so that region
can be determined correctly
Issue-ID: APPC-776
Change-Id: Iaf57a4face50d99a56cd4b85c0a318d34632a1e8
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
Jakub Dudycz [Thu, 22 Mar 2018 13:54:38 +0000 (14:54 +0100)]
EventHandlerImpl unit tests
Improved code coverage.
Change-Id: Iee626e206b1fc2ef1047fc4d50b030319afe0403
Issue-ID: APPC-753
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Michal Kabaj [Wed, 21 Mar 2018 12:26:51 +0000 (13:26 +0100)]
ChefAdapterImpl junits
- Added new Junit class ChefAdapterImplVNFCOperationsTest
- Added unit tests for method vnfcEnvironment
- Small refactor to for exception handling in vnfcEnvironment method to
improve readability and avoid catching and rethrowing same exception
Change-Id: I58a43390ff45598f6d17da48eed3620667008cb7
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
Modaboina, Kusumakumari (km583p) [Tue, 20 Mar 2018 17:17:00 +0000 (13:17 -0400)]
Bugfixes for error handling while attaching volume
Change-Id: I103709186eff4fc9e42038b2e1113b010b822528
Issue-ID: APPC-761
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
Jakub Dudycz [Mon, 19 Mar 2018 09:25:59 +0000 (10:25 +0100)]
LCM package test classes refactor
Extracted some methods and fields to util class
Change-Id: If2f1f617b53ebfb0cad8e350447aff2177784319
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Taka Cho [Wed, 21 Mar 2018 18:09:41 +0000 (14:09 -0400)]
missing a $ in appc-directed-graph pom
Change-Id: I51eaa20c5db47c50e7cc8ffc9f53d7f01bc54c33
Issue-ID: APPC-774
Signed-off-by: Taka Cho <tc012c@att.com>
Lori Keighron [Wed, 21 Mar 2018 18:37:21 +0000 (14:37 -0400)]
Add junit coverage to request handler exceptions
Introduce 7 more junit-test files:
DGWorkflowNotFoundExceptionTest.java
LCMOperationsDisabledExceptionTest.java
MultipleRecordsRetrievedExceptionTest.java
NoRecordsRetrievedExceptionTest.java
RequestValidationExceptionTest.java
VNFNotFoundExceptionTest.java
WorkflowNotFoundExceptionTest.java
Issue-ID: APPC-773
Change-Id: I2e962a9614e3b17d77d2685e1055322531d832a1
Signed-off-by: Lori Keighron <lk2924@att.com>
Jakub Dudycz [Mon, 19 Mar 2018 09:05:43 +0000 (10:05 +0100)]
GenericProviderOperationsRequestFormatter junits
Improved code coverage.
Change-Id: I8914eae1327c15339034aa0d6905b36d7a252171
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Mon, 19 Mar 2018 08:12:01 +0000 (09:12 +0100)]
ProviderOperations unit tests
Improved code coverage.
Change-Id: I04d0afe9799cc9bce5111173031ba8f9baa3e409
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Modaboina, Kusumakumari (km583p) [Tue, 20 Mar 2018 02:09:28 +0000 (22:09 -0400)]
bugfix for error handling while detaching volumes
Change-Id: I96f7d017a63b0741d87666f4608356567932ff77
Issue-ID: APPC-762
Signed-off-by: Modaboina, Kusumakumari (km583p) <km583p@us.att.com>
shubhada [Wed, 21 Mar 2018 12:25:03 +0000 (17:55 +0530)]
Unit test for YANGGenerationException.java
Unit test for YANGGenerationException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-yang-generator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fyang%2Fexception%2FYANGGenerationException.java
Change-Id: Ic23b9d863da6981090feeaad79cd1afa895b8e24
Issue-ID: APPC-772
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Wed, 21 Mar 2018 11:11:07 +0000 (16:41 +0530)]
Unit Test Coverage
Unit Test Coverage for:
1.RequestHandlerInput.java
2.RequestHandlerOutput.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-request-handler-api
Change-Id: I07e6be04fbe4958cd98cb0313e672e2a0098856e
Issue-ID: APPC-771
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Wed, 21 Mar 2018 10:29:56 +0000 (15:59 +0530)]
Unit Test Coverage
Unit Tests for:
1. Constants.java
2. DataReaderException.java
3. DgResolverException.java
4. FlowKey.java
5. VnfExecutionInternalException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-common%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fcommon%2Fimpl
Change-Id: Ib3839ce2eb44b6f2e8b530696f4e4354e61df3d4
Issue-ID: APPC-756
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Wed, 21 Mar 2018 06:10:30 +0000 (11:40 +0530)]
Unit Test Coverage
Unit test Coverage for:
1. AppcClientBusinessException.java
2. AppcClientInternalException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-kit%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fclient%2Flcm%2Fexceptions
Change-Id: Ib06721b86b985400f521811ddd5c4f3278ee69c3
Issue-ID: APPC-768
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Lori Keighron [Tue, 20 Mar 2018 21:03:35 +0000 (17:03 -0400)]
Add junits to request-handler-exception classes
Introduce junit-tests for 3 request-handler-excetion classses
Issue-ID: APPC-769
Change-Id: I49f45ba50adccbfcc9725a7e458054e19f0c5efd
Signed-off-by: Lori Keighron <lk2924@att.com>
Patrick Brady [Tue, 20 Mar 2018 05:59:26 +0000 (22:59 -0700)]
Re-add public declaration
The public declaration of setDbLibService was removed as part of this
(https://gerrit.onap.org/r/#/c/35763/) commit. This caused a failure in
karaf and the appc-common bundle failed to come up. This commit re-adds
public.
Change-Id: Ia6fa5d950b17e4f440a1243d071c90eedc9be818
Signed-off-by: Patrick Brady <pb071s@att.com>
Issue-ID: APPC-731
Michal Kabaj [Fri, 16 Mar 2018 13:53:36 +0000 (14:53 +0100)]
ChefAdapterImpl Junits
- Added new Unit tests for ChefAdapterImpl checkPushJob method
to class ChefAdapterImplJobPusherTest
- Added param check in implementation method
- Small refactor of nested conditions for improved readability
Change-Id: Id65b897535874eea6aafda66b7ac227832446cf4
Issue-ID: APPC-437
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
shubhada [Tue, 20 Mar 2018 05:24:33 +0000 (10:54 +0530)]
Unit test for MessageDestination.java
Unit test for MessageDestination.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-message-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fmessage%2FMessageDestination.java
Change-Id: I17032a622571ce6ed6e6454967edabc2f2ef2d33
Issue-ID: APPC-764
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Tue, 20 Mar 2018 11:38:24 +0000 (17:08 +0530)]
Unit Test Coverage
Unit test coverage for InvalidRequestException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-simulator%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fsimulator%2Fclient%2Fimpl%2FInvalidRequestException.java
Change-Id: I282481303657a4ede2132d04ebe45ab9b18589d7
Issue-ID: APPC-765
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Tue, 20 Mar 2018 11:30:17 +0000 (17:00 +0530)]
Unit Test Coverage
Unit Test Coverage for AppcClientException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc.client%3Aclient-kit%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fclient%2Flcm%2Fexceptions%2FAppcClientException.java
Change-Id: I70eb5b92f6c15b8f67a5e179be58d6f4f2565c47
Issue-ID: APPC-767
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Lori Keighron [Mon, 19 Mar 2018 16:24:47 +0000 (12:24 -0400)]
Added junit coverage to CoreException class
Introduce junit-tests for CoreException class
Issue-ID: APPC-752
Change-Id: Ic5c8c2c83ce99d488e9e79a8fb72e7ad5fcf2ad3
Signed-off-by: Lori Keighron <lk2924@att.com>
Balaji, Ramya (rb111y) [Mon, 19 Mar 2018 16:50:52 +0000 (12:50 -0400)]
Code changes to fix Exception
Reverted changes to method name in Transaction.java
to getuId() as this caused incorrect attributes
to be added to the generated JSON. Added unit test
to ensure this works as expected in the future.
Issue-ID: APPC-760
Change-Id: I07adcda0b5f04bd00efc113b94c68f48af13ad78
Signed-off-by: Balaji, Ramya (rb111y) <rb111y@att.com>
amshegokar [Mon, 19 Mar 2018 09:47:53 +0000 (15:17 +0530)]
Unit Test Coverage
Unit Tests for APPC Dispatcher Common - Domain Model Lib classes Part:2
1.ActionLevel.java
2.RequestModes.java
3.RequestStatus.java
4.ExternalActionStatus.java
5.VNFOperation.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Adomain-model-lib%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdomainmodel%2Flcm
Change-Id: I8f870e43d6f847cd9800a6178e1020ba26f0e211
Issue-ID: APPC-749
Signed-off-by: amshegokar <AS00500801@techmahindra.com>
shubhada [Mon, 19 Mar 2018 12:52:39 +0000 (18:22 +0530)]
Unit tests for appc-ssh-adapter-api classes
Unit Tests for:
1. SshDataAccessException.java
2. SshException.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-ssh-adapter-api%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fadapter%2Fssh
Change-Id: I7c927a5319143e5df051d008f8f5dbb546699b99
Issue-ID: APPC-759
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 11:54:04 +0000 (17:24 +0530)]
Unit test for DependencyTypes.java
Unit test for DependencyTypes.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-dependency-model%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fobjects%2FDependencyTypes.java
Change-Id: I163105492a11a8f9e9657562812e829f17fc149e
Issue-ID: APPC-758
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 11:03:14 +0000 (16:33 +0530)]
Unit test for DependencyModelNotFound.java
Unit test for DependencyModelNotFound.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-dependency-model%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Fdependencymanager%2Fexception%2FDependencyModelNotFound.java
Change-Id: I17f2b9bb34ad161ea0c4b9eb902b0c0437970e37
Issue-ID: APPC-757
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 09:45:08 +0000 (15:15 +0530)]
Unit Test Coverage for Constants.java
Unit test coverage for Constants.java
Sonar Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fimpl%2FConstants.java
Change-Id: Ic44430e25c429f420c667e51c5d5eb7b6feb8fe5
Issue-ID: APPC-755
Signed-off-by: shubhada <SV00449682@techmahindra.com>
shubhada [Mon, 19 Mar 2018 08:00:42 +0000 (13:30 +0530)]
Unit test for:org/onap/appc/dg/aai/objects classes
Unit test Coverage for:
1.AAIQueryResult.java
2.Relationship.java
Sonar-Link:
https://sonar.onap.org/code?id=org.onap.appc%3Aappc&selected=org.onap.appc%3Aappc-dg-aai%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fappc%2Fdg%2Faai%2Fobjects
Change-Id: Ia4bb63454b5150e99cc38b12f867450da7ceae54
Issue-ID: APPC-754
Signed-off-by: shubhada <SV00449682@techmahindra.com>
Jakub Dudycz [Fri, 16 Mar 2018 16:06:29 +0000 (17:06 +0100)]
ResponseStatus unit tests
Improved code coverage.
Change-Id: I4f522d57b3e6e8d64d42c5e8b957db5a4a1bf07a
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 15:44:51 +0000 (16:44 +0100)]
InputBody and OutputBody unit tests
Improved code coverage.
Change-Id: I8b083f3281f0057d14cdfa9ae3c47eb3da99614e
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Jakub Dudycz [Fri, 16 Mar 2018 15:06:41 +0000 (16:06 +0100)]
DmaapMessage and its subclasses unit tests
Improved code coverage.
Change-Id: Iaa8496ce5c7aa5a8fc7ca203baf07ab8b7e55e5d
Issue-ID: APPC-745
Signed-off-by: Jakub Dudycz <jakub.dudycz@nokia.com>
Code Review / appc.git / log