liamfallon [Thu, 25 Nov 2021 10:30:36 +0000 (10:30 +0000)]
Release policy/models: 2.6.0
*** Release Phase 6: This commit is generated by a PF release script ***
This is the sixth phase in releasing images, it releases policy/models.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I6ef3c8df269cb1c315a12a0c0f7ed83c290341a0
liamfallon [Wed, 24 Nov 2021 16:27:59 +0000 (16:27 +0000)]
Update parent and common references
*** Release Phase 5: This commit is generated by a PF release script ***
This is the fifth release phase, it updates parent and common
references in policy/models.
Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ic935d5f85db641416461f8cbc0afb5651a65b42c
FrancescoFioraEst [Wed, 27 Oct 2021 09:18:32 +0000 (10:18 +0100)]
Fix Db connection issues in TOSCA control loop
Issue-ID: POLICY-3153
Change-Id: I28a7962027a9cb383238a6d3765a46a905f8e58b
Signed-off-by: FrancescoFioraEst <francesco.fiora@est.tech>
Ram Krishna Verma [Mon, 25 Oct 2021 22:05:09 +0000 (18:05 -0400)]
Point to snapshot dependency
Issue-ID: POLICY-3788
Change-Id: Ief434babe80980cbe97170011d168e94ee4045aa
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
adheli.tavares [Wed, 20 Oct 2021 08:00:26 +0000 (09:00 +0100)]
Fix for entrypoint to use sh instead of bash.
Issue-ID: POLICY-3767
Change-Id: I463ebdcb75e39b5ee7098c0cee178988fc360788
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
a.sreekumar [Fri, 15 Oct 2021 17:02:21 +0000 (18:02 +0100)]
Improve AAI simulator by configuring responses
Change-Id: Ide7f572dac91110a5d560fc388dd87246c9d195b
Issue-ID: POLICY-3709
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
liamfallon [Thu, 14 Oct 2021 11:00:54 +0000 (12:00 +0100)]
Bump policy/models to Jakarta 2.6.0-SNAPSHOT
Issue-ID: POLICY-3696
Change-Id: I66ec28e3a51a8f388b56ccbf211f71698cf5e8aa
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 13 Oct 2021 18:29:38 +0000 (19:29 +0100)]
Bump policy/models to 2.5.2-SNAPSHOT
Issue-ID: POLICY-3696
Change-Id: Idbdbbe56e5daac2ce8ce780d2c8ce5ff54b8e006
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 13 Oct 2021 14:17:45 +0000 (15:17 +0100)]
Release policy/models artifacts for version 2.5.1
Issue-ID: POLICY-3696
Change-Id: Iee534442d6132be4ae760f47f742927defd401dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 13 Oct 2021 10:38:36 +0000 (11:38 +0100)]
Point at released policy/common and docker images
Issue-ID: POLICY-3696
Change-Id: I438f998a2f93ab1f00509a56f918216b50787fb7
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Wed, 6 Oct 2021 17:45:12 +0000 (18:45 +0100)]
Support in_range TOSCA Constraint
The TOSCA in_range constraint is not supported, causing errors to be
thrown in TOSCA control loop constraint edits.
Issue-ID: POLICY-3695
Change-Id: I95dec4118ce8572c5b76d528878c6782856e0a53
Signed-off-by: liamfallon <liam.fallon@est.tech>
Ram Krishna Verma [Mon, 20 Sep 2021 14:35:19 +0000 (10:35 -0400)]
Revert ignoring tests in models
Reverting ignoring of tests in models
as the staging job has been marked to skip tests.
Issue-ID: POLICY-3587
Change-Id: Ia5946d3b9402ba7810815e73eb207ac5c57a6c74
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
liamfallon [Wed, 15 Sep 2021 09:03:32 +0000 (10:03 +0100)]
Bump policy-models to 2.5.1-SNAPSHOT
Issue-ID: POLICY-3587
Change-Id: Idca2237777c1f7bda3fab89934dc97b9360fbc3d
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Tue, 14 Sep 2021 09:50:17 +0000 (10:50 +0100)]
Release policy-models 2.5.0
Issue-ID: POLICY-3587
Change-Id: I7fab026ee4f58baf73f960aba0d35f77fbd41257
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Mon, 13 Sep 2021 16:12:23 +0000 (17:12 +0100)]
Work around test failure in staging job
The "keytool" program does not exist in the Jenkins staging job
environment, so the test case that checks for a keytool error message
fails because an unexpected error message is received.
Other tests also break so the tests are morked with @Ignore for now.
Issue-ID: POLICY-3587
Change-Id: Ic43e5043c769ff6d2cf604f2a0f29fd4f6931b4b
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Mon, 13 Sep 2021 14:20:26 +0000 (15:20 +0100)]
Use policy-common released version in policy-models
Issue-ID: POLICY-3587
Change-Id: I609d0657aa1991ed7d3c1022af2ade25a6905f8f
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 9 Sep 2021 11:16:07 +0000 (12:16 +0100)]
Point at released policy-parent
Issue-ID: POLICY-3587
Change-Id: I799b3f36d6d362ba82dd359feb57accd9a7b53ae
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Thu, 9 Sep 2021 13:35:10 +0000 (13:35 +0000)]
Merge "Update INFO.yaml"
liamfallon [Wed, 8 Sep 2021 11:20:57 +0000 (12:20 +0100)]
Update INFO.yaml
Update the INFO.yaml file with latest information.
Issue-ID: POLICY-3552
Change-Id: I95b9164e7a208ca38dca31f5e71c65bc30531b84
Signed-off-by: liamfallon <liam.fallon@est.tech>
saul.gill [Tue, 31 Aug 2021 08:33:32 +0000 (09:33 +0100)]
Add check for null for policies and policy types
Add check when reading policies and policy types from db
Issue-ID: POLICY-3606
Change-Id: I7a1d96e4be1841243619e89c31dabc3e761dd17a
Signed-off-by: saul.gill <saul.gill@est.tech>
Ram Krishna Verma [Mon, 30 Aug 2021 21:28:37 +0000 (17:28 -0400)]
Add topics end point to dmaap sim
Add "/topics" end point to dmaap simulator.
It will be used in CSIT tests to verify consolidated health check.
Issue-ID: POLICY-3605
Change-Id: I6814d6dd021e0d98bd99754d4e68f789ef405353
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Fri, 20 Aug 2021 20:39:17 +0000 (16:39 -0400)]
Fix sonars in models
Fixed:
- use "var"
- change constructor to protected
- add equals() to subclasses
Issue-ID: POLICY-3094
Change-Id: Ia62716b1a740b4475e54e496330f50aa7fb404d7
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 17 Aug 2021 19:25:39 +0000 (15:25 -0400)]
Add PDP-TOPIC-CHECK message
Added a new PdpMessage subclass that a PDP can use to verify its ability
to send/receive to/from the PDP-PAP topic before it sends its first
registration message.
Issue-ID: POLICY-3531
Change-Id: Ied61caa805e93e25732385bf91272b4fc248fd69
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Mon, 2 Aug 2021 18:37:35 +0000 (14:37 -0400)]
Upgrade to cds 1.1.5-SNAPSHOT
Upgrading policy components to cds 1.1.5-SNAPSHOT
to verify the contract and fixes coming up in the next released version.
Issue-ID: POLICY-3516
Change-Id: I93602c392a5f917e68a7a1a74eaf0f188f520c39
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ajith Sreekumar [Thu, 29 Jul 2021 08:19:12 +0000 (08:19 +0000)]
Merge "Add "configure" operation to xacml"
Jim Hahn [Wed, 28 Jul 2021 13:48:00 +0000 (09:48 -0400)]
Add junit test for empty statistics filter
Also removed the version field from the filter, as it is not applicable
to the PDP instance name.
Issue-ID: POLICY-3511
Change-Id: I17e8d2d6646a27736a827b9e9e17881d6b0a3795
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 26 Jul 2021 15:11:09 +0000 (11:11 -0400)]
Add "configure" operation to xacml
Added "configure" operation to xacml simulator and actor.xacml.
Issue-ID: POLICY-3502
Change-Id: Ia206303c65ce4e54187d818da9253dabfe864d62
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 26 Jul 2021 13:48:31 +0000 (09:48 -0400)]
Remove actor.guard from models
Replaced by actor.xacml.
Issue-ID: POLICY-3506
Change-Id: I41b6a9918df31b251eb93105fc9413deda04daf3
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 23 Jul 2021 19:14:12 +0000 (15:14 -0400)]
Remove unused statistics methods
The getPdpStatistics method should be removed as they're functionality
has been subsumed by getFilteredPdpStatistics.
Issue-ID: POLICY-3511
Change-Id: I98da98ac483705bea46ebaa0619257195be6b518
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 21 Jul 2021 21:30:32 +0000 (17:30 -0400)]
Limit the number of statistics records returned
Added limit of MAX records (100). Also, if unspecified, or negative,
it defaults to MAX records.
Issue-ID: POLICY-3511
Change-Id: I0170951cd79818af5944adf5d29480bad4de815b
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 21 Jul 2021 21:30:32 +0000 (17:30 -0400)]
Refactor GuardOperation
Extracted DecisionOperation superclass out of GuardOperation.
Issue-ID: POLICY-3502
Change-Id: Ice766e9c33756a5780726c75a0283f89c85cabad
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 20 Jul 2021 18:07:35 +0000 (14:07 -0400)]
Added Xacml actor
Cloned the guard actor to use as a starting point for creating a more
generic actor for interacting with the xacml-pdp.
Also renamed various classes.
Issue-ID: POLICY-3501
Change-Id: I9bd0107845de41a349d56259e6cfa6a3180efa25
Signed-off-by: Jim Hahn <jrh3@att.com>
k.kedron [Mon, 19 Jul 2021 16:05:52 +0000 (18:05 +0200)]
Upgrade CDS dependency
- New CDS client libraries.
- Update code to use new CDS BlueprintProcessingService
Change-Id: I00fb044908774a48755ff8d9ebb32e055a74c819
Issue-ID: POLICY-3507
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Dragosh, Pamela (pd1248) [Mon, 19 Jul 2021 15:10:22 +0000 (11:10 -0400)]
Add attributes to Decision Response
In order to support returning specific attributes, this field will
be needed.
Issue-ID: POLICY-2865
Change-Id: I9901e89abeb2fd375d6e218d4d39e736ff8829da
Signed-off-by: Dragosh, Pamela (pd1248) <pd1248@att.com>
Ram Krishna Verma [Tue, 13 Jul 2021 17:31:01 +0000 (17:31 +0000)]
Merge "Delete extra simulator docker images"
Dragosh, Pamela (pd1248) [Tue, 13 Jul 2021 14:31:52 +0000 (10:31 -0400)]
Update Pam's email INFO.yaml
Issue-ID: POLICY-3484
Change-Id: Ibbba0d4c981df0b27ac76aed97a64dab27871750
Signed-off-by: Dragosh, Pamela (pd1248) <pd1248@att.com>
Jim Hahn [Mon, 12 Jul 2021 19:25:53 +0000 (15:25 -0400)]
Delete extra simulator docker images
The policy-models-simulator docker image, built from
models-sim/packages, subsumes the functionality of the other simulator
images. Deleted the other images.
This simulator still needs some of the code from the dmaap-sim modules,
so only deleted the code from the latter that is not needed by this
simulator.
Also modified the simulator launch script to use sh instead of bash.
Issue-ID: POLICY-3474
Change-Id: Ie7f69b327a18c3e07f154124ae38975d5e6924f0
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Mon, 12 Jul 2021 20:11:51 +0000 (16:11 -0400)]
Add default min records for policy audit
Adding default min records as 10 for policy audit provider.
This is inline with our discussions and design doumented here
https://wiki.onap.org/display/DW/PAP+REST+API+changes+for+Istanbul+release
Issue-ID: POLICY-3340
Change-Id: I5bab5f186f2591b1a2f2c42e9851ad88f73c8dfb
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Mon, 12 Jul 2021 18:34:41 +0000 (18:34 +0000)]
Merge "Handle numRecords default setting when built as 0."
adheli.tavares [Fri, 9 Jul 2021 17:28:28 +0000 (18:28 +0100)]
Handle numRecords default setting when built as 0.
Check the numRecord to be set as DEFAULT_MAX_RECORDS when not added to
the auditFilter (builder set it to 0).
Issue-ID: POLICY-3340
Change-Id: I25ad83bbea71ddd82064aec3069ffa4cbce5aac1
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
Jim Hahn [Mon, 12 Jul 2021 14:04:40 +0000 (10:04 -0400)]
Remove unused DAO statistics methods
The PDP statistics provider had several filter methods, at least one
of which has now been subsumed by another and is no longer being used.
Issue-ID: POLICY-3405
Change-Id: If603eaf3df36fd4e6e3555376bf1b95144ec8eb1
Signed-off-by: Jim Hahn <jrh3@att.com>
adheli.tavares [Mon, 5 Jul 2021 13:59:40 +0000 (14:59 +0100)]
Update pdp statistics to count deploy/undeploy separately.
Issue-ID: POLICY-3383
Change-Id: I41e2668bdebd732149db0ccbe160b67b9952a8d9
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
liamfallon [Mon, 28 Jun 2021 08:33:18 +0000 (09:33 +0100)]
Update policy-models for checkstyle 8.43
Issue-ID: POLICY-3209
Change-Id: Ic45f889ab4d0ed24f6c1fc1aaece0601636e7a10
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Tue, 22 Jun 2021 16:01:37 +0000 (12:01 -0400)]
Add "source" to PAP-PDP messages
Added a "source" field to the PdpStateChange and PdpUpdate messages so
that PAP can record a unique name in the message, for logging purposes.
In a separate review, planning to add a method in policy-common for
creating the unique name. Once that has been created, it will be used
by PAP, to populate the "source" field, and all PDPs, to populate the
"name" field in the PdpStatus messages.
Issue-ID: POLICY-3409
Change-Id: I86c97702abe62a5672720330df50b7b106187661
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Tue, 22 Jun 2021 11:22:36 +0000 (11:22 +0000)]
Merge "Add example for pnf policy chaining"
Jim Hahn [Fri, 18 Jun 2021 20:03:04 +0000 (16:03 -0400)]
Add timestamp to Pdp records
To support the case where multiple PAPs are running, added a timestamp
to the PDP records so the PAPs can all be kept in sync as far as when a
PDP was last responsive.
Issue-ID: POLICY-2898
Change-Id: Ia7e0fd17363ff5827564cbc1537e516156b7f53a
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Mon, 21 Jun 2021 20:45:36 +0000 (16:45 -0400)]
Add example for pnf policy chaining
Adding example for policy chaining in drools-pdp for PNF.
This will be later referenced in the documents in upcoming review.
Issue-ID: POLICY-3382
Change-Id: Ifce5cf17e869566725a8e15fd391fb130c115e0f
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Mon, 21 Jun 2021 13:54:27 +0000 (09:54 -0400)]
Fix new checkstyle issues in models
The new version of checkstyle identified new issues. Fixed those.
Issue-ID: POLICY-3094
Change-Id: I85314bc0249cba0020a0aefbc250851a2b646dd9
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 21 Jun 2021 13:17:35 +0000 (13:17 +0000)]
Merge "Use lombok for errors pap, pdp, sim-dmaap, sim-pdp"
Jim Hahn [Thu, 17 Jun 2021 20:29:33 +0000 (16:29 -0400)]
Use lombok for errors pap, pdp, sim-dmaap, sim-pdp
Issue-ID: POLICY-3396
Change-Id: Ib2c9bc5dc199e15ae9ca077031c0f2cfbc5b6a81
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 17 Jun 2021 20:54:20 +0000 (16:54 -0400)]
Use lombok for events, base, dao
Issue-ID: POLICY-3396
Change-Id: I7b37efc13a25e0e27d63a85a3ee291e91a4e1682
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 18 Jun 2021 13:34:31 +0000 (13:34 +0000)]
Merge "Use lombok annotations for sdnr, simulators"
Jim Hahn [Fri, 18 Jun 2021 13:34:17 +0000 (13:34 +0000)]
Merge "Use lombok annotations for so, vfc"
Jim Hahn [Fri, 18 Jun 2021 13:34:04 +0000 (13:34 +0000)]
Merge "Use lombok annotations for aai, appc, appclcm, cds"
Jim Hahn [Fri, 18 Jun 2021 13:33:50 +0000 (13:33 +0000)]
Merge "Use lombok annotations for tosca, rest, sdnc"
Jim Hahn [Fri, 18 Jun 2021 13:33:33 +0000 (13:33 +0000)]
Merge "Use lombok annotations for actors"
Jim Hahn [Thu, 17 Jun 2021 22:04:53 +0000 (18:04 -0400)]
Use lombok annotations for actors
This is the last one for policy-models!
Issue-ID: POLICY-3396
Change-Id: I05b114a57a720a6ae8ae073b80c8bded36d0d06d
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 17 Jun 2021 21:35:26 +0000 (17:35 -0400)]
Use lombok annotations for aai, appc, appclcm, cds
Issue-ID: POLICY-3396
Change-Id: I81b6b0c7929809ffaeadadd6144e9b9f394bfdc8
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 17 Jun 2021 20:05:25 +0000 (16:05 -0400)]
Use lombok annotations for tosca, rest, sdnc
Issue-ID: POLICY-3396
Change-Id: I3c9e5ee7ea6da2bab4fe37504d39f7ce63868887
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 17 Jun 2021 19:39:34 +0000 (15:39 -0400)]
Use lombok annotations for sdnr, simulators
Issue-ID: POLICY-3396
Change-Id: I16787f72b0529417c58b9e83a21880baaba92a3d
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 17 Jun 2021 19:26:35 +0000 (15:26 -0400)]
Use lombok annotations for so, vfc
Issue-ID: POLICY-3396
Change-Id: I33781c72dd1c0b9a7a525c23e81c4259fa32384f
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Wed, 16 Jun 2021 22:04:16 +0000 (18:04 -0400)]
Add example for policy chaining
Adding example for policy chaining in drools-pdp.
This will be later referenced in the documents in upcoming review.
Issue-ID: POLICY-3382
Change-Id: If2189422cb7e9ac35fb93e0fd9ae44f1cd412686
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Tue, 15 Jun 2021 18:33:56 +0000 (14:33 -0400)]
Replace method parameters with filter parameters
Added more methods taking filter parameters instead of individual method
parameters. Removed the old methods.
Added genOrderClause().
Issue-ID: POLICY-3094
Change-Id: Ie9d8c13a8d4a7f81e284f07fce3d96a35918a114
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Fri, 11 Jun 2021 14:13:17 +0000 (10:13 -0400)]
Fix sonar in policy/models
use "var" for local variables
Issue-ID: POLICY-3077
Change-Id: Ia1ea62e03c016d336c9b11b07b0ea941ba905497
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Thu, 10 Jun 2021 21:38:58 +0000 (17:38 -0400)]
Fix sonars in policy-models
Fixed:
- too many parameters in method call
Fixed it by introducing PfFilterParameters. However, classes having the
Builder annotation are not easily subclassed, so introduced an
interface, too.
Issue-ID: POLICY-3094
Change-Id: Ida99522a542b1296b367c55b7e8f8e83783c2e4f
Signed-off-by: Jim Hahn <jrh3@att.com>
Liam Fallon [Thu, 3 Jun 2021 21:09:07 +0000 (21:09 +0000)]
Merge "Exposing the Audit provider through Models provider."
Jim Hahn [Tue, 1 Jun 2021 15:07:44 +0000 (11:07 -0400)]
Fix junits for new bean validation field names
Issue-ID: POLICY-3333
Change-Id: I339024677a2d090f61cc55d1b056b832c87d231a
Signed-off-by: Jim Hahn <jrh3@att.com>
adheli.tavares [Thu, 3 Jun 2021 09:37:35 +0000 (10:37 +0100)]
Exposing the Audit provider through Models provider.
Change-Id: I4a3a28b6dbbfbad533a69cf46c545ece7e0b147e
Issue-ID: POLICY-2899
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
Liam Fallon [Thu, 3 Jun 2021 10:42:50 +0000 (10:42 +0000)]
Merge "Upgrade CDS dependency"
Jim Hahn [Wed, 2 Jun 2021 14:35:48 +0000 (14:35 +0000)]
Merge "Handling Policy deploy/undeploy audit models"
Rashmi Pujar [Tue, 1 Jun 2021 21:35:56 +0000 (17:35 -0400)]
Upgrade CDS dependency
CDS client libraries are exposed by a different
maven module making is much more cleaner to use.
The only drawback is we need to go back to older
version of grpc-testing artifact due to conflicts.
Issue-ID: POLICY-3338
Signed-off-by: Rashmi Pujar <rashmi.pujar@bell.ca>
Change-Id: I98c79de7f12feefbae7c42c4c8f26357801b44f9
Ram Krishna Verma [Fri, 28 May 2021 18:36:58 +0000 (18:36 +0000)]
Merge "No-sonar on the wrong line"
Jim Hahn [Fri, 28 May 2021 18:33:22 +0000 (18:33 +0000)]
Merge "Remove policies field from PdpUpdate message"
Jim Hahn [Fri, 28 May 2021 14:59:36 +0000 (10:59 -0400)]
No-sonar on the wrong line
Tried putting NOSONAR comment at the end of the statement, because it
seems like checkstyle/sonar doesn't like comments in the middle of a
statement. Nonetheless, sonar still reports an issue on the line with
the "SELECT" statement, so I guess there's no choice but to move NOSONAR
to the end of that line.
Issue-ID: POLICY-3094
Change-Id: If26ad0b1e7dcc9c7aa963da10a9c5160a8fe272d
Signed-off-by: Jim Hahn <jrh3@att.com>
adheli.tavares [Tue, 11 May 2021 13:35:20 +0000 (14:35 +0100)]
Handling Policy deploy/undeploy audit models
Added a new Entity to store information when a Pdp Policy is deployed or
undeployed and its create/retrieve methods.
Change-Id: I35b3608c878bbfbbee0a99a124d100a48fe08131
Issue-ID: POLICY-2899
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
Jim Hahn [Thu, 27 May 2021 21:48:22 +0000 (17:48 -0400)]
Fix more sonars in models
Fixed sonars:
- SQL injection
- use re2j instead of regex
Issue-ID: POLICY-3094
Change-Id: I553bd6aa5832d71a5ac33320e2d0d022f9a00e98
Signed-off-by: Jim Hahn <jrh3@att.com>
waynedunican [Thu, 27 May 2021 08:12:05 +0000 (09:12 +0100)]
Remove policies field from PdpUpdate message
Issue-ID: POLICY-3323
Change-Id: I14dafe4a20f95e2ebe4279e5b6ae141e2ee4fc48
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Signed-off-by: WayneDunican <wayne.dunican@est.tech>
Jim Hahn [Mon, 24 May 2021 15:39:42 +0000 (11:39 -0400)]
Adjust indexes for Op History table
Reordered one index to put requestId first, as that should significantly
reduce the number of index entries to be examined.
Added endtime to another index, which should also reduce the number of
index entries to be examined for look-ups by time.
Issue-ID: POLICY-2874
Change-Id: I29c10fb9cabb22b3520ed1b14d7fe3fd9db40a15
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 12 May 2021 17:25:06 +0000 (13:25 -0400)]
Fix sonars in policy models
Fixed:
- a few other "var" cases
- use re2j instead of java.util.regex
- use correct class for constants
- remove unused constants
Issue-ID: POLICY-3094
Change-Id: Ifcb2b0623e8df0527f0a279e666d062422978ded
Signed-off-by: Jim Hahn <jrh3@att.com>
Liam Fallon [Tue, 11 May 2021 12:28:31 +0000 (12:28 +0000)]
Merge "Fix sonars in policy models"
Liam Fallon [Tue, 11 May 2021 12:28:17 +0000 (12:28 +0000)]
Merge "Fix sonars in policy-models impls & simulators"
Jim Hahn [Mon, 10 May 2021 15:39:27 +0000 (11:39 -0400)]
Fix sonars in policy models
Fixed:
- use "var"
Issue-ID: POLICY-3094
Change-Id: Id5ea7ab049c2018744afa75a55d44e47f216d5bc
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 10 May 2021 13:53:23 +0000 (09:53 -0400)]
Fix sonars in policy-models impls & simulators
Fixed:
- use "var"
Issue-ID: POLICY-3094
Change-Id: I65da54cae5a58966f21f981c6cea1259bfdf4239
Signed-off-by: Jim Hahn <jrh3@att.com>
simulators
Change-Id: I1144568485e62e0c72194caaf21ebf1ba88a6fef
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 7 May 2021 22:07:09 +0000 (18:07 -0400)]
Fix sonars in policy-models actors
Fixed:
- use "var"
- don't throw generic Exception
Issue-ID: POLICY-3094
Change-Id: I020addb9511fd665b5fed48e7d40719e27039224
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 3 May 2021 17:00:16 +0000 (17:00 +0000)]
Merge "Remove GroupValidationResult"
Jim Hahn [Mon, 26 Apr 2021 22:16:36 +0000 (18:16 -0400)]
Remove GroupValidationResult
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: I245e4a647fcbb718faa63a7543f9f81c85da958c
Signed-off-by: Jim Hahn <jrh3@att.com>
ktimoney [Tue, 27 Apr 2021 10:26:09 +0000 (11:26 +0100)]
Add correct filter type prefix to query
Added unit tests
Issue-ID: POLICY-3247
Change-Id: I27474948619b7256a1e504611531eecac15c27c1
Signed-off-by: ktimoney <kevin.timoney@est.tech>
Pamela Dragosh [Mon, 26 Apr 2021 12:55:35 +0000 (12:55 +0000)]
Merge "Add a new key class which uses @GeneratedValue to base classes"
ktimoney [Tue, 13 Apr 2021 13:40:06 +0000 (14:40 +0100)]
Add a new key class which uses @GeneratedValue to base classes
This will provide an alternative unique key.
It will be used in place of PfTimestampKey in the PdpStatistics table.
We make use of the @GeneratedValue annotation to provide this feature.
Added DummyGeneratedIdEntity and unit tests
Added PfFilterFactory class
Added new filter classes
Issue-ID: POLICY-3189
Change-Id: I097eab318d2cb958e1157e35825fd6d35d429a25
Signed-off-by: ktimoney <kevin.timoney@est.tech>
adheli.tavares [Thu, 15 Apr 2021 09:35:00 +0000 (10:35 +0100)]
Refactor CommandLineArguments classes
All CMD Args simulator classes to extend from CMD class on Common.
Fix all unit tests accordingly.
Issue-ID: POLICY-3129
Change-Id: If69e432679772df15b06ce7e316c7c876b69773d
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
Jim Hahn [Fri, 9 Apr 2021 13:49:48 +0000 (09:49 -0400)]
Close DB in junits
Modified some of the junits to close the DB.
In addition, one of the junits was apparently dependent on a previous
test method adding records to the DB, thus the test methods were
actually order dependent, even though no annotations were used to
enforce the order. Modified that method to insert the data, itself, so
the test methods are no longer order dependent.
Issue-ID: POLICY-3171
Change-Id: I778c12796340f2a665b4ba00588c823c925c078c
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 8 Apr 2021 21:26:18 +0000 (17:26 -0400)]
Use distinct names in DB junits
Junits for models often use the same memory DB name which may leave
garbage in the DB from one test to the next. Modified the code to use
distinct names for each XxxTest class.
Issue-ID: POLICY-3171
Change-Id: I2a4a0b4949d532d6949f5d39396288c54d03688b
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 26 Mar 2021 19:18:01 +0000 (19:18 +0000)]
Merge "Fix Sonar Issues models-tosca-simple"
lapentafd [Tue, 23 Mar 2021 17:46:41 +0000 (17:46 +0000)]
Fix Sonar Issues models-tosca-simple
Tests refactoring to reduce number of assertions
Issue-ID: POLICY-3094
Change-Id: I8a9a02100e5d103f574cf2cb89d2e924d0f56507
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Jim Hahn [Wed, 24 Mar 2021 12:41:04 +0000 (12:41 +0000)]
Merge "Fix sonar issues for tests in policy-models"
Ram Krishna Verma [Mon, 22 Mar 2021 21:45:40 +0000 (21:45 +0000)]
Merge "Delete keystores from models"
liamfallon [Fri, 19 Mar 2021 18:18:10 +0000 (18:18 +0000)]
Fix write failure on PDP statistics
Due to the precision of time stamps being saved to the nearest second,
a millisecond precision timestamp was being compared to a second
precision timestamp, causing the write to fail. This change fixes that.
A unit test is also added to test for this on the provider.
In addition, a USE-MARIADB flag is being introduced, which allows unit
tests to be run against a locally installed MariaDB instance so that the
unit tests can be verified against MariaDB locally rather than H2, the
default in Gerrit.
Issue-ID: POLICY-3146
Change-Id: I878f160956e89506743dc074679ee81ac1c48216
Signed-off-by: liamfallon <liam.fallon@est.tech>
Jim Hahn [Fri, 19 Mar 2021 17:08:02 +0000 (13:08 -0400)]
Delete keystores from models
The Keystores are no longer needed in the tarballs, as they are supplied
externally by the CSITs and Helm charts. Deleted those files.
Also modified the junits to use utils-test to generate keystores at
runtime, thus deleted the junit keystore file, too.
Issue-ID: POLICY-3143
Change-Id: Idd24b735a908476765d40bdcb5c741257edc7bb6
Signed-off-by: Jim Hahn <jrh3@att.com>
lapentafd [Thu, 18 Mar 2021 12:06:14 +0000 (12:06 +0000)]
Fix sonar issues for tests in policy-models
Tests refactoring to reduce number of assertions
Issue-ID: POLICY-3094
Change-Id: I445462f0ec5d49474b10c1940c7fa12e687636de
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
Pamela Dragosh [Thu, 18 Mar 2021 12:59:09 +0000 (12:59 +0000)]
Merge "Fix Sonar Issues in models-pdp"