The new version of checkstyle identified new issues. Fixed those.
Issue-ID: POLICY-3094
Change-Id: I85314bc0249cba0020a0aefbc250851a2b646dd9
Signed-off-by: Jim Hahn <jrh3@att.com>
* Check that a query returned one and only one entry and return that entry.
*
* @param someClass the class being searched for
- * @param conceptName the concept name being searched for
+ * @param searchFilter the search filter
* @param resultList the result list returned by the query
* @return the single unique result
*/
- private <T extends PfConcept> T getSingleResult(final Class<T> someClass, final String searchFilter, List<T> ret) {
- if (ret == null || ret.isEmpty()) {
+ private <T extends PfConcept> T getSingleResult(final Class<T> someClass, final String searchFilter,
+ List<T> resultList) {
+ if (resultList == null || resultList.isEmpty()) {
return null;
}
- if (ret.size() > 1) {
+ if (resultList.size() > 1) {
throw new IllegalArgumentException("More than one result was returned query on " + someClass
- + " with filter " + searchFilter + ": " + ret);
+ + " with filter " + searchFilter + ": " + resultList);
}
- return ret.get(0);
+ return resultList.get(0);
}
/**
*
* @param <T> the type of the object to get, a subclass of {@link PfConcept}
* @param someClass the class of the object to get, a subclass of {@link PfConcept}
- * @param t the object that was retrieved from the database
+ * @param objToCheck the object that was retrieved from the database
* @return the checked object or null
*/
private <T extends PfConcept> T checkAndReturn(final Class<T> someClass, final T objToCheck) {
* decoded into an object.
*
* @param source source from which to get the values
- * @param map where to place the decoded values
+ * @param request where to place the decoded values
*/
private void convertPayload(Map<String, Object> source, AppcLcmInput request) {
try {
/**
* Processes a response.
*
- * @param infra communication infrastructure on which the response was received
* @param outcome outcome to be populated
- * @param response raw response to process
+ * @param rawResponse raw response to process
* @param scoResponse response, as a {@link StandardCoderObject}
* @return the outcome, or {@code null} if still waiting for completion
*/
*
* @param outcome outcome to be populate
* @param url URL to which to request was sent
- * @param response raw response to process
+ * @param rawResponse raw response to process
* @return a future to cancel or await the outcome
*/
protected CompletableFuture<OperationOutcome> processResponse(OperationOutcome outcome, String url,
/**
* Starts the operation attempt, without doing any retries.
*
- * @param params operation parameters
* @param attempt attempt number, typically starting with 1
* @return a future that will return the result of a single operation attempt
*/
/**
* Initializes the configuration.
*
- * @param operator operator to be initialized
* @param clientName name of the client which it should use
*/
private void initConfig(String clientName) {
/**
* Initializes the configuration with a real client.
*
- * @param operator operator to be initialized
* @param clientName name of the client which it should use
*/
private void initConfig(String clientName, HttpClientFactory factory) {
/**
* Initializes the configuration with a real client.
*
- * @param operator operator to be initialized
* @param clientName name of the client which it should use
*/
private void initRealConfig(String clientName) {
* Filter PDP groups on PDP state.
*
* @param pdpGroup the PDP group to check
- * @param policyFilter the policy regular expressions to check for
+ * @param pdpState the PDP state of interest
* @return true if the filter should let this PDP group through
*/
private boolean filterOnPdpState(final PdpGroup pdpGroup, final PdpState pdpState) {
/**
* Convert JPA PDP group list to an authorative PDP group list.
*
- * @param foundPdpGroups the list to convert
+ * @param jpaPdpGroupList the list to convert
* @return the authorative list
*/
private List<PdpGroup> asPdpGroupList(List<JpaPdpGroup> jpaPdpGroupList) {
/**
* Validate that all data types referenced in policy types exist.
*
- * @param result the validation result object to use for the validation result
* @param result where the results are added
*/
private void validateReferencedDataTypes(final BeanValidationResult result) {
Code Review / policy / models.git / commitdiff