Add junit test for empty statistics filter

Also removed the version field from the filter, as it is not applicable
to the PDP instance name.

Issue-ID: POLICY-3511
Change-Id: I17e8d2d6646a27736a827b9e9e17881d6b0a3795
Signed-off-by: Jim Hahn <jrh3@att.com>

diff --git a/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpFilterParameters.java b/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpFilterParameters.java
index 775c154..991e823 100644 (file)
--- a/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpFilterParameters.java
+++ b/models-pdp/src/main/java/org/onap/policy/models/pdp/persistence/provider/PdpFilterParameters.java
@@ -30,8 +30,9 @@ import org.onap.policy.models.dao.PfFilterParametersIntfc;
 @Getter
 @Builder
 public class PdpFilterParameters implements PfFilterParametersIntfc {
+    // PDP instance ID
     private String name;
-    private String version;
+
     private Instant startTime;
     private Instant endTime;
 
@@ -63,4 +64,10 @@ public class PdpFilterParameters implements PfFilterParametersIntfc {
             return filterMap;
         }
     }
+
+    @Override
+    public String getVersion() {
+        // version is not used
+        return null;
+    }
 }

diff --git a/models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpStatisticsProviderTest.java b/models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpStatisticsProviderTest.java
index 57f3643..90b85b5 100644 (file)
--- a/models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpStatisticsProviderTest.java
+++ b/models-pdp/src/test/java/org/onap/policy/models/pdp/persistence/provider/PdpStatisticsProviderTest.java
@@ -195,6 +195,11 @@ public class PdpStatisticsProviderTest {
 
         List<PdpStatistics> getPdpStatisticsList;
 
+        // empty filter - should return everything
+        getPdpStatisticsList = new PdpStatisticsProvider().getFilteredPdpStatistics(pfDao, PdpFilterParameters
+                        .builder().build());
+        verifyEquals(getPdpStatisticsList, List.of(pdpStatistics11, pdpStatistics12, pdpStatistics22, pdpStatistics31));
+
         // match on name - returns multiple records
         getPdpStatisticsList = new PdpStatisticsProvider().getFilteredPdpStatistics(pfDao, PdpFilterParameters
                         .builder().name(NAME).group(GROUP).startTime(TIMESTAMP1).endTime(TIMESTAMP2).build());