[VVP] Resources not allowed in 2nd level templates
[vvp/validation-scripts.git] / ice_validator / tests / utils / nested_files.py
index 02f733d..e1918ad 100644 (file)
 # limitations under the License.
 #
 # ============LICENSE_END============================================
-#
-# ECOMP is a trademark and service mark of AT&T Intellectual Property.
-#
-
-"""nested files
-"""
 
-from os import path
+from functools import lru_cache
+from os import path, listdir
 import re
-import yaml
-
-VERSION = "1.0.2"
-
+from tests import cached_yaml as yaml
 
-def get_list_of_nested_files(yml, dirpath):
-    """
-    return a list of all nested files
-    """
+from tests.helpers import load_yaml
 
-    if not hasattr(yml, "items"):
-        return []
+MAX_DEPTH = 2
 
-    nested_files = []
 
-    for v in yml.values():
-        if isinstance(v, dict) and "type" in v:
-            t = v["type"]
-            if t.endswith(".yml") or t.endswith(".yaml"):
-                filepath = path.join(dirpath, t)
-                with open(filepath) as fh:
-                    t_yml = yaml.load(fh)
-                nested_files.append(filepath)
-                nested_files.extend(get_list_of_nested_files(t_yml, dirpath))
-            elif t == "OS::Heat::ResourceGroup":
-                rdt = v.get("properties", {}).get("resource_def", {}).get("type", None)
-                if rdt and (rdt.endswith(".yml") or rdt.endswith(".yaml")):
-                    filepath = path.join(dirpath, rdt)
-                    with open(filepath) as fh:
-                        rdt_yml = yaml.load(fh)
-                    nested_files.append(filepath)
-                    nested_files.extend(get_list_of_nested_files(rdt_yml, dirpath))
-        if isinstance(v, dict):
-            nested_files.extend(get_list_of_nested_files(v, dirpath))
-        elif isinstance(v, list):
-            for d in v:
-                nested_files.extend(get_list_of_nested_files(d, dirpath))
-    return nested_files
-
-
-def check_for_invalid_nesting(yml, yaml_file, dirpath):
+def check_for_invalid_nesting(  # pylint: disable=too-many-branches
+    yml, yaml_file, dirpath
+):
     """
     return a list of all nested files
     """
@@ -95,16 +59,14 @@ def check_for_invalid_nesting(yml, yaml_file, dirpath):
     for v in yml.values():
         if isinstance(v, dict) and "type" in v:
             t = v["type"]
-            if t.endswith(".yml") or t.endswith(".yaml"):
+            if t.lower().endswith(".yml") or t.lower().endswith(".yaml"):
                 filepath = path.join(dirpath, t)
             elif t == "OS::Heat::ResourceGroup":
                 rd = v["properties"]["resource_def"]
                 if not isinstance(rd, dict) or "type" not in rd:
                     invalid_nesting.append(yaml_file)
                     continue
-                elif not p.match(rd["type"]) and not (
-                    rd["type"].endswith(".yml") or rd["type"].endswith(".yaml")
-                ):
+                elif not p.match(rd["type"]):
                     filepath = path.join(dirpath, rd["type"])
                 else:
                     continue
@@ -123,3 +85,118 @@ def check_for_invalid_nesting(yml, yaml_file, dirpath):
             for d in v:
                 invalid_nesting.extend(check_for_invalid_nesting(d, yaml_file, dirpath))
     return invalid_nesting
+
+
+@lru_cache(maxsize=None)
+def get_list_of_nested_files(yml_path, dirpath):
+    """
+    return a list of all nested files
+    """
+
+    yml = load_yaml(yml_path)
+    nested_files = []
+    resources = yml.get("resources") or {}
+
+    for v in resources.values():
+        if isinstance(v, dict) and "type" in v:
+            t = v["type"]
+            if t.endswith(".yml") or t.endswith(".yaml"):
+                filepath = path.join(dirpath, t)
+                if path.exists(filepath):
+                    nested_files.append(filepath)
+                    nested_files.extend(get_list_of_nested_files(filepath, dirpath))
+            elif t == "OS::Heat::ResourceGroup":
+                rdt = v.get("properties", {}).get("resource_def", {}).get("type", None)
+                if rdt and (rdt.endswith(".yml") or rdt.endswith(".yaml")):
+                    filepath = path.join(dirpath, rdt)
+                    if path.exists(filepath):
+                        nested_files.append(filepath)
+                        nested_files.extend(get_list_of_nested_files(filepath, dirpath))
+    return nested_files
+
+
+def get_resourcegroup_nested_files(yml, dirpath):
+    """
+    return a dict.
+    key: key in yml which references a nested ResourceGroup file.
+        (resource->type is ResourceGroup
+            and resource->properties->resource_def->type is a yaml file)
+    value: the nested file name.
+
+    The keys are assumed to be unique across files.
+    A separate test checks for that.
+    """
+
+    if not hasattr(yml, "get"):
+        return {}
+
+    nested_files = {}
+    for rid, r in yml.get("resources", {}).items():
+        if isinstance(r, dict) and "type" in r:
+            t = r["type"]
+            nested_file = None
+            if t == "OS::Heat::ResourceGroup":
+                rdt = r.get("properties", {}).get("resource_def", {}).get("type", None)
+                if rdt and (rdt.endswith(".yml") or rdt.endswith(".yaml")):
+                    nested_file = rdt
+            if nested_file:
+                filepath = path.join(dirpath, nested_file)
+                if path.exists(filepath):
+                    nested_files[rid] = nested_file
+    return nested_files
+
+
+def get_type_nested_files(yml, dirpath):
+    """
+    return a dict.
+    key: key in yml which references a nested type file.
+        (the resource "type" is a yaml file.)
+    value: the nested file name.
+
+    The keys are assumed to be unique across files.
+    A separate test checks for that.
+    """
+
+    if not hasattr(yml, "get"):
+        return {}
+
+    nested_files = {}
+    for rid, r in yml.get("resources", {}).items():
+        if isinstance(r, dict) and "type" in r:
+            t = r["type"]
+            nested_file = None
+            if t.endswith(".yml") or t.endswith(".yaml"):
+                nested_file = t
+            if nested_file:
+                filepath = path.join(dirpath, nested_file)
+                if path.exists(filepath):
+                    nested_files[rid] = nested_file
+    return nested_files
+
+
+def get_nested_files(filenames):
+    """
+    returns all the nested files for a set of filenames
+    """
+    nested_files = []
+    for filename in filenames:
+        if file_is_a_nested_template(filename):
+            nested_files.append(filename)
+    return nested_files
+
+
+@lru_cache(maxsize=None)
+def file_is_a_nested_template(file):
+    directory = path.dirname(file)
+    nested_files = []
+    for filename in listdir(directory):
+        if filename.endswith(".yaml") or filename.endswith(".yml"):
+            filename = "{}/{}".format(directory, filename)
+            try:
+                nested_files.extend(
+                    get_list_of_nested_files(filename, path.dirname(filename))
+                )
+            except yaml.YAMLError as e:
+                print(e)  # pylint: disable=superfluous-parens
+                continue
+    return file in nested_files