Code Review
/
vvp
/
validation-scripts.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
[VVP] Bug fix for test_port_resource_ids
[vvp/validation-scripts.git]
/
ice_validator
/
tests
/
test_port_resource_ids.py
diff --git
a/ice_validator/tests/test_port_resource_ids.py
b/ice_validator/tests/test_port_resource_ids.py
index
6bd2a4e
..
d587743
100644
(file)
--- a/
ice_validator/tests/test_port_resource_ids.py
+++ b/
ice_validator/tests/test_port_resource_ids.py
@@
-108,14
+108,22
@@
def test_port_resource_ids(yaml_file):
if property_uses_get_resource(v, "network"):
continue
if property_uses_get_resource(v, "network"):
continue
+
network_role = get_network_role_from_port(port_resource)
if not network_role:
network_role = get_network_role_from_port(port_resource)
if not network_role:
+ invalid_ports.append(
+ (port_id, "Unable to determine network role for port.")
+ )
continue
network_role = network_role.lower()
network_type = get_network_type_from_port(port_resource)
if not network_type:
continue
network_role = network_role.lower()
network_type = get_network_type_from_port(port_resource)
if not network_type:
+ invalid_ports.append(
+ (port_id, "Unable to determine network type for port (internal or external).")
+ )
continue
continue
+
if network_type == "external":
expected_r_id = r"{}_\d+_{}_port_\d+".format(vm_type, network_role)
else:
if network_type == "external":
expected_r_id = r"{}_\d+_{}_port_\d+".format(vm_type, network_role)
else: