[VVP] Adding tests for new reqs from VNFRQTS-630

[vvp/validation-scripts.git] / ice_validator / tests / test_contrail_instance_ip_resource_id.py

diff --git a/ice_validator/tests/test_contrail_instance_ip_resource_id.py b/ice_validator/tests/test_contrail_instance_ip_resource_id.py
index 13f1b8e..2833d5b 100644 (file)
--- a/ice_validator/tests/test_contrail_instance_ip_resource_id.py
+++ b/ice_validator/tests/test_contrail_instance_ip_resource_id.py
@@ -36,10 +36,6 @@
 # ============LICENSE_END============================================
 #
 #
-"""
-resources:
-{vm-type}_server_{vm-type_index}
-"""
 import pytest
 
 from .structures import Heat
@@ -64,8 +60,9 @@ def run_test(heat_template, regex_names, network_flavor):
         flavor = processor.get_network_flavor(resource)
         if flavor != network_flavor:
             continue
+
         regex_name = processor.get_rid_match_tuple(rid)[0]
-        if regex_name in regex_names:
+        if regex_name and regex_name in regex_names:
             continue
         bad.append(rid)
     assert not bad, "%s resource ids %s must match one of %s" % (
@@ -79,7 +76,7 @@ def run_test(heat_template, regex_names, network_flavor):
 
 
 @validates("R-53310", "R-46128")
-def test_contrail_instance_ip_resource_id_external(heat_template):
+def test_contrail_instance_ip_resource_id_external(yaml_file):
     """
     A VNF's Heat Orchestration Template's Resource OS::ContrailV2::InstanceIp
     that is configuring an IPv4 Address on a port attached to an external
@@ -100,14 +97,14 @@ def test_contrail_instance_ip_resource_id_external(heat_template):
     """
 
     run_test(
-        heat_template,
-        regex_names=("ip", "v6_ip"),
+        yaml_file,
+        regex_names=("external"),
         network_flavor=ContrailV2InstanceIpProcessor.network_flavor_external,
     )
 
 
 @validates("R-62187", "R-87563")
-def test_contrail_instance_ip_resource_id_internal(heat_template):
+def test_contrail_instance_ip_resource_id_internal(yaml_file):
     """
     internal
     {vm-type}_{vm-type_index}_int_{network-role}_vmi_{vmi_index}
@@ -116,23 +113,7 @@ def test_contrail_instance_ip_resource_id_internal(heat_template):
             _v6_IP_{index}
     """
     run_test(
-        heat_template,
-        regex_names=("int_ip", "int_v6_ip"),
+        yaml_file,
+        regex_names=("internal"),
         network_flavor=ContrailV2InstanceIpProcessor.network_flavor_internal,
     )
-
-
-@validates("R-20947", "R-88540")
-def test_contrail_instance_ip_resource_id_subint(heat_template):
-    """
-    subint
-    {vm-type}_{vm-type_index}_subint_{network-role}_vmi_{vmi_index}
-            _IP_{index}
-    {vm-type}_{vm-type_index}_subint_{network-role}_vmi_{vmi_index}
-            _v6_IP_{index}
-    """
-    run_test(
-        heat_template,
-        regex_names=("subint_ip", "subint_v6_ip"),
-        network_flavor=ContrailV2InstanceIpProcessor.network_flavor_subint,
-    )