Add nullcheck to HeatbridgeUtils.extractPciIdsFromVserver 13/128413/1
authorJozsef Csongvai <jozsef.csongvai@bell.ca>
Mon, 11 Apr 2022 01:54:10 +0000 (21:54 -0400)
committerJozsef Csongvai <jozsef.csongvai@bell.ca>
Mon, 11 Apr 2022 01:55:44 +0000 (21:55 -0400)
It throws a NullPointerException when vserver has no l-interfaces

Issue-ID: SO-3924
Change-Id: I5e4116ead0775dd53b92414b9badfa09fe58779e
Signed-off-by: Jozsef Csongvai <jozsef.csongvai@bell.ca>
adapters/mso-openstack-adapters/src/main/java/org/onap/so/heatbridge/utils/HeatBridgeUtils.java

index c281dbd..17fd994 100644 (file)
@@ -35,6 +35,7 @@ package org.onap.so.heatbridge.utils;
 
 import com.google.common.base.Preconditions;
 import com.google.common.base.Strings;
+import java.util.Collections;
 import java.util.List;
 import java.util.Optional;
 import java.util.stream.Collectors;
@@ -71,6 +72,9 @@ public final class HeatBridgeUtils {
     }
 
     public static List<String> extractPciIdsFromVServer(Vserver vserver) {
+        if (vserver.getLInterfaces() == null) {
+            return Collections.emptyList();
+        }
         return vserver.getLInterfaces().getLInterface().stream()
                 .filter(lInterface -> lInterface.getSriovVfs() != null
                         && CollectionUtils.isNotEmpty(lInterface.getSriovVfs().getSriovVf()))