Fixed string literal comparision issue

Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143

Move the "extracted information" string literal on the left side of this string comparison.

Issue-Id: APPC-186
Change-Id: I757599f5c8ebcbe70c86105c335c6195e436486b
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>

diff --git a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
index 4bee115..b775999 100644 (file)
--- a/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
+++ b/bpmn/MSOCoreBPMN/src/main/java/org/openecomp/mso/bpmn/core/domain/ServiceDecomposition.java
@@ -215,7 +215,7 @@ public class ServiceDecomposition extends JsonWrapper implements Serializable {
                        Resource resource = iter.next();\r
                        //resource.getModelInfo().getModelInvariantId();\r
 \r
-                       if (resourceObjectId.equals("extracted information")){\r
+                       if ("extracted information".equals(resourceObjectId)){\r
                                return resource.toJsonString();\r
                        }\r
                }\r