sdnc/northbound.git
6 years agoUse released parent 71/27471/1 amsterdam 1.0.1-Amsterdam 1.0.1-ONAP v1.2.3
Dan Timoney [Thu, 4 Jan 2018 21:01:07 +0000 (16:01 -0500)]
Use released parent

Update to use released version of parent POM.

Change-Id: Iba8dc7c2046a6fd3d4ff9c9620897ee0d75b56a0
Issue-ID: CCSDK-166
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRemove duplicate test 09/25509/3
Dan Timoney [Mon, 4 Dec 2017 22:30:44 +0000 (17:30 -0500)]
Remove duplicate test

A junit test called VnfApiProviderTest.java should be removed to avoid
confusion with vnfApiProviderTest.java.  On Windows and Mac OSX, those
file names are treated as duplicates.

Change-Id: Ia98f19b6c523a57df3fcf5675fb903310ea7f421
Issue-ID: SDNC-212
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoDeleting missing vnf-list entry cause infiniteLoop 31/24931/1
Joey Sullivan [Wed, 22 Nov 2017 21:22:02 +0000 (21:22 +0000)]
Deleting missing vnf-list entry cause infiniteLoop

Deleting a vnf-list entry that does not exist from
the databoker throws a
ModifiedNodeDoesNotExistException.  This
conflicted with the optimistic locking retry
mechanism causing a infinite loop.

Change-Id: I216a31eabf710ed365c8d928e4df0e866848eeca
Issue-ID: SDNC-156
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
(cherry picked from commit 69453d796578d46f1c0b98964b3a786718a86863)

6 years agoBump patch version 77/24477/1
Jessica Wagantall [Mon, 20 Nov 2017 19:05:14 +0000 (11:05 -0800)]
Bump patch version

Bump patch version in preparation for Amsterdam
branching.

Change-Id: I5df05df7ded5bbe81a16041c88339bad3f11e494
Issue-ID: CIMAN-120
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoUpdate version.properties 01/23701/1 1.0.0-Amsterdam 1.0.0-ONAP v1.2.2
Dan Timoney [Wed, 15 Nov 2017 22:13:53 +0000 (17:13 -0500)]
Update version.properties

Fix version in version.properties to 1.2.2

Change-Id: I8f2f71f3dac9dc462cff969b2c666c961d3e978a
Issue-ID: SDNC-79
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRoll to next version 53/23653/1
Dan Timoney [Wed, 15 Nov 2017 17:06:42 +0000 (12:06 -0500)]
Roll to next version

Since release 1.2.1 has already been cut, need to bump version to
1.2.2-SNAPSHOT.

Change-Id: I97f293f264082d78d15984c231b67759c3e1006b
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix VoLTE service delete issue 37/23637/1
ramu.n [Wed, 15 Nov 2017 15:54:44 +0000 (21:24 +0530)]
Fix VoLTE service delete issue

In VoLTE use case underlay uses network-topology-operation with
svc-action create & delete, during underlay create operation
need to update MDSAL OPERATIONAL data store similar to
network-topology-operation with activate.

Change-Id: I312679244656b4bef514595d1ec724969d44d38f
Issue-Id: SDNC-193
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoRm docs in repo consolidated w/ sdnc/oam 13/23613/1
Rich Bennett [Wed, 15 Nov 2017 13:19:14 +0000 (08:19 -0500)]
Rm docs in repo consolidated w/ sdnc/oam

Change-Id: I3e6d9b04c3ce814597d1d3992f947b87d1757f61
Issue-ID: DOC-124
Signed-off-by: Rich Bennett <rb2745@att.com>
6 years agoFix preload-network-topology-operation err msgs 13/23513/4
Marcus G K Williams [Tue, 14 Nov 2017 21:31:01 +0000 (13:31 -0800)]
Fix preload-network-topology-operation err msgs

Issue-Id: SDNC-145
Change-Id: Ibf4fe3101b278ad3dee7632863eb10f4b4c88e48
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoRoll to version 1.2.1-SNAPSHOT 51/22951/1 v1.2.1
Dan Timoney [Thu, 9 Nov 2017 12:53:04 +0000 (07:53 -0500)]
Roll to version 1.2.1-SNAPSHOT

Roll to next release version

Change-Id: Id1d521317ca37583ed28b2bf60b0411120f13e00
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agofix doc8 error 13/22813/1
Morgan Richomme [Wed, 8 Nov 2017 16:20:49 +0000 (17:20 +0100)]
fix doc8 error

JIRA: SDNC-178

Change-Id: If5fe5ef8564eb8f673b95b058159c8259722c59f
Signed-off-by: Morgan Richomme <morgan.richomme@orange.com>
6 years agoAdd DG actions to last-action in GenRes.API Yang 09/22109/2
Marcus G K Williams [Sat, 4 Nov 2017 19:22:35 +0000 (12:22 -0700)]
Add DG actions to last-action in GenRes.API Yang

Issue-Id: SDNC-171
Change-Id: I913a40c604f9cab4d9eb1be56c53b69aefc4a3bf
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoFix GENERIC-RESOURCE-API yang model 65/22065/2
Dan Timoney [Fri, 3 Nov 2017 21:24:19 +0000 (17:24 -0400)]
Fix GENERIC-RESOURCE-API yang model

Add missing enum values and container to yang model
Also, BRG and tunnelxconn's service instance parent
is VNF-API, not GENERIC-RESOURCE-API, so do not
try to retrieve service data.

Change-Id: I12c977a7e621ce654d0d5d38f8ac8f3ad95487bd
Issue-ID: SDNC-166
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUpdate swagger doc for GENERIC-RESOURCE-API 57/22057/1
Dan Timoney [Fri, 3 Nov 2017 20:22:26 +0000 (16:22 -0400)]
Update swagger doc for GENERIC-RESOURCE-API

Update swagger v2.0 doc for GENERIC-RESOURCE-API to reflect changes made
for new tunnelxconn assignment

Change-Id: I3a298ff36a8eefc0a638dc40531f79137443cc56
Issue-ID: SDNC-160
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoNew tunnelxconn assignment 35/21735/1
Dan Timoney [Wed, 1 Nov 2017 23:09:40 +0000 (19:09 -0400)]
New tunnelxconn assignment

Add new assignment (vg-ip) to tunnelxconn assignments container

Change-Id: Ib9439ceb440b508007104b0a8452a9ae64255354
Issue-ID: SDNC-160
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix typos in GENERIC-RESOURCE-API 59/21359/1
Dan Timoney [Mon, 30 Oct 2017 18:53:49 +0000 (14:53 -0400)]
Fix typos in GENERIC-RESOURCE-API

Updated location of Yang-mapping properties file and fixed typo
in Yang model for GENERIC-RESOURCE-API.

Change-Id: I379274beefd5673cca5096ff3769b552e0475535
Issue-ID: SDNC-151
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdd offered apis to sdnc/northbound doc 09/21009/1
Dan Timoney [Fri, 27 Oct 2017 13:04:59 +0000 (09:04 -0400)]
Add offered apis to sdnc/northbound doc

Add links to swagger docs to SDNC Northbound offered APIs

Change-Id: I40def203f5748453e5fea6edfb3f2ec0e242f563
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUse version 0.1.0 of parent 27/20627/1
Dan Timoney [Wed, 25 Oct 2017 21:07:57 +0000 (17:07 -0400)]
Use version 0.1.0 of parent

Update to use version 0.1.0 (released version) of parent pom

Change-Id: I3d03456167e0b9467ae068a91c22a95c58f0c4ee
Issue-ID: SDNC-74
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoCreate a Junit test for NetworkTopologyOperation 57/20157/1
Joey Sullivan [Mon, 23 Oct 2017 13:39:31 +0000 (13:39 +0000)]
Create a Junit test for NetworkTopologyOperation

This test verifies NetworkTopologyOperation RPC
executes a DG then produces the expected
NetworkTopologyOperationOutput and persisted the
expected Service in the DataBroker.  In addition
util classes were updated to make it easier to
write additional MDSAL test in the future.

Change-Id: Icf099c0dbf4445fb5d3e5b009a8cb6e8ca7200cb
Issue-ID: SDNC-101
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
6 years agoCreate a Junit test for ServiceTopologyOperation 11/19811/1
Joey Sullivan [Thu, 19 Oct 2017 19:53:05 +0000 (19:53 +0000)]
Create a Junit test for ServiceTopologyOperation

This test verifies ServiceTopologyOperation RPC
executes a DG then produces the expected
ServiceTopologyOperationOutput and persisted the
expected Service in the DataBroker.  In addition
util classes were written to make it easier to
write additional MDSAL test in the future.

Change-Id: I2281099df767397b628ec2caff06f3dd49962b8b
Issue-ID: SDNC-101
Signed-off-by: Joey Sullivan <joey.sullivan@amdocs.com>
6 years agoIgnore ModifiedNodeDoesNotExistException on delete 03/19803/1
Dan Timoney [Thu, 19 Oct 2017 20:03:04 +0000 (16:03 -0400)]
Ignore ModifiedNodeDoesNotExistException on delete

When trying to deleteVnf from operational or config tree, if a
ModifiedNodeDoesNotExistException is cause for commit exception
it means that the data you are trying to delete does not exist.
So you wanted it gone, it's already gone ... log a message at
debug level but don't fail the transaction.

Change-Id: Iea0f4e78522cc2f437843e2b17080855cd314ea6
Issue-ID: SDNC-137
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoFix vnftools load issues 11/19311/1
Dan Timoney [Tue, 17 Oct 2017 15:14:39 +0000 (11:14 -0400)]
Fix vnftools load issues

Fixed 2 issues that prevented vnftools from loading:

1) Added org.onap.ccsdk.* to Import-Package in provider manifest (needed
to resolve path to SvcLogicJavaPlugin)
2) Removed useless Properties arg from VnfTools constructor

Change-Id: Iba8213710d012836a7a70fca07c7c232a3b7b539
Issue-ID: SDNC-132
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdd junit test for vnfapiProvider 07/19107/1
Hao Kuang [Mon, 16 Oct 2017 16:22:15 +0000 (12:22 -0400)]
Add junit test for vnfapiProvider

(1) added junit test for vnf apiProvider
(2) formatted vnfapiProvider via using ONAP java code formatter
(3) added license for VnfSdnUtilTest

Issue-Id: SDNC-123
Change-Id: Ia0a12003a97331ae790224df14012b48d99af7d5
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoSonar coverage vnfapi -VNFSDNSvcLogicServiceClient 43/18843/1
beili.zhou [Fri, 13 Oct 2017 23:19:11 +0000 (19:19 -0400)]
Sonar coverage vnfapi -VNFSDNSvcLogicServiceClient

Add Junit test case for VNFSDNSvcLogicServiceClient
In VNFSDNSvcLogicServiceClient:
  - Fix sonarlint issues (remove un-used import and etc)
  - Changed tab to 4 spaces as per ONAP Java code style

Issue-Id: SDNC-123
Change-Id: Id176e915f17ef5fabc6805415f92d60b4c8e95b2
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoSonar coverage - GenericResourceApi provider 35/18835/1
beili.zhou [Fri, 13 Oct 2017 21:25:05 +0000 (17:25 -0400)]
Sonar coverage - GenericResourceApi provider

Add Junit test case for GenericResourceApiSvcLogicServiceClient
In GenericResourceApiSvcLogicServiceClient:
  - Fix sonarlint issues (remove un-used import and etc)
  - Changed tab to 4 spaces as per ONAP Java code style

Issue-Id: SDNC-101
Change-Id: I789d20a749f8daa4d6b626fedef6a9bb904bae2e
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoMerge "Add junit test for VnfSdnUtilTest"
Dan Timoney [Fri, 13 Oct 2017 18:10:16 +0000 (18:10 +0000)]
Merge "Add junit test for VnfSdnUtilTest"

6 years agoAdd junit test for VnfSdnUtilTest 87/18787/1
Hao Kuang [Fri, 13 Oct 2017 15:16:57 +0000 (11:16 -0400)]
Add junit test for VnfSdnUtilTest

(1) add junit test for vnfSdnUtilTest
(2) format VnfSdnUtil.java via using ONAP java code formatter
(3) fix some sonar lint issues

Issue-Id: SDNC-123
Change-Id: I0e1cd55f67b238d70514a2caf02f4ead7809de31
Signed-off-by: Hao Kuang <Hao.Kuang@amdocs.com>
6 years agoMerge "Fix installation issues with generic-resource-api"
Marcus Williams [Fri, 13 Oct 2017 16:21:35 +0000 (16:21 +0000)]
Merge "Fix installation issues with generic-resource-api"

6 years agoFix installation issues with generic-resource-api 85/18785/1
Dan Timoney [Fri, 13 Oct 2017 16:07:01 +0000 (12:07 -0400)]
Fix installation issues with generic-resource-api

Updated generic-resource-api to use Aries blueprint to install and
resolved issues preventing it from installing properly in karaf.

Change-Id: Iaef8bdb7a9e6aaf149a8e8a0d847197cf3f704a9
Issue-ID: SDNC-109
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoSonar coverage vnftools - VnfTools 43/18643/1
beili.zhou [Thu, 12 Oct 2017 23:23:27 +0000 (19:23 -0400)]
Sonar coverage vnftools - VnfTools

Add junit test cases for VnfTools class
In VnfTools:
  - Fix sonarlint issues (remove un-used private method and etc)
  - Changed tab to 4 spaces as per ONAP Java code style

Issue-Id: SDNC-122
Change-Id: If216f53c8ffa7b646f6ebf18d4b9568cfdf4683b
Signed-off-by: beili.zhou <beili.zhou@amdocs.com>
6 years agoFixed vnfapi install issue 17/18617/2
Dan Timoney [Thu, 12 Oct 2017 20:01:06 +0000 (16:01 -0400)]
Fixed vnfapi install issue

Fixed issues with vnfapi install:
 - Resolved issue installing vnftools by converting to blueprint
 - Resolved issue not finding RPC implementation of vnfapi by fixing
   dependency feature vnftools, and by converting vnfapi to blueprint.

The root cause in both cases was probably something wrong with the
provider configuration, but it was simpler (not to mention more
maintainable) to just convert from config to blueprint.

Change-Id: I7010a845687673c932457774f3103834d328ab84
Issue-ID: SDNC-119
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdd readthedocs for sdnc/northbound 39/18539/2
Dan Timoney [Thu, 12 Oct 2017 13:11:52 +0000 (09:11 -0400)]
Add readthedocs for sdnc/northbound

Add readthedocs documentation for sdnc/northbound.

Change-Id: Iad6b19f8194564807ac5e2b9772a554ab14c2cad
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUse try-with-resource to close filestream 83/18483/1
surya-huawei [Thu, 12 Oct 2017 08:56:36 +0000 (14:26 +0530)]
Use try-with-resource to close filestream

*Using try-with-resource here makes sure that the resource is
automatically closed and increases code readability

Issue-Id: CCSDK-117
Change-Id: Ie923e4540d5be90324104593a1d5fcb1bd501f5c
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoAdd missing info to swagger doc 37/18037/2
Dan Timoney [Tue, 10 Oct 2017 20:00:59 +0000 (16:00 -0400)]
Add missing info to swagger doc

Add missing required sections of info in swagger doc for
generic-resource-api

Change-Id: Iea25ce95d6bc0ae0d0edb7ad9a4f71be0669f231
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoConvert swagger docs to v 2 29/18029/1
Dan Timoney [Tue, 10 Oct 2017 18:41:12 +0000 (14:41 -0400)]
Convert swagger docs to v 2

Generate updated swagger specs and convert from swagger 1.2 to 2.0
format.

Change-Id: I2d357b903596b3f2341ed5d024465e967fdaa76c
Issue-ID: SDNC-72
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoAdded new request-actions for overlay 95/17195/1
Gaurav Agrawal [Wed, 4 Oct 2017 09:34:50 +0000 (15:04 +0530)]
Added new request-actions for overlay

Added new request-actions for dci overlay activation & deactivation. This
is required to differentiate dci activation/deactivation for VoLTE use case
from normal network activation/deactivation.

Change-Id: I865963b78ae8b8ba3a8173259179013997318e87
Issue-Id: SDNC-110
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoFix url for swagger file 45/16645/1
Brian Freeman [Fri, 29 Sep 2017 13:08:30 +0000 (13:08 +0000)]
Fix url for swagger file

Issue-ID: SDNC-72
Change-Id: Ia0c1504393ea8d3af00a082e0d265ccaf4bfef82
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoAdd VNF-API, GEN-RES SWAGGER doc 93/16493/1
Brian Freeman [Thu, 28 Sep 2017 18:37:24 +0000 (18:37 +0000)]
Add VNF-API, GEN-RES SWAGGER doc

Issue-ID: SDNC-72
Change-Id: I1a9fcf3fb99668acba6e89ce8b1db9500adb5670
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoSetup ReadTheDocs 23/16323/1
Brian Freeman [Thu, 28 Sep 2017 10:22:15 +0000 (10:22 +0000)]
Setup ReadTheDocs

Issue-ID: SDNC-72
Change-Id: Iad42b847700c37d3f1099d6a8cc521141d66dfae
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoMerge "Fix VNF-API yang validation issues"
Dan Timoney [Wed, 27 Sep 2017 07:50:34 +0000 (07:50 +0000)]
Merge "Fix VNF-API yang validation issues"

6 years agoMerge "Improve SDNC Sonar coverage"
Dan Timoney [Wed, 27 Sep 2017 07:49:39 +0000 (07:49 +0000)]
Merge "Improve SDNC Sonar coverage"

6 years agoImprove SDNC Sonar coverage 59/15059/3
ramu.n [Mon, 25 Sep 2017 12:46:12 +0000 (18:16 +0530)]
Improve SDNC Sonar coverage

Added initial test cases for GENERIC-RESOURCE-APIs

Change-Id: I84a0d44210f97b9378ad75cc55919d5d404be6a2
Issue-Id: SDNC-101
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoChange "try" to try-with-resources 11/14611/2
surya-huawei [Fri, 22 Sep 2017 13:44:49 +0000 (19:14 +0530)]
Change "try" to try-with-resources

One major issue in sdnc/northbound module
*This is done for a guaranteed closing of resource
and avoiding the finally block

Issue-Id: CCSDK-87
Change-Id: I3ab9119f0b10f47d16864aa3619cc54e069bb9de
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoMerge "Remove sdnc-sli version dependency"
Dan Timoney [Fri, 22 Sep 2017 19:44:47 +0000 (19:44 +0000)]
Merge "Remove sdnc-sli version dependency"

6 years agoMerge "Fix GENERIC-RESOURCE-API yang validation issues"
Dan Timoney [Fri, 22 Sep 2017 12:03:51 +0000 (12:03 +0000)]
Merge "Fix GENERIC-RESOURCE-API yang validation issues"

6 years agoMerge "Refer JUNIT version of parent pom."
Marcus Williams [Thu, 21 Sep 2017 18:27:37 +0000 (18:27 +0000)]
Merge "Refer JUNIT version of parent pom."

6 years agoMerge "Add RPCs for vCPE"
Dan Timoney [Thu, 21 Sep 2017 17:42:35 +0000 (17:42 +0000)]
Merge "Add RPCs for vCPE"

6 years agoFix VNF-API yang validation issues 17/14317/1
ramu.n [Thu, 21 Sep 2017 16:39:22 +0000 (22:09 +0530)]
Fix VNF-API yang validation issues

when validate VNF-API.yang with "pyang" has some issues

Change-Id: I908a6bee90b24614f66df61afccf617a599b58db
Issue-Id: SDNC-99
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoFix GENERIC-RESOURCE-API yang validation issues 87/14287/1
ramu.n [Thu, 21 Sep 2017 14:48:18 +0000 (20:18 +0530)]
Fix GENERIC-RESOURCE-API yang validation issues

when validate GENERIC-RESOURCE-API.yang with "pyang" has some issues

Change-Id: Ibdc71e5a369a6815766e42667beacc4a262dc196
Issue-Id: SDNC-99
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoAdd RPCs for vCPE 75/14275/1
Dan Timoney [Thu, 21 Sep 2017 14:34:32 +0000 (10:34 -0400)]
Add RPCs for vCPE

Added new RPCs for tunnelxconn and brg RPCs.

Change-Id: I036beaad10a8ac1f4c088dffa9a589b7b6bae227
Issue-ID: SDNC-98
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoRefer JUNIT version of parent pom. 47/14247/2
Gaurav Agrawal [Thu, 21 Sep 2017 13:12:52 +0000 (18:42 +0530)]
Refer JUNIT version of parent pom.

Remove the hardcoded version and rather take from parent pom.

Change-Id: Ia146f738af2b447b6164bcf8a6ed7a5700d767d9
Issue-Id: SDNC-97
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoChange "try" to try-with-resources 19/14119/1
surya-huawei [Thu, 21 Sep 2017 06:13:59 +0000 (11:43 +0530)]
Change "try" to try-with-resources

One major issue in sdnc/northbound module
*This is done for a guaranteed closing of resource
and not worrying about finally block to close it

Issue-Id: CCSDK-87
Change-Id: Ic6ea871cb9fb61cbce24b61d7c434d3404570ae7
Signed-off-by: surya-huawei <a.u.surya@huawei.com>
6 years agoRemove sdnc-sli version dependency 01/13501/1
Brian Freeman [Tue, 19 Sep 2017 15:13:32 +0000 (15:13 +0000)]
Remove sdnc-sli version dependency

Issue-ID: SDNC-86
Change-Id: Iae6f03e1d69840f0c0d2dab97d502eb61b65b149
Signed-off-by: Brian Freeman <bf1936@att.com>
6 years agoMerge "Replace deprecated APIs with newer one"
Dan Timoney [Mon, 18 Sep 2017 20:03:11 +0000 (20:03 +0000)]
Merge "Replace deprecated APIs with newer one"

6 years agoSome minor refinements to generic-resource-api 27/13127/3
Gaurav Agrawal [Mon, 18 Sep 2017 11:57:12 +0000 (17:27 +0530)]
Some minor refinements to generic-resource-api

Minor refinements to generic-resource-api including:
1) Replace printStackTrace() with log
2) Use built-in string formatting instead of string concatenation
3) Removed redundant ';' after switch statement
4) Change the private method names to follow guidelines to start with lower case
5) Removed redundant null assignment

Change-Id: I48eb08f7305aa549b952715615201a13c3458ca4
Issue-Id: SDNC-45
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoReplace deprecated APIs with newer one 73/12973/2
Gaurav Agrawal [Mon, 18 Sep 2017 05:22:15 +0000 (10:52 +0530)]
Replace deprecated APIs with newer one

Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
3) setProperties replaced with setYangMappingProperties

Change-Id: I89fba42e88363c5e1e5b23fe272d2754361aee25
Issue-Id: SDNC-89
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoInherit from oparent-odlparent 71/12771/1
Dan Timoney [Fri, 15 Sep 2017 18:06:42 +0000 (14:06 -0400)]
Inherit from oparent-odlparent

Update version of root pom to 0.0.2-SNAPSHOT to inherit from oparent-odlparent

Change-Id: I5f06b2f0f7d1d78246579f157a589a2886b76c38
Issue-ID: SDNC-32
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoMerge "Set RequestId as MDC in SDNC"
Marcus Williams [Fri, 15 Sep 2017 07:28:07 +0000 (07:28 +0000)]
Merge "Set RequestId as MDC in SDNC"

6 years agoSet RequestId as MDC in SDNC 85/12085/3
vaibhav.jain1 [Wed, 13 Sep 2017 05:02:02 +0000 (10:32 +0530)]
Set RequestId as MDC in SDNC

SDNC dosen't set RequestId as MDC whereas it logs it into the log message
as svcRequestId. A change has been made to set RequestId as MDC so that
it propagates throughout the flow.

Change-Id: I0b66958f3ece2a90e11d2986cfd5bbd0858d27ce
Issue-ID: SO-87
Signed-off-by: vaibhav.jain1 <vaibhav.jain1@amdocs.com>
6 years agoChange openecomp to onap in pom.xml 63/12263/1
Marcus G K Williams [Wed, 13 Sep 2017 18:52:07 +0000 (11:52 -0700)]
Change openecomp to onap in pom.xml

Update components to onap. This change should fix
sdnc-northbound-master-release-version-java-daily
and allow sonar updates.

Issue-Id: SDNC-65
Change-Id: Id6ccb9b3d39cddc64f95eb89efb0de6a10b58485
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoCleanup project's name in Sonar 07/11207/1
Jessica Wagantall [Fri, 8 Sep 2017 18:51:39 +0000 (11:51 -0700)]
Cleanup project's name in Sonar

The name parameter in the root pom.xml should
match the project name in gerrit to reflect consistency
in Sonar.

Change-Id: I29c6363a2ee4fc65f85a25709aa219ee16897d07
Issue-id: CIMAN-65
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
6 years agoFix few Blocker/Critical sonar issues 55/11055/2
ramu.n [Fri, 8 Sep 2017 09:15:31 +0000 (14:45 +0530)]
Fix few Blocker/Critical sonar issues

Fix few Blocker/Critical sonar issues in sdnc northbound modules
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL

Change-Id: I277dd72784a2186acffdd2a7045fecbef528f56b
Issue-Id: SDNC-65
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoMerge "Enable surefire unit tests"
Dan Timoney [Thu, 7 Sep 2017 20:04:08 +0000 (20:04 +0000)]
Merge "Enable surefire unit tests"

6 years agoSome minor refinements/fixes 65/10865/1
Gaurav Agrawal [Thu, 7 Sep 2017 15:02:21 +0000 (20:32 +0530)]
Some minor refinements/fixes

Minor refinements to generic-resource-api like sonar issue fix, removal of redundant typecast etc.

Change-Id: Ibb52f280847478e589640afb428088f379fab5b3
Issue-Id: SDNC-45
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoReplace deprecated APIs with newer one 39/10839/1
Gaurav Agrawal [Thu, 7 Sep 2017 14:00:58 +0000 (19:30 +0530)]
Replace deprecated APIs with newer one

Replace following deprecated API
1) NotificationProviderService replaced with NotificationPublishService
2) InstanceIdentifier<T> toInstance() replace with build()
3) setProperties replaced with setYangMappingProperties

Change-Id: Id3e9f116cb825187bf65cc5ac9d6f49484ab0846
Issue-Id: SDNC-45
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoMerge "Fix Blocker/Critical sonar issues"
Dan Timoney [Thu, 7 Sep 2017 13:13:43 +0000 (13:13 +0000)]
Merge "Fix Blocker/Critical sonar issues"

6 years agoUpdate revision no of generic-resource-api.yang 93/10793/1
Gaurav Agrawal [Thu, 7 Sep 2017 10:37:36 +0000 (16:07 +0530)]
Update revision no of generic-resource-api.yang

Update the generic-resource-api-provider.yang revision to fall in-line with generic-resource-api.yang, also depicting actual initial version addition date.

Issue-Id: SDNC-45
Change-Id: I3193d997fb7261ca1c61eaa61acf949c806e56a4
Signed-off-by: Gaurav Agrawal <gaurav.agrawal@huawei.com>
6 years agoFix Blocker/Critical sonar issues 83/10783/1
Ramu N [Thu, 7 Sep 2017 09:39:16 +0000 (15:09 +0530)]
Fix Blocker/Critical sonar issues

Fix Blocker/Critical sonar issues in vnfapi module
https://sonar.onap.org/component_issues?id=org.openecomp.sdnc.northbound%3Asdnc-northbound#resolved=false|severities=BLOCKER%2CCRITICAL

Issue-Id: SDNC-65
Change-Id: Ie5617b7f40ed1d05eb9657a9686fef4b4c9bec35
Signed-off-by: Ramu N <ramu.n@huawei.com>
6 years agoEnable surefire unit tests 45/10645/1
Marcus G K Williams [Wed, 6 Sep 2017 21:59:20 +0000 (14:59 -0700)]
Enable surefire unit tests

Issue-Id: SDNC-65
Change-Id: I6bd2a5e1fe8aac68c160c1e481106aa507dc67e1
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoSeed code submit of generic-resource-api 33/10433/2
Dan Timoney [Wed, 6 Sep 2017 00:33:51 +0000 (20:33 -0400)]
Seed code submit of generic-resource-api

Final seed code submit of generic-resource-api.  This version is ready
to submit if it verifies clean.

Change-Id: Id5d5cec97a5deccfbda478c0dd7e1967900d76a1
Issue-ID: SDNC-45
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agoUpdate SDNC NB to depend on CCSDK 77/9577/1
Marcus G K Williams [Thu, 31 Aug 2017 02:32:32 +0000 (19:32 -0700)]
Update SDNC NB to depend on CCSDK

Refactor code to use CCSDK

Issue-Id: SDNC-50
Change-Id: If637d1a0609ec5ae9df60939f72eb64888e61e71
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
6 years agoPrune migrated components from sdnc/northbound 41/9441/2
Dan Timoney [Wed, 30 Aug 2017 14:28:08 +0000 (10:28 -0400)]
Prune migrated components from sdnc/northbound

Prune components that were migrated from sdnc/northbound to ccsdk by
removing code and replacing with a README.md that redirects the reader
to the appropriate CCSDK repo

Change-Id: I317b1d0093a1dd4647feaf6b852826a2230f4879
Issue-ID: SDNC-59
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agofix dmaap-listener startup and library 21/8621/1
Brian Freeman [Thu, 24 Aug 2017 12:51:40 +0000 (12:51 +0000)]
fix dmaap-listener startup and library

Change-Id: Ice802b7c415f622e161d0ade2daf933064ac8edd
Signed-off-by: Brian Freeman <bf1936@att.com>
Issue-Id: SDNC-67

6 years agoUpdate root pom 73/6873/1
Dan Timoney [Mon, 7 Aug 2017 20:41:48 +0000 (16:41 -0400)]
Update root pom

Update to use root-boron-sr1 artifactId for root pom.  There is only one
version of this artifact, so should avoid missing version problem.

Change-Id: I4dc81744acf2b47b987544a3e90ac96cfadd3cb2
Issue-ID: SDNC-42
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years ago[ROOTPOM FIX] Use version 1.1.0 of root pom 15/5215/1
Dan Timoney [Thu, 22 Jun 2017 21:24:56 +0000 (17:24 -0400)]
[ROOTPOM FIX] Use version 1.1.0 of root pom

To avoid 'disappearing' root poms, change root pom version to 1.1.0.  If later version is used, Jenkins build will look for earlier versions as part of build and if they disappear, build will fail.  If root pom stays frozen at 1.1.0, it will be recreated daily as part of daily build.

Change-Id: Ifedf465048d63d35226a27244491eceaec17223b
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years ago[SDNC-14] Roll northbound to version 1.1.2 65/4665/1
Dan Timoney [Mon, 5 Jun 2017 20:16:27 +0000 (16:16 -0400)]
[SDNC-14] Roll northbound to version 1.1.2

Roll northbound  to use version 1.1.2 of rootpom, to ensure latest version is being used

Change-Id: I44f45531212bf4bb7eb3bffdc25f34bd1ad8e592
Signed-off-by: Dan Timoney <dtimoney@att.com>
6 years agofix some build issues 35/4435/1
Guo Ruijing [Tue, 23 May 2017 07:14:07 +0000 (07:14 +0000)]
fix some build issues

1. use 1.1.1 rootpom
2. add verson for opendaylight-karaf-empty
3. use parameter for dblib-provider

Change-Id: Ia68a765011c70eae4a7275b33bc2906ed95ba5fb
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
6 years agoMerge "[BLACKDUCK] Fix blackduck config"
David Stilwell [Thu, 18 May 2017 19:54:05 +0000 (19:54 +0000)]
Merge "[BLACKDUCK] Fix blackduck config"

6 years agoMerge "fix maven local build issue"
Dan Timoney [Thu, 18 May 2017 19:45:26 +0000 (19:45 +0000)]
Merge "fix maven local build issue"

6 years ago[BLACKDUCK] Fix blackduck config 25/4325/1
Dan Timoney [Thu, 18 May 2017 16:40:06 +0000 (12:40 -0400)]
[BLACKDUCK] Fix blackduck config

Fix blackduck configuration so that BOM file can be generated via mvn install -P blackduck

Change-Id: Ia59ca1d94aedfa849a3784d9063c4243798f0a2b
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years agofix maven local build issue 09/3809/3
Guo Ruijing [Wed, 3 May 2017 23:55:30 +0000 (23:55 +0000)]
fix maven local build issue

onap jenkins use maven-assembly-plugin 2.2-beta-5. without fix, local build use
maven-assembly-plugin 2.4.1 and build fails as:
Assembly is incorrectly configured: null.

to fix local build issue:
1. update to maven-assembly-plugin 2.6
2. add AssemblyId configuration which is needed for assembly >= 2.2

Change-Id: Id929f6ff31beb64e9025346c0bf636d44a5eaa47
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
7 years agoFix copyright to avoid noisy diff after build 83/3883/1
Guo Ruijing [Thu, 4 May 2017 01:19:03 +0000 (01:19 +0000)]
Fix copyright to avoid noisy diff after build

Change-Id: I9c8b9b8cd23bc65c89843adad7dfb3d1469ded34
Signed-off-by: Guo Ruijing <ruijing.guo@intel.com>
7 years ago[SDNGC-5539] Add missing map 89/3689/1
Dan Timoney [Tue, 25 Apr 2017 14:56:01 +0000 (10:56 -0400)]
[SDNGC-5539] Add missing map

Update dmaap-listener to expect map file in /opt/app/dmaap-listener/lib and to deliver map file

Change-Id: Ibdc84ce136e70b09765026c0ffd2167eb40dba8e
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[RENUMBER] Roll to next snapshot 83/3683/1
Dan Timoney [Tue, 25 Apr 2017 14:44:10 +0000 (10:44 -0400)]
[RENUMBER] Roll to next snapshot

Roll to snapshot version 1.1.1-SNAPSHOT

Change-Id: Ic1cc0e706715cdcd8eca1502e99e65be2e961a42
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[SDNC-5] Split listeners 13/3613/3
Dan Timoney [Fri, 21 Apr 2017 21:36:30 +0000 (17:36 -0400)]
[SDNC-5] Split listeners

Split dmaap-listener and ueb-listener to separate artifacts

Change-Id: I7b1d5b15c8ef850ace75d4da451143ba4062b817
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years agoFix assembly xmls for maven-assembly-plugin v2.2+ 95/3195/1
Gary Wu [Fri, 7 Apr 2017 19:22:23 +0000 (12:22 -0700)]
Fix assembly xmls for maven-assembly-plugin v2.2+

Starting in version 2.2, maven-assembly-plugin
requires an id tag in the assembly descriptor xmls.
This patch allows the project to be built in
environments that use newer versions of
maven-assembly-plugin.

For details, see:
https://issues.apache.org/jira/browse/MASSEMBLY-517

Change-Id: I3a721da4aa47be58127fa3f8971f01635d400185
Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
7 years ago[SDNC-3] Update javadoc config 75/3075/1
Dan Timoney [Wed, 5 Apr 2017 13:48:29 +0000 (09:48 -0400)]
[SDNC-3] Update javadoc config

Update javadoc config to publish to onap.org site

Change-Id: I48d691a50377bbaa40ba48c6feb780b988e24fc8
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[SDNC-5] Rebase sdnc-northbound 05/2905/4
Dan Timoney [Fri, 31 Mar 2017 20:00:20 +0000 (16:00 -0400)]
[SDNC-5] Rebase sdnc-northbound

Port to OpenDaylight Boron and sync updates since 16.10

Change-Id: I036c5d0bb600b305300e653023caffc83a262604
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years agoMerge "Update .gitreview with onap URL"
Dan Timoney [Thu, 30 Mar 2017 22:11:42 +0000 (22:11 +0000)]
Merge "Update .gitreview with onap URL"

7 years agoUpdate domain URLs from openecomp.org to onap.org 89/2689/1
Andrew Grimberg [Wed, 29 Mar 2017 19:59:31 +0000 (12:59 -0700)]
Update domain URLs from openecomp.org to onap.org

The openecomp.org namespace is deprecated in favor of the onap.org
namespace

Change-Id: I820ea58d439f15f79262f42094dcb9523d311129
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
7 years agoUpdate .gitreview with onap URL 37/2637/1
Andrew Grimberg [Wed, 29 Mar 2017 15:20:45 +0000 (08:20 -0700)]
Update .gitreview with onap URL

Change-Id: Ia6d653bfd6acb1618e8733bf2f351d9bf446b30d
Signed-off-by: Andrew Grimberg <agrimberg@linuxfoundation.org>
7 years ago[VERSION] Roll to next version 61/2161/2
Dan Timoney [Wed, 15 Mar 2017 14:42:10 +0000 (10:42 -0400)]
[VERSION] Roll to next version

Roll to version 1.1.0-SNAPSHOT

Change-Id: I3da790c1ed744760070953905180bdc72464843c
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[RELEASE] Fix version.properties 67/1667/1
Dan Timoney [Mon, 6 Mar 2017 15:36:04 +0000 (10:36 -0500)]
[RELEASE] Fix version.properties

Fix version number in version.properties

Change-Id: Id69f86fe7ba0513af8e3293052ea199f5cd38eae
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[VERSION] Roll back to snapshot 91/1391/1
Dan Timoney [Fri, 24 Feb 2017 19:03:39 +0000 (14:03 -0500)]
[VERSION] Roll back to snapshot

Roll back to version 1.0.0-SNAPSHOT

Change-Id: Icf45d62d223d7f8f1111452c93489d9ba9184273
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[STAGING] Staging properties 67/1167/1
Dan Timoney [Wed, 22 Feb 2017 01:59:22 +0000 (20:59 -0500)]
[STAGING] Staging properties

Define properties for staging configuration

Change-Id: I87e409646fbdfa8a5287f05006c291698f214fbe
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[STAGING] Add build profiles 21/1121/1
Dan Timoney [Tue, 21 Feb 2017 18:31:06 +0000 (13:31 -0500)]
[STAGING] Add build profiles

Use build profiles to enable/disable staging and blackduck scans

Change-Id: I2e1d749843cff8f051da4beee379a32d3f9ea86c
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[STAGING] Add staging plugin 97/1097/1
Dan Timoney [Tue, 21 Feb 2017 14:08:47 +0000 (09:08 -0500)]
[STAGING] Add staging plugin

Add staging plugin to project pom.xml

Change-Id: Icf923e6f0f0d5e76dff5a8f3101b462d691eff7c
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[VERSION] Official root pom version 83/1083/1
Dan Timoney [Tue, 21 Feb 2017 13:47:08 +0000 (08:47 -0500)]
[VERSION] Official root pom version

Update to use version 1.0.0 of root pom

Change-Id: I9b9d4bea913f60d62cc9dae171db6c117ec10c72
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years ago[VERSION] Change version to snapshot 99/999/2
Dan Timoney [Mon, 20 Feb 2017 19:48:07 +0000 (14:48 -0500)]
[VERSION] Change version to snapshot

Change version to 1.0.0-SNAPSHOT and skip tests

Change-Id: If753fa7b08f2abb57429efe6b044353c21f18e16
Signed-off-by: Dan Timoney <dtimoney@att.com>
7 years agoInitial commit for OpenECOMP SDN-C northbound 51/451/1
Dan Timoney [Wed, 15 Feb 2017 20:09:44 +0000 (15:09 -0500)]
Initial commit for OpenECOMP SDN-C northbound

Change-Id: Iffe4d4fbcfd21ecbc1000238354094cc064298ce
Signed-off-by: Dan Timoney <dtimoney@att.com>