Code Review / sdc.git / log
? search:
summary | shortlog | log | commit | commitdiff | review | tree
first ⋅ prev ⋅ next
sdc.git
5 years agoupdate sdc version 80/73180/1
commit | commitdiff | tree
Michael Lando [Tue, 20 Nov 2018 20:23:43 +0000 (22:23 +0200)]
update sdc version

update sdc version to 1.3.4 for Casablanca

Change-Id: Ib66541ef7164da8e35bc2967f9ddb70b4db8f668
Issue-ID: SDC-1913
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
5 years agofix issue in in alloted resource 43/73143/1
commit | commitdiff | tree
Michael Lando [Tue, 20 Nov 2018 14:50:37 +0000 (16:50 +0200)]
fix issue in in alloted resource

update aloted template add it to upgrade normative
remove use of mail librery

Change-Id: Ie8922c6cce4ca10baaf401f7a7bfed436ceb585e
Issue-ID: SDC-1945
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
5 years agoAdd new test cases for uncovered conditions.Revert 67/73067/2
commit | commitdiff | tree
Tal Gitelman [Mon, 19 Nov 2018 17:23:42 +0000 (19:23 +0200)]
Add new test cases for uncovered conditions.Revert

- Added new test cases on top of existing test cases.
Rebased it based on comment.

Issue-ID: SDC-1774

Change-Id: I4631c994ce048b2ff57e742f89644f58b8ac4aab
Signed-off-by: Tal Gitelman <tal.gitelman@att.com>
5 years agoUnit-tests in notification, validation, VLM 27/73027/2
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 20:18:53 +0000 (22:18 +0200)]
Unit-tests in notification, validation, VLM

Unit-tests for mappers in a few libraries.

(cherry picked from commit cc628e4c8258820e2fb0a47acdcc47c15a2b71bd)

Change-Id: I250ff97e5dfe90fa05ec329e25cf6a14dac261f7
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoUnit-tests for mappers in item services 22/73022/2
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 16:58:36 +0000 (18:58 +0200)]
Unit-tests for mappers in item services

Change-Id: I44b2574a70f6ad357dd0528f9bf4b3608ec33063
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
(cherry picked from commit 03fb4087901e4cf56b02f6a9456d987f28844a2f)

5 years agoUnit-test for mappers in item permissions 21/73021/2
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 16:34:56 +0000 (18:34 +0200)]
Unit-test for mappers in item permissions

Change-Id: I047da38c9345aba1079e9ce360587a8d0650d10e
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
(cherry picked from commit a53296cab00e739a6b6a177048f3a3bb9c0f298f)

5 years agoAdd UT for Combination model class 58/73058/2
commit | commitdiff | tree
Satyaki Mallick [Wed, 19 Sep 2018 13:21:35 +0000 (18:51 +0530)]
Add UT for Combination model class

Unit Test for Combination class which is part of the Combination feature.

Issue-ID: SDC-1774
Change-Id: Iaa69b2f9f583469603ccd7183b93eb5eb100cfe2
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoAdd new test cases for uncovered lines of code. 57/73057/2
commit | commitdiff | tree
isaac.manuelraj [Tue, 13 Nov 2018 05:26:11 +0000 (10:56 +0530)]
Add new test cases for uncovered lines of code.

Added new test cases on top of existing test class.

Issue-ID: SDC-1774

Change-Id: I1fd38f14ef7fbfc6ddf478852c0dfd35a27607fa
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoAdd new test cases for the class 56/73056/2
commit | commitdiff | tree
isaac.manuelraj [Tue, 13 Nov 2018 05:31:13 +0000 (11:01 +0530)]
Add new test cases for the class

Added new test cases for the class

Issue-ID: SDC-1774

Change-Id: Idf51b3b44a92f7c0caf6ac44a67365ebaa6f7759
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoAdd new test cases for uncovered lines of code. 55/73055/3
commit | commitdiff | tree
isaac.manuelraj [Tue, 13 Nov 2018 06:16:10 +0000 (11:46 +0530)]
Add new test cases for uncovered lines of code.

Added new test cases to existing class.

Issue-ID: SDC-1774

Change-Id: I23215529f9bd1aff144beb18f9e1f158f7d3153b
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoUT-enhance NodeTemplateOperationTest4 54/73054/2
commit | commitdiff | tree
Sindhuri.A [Fri, 16 Nov 2018 13:56:33 +0000 (19:26 +0530)]
UT-enhance NodeTemplateOperationTest4

UT for catalog model NodeTemplateOperation class

Issue-ID: SDC-1775

Change-Id: Ib7907643e19264d94bda7cf04f4ad72b410eac42
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
(cherry picked from commit 9884dc7f6323217b71f29797c155e24d68069162)

5 years agoUT-ElementBusinessLogic3 53/73053/2
commit | commitdiff | tree
Sindhuri.A [Tue, 13 Nov 2018 11:21:18 +0000 (16:51 +0530)]
UT-ElementBusinessLogic3

UT for catalog be ElementBusinessLogicTest class

Issue-ID: SDC-1775

Change-Id: I73581cf34ef3f35880776f11cd17c5365876e1c9
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-AdditionalInformationBusinessLogic2 52/73052/2
commit | commitdiff | tree
Sindhuri.A [Tue, 13 Nov 2018 06:33:27 +0000 (12:03 +0530)]
UT-AdditionalInformationBusinessLogic2

Enhanced UT for catalog-be AdditionalInformationBusinessLogic class

Issue-ID: SDC-1775

Change-Id: If342732eb21ce285fa0a9643a32463712759e448
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-GroupBusinessLogic2 51/73051/2
commit | commitdiff | tree
Sindhuri.A [Mon, 12 Nov 2018 12:57:32 +0000 (18:27 +0530)]
UT-GroupBusinessLogic2

UT for catalog be GroupBusinessLogicTest class

Issue-ID: SDC-1775

Change-Id: Ib0ce6ff0e0fa33787c6f3dc92003c794d3d0e991
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-ToscaOperationFacade 5 50/73050/2
commit | commitdiff | tree
Sindhuri.A [Wed, 14 Nov 2018 13:27:34 +0000 (18:57 +0530)]
UT-ToscaOperationFacade 5

UT for catalog be ToscaOperationFacade class

Issue-ID: SDC-1775

Change-Id: Ie47efa5e9146070f3ef7ec69683db3cbbca1650e
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-AdditionalInfoOperation2 49/73049/2
commit | commitdiff | tree
Sindhuri.A [Fri, 16 Nov 2018 07:07:00 +0000 (12:37 +0530)]
UT-AdditionalInfoOperation2

UT for AdditionalInformationOperation class

Issue-ID: SDC-1775

Change-Id: I971043f92b6566b121f3d31201ce29148d7d2b85
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoAdd new test cases for uncovered conditions. 48/73048/1
commit | commitdiff | tree
isaac.manuelraj [Tue, 13 Nov 2018 11:46:05 +0000 (17:16 +0530)]
Add new test cases for uncovered conditions.

Added new test cases on top of existing test cases.
Rebased it based on comment.

Issue-ID: SDC-1774

Change-Id: I8d09c51cec2469049bde2ba8f77f597c6f418b7b
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoUnit-test for mappers in conflict library 20/73020/2
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 16:15:43 +0000 (18:15 +0200)]
Unit-test for mappers in conflict library

Change-Id: I6136fa7491b34d9f3fb8df78a55b8d992e2d27fe
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
(cherry picked from commit 8a87ab347622c818c50d3faa2d82ee3b5776db81)

5 years agoUnit-tested mappers of action library 17/73017/2
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 15:10:49 +0000 (17:10 +0200)]
Unit-tested mappers of action library

Change-Id: I4e3af94682b1575b6d76b4791c5533d5ebe3a471
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
(cherry picked from commit 85eff1d93444d3246693ea238f98b5a0db047870)

5 years agoUnit-tests for mappers in application config 19/73019/2
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 15:59:40 +0000 (17:59 +0200)]
Unit-tests for mappers in application config

Change-Id: Ic529125ab2f44f5000e39eb3dd724bd977605ccb
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
(cherry picked from commit 24d5134bb5ef6593fa8cab71f52901359e83c8b5)

5 years agoUnit-tests for mappers in VSP library 16/73016/1
commit | commitdiff | tree
vempo [Sat, 17 Nov 2018 19:10:53 +0000 (21:10 +0200)]
Unit-tests for mappers in VSP library

Change-Id: Ibbe2e9c4ee85a7fe77b2b68e21d2266010f4fa62
Issue-ID: SDC-1917
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
(cherry picked from commit 91f0a9df3d688f3a7508c9088c8410872e22428e)

5 years agoblock swagger access 13/72813/1 1.3.3
commit | commitdiff | tree
Michael Lando [Thu, 15 Nov 2018 12:00:20 +0000 (14:00 +0200)]
block swagger access

remove swagger access to mitigate

Change-Id: Ia95eb39f3d5f763d754c6957e40e0224e2423ed7
Issue-ID: SDC-1913
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
5 years agovCPE Tunnel XConn : allottedResourcEtype is 59/72559/1
commit | commitdiff | tree
Tal Gitelman [Tue, 13 Nov 2018 17:37:19 +0000 (19:37 +0200)]
vCPE Tunnel XConn : allottedResourcEtype is

 - failing to match SO trigger

Change-Id: I5e56408f619487c436e7547c0935b3791d24016d
Issue-ID: SDC-1909
Signed-off-by: Tal Gitelman <tal.gitelman@att.com>
5 years agofix two typos 97/72397/3
commit | commitdiff | tree
liang ding [Mon, 12 Nov 2018 03:00:43 +0000 (19:00 -0800)]
fix two typos

Change-Id: Icc3ca322d687365f29051ed8d3a27696d16ad16c
Issue-ID: SDC-1910
Signed-off-by: liang ding <liang.ding@intel.com>
5 years agoUT-ToscaOperationFacade 4 16/72316/3
commit | commitdiff | tree
Sindhuri.A [Fri, 9 Nov 2018 17:10:50 +0000 (22:40 +0530)]
UT-ToscaOperationFacade 4

UT for catalog be ToscaOperationFacade class

Issue-ID: SDC-1775

Change-Id: I9d42dfe6d6a2997e2d9f96d0fdd0f617a0e2cc3c
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoAdd UT for CommonUtil 11/70911/12
commit | commitdiff | tree
Satyaki Mallick [Sun, 21 Oct 2018 13:49:42 +0000 (19:19 +0530)]
Add UT for CommonUtil

Add UT for CommonUtil in openecomp-be.

Issue-ID: SDC-1774

Change-Id: Id197e79ede009f3ca34043f907a48b26af17be53
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoUT-GroupBusinessLogic 93/71793/4
commit | commitdiff | tree
Sindhuri.A [Sat, 3 Nov 2018 16:19:31 +0000 (21:49 +0530)]
UT-GroupBusinessLogic

UT for catalog be GroupBusinessLogicTest class

Issue-ID: SDC-1775

Change-Id: I59ae7cbfdf11ba7f1b94313c9c359bb5b19c56d5
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoDeleted artifact generator modules 02/72202/2
commit | commitdiff | tree
vempo [Thu, 8 Nov 2018 11:56:23 +0000 (13:56 +0200)]
Deleted artifact generator modules

Change-Id: Ibad18285edc1181d7247d395efa8f2322e255147
Issue-ID: SDC-1906
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoAdd new test cases. 40/71940/3
commit | commitdiff | tree
isaac.manuelraj [Tue, 6 Nov 2018 12:20:50 +0000 (17:50 +0530)]
Add new test cases.

Added new test cases to the existing test cases.

Issue-ID: SDC-1774

Change-Id: I7521aa2265153ef17b85e65b5c594fb660fb43c5
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoFix validation bug in operation modal 87/72187/2
commit | commitdiff | tree
Arielk [Thu, 8 Nov 2018 10:42:52 +0000 (12:42 +0200)]
Fix validation bug in operation modal

Checks is for only current tab parameters validity

Change-Id: Ifd33a31c56fc3addd0ecf1479fb9d0559866b56c
Issue-ID: SDC-1907
Signed-off-by: Arielk <Ariel.Kenan@amdocs.com>
5 years agoUT-ElementBusinessLogic2 67/72067/2
commit | commitdiff | tree
Sindhuri.A [Wed, 7 Nov 2018 12:53:00 +0000 (18:23 +0530)]
UT-ElementBusinessLogic2

UT for catalog be ElementBusinessLogicTest class

Issue-ID: SDC-1775

Change-Id: I3e28611e116415a62fbc536f3b2a20c97673d9aa
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoRemoved dead and duplicate code in onboarding 96/72096/3
commit | commitdiff | tree
vempo [Wed, 7 Nov 2018 16:48:04 +0000 (18:48 +0200)]
Removed dead and duplicate code in onboarding

Change-Id: I2ca0f1a4b00938838213ba2d615ab72c80d6dda3
Issue-ID: SDC-1903
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoError displayed on deleting VF/VFC 69/72069/3
commit | commitdiff | tree
Tal Gitelman [Wed, 7 Nov 2018 13:41:55 +0000 (15:41 +0200)]
Error displayed on deleting VF/VFC

 - from Service Composition

Change-Id: I48c2256b0584c69b94c870eefd834eaf2891f56d
Issue-ID: SDC-1888
Signed-off-by: Tal Gitelman <tal.gitelman@att.com>
5 years agoRemoved compile-helper-plugin 71/71971/2
commit | commitdiff | tree
vempo [Tue, 6 Nov 2018 16:41:14 +0000 (18:41 +0200)]
Removed compile-helper-plugin

Change-Id: I4d10879ac3195e25b8a2c97776c59241a25338a8
Issue-ID: SDC-1861
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoRemoved snapshot-signature-plugin 41/71941/1
commit | commitdiff | tree
vempo [Tue, 6 Nov 2018 12:38:50 +0000 (14:38 +0200)]
Removed snapshot-signature-plugin

Change-Id: Iff68a1593fdd1fe5cf2bad8d067b15231208005a
Issue-ID: SDC-1861
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoCleaned up POM of configuration framework 70/71870/2
commit | commitdiff | tree
vempo [Mon, 5 Nov 2018 16:27:54 +0000 (18:27 +0200)]
Cleaned up POM of configuration framework

Removed unused dependencies, inherited versions
from dependencyManagement of the parent.

Change-Id: I324e89e22fa431add147f8d499e01857deb7770a
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoRemoved artifact-copy plugin 71/71871/1
commit | commitdiff | tree
vempo [Mon, 5 Nov 2018 16:41:47 +0000 (18:41 +0200)]
Removed artifact-copy plugin

Change-Id: I2993bdc46693af1b48ed886718d17b835437740e
Issue-ID: SDC-1861
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoRefactor Code NodeTemplateOperation 43/71543/2
commit | commitdiff | tree
Sindhuri.A [Wed, 31 Oct 2018 12:12:01 +0000 (17:42 +0530)]
Refactor Code NodeTemplateOperation

Code refactor : catalog-model classes

Issue-ID: SDC-1880

Change-Id: Ifdf67574746954679ec85045fb96bb949f338161
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoRefactor ComponentInstanceBusinessLogic 27/71727/3
commit | commitdiff | tree
Sindhuri.A [Fri, 2 Nov 2018 10:10:40 +0000 (15:40 +0530)]
Refactor ComponentInstanceBusinessLogic

Code refactor : ComponentInstanceBusinessLogic class

Issue-ID: SDC-1880

Change-Id: I22cc14e927318bcf79bf3f57fcea555a7987290f
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoRefactor catalog-be code 32/71732/3
commit | commitdiff | tree
Sindhuri.A [Fri, 2 Nov 2018 12:49:47 +0000 (18:19 +0530)]
Refactor catalog-be code

Code refactor : catalog-be classes

Issue-ID: SDC-1880

Change-Id: Ib1153c622d2b7f9de7369d388be4d2e5fc84178f
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-ElementBusinessLogic 23/71823/2
commit | commitdiff | tree
Sindhuri.A [Mon, 5 Nov 2018 09:32:07 +0000 (15:02 +0530)]
UT-ElementBusinessLogic

UT for catalog be ElementBusinessLogicTest class

Issue-ID: SDC-1775

Change-Id: I627b7a349dc322da1bffa33e1e1af88bd6777cc9
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoremoved resource-input & service-input folder 47/70347/2
commit | commitdiff | tree
Anjali walsatwar [Fri, 12 Oct 2018 09:16:39 +0000 (14:46 +0530)]
removed resource-input & service-input folder

Issue-ID: SDC-1789

Change-Id: I15868ac889a57fabb1009787098087e22e3f45a5
Signed-off-by: Anjali walsatwar <anjali.walsatwar@huawei.com>
5 years agobump sdc version to 1.3.3 14/71814/4
commit | commitdiff | tree
Michael Lando [Mon, 5 Nov 2018 07:48:40 +0000 (09:48 +0200)]
bump sdc version to 1.3.3

Change-Id: I703591a9985f9792649622b16f2a05aa89d1d8ea
Issue-ID: SDC-1865
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
5 years agolicense fix 94/70894/2
commit | commitdiff | tree
svishnev [Sun, 21 Oct 2018 07:59:00 +0000 (10:59 +0300)]
license fix

Issue-ID: SDC-1850
Change-Id: I6ff92ec2f149f70b3268cb421a5af37c1cb574b9
Signed-off-by: svishnev <shlomo-stanisla.vishnevetskiy@amdocs.com>
5 years agochache result in onboarding 95/71795/4
commit | commitdiff | tree
Yarin Dekel [Sun, 4 Nov 2018 13:00:34 +0000 (15:00 +0200)]
chache result in onboarding

Issue-ID: SDC-1889
Change-Id: I99dc01cc32af99399bc232125b6195b7125e6c61
Signed-off-by: Yarin Dekel <yarind@amdocs.com>
5 years agoBatch delete keyboard shorcut on canvas 41/70641/8
commit | commitdiff | tree
Sindhuri.A [Wed, 17 Oct 2018 07:55:27 +0000 (13:25 +0530)]
Batch delete keyboard shorcut on canvas

Keyboard Shortcut for batch delete (multiple select nodes and delete) on Composition page canvas

Issue-ID: SDC-1734

Change-Id: I7de5d95a1ca6ea27cdd257b20bfdc1ed9b0ce102
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoAccess workflow from SDC in Portal 75/71675/3 1.3.2
commit | commitdiff | tree
priyanshu [Thu, 1 Nov 2018 14:25:31 +0000 (16:25 +0200)]
Access workflow from SDC in Portal

Access workflow from SDC in Portal

Change-Id: I6c0b64d2ed009f1a51567d4b3f9053cde8116eac
Issue-ID: SDC-1887
Signed-off-by: priyanshu <pagarwal@amdocs.com>
5 years agoSorted out unit-test libraries in onboarding 74/71674/1
commit | commitdiff | tree
vempo [Thu, 1 Nov 2018 18:27:39 +0000 (20:27 +0200)]
Sorted out unit-test libraries in onboarding

Fixed scope, removed junit+tesng combinations,
deleted commented-out tests, did minor cleanups.

Change-Id: I71d0adf5c1c95435987dbb8b4077cc43bdf09df8
Issue-ID: SDC-1886
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoupdate sdc to version 1.3.2 36/71636/1
commit | commitdiff | tree
Michael Lando [Thu, 1 Nov 2018 14:25:31 +0000 (16:25 +0200)]
update sdc to version 1.3.2

Change-Id: Ibd1a6a23f061c23e8bb0bb603f6ac315581564f6
Issue-ID: SDC-1865
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
5 years agoFixed Sonar violations in configuration 65/71565/3
commit | commitdiff | tree
vempo [Wed, 31 Oct 2018 16:39:44 +0000 (18:39 +0200)]
Fixed Sonar violations in configuration

Simplified code, added unit tests.

Change-Id: I0a35daf8a2d4cfd0979e30363c9fad30e7c0570b
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoRemove webapp from togglz 00/71400/3
commit | commitdiff | tree
shrikantawachar [Mon, 29 Oct 2018 15:00:11 +0000 (20:30 +0530)]
Remove webapp from togglz

Remove webapp from togglz

Change-Id: I6d2e6a40a667db1a4dc4f535e479f3a59efe04bf
Issue-ID: SDC-1875
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
5 years agoUT-ToscaOperationFacade 3 43/71443/2
commit | commitdiff | tree
Sindhuri.A [Tue, 30 Oct 2018 09:32:17 +0000 (15:02 +0530)]
UT-ToscaOperationFacade 3

UT for catalog be ToscaOperationFacade class

Issue-ID: SDC-1775

Change-Id: I72849bcaa5b86bf77c41ce8aa320e32ca12be719
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoRefactor Code catalog-model 49/71449/2
commit | commitdiff | tree
Sindhuri.A [Tue, 30 Oct 2018 12:13:59 +0000 (17:43 +0530)]
Refactor Code catalog-model

Code refactor : catalog-model classes

Issue-ID: SDC-1880

Change-Id: I8f9e0f87eed6f9db8885572dce159eedc7845173
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoCode refactoring catalog-model 59/71459/2
commit | commitdiff | tree
Sindhuri.A [Tue, 30 Oct 2018 13:37:39 +0000 (19:07 +0530)]
Code refactoring catalog-model

Code refactor : catalog-model classes

Issue-ID: SDC-1880

Change-Id: I75ef87ef25cc9d1da6d59f4ed5d3790a0fbb2c25
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-enhance NodeTemplateOperationTest3 36/71536/2
commit | commitdiff | tree
Sindhuri.A [Wed, 31 Oct 2018 08:47:42 +0000 (14:17 +0530)]
UT-enhance NodeTemplateOperationTest3

UT for catalog model NodeTemplateOperation class

Issue-ID: SDC-1775

Change-Id: Id40b90421b1fb4698a03707b245ccd5ce79721c4
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoupgrading jetty 89/71489/6
commit | commitdiff | tree
Tal Gitelman [Tue, 30 Oct 2018 17:45:19 +0000 (19:45 +0200)]
upgrading jetty

Change-Id: Ie6307656f88cab59346bb17bcfc75ca494b572d7
Issue-ID: SDC-1767
Signed-off-by: Tal Gitelman <tal.gitelman@att.com>
5 years agoRemove duplicate and unused Test Classes 08/70708/3
commit | commitdiff | tree
Satyaki Mallick [Thu, 18 Oct 2018 04:42:32 +0000 (10:12 +0530)]
Remove duplicate and unused Test Classes

Remove unused and duplicate Test Classes

Issue-ID: SDC-1774

Change-Id: I29b9b04d017cfcf85ad670ffc5a549fd88177daf
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoAdd UT for ComponentValidationUtils 97/71297/3
commit | commitdiff | tree
Satyaki Mallick [Fri, 26 Oct 2018 06:10:37 +0000 (11:40 +0530)]
Add UT for ComponentValidationUtils

UT for ComponentValidationUtils.

Issue-ID: SDC-1774

Change-Id: I0154d592a7f059b01843d7bf18f75a1e5bb9916f
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoAdd test case for RestUtil.java 79/71379/3
commit | commitdiff | tree
isaac.manuelraj [Mon, 29 Oct 2018 06:49:16 +0000 (12:19 +0530)]
Add test case for RestUtil.java

Add test case for RestUtil.java class.

Issue-ID: SDC-1774

Change-Id: Ic048bcbac46514d08ec2328b0ab488fbdc606e0a
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoRemoved JMX, other unused code from configuration 34/71534/3
commit | commitdiff | tree
vempo [Wed, 31 Oct 2018 08:27:59 +0000 (10:27 +0200)]
Removed JMX, other unused code from configuration

Removed code duplicates, stabilized test execution via
Maven, re-aranged code, fixed spelling.

Change-Id: I41fc303ea0a8c7d78d89a12bb20850de51cb8c52
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoFE removed condition for nfc when manual 40/71540/2
commit | commitdiff | tree
Yarin Dekel [Wed, 31 Oct 2018 09:59:46 +0000 (11:59 +0200)]
FE removed condition for nfc when manual

Issue-ID: SDC-1882
Change-Id: I65da28506774a078a91b2a1ddbc1fc2ddfd8635c
Signed-off-by: Yarin Dekel <yarind@amdocs.com>
5 years agoAdd NFC naming code to the csar of manual vsp 33/71533/1
commit | commitdiff | tree
talig [Wed, 31 Oct 2018 08:26:03 +0000 (10:26 +0200)]
Add NFC naming code to the csar of manual vsp

In getComponentDisplayName consider the case of manual vsp, in which:
the added suffix "_VNF" should be removed in order to get the component display name

Change-Id: I4a439b6970ed08bd997fef09ec8360ac1bf2b579
Issue-ID: SDC-1882
Signed-off-by: talig <talig@amdocs.com>
5 years agoAdd UT cases for Action.java 11/70711/9
commit | commitdiff | tree
isaac.manuelraj [Thu, 18 Oct 2018 06:17:26 +0000 (06:17 +0000)]
Add UT cases for Action.java

Added UT cases for Action.java

Issue-ID: SDC-1774

Change-Id: I53653df7ea68051b72bb8305c8f618128cbfada1
Signed-off-by: isaac.manuelraj <isaac.manuelraj@huawei.com>
5 years agoDocumentation Enhancement 35/71135/5
commit | commitdiff | tree
Satyaki Mallick [Wed, 24 Oct 2018 10:42:36 +0000 (16:12 +0530)]
Documentation Enhancement

Documentation Enhancement for SDC

Issue-ID: SDC-1841

Change-Id: I32c52bf817ceccf5ebc5621c36e5ebc722556196
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoUT-TopologyTemplateOperation 10/71310/3
commit | commitdiff | tree
Sindhuri.A [Fri, 26 Oct 2018 13:33:28 +0000 (19:03 +0530)]
UT-TopologyTemplateOperation

Add UT for catalog model TopologyTemplateOperation class

Issue-ID: SDC-1775

Change-Id: I4962899dd946edcdeeb2d58c867a9b8d3a1904df
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-enhance ComponentInstanceOperationTest 09/71309/3
commit | commitdiff | tree
Sindhuri.A [Fri, 26 Oct 2018 10:37:29 +0000 (16:07 +0530)]
UT-enhance ComponentInstanceOperationTest

UT for catalog model ComponentInstanceOperation class

Issue-ID: SDC-1775

Change-Id: I1805fea86f34f9cf67eaaa5e3c6c5750e91176c3
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT- CsarBusinessLogic 55/71355/3
commit | commitdiff | tree
Sindhuri.A [Sat, 27 Oct 2018 07:40:13 +0000 (13:10 +0530)]
UT- CsarBusinessLogic

Add UT for catalog-be CsarBusinessLogic class

Issue-ID: SDC-1775

Change-Id: Ida10f287a963863aad7bad1015feb398e426d396
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-ToscaOperationFacade 2 57/71357/2
commit | commitdiff | tree
Sindhuri.A [Sat, 27 Oct 2018 13:34:37 +0000 (19:04 +0530)]
UT-ToscaOperationFacade 2

UT for catalog be ToscaOperationFacade class

Issue-ID: SDC-1775

Change-Id: I2f66bc665d2b50279ba1fb46f79ca3423311afd0
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-enhance NodeTemplateOperationTest2 66/71366/2
commit | commitdiff | tree
Sindhuri.A [Sun, 28 Oct 2018 18:22:25 +0000 (23:52 +0530)]
UT-enhance NodeTemplateOperationTest2

UT for catalog model NodeTemplateOperation class

Issue-ID: SDC-1775

Change-Id: I935f6cebcf12263c6f03f116a55056b290fb215a
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoRemoved unused import 73/71373/2
commit | commitdiff | tree
Sindhuri.A [Mon, 29 Oct 2018 06:48:34 +0000 (12:18 +0530)]
Removed unused import

ToscaElementOperation unused import removal

Issue-ID: SDC-1552

Change-Id: I83299ca24caad7086ff606b32e05100309407c9b
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-ToscaElementOperation 98/71398/1
commit | commitdiff | tree
Sindhuri.A [Mon, 29 Oct 2018 14:48:53 +0000 (20:18 +0530)]
UT-ToscaElementOperation

UT for catalog be ToscaElementOperation class

Issue-ID: SDC-1775

Change-Id: I2b4824897dbd08c028d1dd3e1c6e50c6883dfe95
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoHandled not thread-safe fields in configuration 65/71365/2
commit | commitdiff | tree
vempo [Sun, 28 Oct 2018 17:04:06 +0000 (19:04 +0200)]
Handled not thread-safe fields in configuration

Replaced not thread-safe fields with synchornized versions,
removed duplicate code, deleted class that was accessing DB,
made surefire plugin to pick up all available unit tests
(instead of hand-picked).

Change-Id: Idff3ac333dc87ebfd3ecf50438ba0179556eb9c9
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoRemoved support of dynamic configuration 61/71361/1
commit | commitdiff | tree
vempo [Sun, 28 Oct 2018 12:45:46 +0000 (14:45 +0200)]
Removed support of dynamic configuration

Configuration framework will not poll configuration
for changes, and will not notify client code of them.
Also minor cleanup, added unit tests.

Change-Id: I428b23f7acb13c6610390f46aae6e011d6b0ee80
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoEnabled unit tests of configuration framework 26/71226/3
commit | commitdiff | tree
vempo [Thu, 25 Oct 2018 09:44:35 +0000 (09:44 +0000)]
Enabled unit tests of configuration framework

Added slf4j binding for tests.
Updated patch version of commons-configuration.

Change-Id: Ifef09eb3591f01be4f90f16758448018361dcdb7
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoCode formatting of configuration framework 57/71257/2
commit | commitdiff | tree
vempo [Thu, 25 Oct 2018 16:27:22 +0000 (19:27 +0300)]
Code formatting of configuration framework

Fixed code formatting, removed meaningless Javadoc comments,
added copyright headers, minor (and safe) static analysis fixes.

Change-Id: I3eda1f242905da5b80e024cf30a69ff59381fc43
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoUT-ToscaOperationFacade 96/70896/3
commit | commitdiff | tree
Sindhuri.A [Sun, 21 Oct 2018 09:06:30 +0000 (14:36 +0530)]
UT-ToscaOperationFacade

UT for catalog be ToscaOperationFacade class

Issue-ID: SDC-1775

Change-Id: I6fca2609a4c09ac3eba36243296989c649d77992
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoDocumentation Enhancement 36/71236/2
commit | commitdiff | tree
Satyaki Mallick [Thu, 25 Oct 2018 13:08:29 +0000 (18:38 +0530)]
Documentation Enhancement

Adding license information to the class.

Issue-ID: SDC-1841

Change-Id: Ic24b36d22c0796ba8f742298797b75a86068e82c
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoUT-AdditionalInformationBusinessLogic 37/71237/2
commit | commitdiff | tree
Sindhuri.A [Thu, 25 Oct 2018 13:11:33 +0000 (18:41 +0530)]
UT-AdditionalInformationBusinessLogic

Enhanced UT for catalog-be AdditionalInformationBusinessLogic class createAdditionalInformation method

Issue-ID: SDC-1775

Change-Id: Ia5c19633d3e76f35b45668902d1504136599c5ad
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUpgrading Jetty version in onboarding 52/71252/2
commit | commitdiff | tree
shrikantawachar [Thu, 25 Oct 2018 15:46:21 +0000 (21:16 +0530)]
Upgrading Jetty version in onboarding

Upgrading Jetty version in onboarding

Change-Id: I1b34f019819ee55295af083daa2ba4bf25433a82
Issue-ID: SDC-1870
Signed-off-by: shrikantawachar <shrikant.awachar@amdocs.com>
5 years agoUT-catalog model ModelConverter 2 59/71259/2
commit | commitdiff | tree
Sindhuri.A [Thu, 25 Oct 2018 17:24:41 +0000 (22:54 +0530)]
UT-catalog model ModelConverter 2

Add UT for catalog model ModelConverter class

Issue-ID: SDC-1775

Change-Id: I8cb17faa5a65391bc1ee0d58ed107eccf2e89204
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-enhance NodeTemplateOperationTest 03/71303/2
commit | commitdiff | tree
Sindhuri.A [Fri, 26 Oct 2018 09:14:23 +0000 (14:44 +0530)]
UT-enhance NodeTemplateOperationTest

UT for catalog model NodeTemplateOperation class

Issue-ID: SDC-1775

Change-Id: Ia85ef99c3467e9671b97c53f785aaf6ac1c7a525
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-ToscaElementLifecycleOperation 53/71353/1
commit | commitdiff | tree
Sindhuri.A [Sat, 27 Oct 2018 05:29:25 +0000 (10:59 +0530)]
UT-ToscaElementLifecycleOperation

Add UT for catalog model ToscaElementLifecycleOperation class

Issue-ID: SDC-1775

Change-Id: Ie9a876fcd3f79a67fe7084034afcbd6937ba9bb1
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoAdd UT for zusammen adaptor 60/71160/3
commit | commitdiff | tree
talig [Thu, 25 Oct 2018 07:08:32 +0000 (10:08 +0300)]
Add UT for zusammen adaptor

Change-Id: I80720b3c322b55ae39b363f3042c9f0efb5e1510
Issue-ID: SDC-1822
Signed-off-by: talig <talig@amdocs.com>
5 years agoFixed configuration tests to run on Linux 23/71223/2
commit | commitdiff | tree
vempo [Thu, 25 Oct 2018 08:47:10 +0000 (11:47 +0300)]
Fixed configuration tests to run on Linux

On Linux, environment variables are case sensitive,
while on Windows they are not.

Change-Id: I49dfd68ab3596ff7ee4a7a53aeba906b606df81b
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoUT-ArtifactsBL handleDelete 54/71054/3
commit | commitdiff | tree
Sindhuri.A [Tue, 23 Oct 2018 13:03:14 +0000 (18:33 +0530)]
UT-ArtifactsBL handleDelete

UT for catalog be ArtifactsBusinessLogic class handleDelete method

Issue-ID: SDC-1775

Change-Id: I1ef9807208cca1dc7ad1d23c5096642ea35b072b
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoRemoved code that stored configuration in DB 56/71156/5
commit | commitdiff | tree
vempo [Wed, 24 Oct 2018 14:18:03 +0000 (17:18 +0300)]
Removed code that stored configuration in DB

Conditionally enabled unit tests, fixed a few
static analysis violations, added copyright headers.

Change-Id: I46ccafc5f4397f82b86d5c51bf0452f2060f6a70
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoupdate sdc version to 1.3.1 10/71010/4
commit | commitdiff | tree
Michael Lando [Mon, 22 Oct 2018 22:32:15 +0000 (01:32 +0300)]
update sdc version to 1.3.1

Change-Id: I195d96ddf5bd6257ade7eb56c65f9e4bc2d602b6
Issue-ID: SDC-1865
Signed-off-by: Michael Lando <michael.lando@intl.att.com>
5 years agoValidate vlm is not draft during vsp submit 51/71151/1
commit | commitdiff | tree
talig [Wed, 24 Oct 2018 13:57:45 +0000 (16:57 +0300)]
Validate vlm is not draft during vsp submit

If vlm version is used - make sure it is Certified,
otherwise - make sure the vlm contains at least one Certified version

Change-Id: Iacb28d622f334d7d81d3e56991e5a2540ed7bcc3
Issue-ID: SDC-1843
Signed-off-by: talig <talig@amdocs.com>
5 years agoRemoved config test with Thread.sleep 32/71132/1
commit | commitdiff | tree
vempo [Wed, 24 Oct 2018 09:01:49 +0000 (12:01 +0300)]
Removed config test with Thread.sleep

The tests with Thread.sleep() caused a long build time (>7 min).
Aslo fixed formatting, copyright headers, static analysis violations.

Change-Id: I8279478c1e6812facc51730679d2ee4e73e22ec7
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoDocumentation Enhancement 06/70706/3
commit | commitdiff | tree
Satyaki Mallick [Thu, 18 Oct 2018 04:36:18 +0000 (10:06 +0530)]
Documentation Enhancement

Documentation Enhancement for SDC

Issue-ID: SDC-1841

Change-Id: I0016d15ff06c2bd033c1cf120ce3aba4268f176d
Signed-off-by: Satyaki Mallick <satyaki.mallick@huawei.com>
5 years agoDeleted empty configuration tests module 28/71128/2
commit | commitdiff | tree
vempo [Wed, 24 Oct 2018 07:48:26 +0000 (07:48 +0000)]
Deleted empty configuration tests module

Change-Id: I03aea493ef87f4a5234505296b9627886d99c7e6
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoUT-AdditionalInfoOperation 67/71067/2
commit | commitdiff | tree
Sindhuri.A [Tue, 23 Oct 2018 15:00:42 +0000 (20:30 +0530)]
UT-AdditionalInfoOperation

UT for AdditionalInformationOperation class

Issue-ID: SDC-1775

Change-Id: I404e66ba4c43553523d1f9fd2c161a1b7326579b
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-catalog model ModelConverter 37/70837/2
commit | commitdiff | tree
Sindhuri.A [Fri, 19 Oct 2018 18:27:48 +0000 (23:57 +0530)]
UT-catalog model ModelConverter

UT for catalog model ModelConverter class

Issue-ID: SDC-1775

Change-Id: I323e7804ea9c1f51bc613c8d678cb71fcb65f7e1
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoUT-asdctool DataMigration 33/70733/4
commit | commitdiff | tree
Sindhuri.A [Thu, 18 Oct 2018 13:27:50 +0000 (18:57 +0530)]
UT-asdctool DataMigration

UT for asdctool impl DataMigration class

Issue-ID: SDC-1775

Change-Id: I78a114127ec461a74b29b226026a93c0a895befe
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
5 years agoMoved config tests into config module 23/71123/1
commit | commitdiff | tree
vempo [Wed, 24 Oct 2018 06:18:06 +0000 (06:18 +0000)]
Moved config tests into config module

Change-Id: I7b99fdeeeb66f5de9bcd9283d815976c3d7520b0
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agoDeleted unused configuration-management-cli 20/71120/1
commit | commitdiff | tree
vempo [Wed, 24 Oct 2018 05:13:46 +0000 (05:13 +0000)]
Deleted unused configuration-management-cli

Change-Id: Ia35aaca4fc07cf98eed8edff4ce9b73a633b3798
Issue-ID: SDC-1867
Signed-off-by: vempo <vitaliy.emporopulo@amdocs.com>
5 years agofix a sonar NullPointerException issue in ABL 14/70914/2
commit | commitdiff | tree
Tal Gitelman [Mon, 22 Oct 2018 07:25:50 +0000 (10:25 +0300)]
fix a sonar NullPointerException issue in ABL

Change-Id: I3ee02af56d3073f1e68cefd2a6503cb804af3ffb
Issue-ID: SDC-1831
Signed-off-by: Tal Gitelman <tg851x@intl.att.com>
5 years agonew UI onboarding test 48/70948/2
commit | commitdiff | tree
Yuli Shlosberg [Mon, 22 Oct 2018 13:54:02 +0000 (16:54 +0300)]
new UI onboarding test

Change-Id: I2594e1d4e5c1112bb7845d9fd69d88ceb1e0fa67
Issue-ID: SDC-1854
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
5 years agoWorkflow duplicate artifacts in CSAR 39/70939/2
commit | commitdiff | tree
priyanshu [Mon, 22 Oct 2018 12:24:45 +0000 (17:54 +0530)]
Workflow duplicate artifacts in CSAR

Old workflow artifacts still packed in csar even if another workflow is assigned to same operation

Change-Id: Iee956903222d1fc1e8c898b4989b2198501554bb
Issue-ID: SDC-1862
Signed-off-by: priyanshu <pagarwal@amdocs.com>
5 years agoUnable to create operation with only outputs 40/70940/2
commit | commitdiff | tree
priyanshu [Mon, 22 Oct 2018 12:32:14 +0000 (18:02 +0530)]
Unable to create operation with only outputs

Unable to create operation with only output via No Workflow Option

Change-Id: I735b445caa13098ae01441dcedf0a44b162eb7a0
Issue-ID: SDC-1863
Signed-off-by: priyanshu <pagarwal@amdocs.com>
next
SDC Parent Project Catalog FE and BE