sdc.git
4 years agoIncrease junit TCs 55/98755/8
vasraz [Tue, 15 Oct 2019 09:23:08 +0000 (10:23 +0100)]
Increase junit TCs

1. Re-enable disabled TCs (enable = true)
2. Enable @Ignored TCs
3. Add some Assert when missing
4. Remove old unused TCs (covered in UI)

Change-Id: I900e52f4860b1fdc5bd1e529a1fe7f5c3491465b
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2672

4 years agoFix xpath selectors and format strings in ui-ci 08/100608/3
andre.schmid [Wed, 22 Jan 2020 16:17:07 +0000 (16:17 +0000)]
Fix xpath selectors and format strings in ui-ci

Change-Id: I70209d0c87dcb4277cb1355010a881553704b3f2
Issue-ID: SDC-2731
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoIgnore auto-generated file in catalog-be 74/100674/2
andre.schmid [Thu, 23 Jan 2020 11:47:09 +0000 (11:47 +0000)]
Ignore auto-generated file in catalog-be

Create a gitignore file to catalog-be and add autogenerated
file "Artifact-Generator.properties" to the ignore list.

Change-Id: Ia482e057c56d059c9ee5dde16fd6b0419623936e
Issue-ID: SDC-2724
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoFix sdc-BE-init container startup 71/100671/2
andre.schmid [Thu, 23 Jan 2020 10:51:28 +0000 (10:51 +0000)]
Fix sdc-BE-init container startup

Remove the while true in the startup.sh script that
prevents the container to stop.

Change-Id: If4acc41dde6e1b8d7f726adfef30ab6ddf20b640
Issue-ID: SDC-2724
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoremove unnecessary dependencies from pom 61/100661/3
Yuli Shlosberg [Thu, 23 Jan 2020 09:50:40 +0000 (11:50 +0200)]
remove unnecessary dependencies from pom

Issue-ID: SDC-2734
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
Change-Id: I7ce13f05f646689ae730959d9d81b3b0b95cbbe6

4 years agoFix CSIT - adding missing parameters to template.json 58/100658/1
Yuli Shlosberg [Thu, 23 Jan 2020 09:21:29 +0000 (11:21 +0200)]
Fix CSIT - adding missing parameters to template.json

Issue-ID: SDC-2732
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
Change-Id: Id4fd22b905e7f94725c6a3d83a8650453cbacb2f

4 years agoFix version.rb after Catalog alignment 00/100600/2
andre.schmid [Wed, 22 Jan 2020 14:49:32 +0000 (14:49 +0000)]
Fix version.rb after Catalog alignment

Change-Id: Ibd4401a13d39ecbb6e7ba079e7e66d59c70c9e4b
Issue-ID: SDC-2724, SDC-2729
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoCatalog alignment 63/100463/12
ys9693 [Sun, 19 Jan 2020 11:50:02 +0000 (13:50 +0200)]
Catalog alignment

Issue-ID: SDC-2724
Signed-off-by: ys9693 <ys9693@att.com>
Change-Id: I52b4aacb58cbd432ca0e1ff7ff1f7dd52099c6fe

4 years agoCSIT Fix for SDC-2585 37/100537/1
atulpurohit [Tue, 21 Jan 2020 10:32:05 +0000 (16:02 +0530)]
CSIT Fix for SDC-2585

Issue-ID: SDC-2722
Co-authored-by: nikhil.soni@vodafone.com
Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
Change-Id: I4f9854a74231ffcce7d8bad9ed7d8dec4c408d63

4 years agoOnboard PNF software version Ui test case 30/99430/7
andre.schmid [Thu, 21 Nov 2019 13:23:07 +0000 (13:23 +0000)]
Onboard PNF software version Ui test case

Change-Id: Ie5785c220e15afbc35efaa8158ab86c41fc34437
Issue-ID: SDC-2702
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoRefresh option in validation result page 40/97940/10
atulpurohit [Tue, 5 Nov 2019 09:01:56 +0000 (14:31 +0530)]
Refresh option in validation result page

Issue-ID: SDC-2585
Co-authored-by: nikhil.soni@vodafone.com
Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
Change-Id: I78f1385d219837c300cb33aff82b7459f137babb
Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
4 years agoFix heat env test file 00/99900/1
Ofir Sonsino [Tue, 24 Dec 2019 09:57:26 +0000 (11:57 +0200)]
Fix heat env test file

Change-Id: Ib9540aef5da75535aef54bb5d56d790c080f2b09
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoUnique identifier for test execution 35/97935/8
atulpurohit [Fri, 1 Nov 2019 09:31:03 +0000 (15:01 +0530)]
Unique identifier for test execution

Issue-ID: SDC-2584
Co-authored-by: nikhil.soni@vodafone.com
Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
Change-Id: I3e7f1a84935cbcd26f8a42a6e2d2dbcb7533cb19
Signed-off-by: atulpurohit <atul.purohit1@vodafone.com>
4 years agoDisabled manual service creation for Partner 58/99458/7
Nilay Ranjan [Mon, 9 Dec 2019 17:28:39 +0000 (22:58 +0530)]
Disabled manual service creation for Partner

Changes to disable/hide Partner Domain Service
category to disable manual creation of such services

Issue-ID: SDC-2382
Change-Id: Ie15732360d78542f41101e315fa4aa803531b5f2
Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
4 years agoRevert "Add Option to proxy to plugins" 56/99756/2
aribeiro [Tue, 17 Dec 2019 10:23:13 +0000 (10:23 +0000)]
Revert "Add Option to proxy to plugins"

This reverts commit ee4c4d72

Issue-ID: SDC-2648
Change-Id: I1f6cba80d3fb803530573c75f2fc54ca207e768a
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoIncreased code coverage using junits 61/99461/2
Annick Boghossian [Mon, 9 Dec 2019 04:48:38 +0000 (15:48 +1100)]
Increased code coverage using junits

Issue-ID: SDC-2699
Change-Id: Ifb0b9616a0218028b06755d6ef7150d54a82ecbb
Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
4 years agoFix unprocessed NPE 35/98935/4
Dmitry Puzikov [Thu, 28 Nov 2019 08:24:00 +0000 (09:24 +0100)]
Fix unprocessed NPE

Process NPE safe way.

Add no NPE failures tests.

Add caught exceptions logging.

Issue-ID: SDC-2694
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Change-Id: Ic1d6e7f9b4f210ac0ca289dc6f44d7c6e15ef126

4 years agoAdd PMSH Models 39/99039/6
dfarrelly [Mon, 2 Dec 2019 09:32:14 +0000 (09:32 +0000)]
Add PMSH Models

*Add PM Subscription Handler monitoring policy

Issue-ID: DCAEGEN2-1940
Change-Id: I82bd1d8d686365e124cd7b4438de583215e9fc0a
Signed-off-by: dfarrelly <david.farrelly@est.tech>
4 years agoFix different sonar issues 75/99575/2
Dmitry Puzikov [Thu, 12 Dec 2019 15:34:25 +0000 (16:34 +0100)]
Fix different sonar issues

Added exxception logging,
added tests.

Change-Id: Ia878030d13570b1445e9b077fce77ca387e69f9a
Issue-ID: SDC-2711
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFix the lack of test coverage reported by sonar 58/99558/3
Dmitry Puzikov [Mon, 9 Dec 2019 08:36:35 +0000 (09:36 +0100)]
Fix the lack of test coverage reported by sonar

Added tests to increase coverage.

Fixed test faiulures.

Issue-ID: SDC-2710
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
Change-Id: I3fb49f2fc794411347780a904837d8d0c61aa7bf

4 years agoCommiter removal from INFO.yaml 96/99596/1
Tomasz Golabek [Fri, 13 Dec 2019 08:43:47 +0000 (09:43 +0100)]
Commiter removal from INFO.yaml

Removed Piotr Darosz cause of resignation from commiter role

Change-Id: I9a72f220bdc62442d547ed14e61ca1014f95e5d0
Issue-ID: SDC-2448
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agoAdded datatypes for 3rd Party Partners 23/99123/2
Atif Husain [Wed, 4 Dec 2019 05:40:38 +0000 (16:40 +1100)]
Added datatypes for 3rd Party Partners

Issue-ID: SDC-2385
Change-Id: Iedc5d5b9b30e7cccd3654a1b6e84514643b6d62f
Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
4 years agoAdd service creation API as an External API 42/98642/6
Divyang Patel [Tue, 8 Oct 2019 04:19:53 +0000 (15:19 +1100)]
Add service creation API as an External API

Issue-ID: SDC-2383
Change-Id: I8490163310e892a7ebb6d7e7275edfdeba24045e
Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
4 years agoFix failed merge job 11/99211/2
vasraz [Thu, 5 Dec 2019 13:53:51 +0000 (13:53 +0000)]
Fix failed merge job

Change-Id: I0b4a77bacffc65976fdcc4eeb01cef6edbc9deee
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2687

4 years agoLogged all caught exceptions 59/99159/3
Dmitry Puzikov [Thu, 28 Nov 2019 13:33:24 +0000 (14:33 +0100)]
Logged all caught exceptions

Fix sonar issue related to logging
caught exceptions.

Change-Id: I61b2106165a81f3b2f0f9cc0da5911787504f50e
Issue-ID: SDC-2698
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoUpgrade sdc-tosca version in main SDC pom 05/99005/3
vasraz [Mon, 2 Dec 2019 13:56:40 +0000 (13:56 +0000)]
Upgrade sdc-tosca version in main SDC pom

Change-Id: I7334e84b7e7e4e55310d1af41a0cced8a02116a4
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2687

4 years agoFix impossible to drag and drop same service twice into the composition 34/99134/3
Satoshi Fujii [Wed, 4 Dec 2019 07:15:41 +0000 (16:15 +0900)]
Fix impossible to drag and drop same service twice into the composition

When a service proxy instance including underscore in its name is added into
the composition, instance ID suffix is not properly calculated and that results
in duplicate key error due to ID conflict.
This change normalizes the name to find existing proxy instances to get suffix
number calculated properly.

Change-Id: I6f2ceb4b9cf020e1523264a99e1347b6caa98965
Issue-ID: SDC-2043
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
4 years agoAdd Option to proxy to plugins 26/98926/4
ilanap [Thu, 28 Nov 2019 09:13:24 +0000 (11:13 +0200)]
Add Option to proxy to plugins

Added option to proxy the plugins throught the catalog proxy. Remove hardcoded redirect to workflow and added to the plugin configuration.

Issue-ID: SDC-2691
Signed-off-by: ilanap <ilanap@amdocs.com>
Change-Id: Ica479ff00e1a8c281b9280b5495ac022172775c4
Signed-off-by: ilanap <ilanap@amdocs.com>
4 years agoadd common-app-logging module 42/98842/3
Yuli Shlosberg [Tue, 26 Nov 2019 09:22:33 +0000 (11:22 +0200)]
add common-app-logging module

This module is responsible of logging mechanism in sdc project

Issue-ID: SDC-2686
Signed-off-by: Yuli Shlosberg <ys9693@att.com>
Change-Id: Icf9817fe2c8b8032757a700f6e6be18d2bc9f891

4 years agoUpdate package to add non-mano artifact onap_pnf_software_information. 48/98948/2
aribeiro [Thu, 28 Nov 2019 12:04:01 +0000 (12:04 +0000)]
Update package to add non-mano artifact onap_pnf_software_information.

Issue-ID: SDC-2641
Change-Id: Ifc51e106a7217158ce8c4aac41898956caa7ecec
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoIncrease test coverage 90/98890/3
Dmitry Puzikov [Wed, 20 Nov 2019 16:08:22 +0000 (17:08 +0100)]
Increase test coverage

Added tests for uncovered default methods.

Change-Id: I3bd88ba5d53a8e5614bd72d2781801fcd5f3fe14
Issue-ID: SDC-2669
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFix sonar issue with test coverage 92/98892/2
Dmitry Puzikov [Thu, 21 Nov 2019 14:44:17 +0000 (15:44 +0100)]
Fix sonar issue with test coverage

Added tests to cover the case.

Fixed provider load failure:
If more than one provider is configured and if the first if failng
try to load next one.

Change-Id: Idd7edb90e2b9b1cf21ec20e299140d3362bd1138
Issue-ID: SDC-2693
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFix welcome screen close timeout 47/98847/2
andre.schmid [Mon, 25 Nov 2019 11:51:14 +0000 (11:51 +0000)]
Fix welcome screen close timeout

The welcome screen close timeout is triggering even if you close the
welcome window. After 4 seconds it forces the user to go to the home
screen even if it is already in another screen. The timeout was also
the cause for one known problem in the sanity ui test
"onapOnboardVNFflow".
Adds also a print screen to the ui tests, to check if the resource
was really clicked.
Removes invalids "throws Exception" declarations that were being
handled in the main test method "Vf.changeInstanceNameInVfTest", that
was catching also assertions errors.

Change-Id: Idff26b1ba5b199482e68cc50532fa20f4f834e34
Issue-ID: SDC-2648
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoFix Security Hotspots issues 56/98756/2
vasraz [Tue, 19 Nov 2019 11:31:19 +0000 (11:31 +0000)]
Fix Security Hotspots issues

Change-Id: Icc45769cff71c8153c0afba6e2363b0399144175
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2671

4 years agoFixing sonar issue 55/98355/6
Dmitry Puzikov [Wed, 13 Nov 2019 11:51:41 +0000 (12:51 +0100)]
Fixing sonar issue

Getting rid of nested ifs-fors

Change-Id: I71ef686683b7070614c27aabbf6cd058b5d35ffd
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoAdd alter_tables.cql to gitignore 93/98593/2
andre.schmid [Tue, 12 Nov 2019 11:34:20 +0000 (11:34 +0000)]
Add alter_tables.cql to gitignore

The alter_tables.cql is being copied during build and should be ignored.

Change-Id: I0a0a420e17761247a6575ad8715ccbd20fd5c1e1
Issue-ID: SDC-2640
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoSonar fixes for API to retrieve UI configuration 80/98980/2
ilanap [Sun, 1 Dec 2019 08:10:33 +0000 (10:10 +0200)]
Sonar fixes for API to retrieve UI configuration

Added configuration file with the menu configuration from catalog-ui. Added to the configuration manager. to chef and to the ui rest APIs.

Issue-ID: SDC-2663
Signed-off-by: ilanap <ilanap@amdocs.com>
Change-Id: I032a7666f470e7d4797a555470bf9eb4a43cfcc4

4 years agoUpgrade Node & npm version 66/98866/6
vasraz [Tue, 26 Nov 2019 17:20:27 +0000 (17:20 +0000)]
Upgrade Node & npm version

Change-Id: Ib41da68543824be671e162eb6c0ba78ded1949cb
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2685

4 years agoAdd API to retrieve UI configuration 45/98845/3
ilanap [Tue, 26 Nov 2019 09:53:36 +0000 (11:53 +0200)]
Add API to retrieve UI configuration

Added configuration file with the menu configuration from catalog-ui. Added to the configuration manager. to chef and to the ui rest APIs.

Issue-ID: SDC-2663
Signed-off-by: ilanap <ilanap@amdocs.com>
Change-Id: Ia5e014a273238981241821c0d81b0455bd662b28
Signed-off-by: ilanap <ilanap@amdocs.com>
4 years agoFixing sonar issues 87/98587/3
Dmitry Puzikov [Tue, 19 Nov 2019 08:55:27 +0000 (09:55 +0100)]
Fixing sonar issues

Simplified method ConfigurationUtils::getProperty.

Added unit tests for method.

Change-Id: I521661b464e7f60101ee51ccbc9d915bf5030f31
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFix Sonar issue 24/98724/3
vasraz [Wed, 20 Nov 2019 17:32:02 +0000 (17:32 +0000)]
Fix Sonar issue

Major SmellCode:
Replace StringBuffer with StringBuilder

Change-Id: I0283e5160e5c1f23423c66110015f18c8163411e
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2670

4 years agoupdate info.yaml 87/98787/2
shrek2000 [Sun, 24 Nov 2019 11:20:39 +0000 (13:20 +0200)]
update info.yaml

Change-Id: I9fb6ce18430ad0789a030a9c80dd231f44f6f6de
Issue-ID: SDC-2448
Signed-off-by: shrek2000 <oren.kleks@amdocs.com>
4 years agoFixing sonar issues 11/98411/3
Dmitry Puzikov [Thu, 14 Nov 2019 13:10:22 +0000 (14:10 +0100)]
Fixing sonar issues

Reduce cyclomatic complexity.

Splitted complex method to a set of more simple methods.

Change-Id: Ic0be3cccefa520f38af83872ddc3e981205edc36
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFixing sonar issues 00/98600/2
Dmitry Puzikov [Tue, 19 Nov 2019 13:41:01 +0000 (14:41 +0100)]
Fixing sonar issues

Logging exception instead of printing trace.

Change-Id: I6c24c258fc1b96c74e55aa2f90c82d09f28ef247
Issue-ID: SDC-2660
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFixing sonar issues 02/98602/3
Dmitry Puzikov [Tue, 19 Nov 2019 14:13:23 +0000 (15:13 +0100)]
Fixing sonar issues

Replaced URL with URI to avoid
trigger DNS.

Change-Id: If85f1f2780c46e0966f3707af51571f4a7aa2f15
Issue-ID: SDC-2660
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFix to stabilize sanity ui test suite 30/98530/2
andre.schmid [Fri, 15 Nov 2019 10:07:12 +0000 (10:07 +0000)]
Fix to stabilize sanity ui test suite

Fix the selection of the Resource Composition screen.
Fix the search for a Resource in the home screen.
Refactor some related classes, mainly removing exceptions not thrown,
correcting typos, removing unused/commented code, fixing SonarQube
issues.
Improve the logs and report logs.

Change-Id: I89b5a0d89652367520cededa6744831492bbbaba
Issue-ID: SDC-2648
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoAdd non-mano software information to sanity test PNF packages 84/98184/4
andre.schmid [Tue, 29 Oct 2019 17:18:22 +0000 (17:18 +0000)]
Add non-mano software information to sanity test PNF packages

Adds a sample non-mano artifact onap_pnf_software_information to
existing api sanity test PNF packages.
Resigns the 2 signed packages with the new root certificate. 2/3
packages are signed, so a new root certificate had to be generated,
as the private key of the previous one is missing.
In the docker_run script, creates a new folder to the test certificate,
different from the production folder, and bind it with the sdc-api-tests
docker.
Minor changes in docker_run script.

Change-Id: I78b28303215912df129a0e0d70afad5f3d0c2d09
Issue-ID: SDC-2641
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoValidate non-mano software information artifact 83/98183/6
andre.schmid [Thu, 10 Oct 2019 16:39:03 +0000 (17:39 +0100)]
Validate non-mano software information artifact

Change-Id: Ie9fabd6af821b830e211ff1068fb287357fd38ee
Issue-ID: SDC-2619
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoOnboard PNF software version 81/97781/8
andre.schmid [Tue, 8 Oct 2019 17:27:36 +0000 (18:27 +0100)]
Onboard PNF software version

Change-Id: Id9e32e01f6c2f4c39c8ff10816d982cbb3063bf7
Issue-ID: SDC-2589
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoupdate info.yaml 95/98595/1
Oren Kleks [Tue, 19 Nov 2019 11:51:31 +0000 (13:51 +0200)]
update info.yaml

Change-Id: Ic32f39f3424d69e25079b91eec78f79e4ce5e020
Issue-ID: SDC-2448
Signed-off-by: shrek2000 <oren.kleks@amdocs.com>
4 years agoFix for scalar-unit type value. 16/96716/5
aribeiro [Tue, 1 Oct 2019 15:47:26 +0000 (16:47 +0100)]
Fix for scalar-unit type value.

Issue-ID: SDC-323
Change-Id: I7f19a7356e1cd34deca0a168b3cb707ef657b9cb
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoFixing sonar issue 59/98359/2
Dmitry Puzikov [Wed, 13 Nov 2019 14:14:52 +0000 (15:14 +0100)]
Fixing sonar issue

Constant is used instead of repeated literal.

Change-Id: I540c09f8ba596398257b34ff3189b1a3ce5ab416
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoFixing sonar issues 75/98375/3
Dmitry Puzikov [Wed, 13 Nov 2019 15:52:25 +0000 (16:52 +0100)]
Fixing sonar issues

Added logging instead of skipping or printing stacktraces.

Change-Id: I258a2a76c295f12b30e200c4519bc1bb0741f642
Issue-ID: SDC-2654
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>
4 years agoConfiguration.yaml update 86/98486/1
db384r [Sun, 17 Nov 2019 12:51:08 +0000 (14:51 +0200)]
Configuration.yaml update

Issue-ID: SDC-2658
Signed-off-by: db384r <dvir.baumel@intl.att.com>
Change-Id: Icec6ad0fb74f023df58ca1a8c9e5a432bff6285f

4 years agoadd SDC Meta Data for CDS Integration 45/98145/3
Ahmed Abbas [Thu, 7 Nov 2019 15:52:37 +0000 (17:52 +0200)]
add SDC Meta Data for CDS Integration

Issue-ID: SDC-2631
Signed-off-by: Ahmed Abbas <ahmad.helmy@orange.com>
Change-Id: Ie691e323f771b786d154c0614d0cd724635a5ec2

4 years agoFix incorrect rendering of search box on VF Properties Assignment tab 40/98140/2
vasraz [Thu, 7 Nov 2019 13:15:40 +0000 (13:15 +0000)]
Fix incorrect rendering of search box on VF Properties Assignment tab

Change-Id: I7abb04fa17c525aaba414f1ba1714211ff08b46c
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2328

4 years agoFix sonarQube issue. 80/98180/2
aribeiro [Fri, 8 Nov 2019 10:53:56 +0000 (10:53 +0000)]
Fix sonarQube issue.

Issue-ID: SDC-2646
Change-Id: Ic426e1cccf50e3db40381896ee50b74e647129ee
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoAlign Sdc warnings with VNF Requirements 56/98056/2
Ben David, Elad (eb7504) [Wed, 6 Nov 2019 15:45:27 +0000 (17:45 +0200)]
Align Sdc warnings with VNF Requirements

Change-Id: Ic133faed7f8b612279de0eb836e88e9ea6b694d7
Issue-ID: SDC-2647
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
4 years agoFix sonarqube issues introduced by ZipSlip change 71/97971/3
andre.schmid [Mon, 4 Nov 2019 13:59:28 +0000 (13:59 +0000)]
Fix sonarqube issues introduced by ZipSlip change

Fix major and critical sonarqube issues introduced by ZipSlip change
id I721f3d44b34fe6d242c9537f5a515ce1bb534c9a

Change-Id: I3aa2cd4116936d715baba99a38d43aa40fd62a29
Issue-ID: SDC-1401
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoAlign logging to Onap-ELS 2019.11 84/97884/5
Ben David, Elad (eb7504) [Sun, 3 Nov 2019 15:22:48 +0000 (17:22 +0200)]
Align logging to Onap-ELS 2019.11

Change-Id: I1750493d5c9f2eab8c1395f0fbc9ae66cf74b0a6
Issue-ID: SDC-2639
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
4 years agoAdd a new package with Custom Types to Sanity test. 12/97912/2
aribeiro [Thu, 10 Oct 2019 09:38:21 +0000 (10:38 +0100)]
Add a new package with Custom Types to Sanity test.

Issue-ID: SDC-2616
Change-Id: Id290626724488e58b4840408429c1962a19064a0
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoTransform custom types for PNFD. 22/96322/5
aribeiro [Wed, 11 Sep 2019 12:50:46 +0000 (13:50 +0100)]
Transform custom types for PNFD.

Transformation of customized Node Types for PNFD.

Issue-ID: SDC-2561
Change-Id: Id3e07edff0e5a8cb134aa12c07878e14c33d1512
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoa fix to handle onboard ALTER tables 92/97892/1
Ben David, Elad (eb7504) [Mon, 4 Nov 2019 08:53:24 +0000 (10:53 +0200)]
a fix to handle onboard ALTER tables

Change-Id: I7e721f267e6e5935231d6e38ac490d9335f68f4b
Issue-ID: SDC-2640
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
4 years agoValidate artifacts signature in SOL004 package 19/97619/4
andre.schmid [Mon, 30 Sep 2019 16:47:27 +0000 (17:47 +0100)]
Validate artifacts signature in SOL004 package

Change-Id: Ib048f4501fd8a81cdf11fab19f149350011f772e
Issue-ID: SDC-2632
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoCreate new non-mano Artifact Type entry for pnf software information 25/97725/3
aribeiro [Thu, 3 Oct 2019 14:44:48 +0000 (15:44 +0100)]
Create new non-mano Artifact Type entry for pnf software information

Issue-ID: SDC-2615
Change-Id: I4dd879d50b1dec58aceeaf0c265901c62d038071
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoCentralize onboarding package validation 17/96217/9
andre.schmid [Thu, 19 Sep 2019 15:14:01 +0000 (16:14 +0100)]
Centralize onboarding package validation

Change-Id: I3cc58cf15f62008e83cfc7ddb095d07ab216b82a
Issue-ID: SDC-2583
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoHandle onboard ALTER tables to support upgrade 83/97883/1
Ben David, Elad (eb7504) [Sun, 3 Nov 2019 14:19:16 +0000 (16:19 +0200)]
Handle onboard ALTER tables to support upgrade

Change-Id: I6c96aecccf00a3b02bf07cf172ff752b69d3cc94
Issue-ID: SDC-2640
Signed-off-by: Ben David, Elad (eb7504) <eb7504@intl.att.com>
4 years agoFix for missing import merge issue 52/97752/1
andre.schmid [Wed, 30 Oct 2019 14:30:42 +0000 (14:30 +0000)]
Fix for missing import merge issue

Some imports from SDC-1952 were lost during the merge of SDC-1401,
they were re-added.

Change-Id: Ie3af8290f98afe4fd9278c218a47376abcdd1a3c
Issue-ID: SDC-1952, SDC-1401
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoDmaapPublisher files update 26/97726/2
Ofir Sonsino [Wed, 30 Oct 2019 09:29:18 +0000 (11:29 +0200)]
DmaapPublisher files update

Change-Id: I72b501587ed0b4ea8f7ba54614361d546b255cf6
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoFix zip slip security flaw 01/97301/4
andre.schmid [Fri, 27 Sep 2019 12:27:11 +0000 (13:27 +0100)]
Fix zip slip security flaw

Apply zip slip checking in zip operations throughout the system.
Centralizes most of the zip logic in one class. Create tests to zip
functionalities and zip slip problem.

Change-Id: I721f3d44b34fe6d242c9537f5a515ce1bb534c9a
Issue-ID: SDC-1401
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoValidate SOL004 manifest signature order 23/97523/2
andre.schmid [Thu, 26 Sep 2019 12:22:44 +0000 (13:22 +0100)]
Validate SOL004 manifest signature order

SOL004 Manifest signature must be the last entry of the manifest.

Change-Id: Ie3835f7140ccdf92ef5518ca2d7571930de81971
Issue-ID: SDC-2587
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoadd artifacts support in TOSCA exported yml file 32/87632/32
Liang Ding [Mon, 15 Apr 2019 07:05:05 +0000 (00:05 -0700)]
add artifacts support in TOSCA exported yml file

Change-Id: I56f8a6a1ce758876e83a7ee8318b79644ae7d5cb
Issue-ID: SDC-1952
Signed-off-by: Liang Ding <liang.ding@intel.com>
4 years agoFix for status properties value. 24/96324/2
aribeiro [Thu, 26 Sep 2019 12:20:28 +0000 (13:20 +0100)]
Fix for status properties value.

These changes were made to align the normative types to the TOSCA property definition requirements.

Issue-ID: SDC-322
Change-Id: I32e815dd26990dd6c82c859ad051b271db3c8029
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoBump SDC version 1.6.0 69/97669/1
Ofir Sonsino [Tue, 29 Oct 2019 09:07:28 +0000 (11:07 +0200)]
Bump SDC version 1.6.0

Change-Id: Ibacb46d19d49023a62caa8f5217086cea6c91ac4
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoAvoid duplicated verification if package is signed 04/95904/5
vasraz [Thu, 5 Sep 2019 13:25:39 +0000 (14:25 +0100)]
Avoid duplicated verification if package is signed

Fix potential thread leak by using try-with-resource.

Change-Id: I20eda524cd028b9dfdfa83207a059f4e1dfeff5e
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2580

4 years agoFix and refactor manifest parsing 91/95391/4
andre.schmid [Fri, 30 Aug 2019 17:20:32 +0000 (18:20 +0100)]
Fix and refactor manifest parsing

Fix a CMS signature reading expected token.
Fix the necessity of a empty line in the end of the manifest.
Implement CMS signature, Source checksum algorithm and digest reading.
Indicate the line number and content when a manifest error occurs.
Remove unnecessary recursive reading.
Centralize manifest tokens.
Improve tests by checking the expected error.
Document the code.

Change-Id: I7d12020d8922fc5d4c8d9f238557dfbcc0b65757
Issue-ID: SDC-2563
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoFix factory instance creation instability 16/97316/4
andre.schmid [Fri, 18 Oct 2019 13:58:21 +0000 (14:58 +0100)]
Fix factory instance creation instability

Refactor the factory registry and instance creation.
Remove unnecessary static code in Factory creation.
Centralize the responsibility to read the factory registry configuration
and cache the factory instances in a Singleton called
FactoryRegistryManager.
Clean the base abstract factory that was sharing non factory code, it
had all the factory registry code statically, never used by the concrete
factory classes.

Change-Id: Ie2e9c29013acd36ddaf15383dd6b06432fbdbb66
Issue-ID: SDC-1905
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoChanges for new service category 40/96540/3
atif husain [Wed, 2 Oct 2019 08:03:57 +0000 (18:03 +1000)]
Changes for new service category

Introduced new service category, Partner Domain Service
Added logic to disable composition for Partner Domain Service category

Issue-ID: SDC-2382
Change-Id: I6ed135733c6f05914e102c037ebe9057ad731e75
Signed-off-by: Atif Husain <atif.husain@team.telstra.com>
4 years agoEl Alto known issues 11/97011/1
Ofir Sonsino [Sun, 13 Oct 2019 08:29:47 +0000 (11:29 +0300)]
El Alto known issues

Change-Id: I293935d6a159691390bd90dd3fc2998821c97773
Issue-ID: SDC-2569
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoFix failing unit test 32/96732/1
vasraz [Tue, 8 Oct 2019 15:44:09 +0000 (16:44 +0100)]
Fix failing unit test

Issue-ID: SDC-2609
Change-Id: Ibf411a8d10af858ee2f42f9b4b565b81fee33ebe
Signed-off-by: vasraz <vasyl.razinkov@est.tech>
4 years agoDocument fixed OJSI tickets in release notes 55/96655/1
Krzysztof Opasiak [Sat, 5 Oct 2019 22:33:33 +0000 (00:33 +0200)]
Document fixed OJSI tickets in release notes

Issue-ID: OJSI-31
Issue-ID: OJSI-76
Issue-ID: OJSI-77
Issue-ID: OJSI-78
Issue-ID: OJSI-79
Issue-ID: OJSI-80
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>
Change-Id: Ie57bdbfae0b40ff7633ff674d22ac5ad3c5cf866

4 years agoRevert "Sonar fix NullPointerException" 18/96618/2
Ofir Sonsino [Fri, 4 Oct 2019 10:51:15 +0000 (10:51 +0000)]
Revert "Sonar fix NullPointerException"

This reverts commit b0f96a46e2720c75eb035bbe94015e5a1c6b0b32.

Issue-ID: SDC-2542
Change-Id: I63b5349670c8e5fa814d686cfa93173d0ea6297e
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoFix for error message. 13/96413/2
aribeiro [Mon, 30 Sep 2019 10:04:00 +0000 (11:04 +0100)]
Fix for error message.

Fixing error message for invalid values across SDC backend API.

Issue-ID: SDC-2324
Change-Id: If01307138baf7692e398abf20eb75bbe9a8aa394
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoAdd support for HTTPS in sanity tests 62/96062/2
Petr Ospalý [Fri, 20 Sep 2019 03:51:37 +0000 (05:51 +0200)]
Add support for HTTPS in sanity tests

If 'disableHttp' is enabled then HTTP ports are replaced with HTTPS ports.
Also added the latest trustore with AAF issuer. And because certs for SDC
components have CN set to "sdc" - environment json must have the domain
names correctly too...it will not work with plain IPs.

The changes have been tested from CSIT perspective so if something is
missing here or wrong then it is due to the fact that I was focusing on
bringing https support to the same level as are http tests and there is
also the fact that I do not know SDC component at all.

The changes are also done in a manner of previous ones - hacked on top of
the current codebase, which is in dire need of a rewrite:

- duplicated trustores and other artifacts
- duplicated scripts and/or similar script with small differences
- ui tests use old ubuntu image vs api tests on alpine
- chef codebase is very messy and I see no benefit in the current usage

Issue-ID: SDC-2564

Signed-off-by: Petr Ospalý <p.ospaly@partner.samsung.com>
Change-Id: I32e0fb7723ab8489eb09372d410c6f34aaf7cfc8

4 years agoAdd substitution mapping to sanity test 27/95527/2
andre.schmid [Wed, 11 Sep 2019 19:20:05 +0000 (20:20 +0100)]
Add substitution mapping to sanity test

Change-Id: Ib970a5929f12144faa2e655f5f898c645feb17b7
Issue-ID: SDC-2282
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoSonar fix NullPointerException 04/95304/5
Arindam Mondal [Tue, 10 Sep 2019 06:02:53 +0000 (15:02 +0900)]
Sonar fix NullPointerException

Issue-ID: SDC-2542
Change-Id: I08a93932d2776c40a982bb802aeac994c1f35841
Signed-off-by: arindamm <arind.mondal@samsung.com>
4 years agoFix for closing sdc splashscreen. 73/96273/2
aribeiro [Thu, 26 Sep 2019 10:43:21 +0000 (11:43 +0100)]
Fix for closing sdc splashscreen.

After loading, the SDC splashscreen will now disappear after a total of 4 seconds.

Issue-ID: SDC-2258
Change-Id: I16629b2cf90f6cca0469ceb506128dabfc1ea3e1
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
4 years agoUpdate release notes 15/96515/1
Ofir Sonsino [Wed, 2 Oct 2019 15:27:04 +0000 (18:27 +0300)]
Update release notes

Change-Id: I4ea66e1bef928bb4d43d23e063d9af1c44aa1e8d
Issue-ID: SDC-2569
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agonpm registry fix 94/95894/1
Ofir Sonsino [Wed, 18 Sep 2019 07:32:39 +0000 (10:32 +0300)]
npm registry fix

Change-Id: I6e4b866c118b0c11518a0aff6fce59956b123013
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoBump SDC version 1.5.2 15/95315/1
Ofir Sonsino [Tue, 10 Sep 2019 07:52:13 +0000 (10:52 +0300)]
Bump SDC version 1.5.2

Change-Id: Ib672dc8d60a0b6f4b37fd94afe84bc27dfba4c44
Issue-ID: SDC-2560
Signed-off-by: Ofir Sonsino <os0695@intl.att.com>
4 years agoUpdated the sdc cert for ONAP namespace in the kubernetes. 40/95240/2
k.kedron [Mon, 9 Sep 2019 14:40:21 +0000 (16:40 +0200)]
Updated the sdc cert for ONAP namespace in the kubernetes.

Issue-ID: SDC-2539
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I4dba563d5dd8b041a2a61076a9ccbabcc4d22316

4 years agofix a nested node type issue 64/94064/11
Liang Ding [Thu, 22 Aug 2019 04:58:54 +0000 (21:58 -0700)]
fix a nested node type issue

the newly added node type is considered as nested
when substitution_mapping is enabled in TOSCA yaml file

Change-Id: Ibdee29d7a553c7b1ce085cbe971ceace6c4488f5
Issue-ID: SDC-2282
Signed-off-by: Liang Ding <liang.ding@intel.com>
4 years agoRevert "Basic authorization for unsecured endpoint" 24/95124/1
andre.schmid [Fri, 6 Sep 2019 09:45:03 +0000 (09:45 +0000)]
Revert "Basic authorization for unsecured endpoint"

This reverts commit 34e04405

Change-Id: I6e27ce2d04b50417c3b0c9e5da217cbc57f8d277
Issue-ID: SDC-2556
Signed-off-by: andre.schmid <andre.schmid@est.tech>
4 years agoopenecomp-be code coverage increase 11/94911/2
Piotr Darosz [Wed, 4 Sep 2019 10:27:53 +0000 (12:27 +0200)]
openecomp-be code coverage increase

Add tests for classes in
sdc.vendorsoftwareproduct.types.schemagenerator package

Change-Id: Iabd22f88a5106c881ee687a4b57a62f59c0bc10e
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agocatalog-be code coverage increase 20/94920/5
Piotr Darosz [Wed, 4 Sep 2019 12:19:27 +0000 (14:19 +0200)]
catalog-be code coverage increase

Add tests for DistributionCatalogServlet class

Change-Id: I3da0460f09c803a0ec5a26bd2c7f70f36c6998a1
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agounit tests - catalog-model 26/94926/2
Tomasz Golabek [Wed, 4 Sep 2019 12:29:46 +0000 (14:29 +0200)]
unit tests - catalog-model

Coverage increasing

Change-Id: Idb7902578aca65eaee1a63871e9b84e3c4767233
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agounit tests - NetworkPackageHealer 16/94916/3
Tomasz Golabek [Wed, 4 Sep 2019 10:56:12 +0000 (12:56 +0200)]
unit tests - NetworkPackageHealer

Additional junit tests using mockito

Change-Id: I1a48d0dd15a3319dc096816ea36346f4b13322fc
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>
4 years agocommon code coverage increase 05/94905/2
Piotr Darosz [Wed, 4 Sep 2019 08:05:34 +0000 (10:05 +0200)]
common code coverage increase

Add tests for classes in sdc.tosca.datatypes.model package

Change-Id: Ifc277512d833b2501f0e594b9062d39c26565055
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agoopenecomp-be code coverage increase 84/94884/2
Piotr Darosz [Wed, 4 Sep 2019 07:11:35 +0000 (09:11 +0200)]
openecomp-be code coverage increase

Add tests for classes in openecomp.core.model.types package

Change-Id: I1c8044b2c8d422468dba610b2012e1cb34a75835
Issue-ID: SDC-2326
Signed-off-by: Piotr Darosz <piotr.darosz@nokia.com>
4 years agounit tests - openecomp-sdc 42/94842/2
Tomasz Golabek [Tue, 3 Sep 2019 14:08:37 +0000 (16:08 +0200)]
unit tests - openecomp-sdc

Additional junit tests mostly for pojos

Change-Id: I851d7df94b1e1c225d087b8881c3c1cd30867efb
Issue-ID: SDC-2326
Signed-off-by: Tomasz Golabek <tomasz.golabek@nokia.com>