Add sdc startup in IT

Rework the storage folder for extentReport and outputCsar so they not created outside the maven target folder

Issue-ID: SDC-3232
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ice1139ce141f4b8cf593cd9bdd68dc0ecf0453bf

Add sdc startup in IT

Rework the java packages so that we use onap now + fix the folders written outside of the target folder

Issue-ID: SDC-3232
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I23c2bad4bee6b766cfacc2c544e1431aed4cd608

Expose generic Service properties as properties

During the Service creation, the properties declared in the Generic
Service Type are being parsed to inputs, but not to properties.
The change parses the properties also to properties, keeping the
previous input logic.

Change-Id: I3ceba3adeaab56cd49fc8fbd657b02aa7c93e79b
Issue-ID: SDC-3061
Signed-off-by: andre.schmid <andre.schmid@est.tech>

Fix Error Updating VSP in Rresource Template for PNF

Issue-ID: SDC-3090
Signed-off-by: ajay_dp001 <ajay.deep.singh@est.tech>
Change-Id: I3389a9a942c74f41ed037b9f13498b9cf999d441

Add sdc startup in IT

Move the Api tests code in the integration-test module, and remove the need to have a container

Issue-ID: SDC-3232
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ia2b5d94d958e975867c600597ab5e56dffcd06ab
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

Add sdc startup in IT

Add the SDC startup for IT tests

Issue-ID: SDC-3232
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I865eabfb6c61f26f98ee12906de09f1a8daa469a
Signed-off-by: sebdet <sebastien.determe@intl.att.com>

SDC changes for adding helm

Issue-ID: REQ-341

Signed-off-by: Sithara Nambiar <sitharav.aredath@huawei.com>
Change-Id: I4721f6e8e2690dc5f7c10bb7b1b2f53ec5f318c7

Fix release note and doc

doc issue identified, some index are wrong
not only the release note, I noticed other ones

Issue-ID: SDC-3221
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I0f062295211442233d2bb2f52f1930f8421955b1

Java 11 Migration work for 'openecomp-sdc-translator-core'

- Replaced Corn CPS with ClassGraph

Issue-ID: SDC-3029
Signed-off-by: Chris Andre <chris.andre@yoppworks.com>
Change-Id: I3002f3aa01a647d6ab2f4c32c399833034241800

Fix policy element type

CSAR onboarding phase: policy element type fixed
from map to list according TOSCA format documentation.

Change-Id: I654f4b049a8f5129938a5d5f8307e105e2bed024
Issue-ID: SDC-3152
Signed-off-by: Dmitry Puzikov <d.puzikov2@partner.samsung.com>

Fix workflow designer issue

Fix the issue so that the workflow bpmn will be packed into csar again.

Issue-ID: SDC-3181
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I5f8ca112fe1bd2a7abf1529f491400237d88ce56

Revert "Refactor CsarUtils::addInnerComponentsToCSAR"

This reverts commit f4165e2af8ae596d574aecae2fcf174420396b2e.

Reason for revert: This PR has broken the API tests and the csar generation (csar.meta) is not present anymore. Therefore some components may not be able to open the CSAR with the sdc-tosca libraries
We must rollback for now, until a fix is provided

Change-Id: I3af8b9f08dd28b6abdb4df9acdcf9ab2623d10e5
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Issue-ID: SDC-3225

Add substitution filter UI support

Issue-ID: SDC-3195
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Idc6301a1ab7442f8d2d59931abf0a0741cc8e410

Add component unique id to plugin context view

Issue-ID: SDC-3224
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ib65bbc13766e2ae794ff26c41ee4f94770a362ee

Remove needless Getter/Setter testing

Change-Id: I4802e15a57b01d520e875db295df2eb826b6b5c0
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-2708

Fix broken UI & API tests

Due to issues in the log4j files, the tests can't be started and crash

Issue-ID: SDC-3223
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I77909d98c716a8a232f5cc8ae8baddebb4ee581f

Update css file name in conf.py

ribbon.css is the correct name of the css file.

Issue-ID: CIMAN-376
Signed-off-by: Jessica Wagantall <jwagantall@linuxfoundation.org>
Change-Id: I29b22c8abb88c055ff40b64599498c5fc3bfe8dd

Fix broken transitive dependency

Change-Id: I8890eeca62826ee36bac43709761079acf21f235
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3218

Upgrade Vulnerable Direct Dependencies [log4j]

Signed-off-by: amohamad <a.mohamad@queensu.ca>
Issue-ID: SDC-3051

Upgrade from the  vulnerable log4j 1.x to log4j 2.13.1

Add a log4j version property in  sdc-main pom.xml

Add two maven dependencies to respective child pom.xml

Change name of log4j .properties and .xml config files
to reflect log4j2 naming

Update the configuration files to the totally new
log4j 2 config syntax

Replace PropertyConfigurator with LoggerContext

Remove the abandoned log4j.lf5.util.ResourceUtils

Signed-off-by: amohamad <a.mohamad@queensu.ca>
Change-Id: Ie0f141eb2e0337ee5b63b61dc1395ccd8040558d

Optimization in git clone using --depth

optimize the git clone using --depth flag in term of size of clone
and also in term's of time taken to fetch the files and commit history
of whole repository .

More detail can be found at blog
https://www.atlassian.com/git/tutorials/big-repositories

Issue-ID: SDC-3089
Signed-off-by: Pratik Raj <rajpratik71@gmail.com>
Change-Id: Ib806bf0c172bd304abe9a138e2f85fcf14e07675

Improve Utils coverage and improve Sonar score

Issue-ID: SDC-3131
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I784a0ad563141dfb546ec1d227b3eb03e08faef3

Config. allowed instances in component composition

During the creation of Resource and Services components,
the allowed types to add in its composition are hard-coded.
This change allows those types to be configurable using the
configuration.yaml backend file.

Change-Id: If48849b57fe5124468db3d55f2f06391348935fb
Issue-ID: SDC-3177
Signed-off-by: andre.schmid <andre.schmid@est.tech>

Release Master 1.7.0

Release first draft Master Guilin 1.7.0

Issue-ID: SDC-3220
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ic99b1f57ab3375e3bfa05f743216870ad82ef103

Update Release Note

Update Release note for Frankfurt Maintenance release

Issue-ID: SDC-3189
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I5b0fb24938646b1ef4344449301caf056bd8cac4

Fix CRITICAL BUG

https://sonarcloud.io/project/issues?fileUuids=AXF_8JZ3aPDFCRVJURGa&id=onap_sdc&resolved=false&types=BUG

Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3204
Change-Id: I55f1c6c95c4de59d9ca5493d99c7fd3569379622

Update INFO.yaml

Update committer list as per : https://lists.onap.org/g/onap-tsc/topic/75373026#6714

Issue-ID: SDC-3203
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: Ida7f9a6a36fe0cbc8f3c3f7fae0693e9e0bc9320

Align onap/base_sdc-xyz versions

Change-Id: Ic2e53bb76b0b6bc54de3336f5e5916eba189fe18
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3201

Fix missing referenced node_types

Issue-ID: SDC-3153
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: I0b17ac92a49e1f006f5708b20af82a62ee769a9e

Refactor CsarUtils::addInnerComponentsToCSAR

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I4f9a52950d4d6ffadf9a5cb170c99d229ac83a35
Issue-ID: SDC-2812

Add substitution_filter endpoints unit tests

Issue-ID: SDC-3166
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ie01f7abc5eccc36e8f1159cbece329a7fadeacd5

Add endpoints for supporting substitution_filter

Issue-ID: SDC-3160
Change-Id: Ibc722f283451fecde7655e867654880ae50cc645
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>

Add substitution_filter business logic unit tests

Issue-ID: SDC-3165
Change-Id: I91f3075c43d04add450c16614b07f08219ad743d
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>

Clean ValidatorExecutor hierarchy

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I9d919b1d57eac1d25c8b3874366c2cb9e906923a
Issue-ID: SDC-2499

Add support for substitution_filter business logic

Tosca simple YAML profile allows for
substitution_filter to be specified for
a topology template to provide processing
instructions to the orchestrator.

Issue-ID: SDC-3147
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: Ia94b8c447d3157e614f9d1524ad4520b3980ba4d

Add test contracts for ValidatorExecutor and TopologyTemplateValidatorExecutor

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I10f0de565588e0bc7cd0f47ba7f714eab3f1f7f7
Issue-ID: SDC-2499

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I33638b39d39b7e918437cb9f3e0f15d52fa92218

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I004b0f579ff1f273f39a155217972f5efcdcf5cb

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ib6ee78fd5756d615c2a103ac0d7d26070fd24206

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Change-Id: Ic29f9233838e25c195d2b349bfac8e6d56888609
Signed-off-by: sebdet <sebastien.determe@intl.att.com>

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3158
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I0ae188c5f0e2d96fd94de66fe0dcd0c47bcd9af5

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3116
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: Ic29f9233838e15b195d1a339bfac8e6d56888609

Clean CsarUtils::MainYamlWithDependencies

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I593dd7bb6a20445899a14da793e8c550e1e14e09
Issue-ID: SDC-2812

Refactor MapDataDefinitionTest

Adding more tests and adding assert for old tests.

Issue-ID: SDC-3146
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I0b3ebb3d46b26ecdf52c78ee29b2777f6ecc73e5
Signed-off-by: xuegao <xg353y@intl.att.com>

Fix typo in package name and classes

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I55a6efeb4a0c2b4734dc3a091afbc6295599c74b
Issue-ID: SDC-2499

Fix issue introduced by #109494

use maven checkstyle.skip
remove duplicated dependency

Change-Id: I942a9612df7093206d0019d69a8f28c6dff7bcf6
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3148

Fix test coverage drop introduced by #109510

Change-Id: Ic74f11f60ff7673330a8c3521da49a92f70ae0fb
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3149

Fix for NullPointerException while onboarding VF

Issue-ID: SDC-3161
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>
Change-Id: I6eefcb86c6ef97fb19449e1fc45cee3cb91b3a2a

Rationalize maven dependencies

Issue-ID: SDC-3149
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I1ee42494a4cc5b185b6dfcbee44399d2960cf880

Cleaned up ArtifactValidatorExecuter and IArtifactValidatorExecutor

This commit intends to clean the tests related to ArtifactValidatorExecuter and IArtifactValidatorExecutor by introducing the concept of test contract. Some renaming have to be done to fix the typo in Executer (it should be named Executor), hence the number of changes.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I5cd4512c425ae01f4f1118c9d61e6fce3df94f1d
Issue-ID: SDC-2499

add a new profil for fast build

Issue-ID: SDC-3148
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: Ie98194fe6d136f57491a0590ab2afc9db59fbfbd

Fix Security Vulnerability

Fix Sonar Major by switching to better protocol

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I9f5d8640c991ae895a41dadf67a11872952fe38a

Fix Assert

Fix Sonar Asserts

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I92dcd21a3cec903792c20275be8b955c5910e566

Fix for name clash in csar generation

Issue-ID: SDC-3144
Change-Id: Ia9b66bb14bbff3add70eed8dfe41acc55c72b35b
Signed-off-by: KrupaNagabhushan <krupa.nagabhushan@est.tech>

Improvement sdc-BE-init python scripts

- Implemented retries when request fail
- Moved configuration variables to the Properties file
- Extended sdcBeProxy
- Implemented script to run import/update (should fix deployment glitch)
- Updated the import_Normatives recipes to use new script

Issue-ID: SDC-2784
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I83fab898783ad8d3b3d532af43d75bc54d033c33

Refactoring the check backend, create consumers

Continue refactoring:
- added script for healthCheck, create new consumers
- also update chef recipes to use new script

Issue-ID: SDC-2784
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I158d816362f91f74b217fe85112cf7c14da8f1ec

Add Node Filter Business Logic Unit Tests

Issue-ID: SDC-3125
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I80c755f4fffa813396ceb85c6aa7fde5b32590cd

Refactoring the sdc-BE-init python scripts

Deeper refactoring of python script:
- create the python package with init script
- support for python 3.x
- reuse code
- new design
- support for .json conf file
- update the docker chef script

Issue-ID: SDC-2784
Signed-off-by: Krystian Kedron <k.kedron@partner.samsung.com>
Change-Id: I02169eb7d0e3e90851ba1811536d1712c3b4145f

Decouple TXT Report file writing and formatting logic (6/6)

This commit moves the writeReportLineToFile from ReportManager to ReportFile, deletes ReportManager (as it's not longer used), and finalizes the decoupling between the writing and the formatting logic of the TXT Report file.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ia5cce71535ea808e6e24807ed62ae9b262eab6ad
Issue-ID: SDC-2499

Decouple TXT Report file writing and formatting logic (5/6)

This commit aims to move the reportEndOfToolRun function from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I17731864c34ed9a70b1b1e91b89bad835dc72449
Issue-ID: SDC-2499

Improve test coverage

Adding more tests to improve test coverage.

Issue-ID: SDC-3129
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I23a717bfb6a0004e58ff3ca37d6dd877a956931e
Signed-off-by: xuegao <xg353y@intl.att.com>

Refactor ToscaTypeTest

Adding more tests and adding assert for old tests.

Issue-ID: SDC-3143
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: Id7cf5ec763b0d43dece9493613e336a4b3df9b72
Signed-off-by: xuegao <xg353y@intl.att.com>

Decouple TXT Report file writing and formatting logic (4/6)

This commit aims to move the reportValidatorTypeSummary function from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I30898d69bbcdb129a2dac917c4dee3c276556e91
Issue-ID: SDC-2499

Decouple TXT Report file writing and formatting logic (3/6)

This commit aims to move the printValidationTaskStatus function's logic from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ic33a519f4c70276d404a83bf7de8a27f0007b285
Issue-ID: SDC-2499

Improve ActionUtil coverage and improve Sonar score

Issue-ID: SDC-3133
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I5e6f927599520efa5bfa5856863ca173ecdfb553
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

Toggle

Add toggling mechanism to catalog side.
The first toggleable feature is healing - this was added to healing flow, in healJanusGraphDao

Issue-ID: SDC-2874
Signed-off-by: talio <talio@amdocs.com>
Change-Id: If386651cab8304ebaf13497ded3a7a50bd60e477
Signed-off-by: talio <talio@amdocs.com>

Add Node Filter Servlets Unit Tests

Issue-ID: SDC-3117
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>
Change-Id: I84e728f21290a59c7674f97d5977b945b93ef546

Add Support for node_filters

Allows for node_filter to be specified for a node template
to provide processing instructions to the orchestrator

Issue-ID: SDC-3095
Change-Id: I4e496e300552049d9bfd00df878b86d9fb97312b
Signed-off-by: aribeiro <anderson.ribeiro@est.tech>

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3116
Change-Id: I87802cc9edb378bdbe456c3ca4f10d8c6ebe9425
Signed-off-by: sebdet <sebastien.determe@intl.att.com>

Fix sonar issues

Fix sonar/checkstyle issues in sdc code

Issue-ID: SDC-3116
Signed-off-by: sebdet <sebastien.determe@intl.att.com>
Change-Id: I87802bb9edb378bdbe456c3ca4f10d8c6dae9437

Decouple TXT Report file writing and formatting logic (2/6)

This commit aims to move the reportStartValidatorRun function's logic from ReportManager (deprecated) to ReportFile.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I93c2e8f98cdef598094647d734d0deec0f1941db
Issue-ID: SDC-2499

Fix Assert usage

Sonar Fix, fix assert usage in this file

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I292649e84e589a35eb69139de53b3ee95223be26

fix sonar issues related to MessageContainer.java

Issue-ID: SDC-3127
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I02357fa3cbf7afd7845737ba01c72dc202401882
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

Remove duplicate code

Removing duplicate code.

Issue-ID: SDC-3132
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I595a791ebd7cb160d7149ea92a6434d52cfc9f48

Remove unused method

Removing unused method in Constraint and use lombok annotations instead.

Issue-ID: SDC-3130
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: Ia718d184c55d40503f42830966bb11675b7c3f85
Signed-off-by: xuegao <xg353y@intl.att.com>

Fix Vulnerabilities

Fix the vulnerabilities reported by Sonar.

Issue-ID: SDC-3114
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: Icf97e427ef0c192b2f279380d7ee9eb570949d1f
Signed-off-by: xuegao <xg353y@intl.att.com>

Fix Sonar issues

Assert params updated to be in correct order

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I8be2dec4a1d5ec9ab59ea8fddab540958fe25511

Fix Sonar issues

Assert params updated to be in correct order

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I10168defa289e45102f7f8aa436db8ca7176fe6a

Fix Sonar issues

Fix assertThat usage and tests

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: Ife533a479096047c4ccb7ae46dfaaa6e2ece974d

improve test coverage

Issue-ID: SDC-3120
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>
Change-Id: I8e02fcb3f495d70c14e6e9cf0304085d77918805

Decouple TXT Report file writing and formatting logic (1/6)

This commit is the first of a series aiming to decouple the writing and formatting logic of text report files in the asdc tool. Unfortunately because of a significant amount of technical debt, a small hack had to be done so that the header of the file is not written twice. This will be removed in a future change.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I8d2a7c1353d59562d8026088824c26ae0daa36e9
Issue-ID: SDC-2499

Fix more doc warnings

Fix couple of doc warnings

Issue-ID: SDC-1357
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I3c195ab8d9caacce7dde5d8e9631a0fb7c2ea25a

datatypes.Constants:
  - adhere to naming conventions
  - remove unused

Issue-ID: SDC-3126
Change-Id: I4ea23a8c69aaaf8fcc404868d3c59c47d09ba442
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

Importing VSP with node_type in separate file

Import fails when a node_type referenced in the main template is defined in a separate yaml file in the csar even when that separate file is correctly imported in the main template

Change-Id: I6abe074585c2ce592fe9bed7abe76f0856bcfe93
Issue-ID: SDC-2850
Signed-off-by: MichaelMorris <michael.morris@est.tech>

create tests for ScalarUnitValidator.java

Issue-ID: SDC-3123
Change-Id: Iaa60ce2df46ee7a4d9138a56cf4d4c115a059240
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

create tests for PropertyTypeExt.java and remove unsused method

Issue-ID: SDC-3124
Change-Id: I5d3baeeff23c0003952eabc39a5f9dd296dd7c39
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

Decouple CSV Report file writing and formatting logic

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I6168b71bb54192a806ff6aa437788bedad933c76
Issue-ID: SDC-2499

Fix Java Code Conventions non-compliance issues

Update locations of the constructor and private variable to comply with the Java Code Conventions.

Issue-ID: SDC-3121
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I0114c880e389f0ed167262c9cd513583be35ba56
Signed-off-by: xuegao <xg353y@intl.att.com>

Reduce nest statement levels

Reduce the if/for/switch/try nest statement levels to less than 3.

Issue-ID: SDC-3119
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I60f0c0203db4495c6e10127114acdb8586867b14
Signed-off-by: xuegao <xg353y@intl.att.com>

Refactor ArtifactsBusinessLogic::getUpdatedGroupInstances

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: I6d62c1f916aa820f84328d25d2afbc7470397b0d
Issue-ID: SDC-2961

Reduce nest statement levels

Reduce the if/for/switch/try nest statement levels to less than 3.

Issue-ID: SDC-3118
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I490e66a807a0a8508b7e3c1da332546f2ced3005

Extract ComponentCache from CsarUtils

This commit aims to decouple the component caching logic from CsarUtils to its own class.

Signed-off-by: Francis Toth <francis.toth@yoppworks.com>
Change-Id: Ia7e9284639ec8cd87ca5107e12f295e2eb599768
Issue-ID: SDC-2812

Support the substitution_mappings in the VNFD

Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-2957
Change-Id: I8a385b02568b3bf3d83a250cbe36a7e7f61e710c

Fix Sonar issues

Hide implicit public constructor in utility class

Issue-ID: SDC-3116
Signed-off-by: ChrisC <christophe.closset@intl.att.com>
Change-Id: I4edd2ac37aab2fd587b5d46391dd669181385748

add information on the containers based on what is available in the wiki

Issue-ID: SDC-2449
Change-Id: I740a14623161e051399f03d1788ae8a2605c1076
Signed-off-by: JulienBe <julien.bertozzi@intl.att.com>

Manifest is optional in ETSI SOL004 manifest

SOL004MetaDirectoryValidtor enforces all files contained in an ETSI SOL004 CSAR are included in the manifest file, however the manifest itself is not mandatory to include in the manifest

Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-3057
Change-Id: I460071ecbd21578edb0603f600da0ac1ea877539

Add some unit tests

This change added some unit tests for ComponentInstanceBusinessLogic
to increase test coverage and removed unused variables for better
readability.
Also the test class was rewritten to use JUnit 5.

Change-Id: I519976d00d8eccc194f8f1168d45f95392808652
Signed-off-by: Satoshi Fujii <fujii-satoshi@jp.fujitsu.com>
Issue-ID: SDC-2885

Onboard TOSCA data_types defined in package

Onboard TOSCA data_types defined in a CSAR package
that does not exists in the SDC default data_types
library. Those data_types were being lost.
All data_types declared in the package will be
included in the "GlobalSubstitutionServiceTemplate".
This includes the data_types declared in the main
topology template and in its imported definition
files.
Defines a maven profile to compile the catalog-be
in the main SDC pom.

Change-Id: I39445b0f42e924dc1015945b7e605e804c1d505b
Issue-ID: SDC-2763
Signed-off-by: André Schmid <andre.schmid@est.tech>
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>

Fix 'not running Junit5 tests'-issue

Change-Id: Iee67a4af7262e554a86252b411264f55ff1baa88
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3109

Fix Critical security vulnerability

com.fasterxml.jackson.core : jackson-databind : 2.9.9

Change-Id: I81af7879cb1fbcd158177a3dc220b704ff2f3388
Signed-off-by: Vasyl Razinkov <vasyl.razinkov@est.tech>
Issue-ID: SDC-3111

Fix bug in UpdateIsVnfMenu

Fix the unboxing bug reported by Sonar.

Issue-ID: SDC-3112
Signed-off-by: xuegao <xg353y@intl.att.com>
Change-Id: I4ed3f9a48ad21af2f9f67872791df2796c4e4ad1