Fix error updating milestone 14/136114/3
authorMichaelMorris <michael.morris@est.tech>
Sun, 8 Oct 2023 14:09:11 +0000 (15:09 +0100)
committerVasyl Razinkov <vasyl.razinkov@est.tech>
Mon, 9 Oct 2023 09:59:54 +0000 (09:59 +0000)
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-4648
Change-Id: Iff21ecf1e0b999301baf6b7a2c26218fee8856da

catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/ComponentInterfaceOperationBusinessLogic.java
catalog-be/src/test/java/org/openecomp/sdc/be/components/impl/ComponentInterfaceOperationBusinessLogicTest.java

index a10bae9..32fdffe 100644 (file)
@@ -140,7 +140,7 @@ public class ComponentInterfaceOperationBusinessLogic extends BaseBusinessLogic
         final OperationDataDefinition updatedOperationDataDefinition = optionalOperationDataDefinition.get();
         final Optional<ComponentInstanceInterface> optionalComponentInstanceInterface = componentInstanceInterfaceList.stream().filter(
                 ci -> ci.getOperations().values().stream().anyMatch(
-                    operationDataDefinition -> operationDataDefinition.getUniqueId().equalsIgnoreCase(updatedOperationDataDefinition.getUniqueId())))
+                    operationDataDefinition -> operationDataDefinition.getName().equalsIgnoreCase(updatedOperationDataDefinition.getName())))
             .findFirst();
         if (optionalComponentInstanceInterface.isEmpty()) {
             responseFormat = componentsUtils.getResponseFormat(ActionStatus.INTERFACE_NOT_FOUND_IN_COMPONENT);
index 1dd7f40..42cf3f2 100644 (file)
@@ -133,6 +133,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
         artifactDataDefinition.setArtifactName("EO Implementation info");
         operationDataDefinition.setImplementation(artifactDataDefinition);
@@ -180,6 +181,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
         final ListDataDefinition<OperationInputDefinition> inputsDefinitionListData = new ListDataDefinition<>();
         OperationInputDefinition input1 = new OperationInputDefinition();
@@ -238,6 +240,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
         final ListDataDefinition<OperationInputDefinition> inputsDefinitionListData = new ListDataDefinition<>();
         OperationInputDefinition input1 = new OperationInputDefinition();
@@ -299,6 +302,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
 
         artifactDataDefinition.setArtifactName("EO Implementation info");
@@ -364,6 +368,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
 
         artifactDataDefinition.setArtifactName("EO Implementation info");
@@ -429,6 +434,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
         artifactDataDefinition.setArtifactName("EO Implementation info");
         operationDataDefinition.setImplementation(artifactDataDefinition);
@@ -468,6 +474,7 @@ class ComponentInterfaceOperationBusinessLogicTest extends BaseBusinessLogicMock
         final Map<String, OperationDataDefinition> operations = new HashMap<>();
         final OperationDataDefinition operationDataDefinition = new OperationDataDefinition();
         operationDataDefinition.setUniqueId(UUID.randomUUID().toString());
+        operationDataDefinition.setName("myOperationName");
         final ArtifactDataDefinition artifactDataDefinition = new ArtifactDataDefinition();
         artifactDataDefinition.setArtifactName("EO Implementation info");
         operationDataDefinition.setImplementation(artifactDataDefinition);