Fix bottleneck on simulator requests 37/127237/2
authorandre.schmid <andre.schmid@est.tech>
Tue, 22 Feb 2022 13:50:12 +0000 (13:50 +0000)
committerandre.schmid <andre.schmid@est.tech>
Tue, 22 Feb 2022 19:57:35 +0000 (19:57 +0000)
Removes unnecessary synchronized in one of the simulator methods,
which almost all calls pass through. This was restricting to execute
calls in parallel.

Change-Id: I7c53eee951c02031b78adacdc292aa51e6e66186
Issue-ID: SDC-3885
Signed-off-by: andre.schmid <andre.schmid@est.tech>
integration-tests/src/test/java/org/onap/sdc/frontend/ci/tests/pages/component/workspace/InterfaceDefinitionOperationsModal.java
utils/webseal-simulator/src/main/java/org/openecomp/sdc/webseal/simulator/SdcProxy.java

index cb2ee3d..c8af405 100644 (file)
@@ -20,6 +20,7 @@
 package org.onap.sdc.frontend.ci.tests.pages.component.workspace;
 
 import com.aventstack.extentreports.Status;
+import java.time.Duration;
 import lombok.AllArgsConstructor;
 import lombok.Getter;
 import org.onap.sdc.frontend.ci.tests.execute.setup.ExtentTestActions;
@@ -27,6 +28,7 @@ import org.onap.sdc.frontend.ci.tests.pages.AbstractPageObject;
 import org.openqa.selenium.By;
 import org.openqa.selenium.WebDriver;
 import org.openqa.selenium.WebElement;
+import org.openqa.selenium.interactions.Actions;
 
 /**
  * Represents the Composition Interface Operations Modal.
@@ -67,6 +69,9 @@ public class InterfaceDefinitionOperationsModal extends AbstractPageObject {
         fillInputName(interfaceOperationsData.getInputName());
         fillInputValue(interfaceOperationsData.getInputValue());
         clickOnSave();
+        //there is no feedback from the UI to check if the update was successful. Forcing a wait time trying to guarantee that,
+        // although time is never a guarantee in this case.
+        new Actions(webDriver).pause(Duration.ofSeconds(5)).perform();
     }
 
     private void fillDescription(final String description) {
index 51d6796..0637f7e 100644 (file)
@@ -146,7 +146,7 @@ public class SdcProxy extends HttpServlet {
         proxy(request, response, MethodEnum.DELETE);
     }
 
-    private synchronized void proxy(HttpServletRequest request, HttpServletResponse response, MethodEnum methodEnum) throws IOException {
+    private void proxy(HttpServletRequest request, HttpServletResponse response, MethodEnum methodEnum) throws IOException {
 
         Map<String, String[]> requestParameters = request.getParameterMap();
         String userIdHeader = getUseridFromRequest(request);