Nested Dependency issues 71/46771/3
authorsiddharth0905 <siddharth.singh4@amdocs.com>
Wed, 9 May 2018 11:12:59 +0000 (16:42 +0530)
committersiddharth0905 <siddharth.singh4@amdocs.com>
Mon, 14 May 2018 11:43:24 +0000 (17:13 +0530)
Remove nested depends On connectivity

Change-Id: I65bd9473f879fa72b453c2793f2b2406adde4513
Issue-ID: SDC-1315
Signed-off-by: siddharth0905 <siddharth.singh4@amdocs.com>
27 files changed:
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/main/java/org/openecomp/sdc/translator/services/heattotosca/ConsolidationEntityType.java
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/main/java/org/openecomp/sdc/translator/services/heattotosca/ConsolidationTypesConnectivity.java
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/java/org/openecomp/sdc/translator/services/heattotosca/buildconsolidationdata/ConsolidationDataTestUtil.java
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/java/org/openecomp/sdc/translator/services/heattotosca/impl/resourcetranslation/ContrailV2VlanToInterfaceResourceConnectionTest.java
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/heat/nested/nested2levels/expectedoutputfiles/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/mixPatterns/connectivityBetweenPatterns/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/mixPatterns/dependencyConnectivity/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/mixPatterns/oneAppearancePerPattern/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/mixPatterns/twoAppearancePerPatternWithConnectivities/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/multiLevel/twoNestedLevelsWithAllPatternsAndConnectivities/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/oneLevel/nestedAllPatternsConnectivity/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedOtherScenarios/oneLevel/nestedTwoSameOneDiffWithConnectivity/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedSingleCompute/duplicateReqs/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedSingleCompute/multipleReferencesToSameNestedFilesWithSameComputeType/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedSingleCompute/nestedNodesConnectedIn/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedSingleCompute/nestedWithOneCompute/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/nestedSingleCompute/nestedWithOneComputeDiffPortType/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern1a/subInterfaceNodesConnectedIn/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern1a/subInterfaceNodesConnectedOut/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern1c1/allConnectivities/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern1c2/differentNodesConnectedOut/in/main.yml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern1c2/differentNodesConnectedOut/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern4/subInterfaceNodesConnectedIn/out/nested_pattern4ServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/pattern4/subInterfaceNodesConnectedOut/out/nested_pattern4ServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/fulltest/subinterface/vlantagging/vfcInstanceGroup/pattern4SubInterfaceNodesConnectedOut/out/nested_pattern4ServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/securityrulestoportconnection/securityRulesToPortGetResource/out/MainServiceTemplate.yaml
openecomp-be/lib/openecomp-sdc-translator-lib/openecomp-sdc-translator-core/src/test/resources/mock/services/heattotosca/subInterfaceToInterfaceConnection/inoutattr/expectedoutputfiles/MainServiceTemplate.yaml

index dd7825b..d4b8560 100644 (file)
@@ -20,88 +20,75 @@ import static org.openecomp.sdc.translator.services.heattotosca.ConsolidationDat
 import static org.openecomp.sdc.translator.services.heattotosca.ConsolidationDataUtil.isPortResource;
 import static org.openecomp.sdc.translator.services.heattotosca.ConsolidationDataUtil.isVolumeResource;
 
+import java.util.*;
+import java.util.stream.Collectors;
+
 import org.openecomp.sdc.heat.datatypes.model.Resource;
 import org.openecomp.sdc.translator.datatypes.heattotosca.TranslationContext;
 
-import java.util.Arrays;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.Set;
-import java.util.stream.Collectors;
-
 /**
  * The enum Entity type.
  */
 public enum ConsolidationEntityType {
-  COMPUTE,
-  PORT,
-  VOLUME,
-  NESTED,
-  //Simple nested VFC (nested file with one compute) or a complex VFC (nested ST with more than
-  //one compute)
-  VFC_NESTED,
-  SUB_INTERFACE,
-  OTHER;
+    COMPUTE, PORT, VOLUME, NESTED,
+    //Simple nested VFC (nested file with one compute) or a complex VFC (nested ST with more than
+    //one compute)
+    VFC_NESTED, SUB_INTERFACE, OTHER;
+
+    private ConsolidationEntityType sourceEntityType;
+    private ConsolidationEntityType targetEntityType;
+
+    public ConsolidationEntityType getSourceEntityType() {
+        return sourceEntityType;
+    }
 
-  private ConsolidationEntityType sourceEntityType;
-  private ConsolidationEntityType targetEntityType;
+    public ConsolidationEntityType getTargetEntityType() {
+        return targetEntityType;
+    }
 
-  public ConsolidationEntityType getSourceEntityType() {
-    return sourceEntityType;
-  }
 
-  public ConsolidationEntityType getTargetEntityType() {
-    return targetEntityType;
-  }
+    /**
+     * Sets entity type.
+     *
+     * @param sourceResource the source resource
+     * @param targetResource the target resource
+     */
+    public void setEntityType(Resource sourceResource, Resource targetResource, TranslationContext context) {
+        targetEntityType = getEntityType(targetResource, context);
+        sourceEntityType = getEntityType(sourceResource, context);
+    }
 
+    private static final Set<ConsolidationEntityType> consolidationEntityTypes = initConsolidationEntities();
 
-  /**
-   * Sets entity type.
-   *
-   * @param sourceResource          the source resource
-   * @param targetResource          the target resource
-   */
-  public void setEntityType(Resource sourceResource,
-                            Resource targetResource,
-                            TranslationContext context) {
-    targetEntityType =
-        getEntityType(targetResource, context);
-    sourceEntityType =
-        getEntityType(sourceResource, context);
-  }
+    private static Set<ConsolidationEntityType> initConsolidationEntities() {
+        return Collections.unmodifiableSet(EnumSet.allOf(ConsolidationEntityType.class).stream().filter(
+                consolidationEntityType -> consolidationEntityType != ConsolidationEntityType.OTHER
+                && consolidationEntityType != ConsolidationEntityType.VOLUME).collect(Collectors.toSet()));
+    }
 
-  private static final Set<ConsolidationEntityType> consolidationEntityTypes = initConsolidationEntities();
-  
-  private static Set<ConsolidationEntityType> initConsolidationEntities() {
-    Set<ConsolidationEntityType> consolidationEntityTypes = new HashSet<>(Arrays.asList(ConsolidationEntityType
-        .values()));
-    return Collections.unmodifiableSet(consolidationEntityTypes.stream()
-        .filter(entity -> entity != ConsolidationEntityType.OTHER
-            && entity != ConsolidationEntityType.VOLUME)
-        .collect(Collectors.toSet()));
-  }
+    public static Set<ConsolidationEntityType> getSupportedConsolidationEntities() {
+        return consolidationEntityTypes;
+    }
 
-  public static Set<ConsolidationEntityType> getSupportedConsolidationEntities() {
-    return consolidationEntityTypes;
-  }
+    private ConsolidationEntityType getEntityType(Resource resource, TranslationContext context) {
+        ConsolidationEntityType consolidationEntityType = ConsolidationEntityType.OTHER;
+        if (isComputeResource(resource)) {
+            consolidationEntityType = ConsolidationEntityType.COMPUTE;
+        } else if (isPortResource(resource)) {
+            consolidationEntityType = ConsolidationEntityType.PORT;
+        } else if (isVolumeResource(resource)) {
+            consolidationEntityType = ConsolidationEntityType.VOLUME;
+        } else if (HeatToToscaUtil.isNestedResource(resource)) {
+            if (HeatToToscaUtil.isNestedVfcResource(resource, context)) {
+                consolidationEntityType = ConsolidationEntityType.VFC_NESTED;
+            } else {
+                consolidationEntityType = ConsolidationEntityType.NESTED;
+            }
+        }
+        return consolidationEntityType;
+    }
 
-  private ConsolidationEntityType getEntityType(Resource resource, TranslationContext context) {
-    ConsolidationEntityType consolidationEntityType = ConsolidationEntityType.OTHER;
-    if (isComputeResource(resource)) {
-      consolidationEntityType = ConsolidationEntityType.COMPUTE;
-    } else if (isPortResource(resource)) {
-      consolidationEntityType = ConsolidationEntityType.PORT;
-    } else if (HeatToToscaUtil.isSubInterfaceResource(resource, context)) {
-      consolidationEntityType = ConsolidationEntityType.SUB_INTERFACE;
-    } else if (isVolumeResource(resource)) {
-      consolidationEntityType = ConsolidationEntityType.VOLUME;
-    } else if (HeatToToscaUtil.isNestedResource(resource)) {
-      if (HeatToToscaUtil.isNestedVfcResource(resource, context)) {
-        consolidationEntityType = ConsolidationEntityType.VFC_NESTED;
-      } else {
-        consolidationEntityType = ConsolidationEntityType.NESTED;
-      }
+    public static boolean isEntityTypeNested(ConsolidationEntityType entityType) {
+        return NESTED == entityType || VFC_NESTED == entityType;
     }
-    return consolidationEntityType;
-  }
 }
\ No newline at end of file
index 2edb4fb..7b258d6 100644 (file)
@@ -1,79 +1,39 @@
 package org.openecomp.sdc.translator.services.heattotosca;
 
-import org.apache.commons.collections.CollectionUtils;
-
-import java.util.EnumMap;
-import java.util.Map;
-import java.util.Set;
-import java.util.stream.Collectors;
-import java.util.stream.Stream;
+import com.google.common.collect.ImmutableSet;
+import com.google.common.collect.ImmutableSetMultimap;
+import com.google.common.collect.Multimap;
 
 public class ConsolidationTypesConnectivity {
 
-  private static Map<ConsolidationEntityType, Set<ConsolidationEntityType>>
-      entityToEntitiesWithoutRelationship = new EnumMap<>(ConsolidationEntityType.class);
-
-  static {
-    entityToEntitiesWithoutRelationship
-        .put(ConsolidationEntityType.COMPUTE, getIgnoredComputeRelationships());
-    entityToEntitiesWithoutRelationship
-        .put(ConsolidationEntityType.PORT,getIgnoredPortRelationships());
-    entityToEntitiesWithoutRelationship
-        .put(ConsolidationEntityType.VOLUME, getIgnoredVolumeRelationships());
-    entityToEntitiesWithoutRelationship
-        .put(ConsolidationEntityType.VFC_NESTED, getIgnoredVfcNestedRelationships());
-    entityToEntitiesWithoutRelationship
-        .put(ConsolidationEntityType.NESTED, getIgnoredNestedRelationships());
-  }
-
-  private ConsolidationTypesConnectivity() {
-  }
-
-  private static Set<ConsolidationEntityType> getIgnoredComputeRelationships(){
-    return Stream.of(ConsolidationEntityType.COMPUTE,
-        ConsolidationEntityType.VOLUME,
-        ConsolidationEntityType.PORT,
-        ConsolidationEntityType.NESTED,
-        ConsolidationEntityType.VFC_NESTED).collect(Collectors.toSet());
-  }
-
-  private static Set<ConsolidationEntityType> getIgnoredPortRelationships(){
-    return Stream.of(ConsolidationEntityType.COMPUTE,
-        ConsolidationEntityType.VOLUME,
-        ConsolidationEntityType.PORT,
-        ConsolidationEntityType.NESTED,
-        ConsolidationEntityType.VFC_NESTED).collect(Collectors.toSet());
-  }
-
-  private static Set<ConsolidationEntityType> getIgnoredVolumeRelationships(){
-    return Stream.of(ConsolidationEntityType.COMPUTE,
-        ConsolidationEntityType.VOLUME,
-        ConsolidationEntityType.PORT,
-        ConsolidationEntityType.NESTED,
-        ConsolidationEntityType.VFC_NESTED).collect(Collectors.toSet());
-  }
-
-  private static Set<ConsolidationEntityType> getIgnoredVfcNestedRelationships(){
-    return Stream.of(ConsolidationEntityType.COMPUTE,
-        ConsolidationEntityType.VOLUME,
-        ConsolidationEntityType.PORT,
-        ConsolidationEntityType.NESTED,
-        ConsolidationEntityType.VFC_NESTED).collect(Collectors.toSet());
-  }
-
-  private static Set<ConsolidationEntityType> getIgnoredNestedRelationships(){
-    return Stream.of(ConsolidationEntityType.COMPUTE,
-        ConsolidationEntityType.PORT,
-        ConsolidationEntityType.NESTED,
-        ConsolidationEntityType.VFC_NESTED).collect(Collectors.toSet());
-  }
-
-  public static boolean isDependsOnRelationshipValid(ConsolidationEntityType source,
-                                                     ConsolidationEntityType target) {
-    Set<ConsolidationEntityType> consolidationEntityTypes =
-        entityToEntitiesWithoutRelationship.get(source);
-    return CollectionUtils.isEmpty(consolidationEntityTypes) ||
-        !consolidationEntityTypes.contains(target);
-
-  }
+    private static Multimap<ConsolidationEntityType, ConsolidationEntityType> entityToEntitiesWithoutRelationship;
+    private static ImmutableSet<ConsolidationEntityType> consolidationEntityRelationNodes = ImmutableSet.of(
+            ConsolidationEntityType.COMPUTE, ConsolidationEntityType.VOLUME,
+            ConsolidationEntityType.PORT, ConsolidationEntityType.NESTED,
+            ConsolidationEntityType.VFC_NESTED);
+
+    static {
+        entityToEntitiesWithoutRelationship =
+                ImmutableSetMultimap.<ConsolidationEntityType, ConsolidationEntityType>builder()
+                        .putAll(ConsolidationEntityType.COMPUTE, consolidationEntityRelationNodes)
+                        .putAll(ConsolidationEntityType.PORT, consolidationEntityRelationNodes)
+                        .putAll(ConsolidationEntityType.VOLUME, consolidationEntityRelationNodes)
+                        .putAll(ConsolidationEntityType.VFC_NESTED, consolidationEntityRelationNodes)
+                        .putAll(ConsolidationEntityType.NESTED, consolidationEntityRelationNodes)
+                        .build();
+    }
+
+    private ConsolidationTypesConnectivity() {
+    }
+
+    static boolean isDependsOnRelationshipValid(ConsolidationEntityType source, ConsolidationEntityType target) {
+        return !eitherSourceOrTargetIsNested(source, target)
+                       && (!entityToEntitiesWithoutRelationship.containsKey(source)
+                                   || !entityToEntitiesWithoutRelationship.containsEntry(source, target));
+    }
+
+    private static boolean eitherSourceOrTargetIsNested(ConsolidationEntityType source,
+                                                               ConsolidationEntityType target) {
+        return ConsolidationEntityType.isEntityTypeNested(source) || ConsolidationEntityType.isEntityTypeNested(target);
+    }
 }
index 5c7bc20..b32e30e 100644 (file)
@@ -808,7 +808,6 @@ public class ConsolidationDataTestUtil {
           nestedTemplateConsolidationData.getNodesConnectedIn();
       List<String> dependentNodes = new LinkedList<>();
       dependentNodes.add("packet_mirror_network");
-      validateNestedNodesConnectedInDependency(nodesConnectedIn, nestedNodeTemplateId, dependentNodes);
 
       //Validate get attribute in
       Map<String, List<GetAttrFuncData>> nodesGetAttrIn =
@@ -852,7 +851,6 @@ public class ConsolidationDataTestUtil {
               nestedTemplateConsolidationData.getNodesConnectedIn();
           List<String> dependentNodes = new LinkedList<>();
           dependentNodes.add("packet_mirror_network");
-          validateNestedNodesConnectedInDependency(nodesConnectedIn, nestedNodeTemplateId, dependentNodes);
         } else {
           Assert.assertNull(nestedTemplateConsolidationData.getNodesConnectedIn());
         }
@@ -920,7 +918,6 @@ public class ConsolidationDataTestUtil {
           nestedTemplateConsolidationData.getNodesConnectedIn();
       List<String> dependentNodes = new LinkedList<>();
       dependentNodes.add("packet_mirror_network");
-      validateNestedNodesConnectedInDependency(nodesConnectedIn, nestedNodeTemplateId, dependentNodes);
       //Validate output parameter get attribute in
       List<GetAttrFuncData> getAttrFuncData =
           nestedTemplateConsolidationData.getNodesGetAttrIn().get("packet_mirror_network");
index 564cddb..4a0615d 100644 (file)
@@ -92,9 +92,6 @@ public class ContrailV2VlanToInterfaceResourceConnectionTest extends BaseResourc
     SubInterfaceTemplateConsolidationData data = subInfList.get(0);
 
     Assert.assertEquals(NETWORK_ROLE_INOUT_ATTR_TEST, data.getNetworkRole());
-    Assert.assertEquals(ONE, data.getNodesConnectedIn().size());
-    Assert.assertEquals(ONE, data.getNodesConnectedOut().size());
-    Assert.assertEquals(TWO, data.getNodesConnectedOut().get("control_int_net").size());
     Assert.assertEquals(ONE, data.getNodesGetAttrIn().size());
     Assert.assertEquals(ONE, data.getNodesGetAttrOut().size());
     Assert.assertEquals(ONE, data.getOutputParametersGetAttrIn().size());
index 3c41ae0..132cbda 100644 (file)
@@ -73,11 +73,6 @@ topology_template:
           - output_attr_1
         network_name:
           get_input: jsa_net_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested
-          relationship: tosca.relationships.DependsOn
     jsa_security_group1:
       type: org.openecomp.resource.vfc.rules.nodes.heat.network.neutron.SecurityRules
       properties:
@@ -275,4 +270,4 @@ topology_template:
           Version 2.0 02-09-2016 (Authors: John Doe, user PROD)
       members:
       - packet_mirror_network
-      - test_nested
+      - test_nested
\ No newline at end of file
index b145938..76b05fb 100644 (file)
@@ -694,14 +694,6 @@ topology_template:
         network_name:
           get_input: net_name
       requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: nestedNoUnified
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: 4p_nested
-          relationship: tosca.relationships.DependsOn
       - dependency:
           capability: feature_1c2_catalog_instance_1c2_t1_port
           node: abstract_1c2_catalog_instance_1
index de39122..0556b0b 100644 (file)
@@ -623,14 +623,6 @@ topology_template:
         network_name:
           get_input: net_name
       requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: nestedNoNestedSingleComputePattern
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: 4p_nested
-          relationship: tosca.relationships.DependsOn
       - dependency:
           capability: feature_1c2_catalog_instance_1c2_t1_port
           node: abstract_1c2_catalog_instance_1
@@ -679,10 +671,6 @@ topology_template:
           capability: feature_a_single_1a_1a_t1_port
           node: abstract_a_single_1a
           relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: nestedWithNoNovaHadDependencyToIt
-          relationship: tosca.relationships.DependsOn
     abstract_a_single_1a:
       type: org.openecomp.resource.abstract.nodes.a_single_1a
       directives:
index 0930c15..9c5f7f8 100644 (file)
@@ -578,14 +578,6 @@ topology_template:
         network_name:
           get_input: net_name
       requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: nestedNoUnified
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: 4p_nested
-          relationship: tosca.relationships.DependsOn
       - dependency:
           capability: feature_1c2_catalog_instance_1c2_t1_port
           node: abstract_1c2_catalog_instance_1
index 58b33a4..6741c72 100644 (file)
@@ -1518,22 +1518,6 @@ topology_template:
         network_name:
           get_input: net_name
       requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: nestedNoUnified_1
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: nestedNoUnified_2
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: 4p_nested_1
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: 4p_nested_2
-          relationship: tosca.relationships.DependsOn
       - dependency:
           capability: feature_1c2_catalog_instance_1c201_port
           node: abstract_1c2_catalog_instance_1
index 8269732..e8dbc5a 100644 (file)
@@ -359,19 +359,6 @@ topology_template:
       properties:
         network_name:
           get_input: jsa_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_all_patterns
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_no_compute
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_pattern_4
-          relationship: tosca.relationships.DependsOn
     abstract_rd_server_1b:
       type: org.openecomp.resource.abstract.nodes.rd_server_1b
       directives:
index edb739a..6d45dc1 100644 (file)
@@ -27,19 +27,6 @@ topology_template:
       properties:
         network_name:
           get_input: jsa_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_all_patterns
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_no_compute
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_pattern_4
-          relationship: tosca.relationships.DependsOn
     test_nested_pattern_4:
       type: org.openecomp.resource.abstract.nodes.heat.pd_server
       directives:
@@ -106,4 +93,4 @@ topology_template:
       - dependsOn_network
       - test_nested_pattern_4
       - test_nested_no_compute
-      - test_nested_all_patterns
+      - test_nested_all_patterns
\ No newline at end of file
index 0c7dc7b..b1d5708 100644 (file)
@@ -40,19 +40,6 @@ topology_template:
       properties:
         network_name:
           get_input: jsa_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_same_file_1
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_same_file_2
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: test_nested_diff_file
-          relationship: tosca.relationships.DependsOn
     test_nested_diff_file:
       type: org.openecomp.resource.abstract.nodes.heat.nested-other-file-1B
       directives:
@@ -135,4 +122,4 @@ topology_template:
       - test_nested_same_file_1
       - test_nested_same_file_2
       - jsa_security_group1
-      - jsa_security_group2
+      - jsa_security_group2
\ No newline at end of file
index d63fd06..1f76f3e 100644 (file)
@@ -2290,10 +2290,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: cscf_internal_network_0
           relationship: tosca.relationships.network.LinksTo
-      - dependency_cscf_server_0:
-          capability: tosca.capabilities.Node
-          node: cscf_internal_network_0
-          relationship: tosca.relationships.DependsOn
     oam_oam_vip_1_port:
       type: org.openecomp.resource.cp.nodes.heat.network.neutron.Port
       properties:
@@ -2412,14 +2408,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: cscf_internal_dpdk_network_0
           relationship: tosca.relationships.network.LinksTo
-      - dependency_tdcore_server_0:
-          capability: tosca.capabilities.Node
-          node: cscf_internal_network_0
-          relationship: tosca.relationships.DependsOn
-      - dependency_tdcore_server_0:
-          capability: tosca.capabilities.Node
-          node: cscf_internal_dpdk_network_0
-          relationship: tosca.relationships.DependsOn
     lbd_ims_core_v6_vip_2_port:
       type: org.openecomp.resource.cp.nodes.heat.network.neutron.Port
       properties:
@@ -2750,14 +2738,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: cscf_internal_dpdk_network_0
           relationship: tosca.relationships.network.LinksTo
-      - dependency_tdcore_server_0:
-          capability: tosca.capabilities.Node
-          node: cscf_internal_network_0
-          relationship: tosca.relationships.DependsOn
-      - dependency_tdcore_server_0:
-          capability: tosca.capabilities.Node
-          node: cscf_internal_dpdk_network_0
-          relationship: tosca.relationships.DependsOn
     oam_volume_1:
       type: org.openecomp.resource.vfc.nodes.heat.cinder.Volume
       properties:
@@ -3503,10 +3483,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: cscf_internal_network_0
           relationship: tosca.relationships.network.LinksTo
-      - dependency_cscf_server_0:
-          capability: tosca.capabilities.Node
-          node: cscf_internal_network_0
-          relationship: tosca.relationships.DependsOn
     lbd_internal_dpdk_vip_1_port:
       type: org.openecomp.resource.cp.nodes.heat.network.neutron.Port
       properties:
@@ -4153,4 +4129,4 @@ topology_template:
                 get_input: vnf_name
         container_type: host
       targets:
-      - tdcore_zone_1_server_group_group
+      - tdcore_zone_1_server_group_group
\ No newline at end of file
index f0d049f..323bbb3 100644 (file)
@@ -2237,11 +2237,6 @@ topology_template:
           get_input: oam_net_id
         vson_vm_names:
         - get_input: vson_clm_name_0
-      requirements:
-      - dependency_vson_server_1:
-          capability: tosca.capabilities.Node
-          node: oam_net_security_group
-          relationship: tosca.relationships.DependsOn
     vson_mgt_group:
       type: org.openecomp.resource.abstract.nodes.heat.vson_vm_2
       directives:
@@ -3428,4 +3423,4 @@ topology_template:
       value: vson_dbs_volume_1
     vson_mon_server_group_id:
       description: ID of the Server Group intended for vSON MON instances.
-      value: UNSUPPORTED_RESOURCE_vson_mon_server_group
+      value: UNSUPPORTED_RESOURCE_vson_mon_server_group
\ No newline at end of file
index 788f1f0..dc10b5c 100644 (file)
@@ -479,10 +479,6 @@ topology_template:
         network_name:
           get_input: net_name
       requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: server_pcm_001
-          relationship: tosca.relationships.DependsOn
       - dependency:
           capability: feature_compute
           node: abstract_compute
@@ -643,4 +639,4 @@ topology_template:
         description: |
           Version 2.0 02-09-2016 (Authors: John Doe, user PROD)
       members:
-      - test_shared_node_connected_in_nested
+      - test_shared_node_connected_in_nested
\ No newline at end of file
index f26ec33..038dc88 100644 (file)
@@ -306,11 +306,6 @@ topology_template:
       properties:
         network_name:
           get_input: port_net_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: server_pcm_001
-          relationship: tosca.relationships.DependsOn
     abstract_compute:
       type: org.openecomp.resource.abstract.nodes.compute
       directives:
@@ -359,4 +354,4 @@ topology_template:
       members:
       - server_pcm_001
       - packet_mirror_network
-      - abstract_compute
+      - abstract_compute
\ No newline at end of file
index 91253ae..def85b6 100644 (file)
@@ -306,11 +306,6 @@ topology_template:
       properties:
         network_name:
           get_input: net_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: server_pcm_001
-          relationship: tosca.relationships.DependsOn
     compute_port_0:
       type: org.openecomp.resource.cp.nodes.heat.network.neutron.Port
       properties:
@@ -380,4 +375,4 @@ topology_template:
       - server_pcm_001
       - packet_mirror_network
       - compute_port_0
-      - abstract_compute
+      - abstract_compute
\ No newline at end of file
index eba062f..2b17893 100644 (file)
@@ -454,11 +454,6 @@ topology_template:
             params:
               VNF_NAME:
                 get_input: vnf_name
-      requirements:
-      - dependency:
-          capability: feature_vdbe_untr_x_subport_vdbe_vdbe_untr_1_port_nested
-          node: abstract_vdbe
-          relationship: tosca.relationships.DependsOn
     control_int_net:
       type: org.openecomp.resource.vl.nodes.heat.network.contrailV2.VirtualNetwork
       properties:
@@ -567,4 +562,4 @@ topology_template:
       members:
       - fabric_int_net
       - control_int_net
-      - abstract_vdbe
+      - abstract_vdbe
\ No newline at end of file
index d972079..5b190bf 100644 (file)
@@ -477,10 +477,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: control_int_net
           relationship: tosca.relationships.network.LinksTo
-      - dependency_vdbe_vdbe_untr_1_port_nested:
-          capability: tosca.capabilities.Node
-          node: control_int_net
-          relationship: tosca.relationships.DependsOn
   groups:
     main_group:
       type: org.openecomp.groups.heat.HeatStack
@@ -490,4 +486,4 @@ topology_template:
           Version 2.0 02-09-2016 (Authors: John Doe, user PROD)
       members:
       - control_int_net
-      - abstract_vdbe
+      - abstract_vdbe
\ No newline at end of file
index 1cbb297..9b01aa7 100644 (file)
@@ -454,11 +454,6 @@ topology_template:
             params:
               VNF_NAME:
                 get_input: vnf_name
-      requirements:
-      - dependency:
-          capability: feature_vdbe_untr_x_vlan1-Network-Role_vmi_subport_vdbe_vdbe_untr_1_port_vlan1
-          node: abstract_vdbe
-          relationship: tosca.relationships.DependsOn
     control_int_net:
       type: org.openecomp.resource.vl.nodes.heat.network.contrailV2.VirtualNetwork
       properties:
@@ -613,10 +608,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: control_int_net
           relationship: tosca.relationships.network.LinksTo
-      - dependency_vdbe_vdbe_untr_1_port_vlan1:
-          capability: tosca.capabilities.Node
-          node: control_int_net
-          relationship: tosca.relationships.DependsOn
   groups:
     main_group:
       type: org.openecomp.groups.heat.HeatStack
@@ -634,4 +625,4 @@ topology_template:
       value:
         get_attribute:
         - abstract_vdbe
-        - vdbe_vdbe_untr_1_port_vlan1_aap_address_mode
+        - vdbe_vdbe_untr_1_port_vlan1_aap_address_mode
\ No newline at end of file
index b2cc392..b4bd810 100644 (file)
@@ -763,7 +763,7 @@ topology_template:
           - pd_server_names
           - 0
         subinterface_nested_service_template_filter_count:
-        - 9
+        - 19
         vm_flavor_name:
           get_input: pd_flavor_name
         subinterface_nested_p1:
@@ -795,10 +795,6 @@ topology_template:
           - service_template_filter
           - index_value
       requirements:
-      - dependency_pd_server_pd01_port_nested:
-          capability: tosca.capabilities.Node
-          node: test_net2
-          relationship: tosca.relationships.DependsOn
       - subinterface_link_template_Vlan_vmi_1_pd_server_pd01_port_nested:
           capability: tosca.capabilities.network.Linkable
           node: test_net1
@@ -813,4 +809,4 @@ topology_template:
       - test_net2
       - test_net1
       - abstract_pd_server_0
-      - abstract_pd_server_1
+      - abstract_pd_server_1
\ No newline at end of file
index d307f6e..17f8e6b 100644 (file)
@@ -244,11 +244,6 @@ topology_template:
             params:
               VNF_NAME:
                 get_input: vnf_name
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: vdbe_untr_1_subports
-          relationship: tosca.relationships.DependsOn
     vdbe_untr_1_port:
       type: org.openecomp.resource.cp.nodes.heat.contrailV2.VirtualMachineInterface
       properties:
@@ -606,4 +601,4 @@ topology_template:
       - dependency
       dependency_vdbe_untr_1_subports:
       - vdbe_untr_1_subports
-      - dependency
+      - dependency
\ No newline at end of file
index bde17d0..0b9a7a2 100644 (file)
@@ -339,10 +339,6 @@ topology_template:
           capability: tosca.capabilities.network.Bindable
           node: vdbe_untr_1_port
           relationship: tosca.relationships.network.BindsTo
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: control_int_net
-          relationship: tosca.relationships.DependsOn
     control_int_net:
       type: org.openecomp.resource.vl.nodes.heat.network.contrailV2.VirtualNetwork
       properties:
@@ -559,4 +555,4 @@ topology_template:
       - dependency
       dependency_vdbe_untr_1_subports:
       - vdbe_untr_1_subports
-      - dependency
+      - dependency
\ No newline at end of file
index 17a2d85..668cdab 100644 (file)
@@ -339,10 +339,6 @@ topology_template:
           capability: tosca.capabilities.network.Bindable
           node: vdbe_0_untr_vmi_1
           relationship: tosca.relationships.network.BindsTo
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: control_int_net
-          relationship: tosca.relationships.DependsOn
     control_int_net:
       type: org.openecomp.resource.vl.nodes.heat.network.contrailV2.VirtualNetwork
       properties:
@@ -559,4 +555,4 @@ topology_template:
       - dependency
       dependency_vdbe_untr_1_subports:
       - vdbe_untr_1_subports
-      - dependency
+      - dependency
\ No newline at end of file
index 0222331..b97831a 100644 (file)
@@ -1323,26 +1323,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: packet_internal_network
           relationship: tosca.relationships.network.LinksTo
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: security_group
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
     vProbe:
       type: org.openecomp.resource.abstract.nodes.heat.FEAdd_On_Module_vProbeTemplate
       directives:
@@ -1425,26 +1405,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: packet_internal_network
           relationship: tosca.relationships.network.LinksTo
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: security_group
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
     packet_mirror_network:
       type: org.openecomp.resource.vl.nodes.heat.network.neutron.Net
       properties:
@@ -1648,27 +1608,6 @@ topology_template:
           get_input: qrouter_volume_size_2
         rpmrepository_ip_0:
           get_input: rpmrepository_ip_0
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: security_group
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
     vLB:
       type: org.openecomp.resource.abstract.nodes.heat.FEAdd_On_Module_vLBTemplate
       directives:
@@ -1746,26 +1685,6 @@ topology_template:
           capability: tosca.capabilities.network.Linkable
           node: packet_mirror_network
           relationship: tosca.relationships.network.LinksTo
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: security_group
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_mirror_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: packet_internal_network
-          relationship: tosca.relationships.DependsOn
   groups:
     FEBase_Module_group:
       type: org.openecomp.groups.heat.HeatStack
@@ -1778,4 +1697,4 @@ topology_template:
       - packet_internal_network
       - security_group
       - QRouter0
-      - vLB
+      - vLB
\ No newline at end of file
index 6464616..84a631b 100644 (file)
@@ -510,10 +510,6 @@ topology_template:
           capability: tosca.capabilities.network.Bindable
           node: vdbe_untr_vmi
           relationship: tosca.relationships.network.BindsTo
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: control_int_net
-          relationship: tosca.relationships.DependsOn
     control_int_net:
       type: org.openecomp.resource.vl.nodes.heat.network.contrailV2.VirtualNetwork
       properties:
@@ -527,11 +523,6 @@ topology_template:
           get_attribute:
           - vdbe_untr_1_subports
           - count
-      requirements:
-      - dependency:
-          capability: tosca.capabilities.Node
-          node: vdbe_untr_1_subports
-          relationship: tosca.relationships.DependsOn
   groups:
     main_group:
       type: org.openecomp.groups.heat.HeatStack