--- /dev/null
+<?xml version="1.0"?>
+<!--
+ ============LICENSE_START=======================================================
+ SDC
+ ================================================================================
+ Copyright (C) 2019 Nokia. All rights reserved.
+ ================================================================================
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ ============LICENSE_END=========================================================
+ -->
+
+<!DOCTYPE suppressions PUBLIC
+ "-//Checkstyle//DTD SuppressionFilter Configuration 1.0//EN"
+ "https://checkstyle.org/dtds/suppressions_1_0.dtd">
+<suppressions>
+ <suppress checks=".*" files="\.java" lines="1-20"/>
+ <suppress checks=".*" files="\.properties"/>
+ <suppress checks="javadoc" files="\.java"/>
+ <suppress checks="LineLength" files="\.java"/>
+ <suppress checks="HiddenField" files="\.java"/>
+ <suppress checks="FinalClass" files="\.java"/>
+ <suppress checks="FinalParameters" files="\.java"/>
+ <suppress checks="AvoidInlineConditionals" files="\.java"/>
+ <suppress checks="DesignForExtension" files="\.java"/>
+ <suppress checks="ImportOrder" files="\.java"/>
+ <suppress checks="LocalVariableName" files="\.java"/>
+ <suppress checks="AbbreviationAsWordInName" files="\.java"/>
+ <!--Checkstyle requirements that don't match SnakeYAML parser requirements-->
+ <suppress checks="ParameterName" files="common/onap-tosca-datatype/.*/*.java"/>
+ <suppress checks="MethodName" files="common/onap-tosca-datatype/.*/*.java"/>
+ <suppress checks="MemberName" files="common/onap-tosca-datatype/.*/*.java"/>
+
+</suppressions>
\ No newline at end of file
*/
class ConfigurationLoader {
+ private ConfigurationLoader() {
+ }
+
static Configuration load() {
ServiceLoader<ConfigurationManager> loader = ServiceLoader.load(ConfigurationManager.class);
Pattern pattern = Pattern.compile("^.*\\$\\{(.*)\\}.*");
Matcher matcher = pattern.matcher(data);
if (matcher.matches()) {
+ final int substringStartIndex = 4;
String key = matcher.group(1);
String value;
if (key.toUpperCase().startsWith("ENV:")) {
- value = System.getenv(key.substring(4));
+ value = System.getenv(key.substring(substringStartIndex));
} else if (key.toUpperCase().startsWith("SYS:")) {
- value = System.getProperty(key.substring(4));
+ value = System.getProperty(key.substring(substringStartIndex));
} else {
value = ConfigurationUtils.getCollectionString(
ConfigurationManager.lookup().getAsStringValues(tenant, namespace, key).toString());
if (List.class.isAssignableFrom(clazz)) {
return getConcreteCollection(List.class);
}
- throw new IllegalArgumentException("Only corresponding array classes and any are allowed as argument." +
- "assignable from TransferQueue, BlockingQueue, Deque, Queue, SortedSet, Set, List class");
+ throw new IllegalArgumentException("Only corresponding array classes and any are allowed as argument."
+ + "assignable from TransferQueue, BlockingQueue, Deque, Queue, SortedSet, Set, List class");
}
public static Collection getConcreteCollection(Class clazz) {
case "java.util.concurrent.BlockingQueue":
return new LinkedBlockingQueue<>();
default:
- throw new IllegalArgumentException("Only corresponding array classes and any are allowed as argument." +
- "assignable from TransferQueue, BlockingQueue, Deque, Queue, SortedSet, Set, List class");
+ throw new IllegalArgumentException("Only corresponding array classes and any are allowed as argument."
+ + "assignable from TransferQueue, BlockingQueue, Deque, Queue, SortedSet, Set, List class");
}
}
private static final String KEY_CANNOT_BE_NULL = "Key can't be null.";
- private static final NonConfigResource nonConfigResource = new NonConfigResource();
+ private static final NonConfigResource NON_CONFIG_RESOURCE = new NonConfigResource();
static {
}
moduleConfig.addConfig(url);
} else {
- nonConfigResource.add(url);
+ NON_CONFIG_RESOURCE.add(url);
}
}
String configLocation = System.getProperty("config.location");
}
moduleConfig.addConfig(file);
} else {
- nonConfigResource.add(file);
+ NON_CONFIG_RESOURCE.add(file);
}
}
}
clazzToInstantiate = field.getType();
}
Constructor construct = getConstructorWithArguments(clazzToInstantiate, Collection.class);
+
if (construct != null) {
construct.setAccessible(true);
field.set(objToReturn, construct.newInstance(list));
- } else if ((construct = getConstructorWithArguments(clazzToInstantiate, Integer.class,
- Boolean.class, Collection.class)) != null) {
- construct.setAccessible(true);
- field.set(objToReturn, construct.newInstance(list.size(), true, list));
+ } else {
+ construct = getConstructorWithArguments(clazzToInstantiate, Integer.class,
+ Boolean.class, Collection.class);
+ if (construct != null) {
+ construct.setAccessible(true);
+ field.set(objToReturn, construct.newInstance(list.size(), true, list));
+ }
}
}
} else if (Map.class.isAssignableFrom(field.getType())) {
if (String.class.equals(clazz)) {
if (obj.toString().startsWith("@") && ConfigurationUtils.isExternalLookup(processingHint)) {
String contents = ConfigurationUtils.getFileContents(
- nonConfigResource.locate(obj.toString().substring(1).trim()));
+ NON_CONFIG_RESOURCE.locate(obj.toString().substring(1).trim()));
if (contents == null) {
contents = ConfigurationUtils.getFileContents(obj.toString().substring(1).trim());
}
public final class ConfigurationRepository {
- private static final ConfigurationRepository repo = new ConfigurationRepository();
+ private static final ConfigurationRepository REPO = new ConfigurationRepository();
private final Set<String> tenants = Collections.synchronizedSet(new HashSet<>());
}
public static ConfigurationRepository lookup() {
- return repo;
+ return REPO;
}
public Set<String> getTenants() {
private final Map<String, FileBasedConfigurationBuilder<FileBasedConfiguration>> overrideConfiguration =
new LinkedHashMap<>();
- BasicConfigurationBuilder<Configuration> builder;
- Timestamp lastConfigurationBuildTime;
- Configuration config;
- Configuration composite;
+ private BasicConfigurationBuilder<Configuration> builder;
+ private Timestamp lastConfigurationBuildTime;
+ private Configuration config;
+ private Configuration composite;
- public ConfigurationHolder(BasicConfigurationBuilder builder) {
+ ConfigurationHolder(BasicConfigurationBuilder builder) {
this.builder = builder;
}
- public ConfigurationHolder(Configuration builder) {
+ ConfigurationHolder(Configuration builder) {
this.config = builder;
}
- public void addOverrideConfiguration(String path, BasicConfigurationBuilder<FileBasedConfiguration> builder) {
+ void addOverrideConfiguration(String path, BasicConfigurationBuilder<FileBasedConfiguration> builder) {
overrideConfiguration.put(path.toUpperCase(), (FileBasedConfigurationBuilder) builder);
getEffectiveConfiguration(config, overrideConfiguration.values());
}
package org.onap.sdc.gab;
import java.io.IOException;
+
import org.onap.sdc.gab.model.GABQuery;
import org.onap.sdc.gab.model.GABQuery.GABQueryType;
import org.onap.sdc.gab.model.GABResults;
}
}
- private GABYamlParser parse(GABQuery gabQuery, GABYamlParser gabYamlParser){
- return gabQuery.getType() == GABQueryType.PATH ?
- gabYamlParser.parseFile(gabQuery.getDocument()) : gabYamlParser.parseContent(gabQuery.getDocument());
+ private GABYamlParser parse(GABQuery gabQuery, GABYamlParser gabYamlParser) {
+ return gabQuery.getType() == GABQueryType.PATH
+ ? gabYamlParser.parseFile(gabQuery.getDocument()) : gabYamlParser.parseContent(gabQuery.getDocument());
}
}
* PATH - when provided path to the yaml file
* CONTENT - when provided yaml file content
*/
- public enum GABQueryType{
+ public enum GABQueryType {
PATH, CONTENT
}
import com.google.common.base.MoreObjects;
import lombok.AllArgsConstructor;
import lombok.Getter;
-import org.onap.sdc.gab.GABService;
/**
* See GABResultEntry.{@link #path}, GABResultEntry.{@link #data}
*/
public class YamlParser implements AutoCloseable {
- private static Logger LOGGER = Logger.getLogger(YamlParser.class.getName());
+ private static final Logger LOGGER = Logger.getLogger(YamlParser.class.getName());
private Stream<Object> parsedYamlContent;
private InputStream inputStream;
List<List<SimpleEntry<String, ? extends Collection<Object>>>> collect() throws IOException {
try {
return parsedYamlContent.map(containsKeys).filter(notEmptyListPredicate()).collect(Collectors.toList());
- } catch(Exception e){
+ } catch (Exception e) {
LOGGER.log(Level.WARNING, "Unexpected document content. Please check body of the yaml file.", e);
throw new IOException("Unexpected document content");
}
@Getter
@Setter
-public class AttributeDefinition implements Cloneable{
+public class AttributeDefinition implements Cloneable {
private String type;
private String description;
import java.util.List;
import java.util.Map;
-public class CapabilityDefinition implements Cloneable{
+public class CapabilityDefinition implements Cloneable {
private String type;
private String description;
@Data
public class Condition {
- private Map<String,Constraint> constraint;
+ private Map<String, Constraint> constraint;
private String period;
private Integer evaluations;
private String method;
private Map<String, String> keys;
private String user;
- public Credential(){
+ public Credential() {
this.token_type = "password";
}
private String derived_from;
private String version;
- Map<String, String> metadata;
+ private Map<String, String> metadata;
private String description;
private List<Constraint> constraints;
private Map<String, PropertyDefinition> properties;
import java.util.Objects;
import org.onap.sdc.tosca.services.DataModelCloneUtil;
-public class DefinitionOfDataType implements Cloneable{
-
- protected String type;
- protected String description;
- protected Object value;
- protected Boolean required;
- protected Object _default;
- protected Status status;
- protected List<Constraint> constraints;
- protected EntrySchema entry_schema;
+public class DefinitionOfDataType implements Cloneable {
+
+ private String type;
+ private String description;
+ private Object value;
+ private Boolean required;
+ private Object _default;
+ private Status status;
+ private List<Constraint> constraints;
+ private EntrySchema entry_schema;
public String getType() {
return type;
import org.onap.sdc.tosca.services.DataModelCloneUtil;
-public class Implementation implements Cloneable{
+public class Implementation implements Cloneable {
private String primary;
private List<String> dependencies;
for (Map.Entry<String, Object> entry : interfaceAsMap.entrySet()) {
Optional<Map.Entry<String, ? extends OperationDefinition>> operationDefinition =
createOperation(entry.getKey(), entry.getValue(), fieldNames,
- interfaceDefinition instanceof InterfaceDefinitionType ? OperationDefinitionType.class :
- OperationDefinitionTemplate.class);
+ interfaceDefinition instanceof InterfaceDefinitionType ? OperationDefinitionType.class
+ : OperationDefinitionTemplate.class);
operationDefinition
.ifPresent(operation -> interfaceDefinition.addOperation(operation.getKey(), operation.getValue()));
}
import java.util.HashMap;
import java.util.Map;
+import java.util.Objects;
import java.util.Optional;
import org.apache.commons.collections4.MapUtils;
import org.onap.sdc.tosca.services.DataModelCloneUtil;
if (this == o) {
return true;
}
- if (!(o instanceof InterfaceDefinitionType)) {
+ if (o == null || getClass() != o.getClass()) {
return false;
}
-
InterfaceDefinitionType that = (InterfaceDefinitionType) o;
-
- if (getType() != null ? !getType().equals(that.getType()) : that.getType() != null) {
- return false;
- }
- if (getInputs() != null ? !getInputs().equals(that.getInputs()) : that.getInputs() != null) {
- return false;
- }
- return getOperations() != null ? getOperations().equals(that.getOperations()) : that.getOperations() == null;
+ return Objects.equals(type, that.type)
+ && Objects.equals(inputs, that.inputs)
+ && Objects.equals(operations, that.operations);
}
@Override
public int hashCode() {
- int result = getType() != null ? getType().hashCode() : 0;
- result = 31 * result + (getInputs() != null ? getInputs().hashCode() : 0);
- result = 31 * result + (getOperations() != null ? getOperations().hashCode() : 0);
- return result;
+ return Objects.hash(type, inputs, operations);
}
@Override
throw new ToscaRuntimeException(CONVERT_INTERFACE_TYPE_OBJECT_ERROR + toscaInterfaceTypeObj.toString());
}
} catch (Exception exc) {
- throw new ToscaRuntimeException(CONVERT_INTERFACE_TYPE_OBJECT_ERROR + toscaInterfaceTypeObj.toString(),exc);
+ throw new ToscaRuntimeException(CONVERT_INTERFACE_TYPE_OBJECT_ERROR + toscaInterfaceTypeObj.toString(), exc);
}
}
public class OperationDefinition implements Cloneable {
- protected String description;
+ private String description;
public String getDescription() {
return description;
public class PropertyDefinition extends DefinitionOfDataType {
public PropertyDefinition() {
- this.status = Status.SUPPORTED;
- this.required = true;
+ setStatus(Status.SUPPORTED);
+ setRequired(true);
}
@Override
SCALAR_UNIT_SIZE("scalar-unit.size"),
SCALAR_UNIT_FREQUENCY("scalar-unit.frequency");
- private static final Map<String, PropertyType> mMap =
+ private static final Map<String, PropertyType> M_MAP =
Collections.unmodifiableMap(initializeMapping());
- private static final Set<String> simplePropertyTypes =
+ private static final Set<String> SIMPLE_PROPERTY_TYPES =
Collections.unmodifiableSet(initializeSimplePropertyTypes());
private String displayName;
* @return PropertyType
*/
public static PropertyType getPropertyTypeByDisplayName(String displayName) {
- if (mMap.containsKey(displayName)) {
- return mMap.get(displayName);
+ if (M_MAP.containsKey(displayName)) {
+ return M_MAP.get(displayName);
}
return null;
}
private static Set<String> initializeSimplePropertyTypes() {
- Set<String> simplePropertyTypes = new HashSet<>(4);
+ final int setSize = 4;
+ Set<String> simplePropertyTypes = new HashSet<>(setSize);
simplePropertyTypes.add(STRING.getDisplayName().toLowerCase());
simplePropertyTypes.add(INTEGER.getDisplayName().toLowerCase());
simplePropertyTypes.add(FLOAT.getDisplayName().toLowerCase());
}
public static Set<String> getSimplePropertyTypes() {
- return simplePropertyTypes;
+ return SIMPLE_PROPERTY_TYPES;
}
public String getDisplayName() {
return displayName;
}
-
}
EXPERIMENTAL("experimental"),
experimental("experimental"),
DEPRECATED("deprecated"),
- deprecated("deprecated"),;
+ deprecated("deprecated");
private String displayName;
Status(String displayName) {
package org.onap.sdc.tosca.datatypes.model;
+import java.util.Objects;
+
public class Trigger {
private String description;
private Condition condition;
private Object action;
- @Override
- public int hashCode() {
- int result = getDescription() != null ? getDescription().hashCode() : 0;
- result = 31 * result + getEvent_type().hashCode();
- result = 31 * result + (getSchedule() != null ? getSchedule().hashCode() : 0);
- result = 31 * result + (getTarget_filter() != null ? getTarget_filter().hashCode() : 0);
- result = 31 * result + (getCondition() != null ? getCondition().hashCode() : 0);
- result = 31 * result + getAction().hashCode();
- return result;
- }
-
- @Override
- public boolean equals(Object o) {
- if (this == o) {
- return true;
- }
- if (!(o instanceof Trigger)) {
- return false;
- }
-
- Trigger trigger = (Trigger) o;
-
- if (getDescription() != null ? !getDescription().equals(trigger.getDescription()) :
- trigger.getDescription() != null) {
- return false;
- }
- if (!getEvent_type().equals(trigger.getEvent_type())) {
- return false;
- }
- if (getSchedule() != null ? !getSchedule().equals(trigger.getSchedule()) : trigger.getSchedule() != null) {
- return false;
- }
- if (getTarget_filter() != null ? !getTarget_filter().equals(trigger.getTarget_filter()) :
- trigger.getTarget_filter() != null) {
- return false;
- }
- if (getCondition() != null ? !getCondition().equals(trigger.getCondition()) : trigger.getCondition() != null) {
- return false;
- }
- return getAction().equals(trigger.getAction());
- }
-
public String getDescription() {
return description;
}
public void setAction(Object action) {
this.action = action;
}
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(description, event_type, schedule, target_filter, condition, action);
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) {
+ return true;
+ }
+ if (o == null || getClass() != o.getClass()) {
+ return false;
+ }
+ Trigger trigger = (Trigger) o;
+ return Objects.equals(description, trigger.description)
+ && Objects.equals(event_type, trigger.event_type)
+ && Objects.equals(schedule, trigger.schedule)
+ && Objects.equals(target_filter, trigger.target_filter)
+ && Objects.equals(condition, trigger.condition)
+ && Objects.equals(action, trigger.action);
+ }
}
public class ServiceFilter extends NodeFilter {
- Object tosca_id;
+ private Object tosca_id;
public Object getTosca_id() {
return tosca_id;
SubstitutionMappingExt that = (SubstitutionMappingExt) o;
- return getSubstitution_filter() != null ? getSubstitution_filter().equals(that.getSubstitution_filter()) :
- that.getSubstitution_filter() == null;
+ return getSubstitution_filter() != null ? getSubstitution_filter().equals(that.getSubstitution_filter())
+ : that.getSubstitution_filter() == null;
}
@Override
*/
JSON("json");
- private static final Map<String, PropertyTypeExt> mMap =
+ private static final Map<String, PropertyTypeExt> M_MAP =
Collections.unmodifiableMap(initializeMapping());
private String displayName;
* @return the property type by display name
*/
public static PropertyTypeExt getPropertyTypeByDisplayName(String displayName) {
- if (mMap.containsKey(displayName)) {
- return mMap.get(displayName);
+ if (M_MAP.containsKey(displayName)) {
+ return M_MAP.get(displayName);
}
return null;
}
public class CommonUtil {
private static final String DEFAULT = "default";
- private static final String _DEFAULT = "_default";
+ private static final String UNDERSCORE_DEFAULT = "_default";
private static ImmutableSet<Class<?>> complexClassType = ImmutableSet.of(Map.class, String.class, Integer.class, Float.class,
Double.class, Set.class, Object.class, List.class);
if (objectAsMap.containsKey(DEFAULT)) {
Object defaultValue = objectAsMap.get(DEFAULT);
objectAsMap.remove(DEFAULT);
- objectAsMap.put(_DEFAULT, defaultValue);
+ objectAsMap.put(UNDERSCORE_DEFAULT, defaultValue);
}
return objectAsMap;
}
} else if (mapEntry.getValue() instanceof List) {
List cloneObj = yamlUtil.yamlToObject(yamlUtil.objectToYaml(mapEntry.getValue()), List.class);
cloneMap.put(mapEntry.getKey(), cloneObj);
- } else if (mapEntry.getValue() instanceof Cloneable){
+ } else if (mapEntry.getValue() instanceof Cloneable) {
throw new ToscaRuntimeException("Clone Not Supported Exception");
} else {
cloneMap.put(mapEntry.getKey(), mapEntry.getValue());
import java.beans.IntrospectionException;
import java.io.IOException;
import java.io.InputStream;
-import java.util.*;
+import java.util.AbstractMap;
+import java.util.LinkedHashMap;
+import java.util.LinkedHashSet;
+import java.util.Map;
+import java.util.Set;
/**
* The type Yaml util.
Code Review / sdc.git / commitdiff