Fix NPE for no inputs on instance operation 20/130720/2
authorMichaelMorris <michael.morris@est.tech>
Fri, 26 Aug 2022 15:56:59 +0000 (16:56 +0100)
committerVasyl Razinkov <vasyl.razinkov@est.tech>
Wed, 7 Sep 2022 13:14:33 +0000 (13:14 +0000)
Signed-off-by: MichaelMorris <michael.morris@est.tech>
Issue-ID: SDC-4145
Change-Id: I6813382db7101de0c18d03a058c2c36a48b5a828

catalog-be/src/main/java/org/openecomp/sdc/be/components/impl/ServiceImportBusinessLogic.java

index 0a7ce20..bf0f1b2 100644 (file)
@@ -1997,6 +1997,10 @@ public class ServiceImportBusinessLogic {
 
     private void mergeOperationInputDefinitions(ListDataDefinition<OperationInputDefinition> inputsFromNodeType,
                                                 ListDataDefinition<OperationInputDefinition> instanceInputs) {
+        if (inputsFromNodeType == null || CollectionUtils.isEmpty(inputsFromNodeType.getListToscaDataDefinition()) || instanceInputs == null
+                || CollectionUtils.isEmpty(instanceInputs.getListToscaDataDefinition())) {
+            return;
+        }
         instanceInputs.getListToscaDataDefinition().forEach(
             instanceInput -> inputsFromNodeType.getListToscaDataDefinition().stream().filter(
                 templateInput -> templateInput.getName().equals(instanceInput.getName())