catalog-be/src/test/java/org/openecomp/sdc/be/components/merge/group/GroupPropertiesMergeCommandTest.java

   1 /*-
   2  * ============LICENSE_START=======================================================
   3  * SDC
   4  * ================================================================================
   5  * Copyright (C) 2019 AT&T Intellectual Property. All rights reserved.
   6  * ================================================================================
   7  * Licensed under the Apache License, Version 2.0 (the "License");
   8  * you may not use this file except in compliance with the License.
   9  * You may obtain a copy of the License at
  10  *
  11  *      http://www.apache.org/licenses/LICENSE-2.0
  12  *
  13  * Unless required by applicable law or agreed to in writing, software
  14  * distributed under the License is distributed on an "AS IS" BASIS,
  15  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
  16  * See the License for the specific language governing permissions and
  17  * limitations under the License.
  18  * ============LICENSE_END=========================================================
  19  */
  20
  21 package org.openecomp.sdc.be.components.merge.group;
  22
  23
  24 import fj.data.Either;
  25 import org.junit.Before;
  26 import org.junit.Test;
  27 import org.junit.runner.RunWith;
  28 import org.mockito.ArgumentCaptor;
  29 import org.mockito.Captor;
  30 import org.mockito.Mock;
  31 import org.mockito.junit.MockitoJUnitRunner;
  32 import org.openecomp.sdc.be.auditing.impl.AuditingManager;
  33 import org.openecomp.sdc.be.components.merge.property.DataDefinitionsValuesMergingBusinessLogic;
  34 import org.openecomp.sdc.be.components.utils.GroupDefinitionBuilder;
  35 import org.openecomp.sdc.be.components.utils.ResourceBuilder;
  36 import org.openecomp.sdc.be.dao.api.ActionStatus;
  37 import org.openecomp.sdc.be.datatypes.enums.CreatedFrom;
  38 import org.openecomp.sdc.be.datatypes.enums.PromoteVersionEnum;
  39 import org.openecomp.sdc.be.impl.ComponentsUtils;
  40 import org.openecomp.sdc.be.model.GroupDefinition;
  41 import org.openecomp.sdc.be.model.Resource;
  42 import org.openecomp.sdc.be.model.jsonjanusgraph.operations.GroupsOperation;
  43
  44 import java.util.List;
  45 import java.util.stream.Stream;
  46
  47 import static org.assertj.core.api.Assertions.assertThat;
  48 import static org.mockito.ArgumentMatchers.any;
  49 import static org.mockito.ArgumentMatchers.eq;
  50 import static org.mockito.Mockito.mock;
  51 import static org.mockito.Mockito.verify;
  52 import static org.mockito.Mockito.verifyZeroInteractions;
  53 import static org.mockito.Mockito.when;
  54
  55 @RunWith(MockitoJUnitRunner.class)
  56 public class GroupPropertiesMergeCommandTest {
  57
  58     private GroupPropertiesMergeCommand testInstance;
  59     @Mock
  60     private DataDefinitionsValuesMergingBusinessLogic mergeBusinessLogic;
  61     @Mock
  62     private GroupsOperation groupsOperation;
  63     @Captor
  64     private ArgumentCaptor<List<GroupDefinition>> updatedGroupsCaptor;
  65
  66     private GroupDefinition newGroup1, newGroup2, newGroup3;
  67     private GroupDefinition prevGroup1, prevGroup2, prevGroup3;
  68     private Resource prevResource, newResource;
  69
  70
  71     @Before
  72     public void setUp() throws Exception {
  73         testInstance = new GroupPropertiesMergeCommand(groupsOperation, new ComponentsUtils(mock(AuditingManager.class)), mergeBusinessLogic);
  74         newGroup1 = createVspGroupWithProperties("group1Id", "group1New", "prop1", "prop2");
  75         newGroup2 = createUserGroupWithProperties("group2Id", "group2New", "prop3", "prop4");
  76         newGroup3 = createVspGroupWithProperties("group3Id", "group3New");
  77         prevGroup1 = createVspGroupWithProperties("group1Id", "group1Old", "prop1", "prop2");
  78         prevGroup2 = createUserGroupWithProperties("group2Id", "group2Old", "prop3", "prop4");
  79         prevGroup3 = createVspGroupWithProperties("group3Id", "group3Old");
  80
  81         prevResource = new ResourceBuilder()
  82                 .addGroup(prevGroup1)
  83                 .addGroup(prevGroup2)
  84                 .addGroup(prevGroup3)
  85                 .addInput("input1")
  86                 .addInput("input2")
  87                 .build();
  88
  89         newResource = new ResourceBuilder()
  90                 .addGroup(newGroup1)
  91                 .addGroup(newGroup2)
  92                 .addGroup(newGroup3)
  93                 .addInput("input1")
  94                 .build();
  95     }
  96
  97     @Test
  98     public void whenNewComponentHasNoGroups_returnOk() {
  99         ActionStatus mergeStatus = testInstance.mergeComponents(prevResource, new Resource());
 100         assertThat(mergeStatus).isEqualTo(ActionStatus.OK);
 101         verifyZeroInteractions(mergeBusinessLogic, groupsOperation);
 102     }
 103
 104     @Test
 105     public void whenOldComponentHasNoGroups_returnOk() {
 106         ActionStatus mergeStatus = testInstance.mergeComponents(new Resource(), newResource);
 107         assertThat(mergeStatus).isEqualTo(ActionStatus.OK);
 108         verifyZeroInteractions(mergeBusinessLogic, groupsOperation);
 109     }
 110
 111     @Test
 112     public void whenOldOrNewGroupHasNoProperties_noNeedToMergeItsProperties() {
 113         GroupDefinition oldGrpNoProps = createVspGroupWithProperties("grp1", "grp1");
 114         GroupDefinition newGrpWithProps = createVspGroupWithProperties("grp1", "grp1", "prop1", "prop2");
 115
 116         GroupDefinition oldGrpWithProps = createVspGroupWithProperties("grp2", "grp2", "prop3");
 117         GroupDefinition newGrpNoProps = createVspGroupWithProperties("grp2", "grp2");
 118
 119         Resource prevResource = createResourceWithGroups(oldGrpNoProps, oldGrpWithProps);
 120         Resource newResource = createResourceWithGroups(newGrpWithProps, newGrpNoProps);
 121         ActionStatus mergeStatus = testInstance.mergeComponents(prevResource, newResource);
 122         assertThat(mergeStatus).isEqualTo(ActionStatus.OK);
 123         verifyZeroInteractions(mergeBusinessLogic, groupsOperation);
 124     }
 125
 126     @Test
 127     public void whenNewGroupIsUserDefined_itWasAlreadyMergedInEarlierCommand_noNeedToMerge() {
 128         GroupDefinition oldUserDefinedGrp = createUserGroupWithProperties("grp1", "grp1", "prop1");
 129         GroupDefinition newUserDefinedGrp = createVspGroupWithProperties("grp1", "grp1", "prop1");
 130         Resource prevResource = createResourceWithGroups(oldUserDefinedGrp);
 131         Resource newResource = createResourceWithGroups(newUserDefinedGrp);
 132         ActionStatus mergeStatus = testInstance.mergeComponents(prevResource, newResource);
 133         assertThat(mergeStatus).isEqualTo(ActionStatus.OK);
 134         verifyZeroInteractions(mergeBusinessLogic, groupsOperation);
 135     }
 136
 137     @Test
 138     public void whenNewGroupWasntExistInPrevVersion_noMergeRequired_matchByInvariantName() {
 139         GroupDefinition oldGrp = createUserGroupWithProperties("grp1", "grp1", "prop1");
 140         GroupDefinition newGrp = createVspGroupWithProperties("newGrp1", "grp1", "prop1");
 141         Resource prevResource = createResourceWithGroups(oldGrp);
 142         Resource newResource = createResourceWithGroups(newGrp);
 143         ActionStatus mergeStatus = testInstance.mergeComponents(prevResource, newResource);
 144         assertThat(mergeStatus).isEqualTo(ActionStatus.OK);
 145         verifyZeroInteractions(mergeBusinessLogic, groupsOperation);
 146     }
 147
 148     @Test
 149     public void mergeGroupProperties_updateGroupsAfterMerge_mergeOnlyGroups() {
 150         when(groupsOperation.updateGroups(eq(newResource), updatedGroupsCaptor.capture(), any(PromoteVersionEnum.class))).thenReturn(Either.left(null));
 151         ActionStatus mergeStatus = testInstance.mergeComponents(prevResource, newResource);
 152         assertThat(mergeStatus).isEqualTo(ActionStatus.OK);
 153         verify(mergeBusinessLogic).mergeInstanceDataDefinitions(prevGroup1.getProperties(), prevResource.getInputs(), newGroup1.getProperties(), newResource.getInputs());
 154         assertThat(updatedGroupsCaptor.getValue())
 155                 .containsExactly(newGroup1);
 156
 157     }
 158
 159     private GroupDefinition createUserGroupWithProperties(String invariantName, String groupName, String ... propsNames) {
 160         return createGroupWithProperties(invariantName, groupName, CreatedFrom.UI, propsNames);
 161     }
 162
 163     private GroupDefinition createVspGroupWithProperties(String invariantName, String groupName, String ... propsNames) {
 164         return createGroupWithProperties(invariantName, groupName, CreatedFrom.CSAR, propsNames);
 165     }
 166
 167     private GroupDefinition createGroupWithProperties(String invariantName, String groupName, CreatedFrom createdFrom, String ... propsNames) {
 168         GroupDefinitionBuilder groupDefinitionBuilder = GroupDefinitionBuilder.create()
 169                 .setUniqueId(invariantName)
 170                 .setName(groupName)
 171                 .setCreatedFrom(createdFrom)
 172                 .setInvariantName(invariantName);
 173         Stream.of(propsNames).forEach(groupDefinitionBuilder::addProperty);
 174         return groupDefinitionBuilder.build();
 175     }
 176
 177     private Resource createResourceWithGroups(GroupDefinition ... groups) {
 178         ResourceBuilder resourceBuilder = new ResourceBuilder();
 179         Stream.of(groups).forEach(resourceBuilder::addGroup);
 180         return resourceBuilder.build();
 181     }
 182 }