Fix for NullPointerException in ecomp-portal-BE-common

A "NullPointerException" could be thrown; "epUser" is nullable here
Either log or rethrow this exception

Issue-ID: PORTAL-562
Change-Id: I11a72534f75efec474f49f8a5cb66affb810348f
Signed-off-by: Parshad Patel <pars.patel@samsung.com>

Merge "Fix typo in addNewUser()"

Merge "Fix typo in isCssReady()"

Merge "Fix null pointer exception"

Merge "General sonar fixes"

Fix typo in addNewUser()

Coverity-scan: CID-192094
Issue-ID: PORTAL-684
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: If6dccd56be6c755771be7bf3724ee66ed10ac606

Fix typo in isCssReady()

Coverity-scan: CID-192115
Issue-ID: PORTAL-16
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: If4aacbb6e7f2cdf6895a1ca6130247b8238414ef

Fix null pointer exception

+) Fix NPE
++) implement equals instead of ==

Issue-ID: PORTAL-680
Change-Id: I3a0df60b6171b114afc841b40838f6a4484370ee
Signed-off-by: arind.mondal <arind.mondal@samsung.com>

Merge "XSS Vulnerability fix in DashboardController"

Merge "XSS Vulnerability fix in ExternalAccessRolesControllerDashboardController"

Merge "XSS Vulnerability fix in AuxApiRequestMapperController"

Merge "XSS Vulnerability fix in SharedContextRestController"

Merge "XSS Vulnerability fix in WidgetsController"

Merge "XSS Vulnerability fix in AuditLogController"

Merge "XSS Vulnerability fix in AppContactUsController"

Merge "XSS Vulnerability fix in AppsController"

General sonar fixes

+) removed unused imports and done formatting

Issue-ID: PORTAL-680
Change-Id: I1f6ceca61dfc59726cc9e5f7ad802e5c9b0f4d6e
Signed-off-by: arindamm <arind.mondal@samsung.com>

Merge "NoClassDefFoundError javax/xml/bind/ValidationException"

XSS Vulnerability fix in DashboardController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Change-Id: I84bfb81e5d87f80211d46d1141cbf8e4075660fe
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

XSS Vulnerability fix in ExternalAccessRolesControllerDashboardController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Change-Id: I9a978846ffc50d840a676b994aa4fb89248b5372
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

XSS Vulnerability fix in AuxApiRequestMapperController

Custom data validotor is used to valid incoming data.

Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I1b2a1fe0fcb6278a7b12017479243009142c2cbd

NoClassDefFoundError javax/xml/bind/ValidationException

Add dependency to pom.xml file

Issue-ID: PORTAL-660
Change-Id: I02e21024d10cca71b2f090117fb0afdf0b29578b
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Unused classes delete from Portal

These classes are unused anywhere in the Portal project.

Issue-ID: PORTAL-655
Change-Id: If92d0df0efb0b5120190a44c46b2fed31ba32b89
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

XSS Vulnerability fix in SharedContextRestController

Custom data validator used to secure this class

Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I231731b9deb60310b698d70179cddd471cffd7fb

XSS Vulnerability fix in WidgetsController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I0113097b2118656780f4f9bca8b4ee99e85b6f6d

XSS Vulnerability fix in AuditLogController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: Iafaca1806cf7106b91efdfd9cb40132020b114f2

XSS Vulnerability fix in AppContactUsController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: Ie8df4df552cfe53e3839c7021284f0226ea56a39

XSS Vulnerability fix in AppsController

Custom XSS filter used to fix thisa issue.
DataValidator upgrade to single instance of ValidatorFactory;

Issue-ID: OJSI-15
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I7222cfb84e1e5bb240619aac9c7bca85d215229a

CRLF fix in your-angular-app.rst file

Fix CRLF

Issue-ID: PORTAL-659
Change-Id: I562115ec29306e8a73b31f1f0e62e05b54cfdd9d
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Revert "Fix sql injection vulnerability"

This reverts commit 941133a42bad6a1d73c63913a950d1e4bc814fde.
This is required because this commit breaks the portal unit test due
to some other changes that happen between verify job and merge of that commit.

Issue-ID: OJSI-174
Change-Id: Ieb53f8ba23e2b1b05c67ec4d7d51c6d5107cfb87
Signed-off-by: Krzysztof Opasiak <k.opasiak@samsung.com>

Merge "LanguageServiceImpl logging vulnerability fix"

Merge "EPAppServiceImpl class fix."

Merge "SharedContext class DB constraints"

Merge "FunctionalMenuRole class DB constraints"

Merge "PortalAdmin class DB constraints"

Merge "FavoritesFunctionalMenuItemJson class DB constraints"

Merge "EpNotificationItem class DB constraints"

Merge "EpRoleNotificationItem class DB constraints"

Merge "ExtractJar sonar issues fix"

Merge "CommonWidget class DB constraints"

Merge "XSS Vulnerability fix in PortalAdminController"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

XSS Vulnerability fix in PortalAdminController

Custom data validator used to fix this issue.

Issue-ID: OJSI-15
Change-Id: I224887d31e4e2d7301544194ef44ba38e66e047d
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

AuthUtil method isAccessAllowed() argument change

Change argument length to match argument length from to sdk version.

Issue-ID: PORTAL-656
Change-Id: I6fe28800e0baccaab43419d3aa0d8c43b1ebe771
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

LanguageServiceImpl logging vulnerability fix

Sonar issue: "Use a logger to log this exception" fix
This patch also minor code issues

Issue-ID: PORTAL-622
Change-Id: I304285ca7837bcf929249f7c6b93b6de9cf8fae5
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EPAppServiceImpl class fix.

Sonar issues fix:
Remove this unused "logger" private field.
Remove this unused "syncRests" private field.

unused imports delete and unneeded fields initialization fix.
StringBuilder performance fix.

Issue-ID: PORTAL-620
Change-Id: Ibd1cf732b216594b47801767d0a98e59b0aba200
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: Ia655ccf79800c132b3ac466016b8fdfd9f9c27bd

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I9dcec677ee9edd0d274a486af37eb950d8e828cf

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I8d72c819004f05fbbf464cde73b405f2028c7bb6

PeerBroadcastSocket sonar issues fix and code refactor

Sonar issues fix and code refactor.
Session data save moved to another method.
Rest of code don't really do anything.

Issue-ID: PORTAL-624
Change-Id: I53b36377f2d2645d8c24ad2384959f0599e07303
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

ONAPWelcomeController sonar issue fix

String viewName and getter/setter can be romoved from his class.
ONAPWelcomeController Overrides this field 1 to 1.

Issue-ID: PORTAL-652
Change-Id: Idbb41f52a63c6ea681f6ba7753991d766849e3a2
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

ONAPLoginController sonar issues fix.

Sonar issues fix plus @Autowired in constructor not in fields.

Issue-ID: PORTAL-651
Change-Id: I99329b986877d040c6fdda9daf42a5c501a39605
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

SimpleLoginStrategy sonar issues fix

"Either remove or fill this block of code."
"Move the "" string literal on the left side of this string comparison."
"Define and throw a dedicated exception instead of using a generic one."

Issue-ID: PORTAL-650
Change-Id: I92018287a6f585020f0ae6f042b1bb1de84a5e14
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

OpenIdConnectLoginStrategy sonar issues fix

Redundant suppression("rawtypes") removed.
Sonar issue:
Move the "" string literal on the left side of this string comparison.
Define and throw a dedicated exception instead of using a generic one.

Issue-ID: PORTAL-649
Change-Id: Ia2c80ad4848c22c94a2db731425250784d382841
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

Fix sql injection vulnerability

Use a variable binding instead of concatenation.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I0574e882e4d500408b6a6bab8986822669cba5d4

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: Ia75da49ed582836a47b5fdcddab62fbe02e36e72

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

Merge "Fix sql injection vulnerability"

WebAnalyticsExtAppController sonar issues

- Rename this local variable to match the regular expression
- Make this anonymous inner class a lambda.
- Immediately return this expression instead of assigning it to
the temporary variable "response".
- Move the "" string literal on the left side of this string comparison.
- Replace the type specification in this constructor call
with the diamond operator ("<>").

Issue-ID: PORTAL-648
Change-Id: I1666d94dccbbe8aa835ea9a443a9973a245353f4
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

HealthMonitor sonar issues

Remove this unused "numIntervalsClusterNotHealthy" local variable.
Use "Long.parseLong" for this string-to-long conversion.
Make the enclosing method "static" or remove this set.
Change this instance-reference to a static reference.
Remove the literal "false" boolean value.
This block of commented-out lines of code should be removed.
Add the "@Override" annotation above this method signature

Issue-ID: PORTAL-647
Change-Id: I1880177f0906e6267807bbb9c0b7a81651e3c020
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EPLdapService sonar issue fix

Annotate the interface with the @FunctionalInterface annotation.

Issue-ID: PORTAL-646
Change-Id: Idc6c70b9edaed73024721a3bc8c91796a0df9183
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

AppWithRolesForUser sonar security issue

I used Lombok annotation to provide accessors.

Issue-ID: PORTAL-645
Change-Id: Iad852434f30b81535398913df162fa8f4bd1ecff
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

SharedContext class DB constraints

Java Bean Validation SR 380 annotations added to classes
Getter, Setter changed to lombok annotation

Issue-ID: PORTAL-643
Change-Id: I690665b97e431de50750d5a497afcf0cc2efa065
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FunctionalMenuRole class DB constraints

Java Bean Validation SR 380 annotations added to classes
Getter, Setter, hashCode, equals changed to lombok annotation

Issue-ID: PORTAL-642
Change-Id: I666b0245add8e97f490d991701f548c0cd128cb6
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

PortalAdmin class DB constraints

Java Bean Validation SR 380 annotations added to classes
Getter/Setter changed into lombok annotation

Issue-ID: PORTAL-641
Change-Id: I98909f4a82372f110aa42452476fb85c9bccbf3a
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

FavoritesFunctionalMenuItemJson class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-640
Change-Id: I5080e848de12669db9cdd24afe86510dcd82c3e2
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EpNotificationItem class DB constraints

Java Bean Validation SR 380 annotations added to classes
Unnecessary getter/setter, hashCode/equals changed to lombok annotation

Issue-ID: PORTAL-639
Change-Id: I58a6c734446fa10499feb7e4f1cef57dfd9e66b0
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

EpRoleNotificationItem class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-638
Change-Id: I035ad9703f25cc87567700f66c3649ca53aee2df
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>

CommonWidget class DB constraints

Java Bean Validation SR 380 annotations added to classes

Issue-ID: PORTAL-637
Signed-off-by: Dominik Mizyn <d.mizyn@samsung.com>
Change-Id: I64741f835deb8aed14ad8d716d21bb4c1901b55f

Merge "PortalAdminUserRole class DB constraints"

Merge "MicroserviceParameter class DB constraints"

Merge "MicroserviceDataApp class DB constraints"

Merge "Application Onboarding page changes "

Application Onboarding page changes

Issue-ID: PORTAL-644

Application Onboarding page changes , DB scripts

Change-Id: Id689e15f5abd56192420e6761440659531108ab4
Signed-off-by: Kotta, Shireesha (sk434m) <sk434m@att.com>

Merge "Sonar: Reduce cyclomatic complexity"

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I676ed349746cdabf320027dd27a0c16949fff6d8

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I45895dc7665ff17394e602cbccf875e4e91b5ce1

Fix sql injection vulnerability

Use a variable binding instead of concatenation.
Change test 'getAppRolesForNonCentralizedPartnerAppTest'.

Issue-ID: OJSI-174
Signed-off-by: Dominik Orliński <d.orlinski@samsung.com>
Change-Id: I5cb7561e4b2b781834bd4f2ec36dee58b4738bf2

Merge "WidgetFileApp class DB constraints"

Merge "FavoritesFunctionalMenuItem class DB constraints"

Merge "WidgetCatalog class DB constraints"

Merge "Change default character to utf8 for portal db"

Merge "Sonar critical fixes in MicroserviceServiceImpl"

Merge "Sonar fix: make "dateFormat" an instance variable"

Merge "Sonar critical fixes in EPAppCommonServiceImpl"

Merge "RoleApp class DB constraints"

Merge "App class DB constraints"

Merge "FunctionalMenuItem DB constraints fix"

Merge "FunctionalMenuItem DB constraints add"

Merge "XSS Vulnerability fix in DashboardSearchResultController"

Merge "Custom data validator"

Merge "XSS Vulnerability fix in TicketEventController"

Merge "XSS Vulnerability fix in RoleManageController"

Merge "Fix sql injection vulnerability"

Merge "XSS Vulnerability fix in AppsOSController"