Fix sql injection vulnerability
[portal.git] / ecomp-portal-BE-common / src / test / java / org / onap / portalapp / portal / controller / AppsControllerExternalRequestTest.java
1 /*-
2  * ============LICENSE_START==========================================
3  * ONAP Portal
4  * ===================================================================
5  * Copyright (C) 2017 AT&T Intellectual Property. All rights reserved.
6  * ===================================================================
7  *
8  * Unless otherwise specified, all software contained herein is licensed
9  * under the Apache License, Version 2.0 (the "License");
10  * you may not use this software except in compliance with the License.
11  * You may obtain a copy of the License at
12  *
13  *             http://www.apache.org/licenses/LICENSE-2.0
14  *
15  * Unless required by applicable law or agreed to in writing, software
16  * distributed under the License is distributed on an "AS IS" BASIS,
17  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
18  * See the License for the specific language governing permissions and
19  * limitations under the License.
20  *
21  * Unless otherwise specified, all documentation contained herein is licensed
22  * under the Creative Commons License, Attribution 4.0 Intl. (the "License");
23  * you may not use this documentation except in compliance with the License.
24  * You may obtain a copy of the License at
25  *
26  *             https://creativecommons.org/licenses/by/4.0/
27  *
28  * Unless required by applicable law or agreed to in writing, documentation
29  * distributed under the License is distributed on an "AS IS" BASIS,
30  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
31  * See the License for the specific language governing permissions and
32  * limitations under the License.
33  *
34  * ============LICENSE_END============================================
35  *
36  * 
37  */
38 package org.onap.portalapp.portal.controller;
39
40 import static org.junit.Assert.assertEquals;
41
42 import java.util.ArrayList;
43 import java.util.List;
44
45 import javax.servlet.http.HttpServletRequest;
46 import javax.servlet.http.HttpServletResponse;
47
48 import org.junit.Before;
49 import org.junit.Test;
50 import org.mockito.InjectMocks;
51 import org.mockito.Mock;
52 import org.mockito.Mockito;
53 import org.mockito.MockitoAnnotations;
54 import org.onap.portalapp.portal.controller.AppsControllerExternalRequest;
55 import org.onap.portalapp.portal.core.MockEPUser;
56 import org.onap.portalapp.portal.domain.EPApp;
57 import org.onap.portalapp.portal.domain.EPUser;
58 import org.onap.portalapp.portal.ecomp.model.PortalRestResponse;
59 import org.onap.portalapp.portal.ecomp.model.PortalRestStatusEnum;
60 import org.onap.portalapp.portal.framework.MockitoTestSuite;
61 import org.onap.portalapp.portal.service.AdminRolesService;
62 import org.onap.portalapp.portal.service.EPAppService;
63 import org.onap.portalapp.portal.service.PortalAdminService;
64 import org.onap.portalapp.portal.service.UserService;
65 import org.onap.portalapp.portal.service.UserServiceImpl;
66 import org.onap.portalapp.portal.transport.FieldsValidator;
67 import org.onap.portalapp.portal.transport.OnboardingApp;
68 import org.onap.portalapp.util.EPUserUtils;
69
70 public class AppsControllerExternalRequestTest extends MockitoTestSuite {
71
72         @Mock
73         AdminRolesService adminRolesService;
74
75         @Mock
76         EPAppService appService;
77
78         @Mock
79         PortalAdminService portalAdminService;
80
81         @Mock
82         UserService userService = new UserServiceImpl();
83
84         @InjectMocks
85         AppsControllerExternalRequest appsControllerExternalRequest = new AppsControllerExternalRequest();
86
87         @Before
88         public void setup() {
89                 MockitoAnnotations.initMocks(this);
90         }
91
92         MockitoTestSuite mockitoTestSuite = new MockitoTestSuite();
93
94         HttpServletRequest mockedRequest = mockitoTestSuite.getMockedRequest();
95         HttpServletResponse mockedResponse = mockitoTestSuite.getMockedResponse();
96         NullPointerException nullPointerException = new NullPointerException();
97
98         MockEPUser mockUser = new MockEPUser();
99         @Mock
100         EPUserUtils ePUserUtils = new EPUserUtils();
101
102         @Test
103         public void postPortalAdminIfUSerNullTest() {
104                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
105                 expectedportalRestResponse.setMessage("Missing required field: email, loginId, or loginPwd");
106                 expectedportalRestResponse.setResponse(null);
107                 PortalRestStatusEnum portalRestStatusEnum = null;
108                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
109                 EPUser user = mockUser.mockEPUser();
110                 user.setEmail("guestT@test.portal.onap.org");
111                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
112                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
113                                 .postPortalAdmin(mockedRequest, mockedResponse, user);
114                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
115         }
116
117         @Test
118         public void postPortalAdminTest() {
119                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
120                 expectedportalRestResponse.setMessage("java.lang.NullPointerException");
121                 expectedportalRestResponse.setResponse(null);
122                 PortalRestStatusEnum portalRestStatusEnum = null;
123                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
124                 EPUser user = mockUser.mockEPUser();
125                 user.setEmail("guestT@test.portal.onap.org");
126                 user.setLoginPwd("pwd");
127                 user.setLoginId("Test");
128                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
129                 Mockito.when(userService.getUserByUserId(user.getOrgUserId())).thenThrow(nullPointerException);
130                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
131                                 .postPortalAdmin(mockedRequest, mockedResponse, user);
132                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
133         }
134
135         @Test
136         public void postPortalAdminCreateUserIfNotFoundTest() throws Exception {
137                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
138                 expectedportalRestResponse.setMessage(null);
139                 expectedportalRestResponse.setResponse(null);
140                 PortalRestStatusEnum portalRestStatusEnum = null;
141                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
142                 EPUser user = mockUser.mockEPUser();
143                 user.setEmail("guestT@test.portal.onap.org");
144                 user.setLoginPwd("pwd");
145                 user.setLoginId("Test");
146                 List<EPUser> expectedList = null;
147                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
148                 Mockito.when(userService.getUserByUserId(user.getOrgUserId())).thenReturn(expectedList);
149                 Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
150                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
151                                 .postPortalAdmin(mockedRequest, mockedResponse, user);
152                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
153         }
154
155         @Test
156         public void postPortalAdminCreateUserIfFoundTest() throws Exception {
157                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
158                 expectedportalRestResponse.setMessage(null);
159                 expectedportalRestResponse.setResponse(null);
160                 PortalRestStatusEnum portalRestStatusEnum = null;
161                 expectedportalRestResponse.setStatus(portalRestStatusEnum.OK);
162                 EPUser user = mockUser.mockEPUser();
163                 user.setEmail("guestT@test.portal.onap.org");
164                 user.setLoginPwd("pwd");
165                 user.setLoginId("Test");
166                 List<EPUser> expectedList = new ArrayList<EPUser>();
167                 expectedList.add(user);
168                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
169                 Mockito.when(userService.getUserByUserId(user.getOrgUserId())).thenReturn(expectedList);
170                 Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
171                 Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
172                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
173                                 .postPortalAdmin(mockedRequest, mockedResponse, user);
174                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
175         }
176 /*reference*/
177         @Test
178         public void postPortalAdminCreateUserIfNotSuperAdminTest() throws Exception {
179                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
180                 expectedportalRestResponse.setMessage(null);
181                 expectedportalRestResponse.setResponse(null);
182                 PortalRestStatusEnum portalRestStatusEnum = null;
183                 expectedportalRestResponse.setStatus(portalRestStatusEnum.OK);
184                 EPUser user = mockUser.mockEPUser();
185                 user.setEmail("guestT@test.portal.onap.org");
186                 user.setLoginPwd("pwd");
187                 user.setLoginId("Test");
188                 List<EPUser> expectedList = new ArrayList<EPUser>();
189                 expectedList.add(user);
190                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
191                 Mockito.when(userService.getUserByUserId(user.getOrgUserId())).thenReturn(expectedList);
192                 Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
193                 Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(false);
194
195                 FieldsValidator expectedFieldValidator = new FieldsValidator();
196                 expectedFieldValidator.setHttpStatusCode((long) 200);
197                 expectedFieldValidator.setFields(null);
198                 expectedFieldValidator.setErrorCode(null);
199                 Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
200
201                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
202                                 .postPortalAdmin(mockedRequest, mockedResponse, user);
203                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
204         }
205
206         @Test
207         public void postPortalAdminCreateUserIfFieldValidatorErrorTest() throws Exception {
208                 FieldsValidator expectedFieldValidator = new FieldsValidator();
209                 expectedFieldValidator.setHttpStatusCode((long) 500);
210                 expectedFieldValidator.setFields(null);
211                 expectedFieldValidator.setErrorCode(null);
212                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
213                 expectedportalRestResponse.setMessage("FieldsValidator [httpStatusCode=500, errorCode=null, fields=null]");
214                 expectedportalRestResponse.setResponse(null);
215                 PortalRestStatusEnum portalRestStatusEnum = null;
216                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
217                 EPUser user = mockUser.mockEPUser();
218                 user.setEmail("guestT@test.portal.onap.org");
219                 user.setLoginPwd("pwd");
220                 user.setLoginId("Test");
221                 List<EPUser> expectedList = new ArrayList<EPUser>();
222                 expectedList.add(user);
223                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
224                 Mockito.when(userService.getUserByUserId(user.getOrgUserId())).thenReturn(expectedList);
225                 Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
226                 Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(false);
227                 Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
228                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
229                                 .postPortalAdmin(mockedRequest, mockedResponse, user);
230                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
231         }
232
233         @Test
234         public void getOnboardAppExternalTest() {
235                 EPApp epApp = new EPApp();
236                 Long appId = (long) 1;
237                 Mockito.when(appService.getApp(appId)).thenReturn(epApp);
238                 OnboardingApp expectedApp = new OnboardingApp();
239                 Mockito.doNothing().when(appService).createOnboardingFromApp(epApp, expectedApp);
240                 OnboardingApp actualApp = appsControllerExternalRequest.getOnboardAppExternal(mockedRequest, mockedResponse,
241                                 appId);
242                 assertEquals(expectedApp.getClass(), actualApp.getClass());
243         }
244
245         @Test
246         public void postOnboardAppExternalExceptionTest() {
247                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
248                 expectedportalRestResponse.setMessage("Unexpected field: id");
249                 expectedportalRestResponse.setResponse(null);
250                 PortalRestStatusEnum portalRestStatusEnum = null;
251                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
252
253                 OnboardingApp expectedOnboardingApp = new OnboardingApp();
254                 expectedOnboardingApp.id = (long) 1;
255
256                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
257                                 .postOnboardAppExternal(mockedRequest, mockedResponse, expectedOnboardingApp);
258                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
259         }
260
261         @Test
262         public void postOnboardAppExternalTest() {
263                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
264                 expectedportalRestResponse.setMessage(
265                                 "Missing required field: name, url, restUrl, restrictedApp, isOpen, isEnabled, myLoginsAppOwner");
266                 expectedportalRestResponse.setResponse(null);
267                 PortalRestStatusEnum portalRestStatusEnum = null;
268                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
269
270                 OnboardingApp expectedOnboardingApp = new OnboardingApp();
271                 expectedOnboardingApp.id = null;
272
273                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
274                                 .postOnboardAppExternal(mockedRequest, mockedResponse, expectedOnboardingApp);
275                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
276
277         }
278
279         @Test
280         public void putOnboardAppExternalifAppNullTest() {
281                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
282                 expectedportalRestResponse.setMessage("Unexpected value for field: id");
283                 expectedportalRestResponse.setResponse(null);
284                 PortalRestStatusEnum portalRestStatusEnum = null;
285                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
286                 Long appId = null;
287                 OnboardingApp expectedOnboardingApp = new OnboardingApp();
288                 expectedOnboardingApp.id = null;
289
290                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
291                                 .putOnboardAppExternal(mockedRequest, mockedResponse, appId, expectedOnboardingApp);
292                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
293         }
294
295         @Test
296         public void putOnboardAppExternalIfOnboardingAppDetailsNullTest() {
297                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
298                 expectedportalRestResponse.setMessage(
299                                 "Missing required field: name, url, restUrl, restrictedApp, isOpen, isEnabled, myLoginsAppOwner");
300                 expectedportalRestResponse.setResponse(null);
301                 PortalRestStatusEnum portalRestStatusEnum = null;
302                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
303                 Long appId = (long) 1;
304                 OnboardingApp expectedOnboardingApp = new OnboardingApp();
305                 expectedOnboardingApp.id = (long) 1;
306                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
307                                 .putOnboardAppExternal(mockedRequest, mockedResponse, appId, expectedOnboardingApp);
308                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
309         }
310         
311         @Test
312         public void putOnboardAppExternalIfOnboardingAppDetailsTest() {
313                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
314                 expectedportalRestResponse.setMessage("Failed to find user: testUser");
315                 expectedportalRestResponse.setResponse(null);
316                 PortalRestStatusEnum portalRestStatusEnum = null;
317                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
318                 Long appId = (long) 1;
319
320                 OnboardingApp expectedOnboardingApp = new OnboardingApp();
321                 expectedOnboardingApp.id = (long) 1;
322                 expectedOnboardingApp.name = "test";
323                 expectedOnboardingApp.url="test.com";
324                 expectedOnboardingApp.restUrl="test1.com";
325                 expectedOnboardingApp.myLoginsAppOwner="testUser";
326                 expectedOnboardingApp.restrictedApp=false;
327                 expectedOnboardingApp.isOpen=true;
328                 expectedOnboardingApp.isEnabled=true;
329                 EPUser user = mockUser.mockEPUser();
330                 user.setEmail("guestT@test.portal.onap.org");
331                 user.setLoginPwd("pwd");
332                 user.setLoginId("Test");
333                 List<EPUser> expectedList = new ArrayList<EPUser>();
334                 expectedList.add(user);
335                 FieldsValidator expectedFieldValidator = new FieldsValidator();
336                 expectedFieldValidator.setHttpStatusCode((long) 200);
337                 expectedFieldValidator.setFields(null);
338                 expectedFieldValidator.setErrorCode(null);
339                 Mockito.when(userService.getUserByUserId(user.getOrgUserId())).thenReturn(expectedList);
340
341                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
342                                 .putOnboardAppExternal(mockedRequest, mockedResponse, appId, expectedOnboardingApp);
343                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
344         }
345         
346         @Test
347         public void putOnboardAppExternalIfOnboardingAppDetailsTest2() throws Exception {
348
349                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
350                 expectedportalRestResponse.setMessage(null);
351                 expectedportalRestResponse.setResponse(null);
352                 PortalRestStatusEnum portalRestStatusEnum = null;
353                 expectedportalRestResponse.setStatus(portalRestStatusEnum.OK);
354                 
355                 Long appId = (long) 1;
356                 
357                 OnboardingApp oldOnboardApp = new OnboardingApp();
358                 oldOnboardApp.id = (long) 1;
359                 oldOnboardApp.name = "test";
360                 oldOnboardApp.url="test.com";
361                 oldOnboardApp.restUrl="test1.com";
362                 oldOnboardApp.myLoginsAppOwner="12";
363                 oldOnboardApp.restrictedApp=false;
364                 oldOnboardApp.isOpen=true;
365                 oldOnboardApp.isEnabled=true;
366                 
367                 
368                 EPUser user = mockUser.mockEPUser();
369                 user.setEmail("guestT@test.portal.onap.org");
370                 user.setLoginPwd("pwd");
371                 user.setLoginId("Test");
372                 List<EPUser> expectedList = new ArrayList<EPUser>();
373                 expectedList.add(user);
374                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
375                 Mockito.when(userService.getUserByUserId(oldOnboardApp.myLoginsAppOwner)).thenReturn(expectedList);
376                 //Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
377                 Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
378                 
379
380                 FieldsValidator expectedFieldValidator = new FieldsValidator();
381                 expectedFieldValidator.setHttpStatusCode((long) 200);
382                 expectedFieldValidator.setFields(null);
383                 expectedFieldValidator.setErrorCode(null);
384                 Mockito.when(appService.modifyOnboardingApp(oldOnboardApp, user)).thenReturn(expectedFieldValidator);
385                 //Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
386
387                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest.putOnboardAppExternal(mockedRequest, mockedResponse, appId, oldOnboardApp);
388                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
389                 }
390         
391         
392         @Test
393         public void putOnboardAppExternalTest() throws Exception {
394
395                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
396                 expectedportalRestResponse.setMessage("FieldsValidator [httpStatusCode=500, errorCode=null, fields=null]");
397                 expectedportalRestResponse.setResponse(null);
398                 PortalRestStatusEnum portalRestStatusEnum = null;
399                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
400                 
401                 Long appId = (long) 1;
402                 
403                 OnboardingApp oldOnboardApp = new OnboardingApp();
404                 oldOnboardApp.id = (long) 1;
405                 oldOnboardApp.name = "test";
406                 oldOnboardApp.url="test.com";
407                 oldOnboardApp.restUrl="test1.com";
408                 oldOnboardApp.myLoginsAppOwner="12";
409                 oldOnboardApp.restrictedApp=false;
410                 oldOnboardApp.isOpen=true;
411                 oldOnboardApp.isEnabled=true;
412                 
413                 
414                 EPUser user = mockUser.mockEPUser();
415                 user.setEmail("guestT@test.portal.onap.org");
416                 user.setLoginPwd("pwd");
417                 user.setLoginId("Test");
418                 List<EPUser> expectedList = new ArrayList<EPUser>();
419                 expectedList.add(user);
420                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
421                 Mockito.when(userService.getUserByUserId(oldOnboardApp.myLoginsAppOwner)).thenReturn(expectedList);
422                 //Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
423                 Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
424                 
425
426                 FieldsValidator expectedFieldValidator = new FieldsValidator();
427                 expectedFieldValidator.setHttpStatusCode((long) 500);
428                 expectedFieldValidator.setFields(null);
429                 expectedFieldValidator.setErrorCode(null);
430                 Mockito.when(appService.modifyOnboardingApp(oldOnboardApp, user)).thenReturn(expectedFieldValidator);
431                 //Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
432
433                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest.putOnboardAppExternal(mockedRequest, mockedResponse, appId, oldOnboardApp);
434                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
435                 }
436         
437         @Test
438         public void putOnboardAppExternalIsNotSuperAdminTest() throws Exception {
439
440         PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
441         expectedportalRestResponse.setMessage("User lacks Portal admin role: Test");
442         expectedportalRestResponse.setResponse(null);
443         PortalRestStatusEnum portalRestStatusEnum = null;
444         expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
445         
446         Long appId = (long) 1;
447         
448         OnboardingApp oldOnboardApp = new OnboardingApp();
449         oldOnboardApp.id = (long) 1;
450         oldOnboardApp.name = "test";
451         oldOnboardApp.url="test.com";
452         oldOnboardApp.restUrl="test1.com";
453         oldOnboardApp.myLoginsAppOwner="12";
454         oldOnboardApp.restrictedApp=false;
455         oldOnboardApp.isOpen=true;
456         oldOnboardApp.isEnabled=true;
457         
458         
459         EPUser user = mockUser.mockEPUser();
460         user.setEmail("guestT@test.portal.onap.org");
461         user.setLoginPwd("pwd");
462         user.setLoginId("Test");
463         List<EPUser> expectedList = new ArrayList<EPUser>();
464         expectedList.add(user);
465         Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
466         Mockito.when(userService.getUserByUserId(oldOnboardApp.myLoginsAppOwner)).thenReturn(expectedList);
467         //Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
468         Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(false);
469
470         FieldsValidator expectedFieldValidator = new FieldsValidator();
471         expectedFieldValidator.setHttpStatusCode((long) 200);
472         expectedFieldValidator.setFields(null);
473         expectedFieldValidator.setErrorCode(null);
474         //Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
475
476         PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest.putOnboardAppExternal(mockedRequest, mockedResponse, appId, oldOnboardApp);
477         assertEquals(actualPortalRestResponse, expectedportalRestResponse);
478         }
479         
480         @Test
481         public void putOnboardAppExternalWithExceptionTest() {
482                 PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
483                 expectedportalRestResponse.setMessage("java.lang.NullPointerException");
484                 expectedportalRestResponse.setResponse(null);
485                 PortalRestStatusEnum portalRestStatusEnum = null;
486                 expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
487                 EPUser user = mockUser.mockEPUser();
488                 user.setEmail("guestT@test.portal.onap.org");
489                 user.setLoginPwd("pwd");
490                 user.setLoginId("Test");
491                 Long appId = (long) 1;
492                 
493                 OnboardingApp oldOnboardApp = new OnboardingApp();
494                 oldOnboardApp.id = (long) 1;
495                 oldOnboardApp.name = "test";
496                 oldOnboardApp.url="test.com";
497                 oldOnboardApp.restUrl="test1.com";
498                 oldOnboardApp.myLoginsAppOwner="12";
499                 oldOnboardApp.restrictedApp=false;
500                 oldOnboardApp.isOpen=true;
501                 oldOnboardApp.isEnabled=true;
502                 Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
503                 Mockito.when(userService.getUserByUserId(oldOnboardApp.myLoginsAppOwner)).thenThrow(nullPointerException);
504                 PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest
505                                 .putOnboardAppExternal(mockedRequest, mockedResponse, appId,oldOnboardApp);
506                 assertEquals(actualPortalRestResponse, expectedportalRestResponse);
507         }
508         
509         @Test
510         public void postOnboardAppExternalwithExceptionTest() throws Exception {
511
512         PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
513         expectedportalRestResponse.setMessage("User lacks Portal admin role: Test");
514         expectedportalRestResponse.setResponse(null);
515         PortalRestStatusEnum portalRestStatusEnum = null;
516         expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
517         
518         Long appId = (long) 1;
519         
520         
521         
522         OnboardingApp newOnboardApp = new OnboardingApp();
523         //newOnboardApp.id = (long) 1;
524         newOnboardApp.name = "test";
525         newOnboardApp.url="test.com";
526         newOnboardApp.restUrl="test1.com";
527         newOnboardApp.myLoginsAppOwner="12";
528         newOnboardApp.restrictedApp=false;
529         newOnboardApp.isOpen=true;
530         newOnboardApp.isEnabled=true;
531         
532         
533         EPUser user = mockUser.mockEPUser();
534         user.setEmail("guestT@test.portal.onap.org");
535         user.setLoginPwd("pwd");
536         user.setLoginId("Test");
537         List<EPUser> expectedList = new ArrayList<EPUser>();
538         expectedList.add(user);
539         Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
540         Mockito.when(userService.getUserByUserId(newOnboardApp.myLoginsAppOwner)).thenReturn(expectedList);
541         //Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
542         Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(false);
543
544         FieldsValidator expectedFieldValidator = new FieldsValidator();
545         expectedFieldValidator.setHttpStatusCode((long) 200);
546         expectedFieldValidator.setFields(null);
547         expectedFieldValidator.setErrorCode(null);
548         //Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
549
550         PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest.postOnboardAppExternal(mockedRequest, mockedResponse,newOnboardApp);
551         assertEquals(actualPortalRestResponse, expectedportalRestResponse);
552         }
553
554         @Test
555         public void postOnboardAppExternalIsNotSuperAdminTest() throws Exception {
556
557         PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
558         expectedportalRestResponse.setMessage("java.lang.NullPointerException");
559         expectedportalRestResponse.setResponse(null);
560         PortalRestStatusEnum portalRestStatusEnum = null;
561         expectedportalRestResponse.setStatus(portalRestStatusEnum.ERROR);
562         
563         Long appId = (long) 1;
564         
565         
566         
567         OnboardingApp newOnboardApp = new OnboardingApp();
568         //newOnboardApp.id = (long) 1;
569         newOnboardApp.name = "test";
570         newOnboardApp.url="test.com";
571         newOnboardApp.restUrl="test1.com";
572         newOnboardApp.myLoginsAppOwner="12";
573         newOnboardApp.restrictedApp=false;
574         newOnboardApp.isOpen=true;
575         newOnboardApp.isEnabled=true;
576         
577         
578         EPUser user = mockUser.mockEPUser();
579         user.setEmail("guestT@test.portal.onap.org");
580         user.setLoginPwd("pwd");
581         user.setLoginId("Test");
582         List<EPUser> expectedList = new ArrayList<EPUser>();
583         expectedList.add(user);
584         Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
585         Mockito.when(userService.getUserByUserId(newOnboardApp.myLoginsAppOwner)).thenReturn(expectedList);
586         //Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
587         Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
588
589         FieldsValidator expectedFieldValidator = new FieldsValidator();
590         expectedFieldValidator.setHttpStatusCode((long) 200);
591         expectedFieldValidator.setFields(null);
592         expectedFieldValidator.setErrorCode(null);
593         //Mockito.when(portalAdminService.createPortalAdmin(user.getOrgUserId())).thenReturn(expectedFieldValidator);
594
595         PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest.postOnboardAppExternal(mockedRequest, mockedResponse,newOnboardApp);
596         assertEquals(actualPortalRestResponse, expectedportalRestResponse);
597         }
598         
599         @Test
600         public void postOnboardAppExternalIsSuperAdminTest() throws Exception {
601
602         PortalRestResponse<String> expectedportalRestResponse = new PortalRestResponse<String>();
603         expectedportalRestResponse.setMessage(null);
604         expectedportalRestResponse.setResponse(null);
605         PortalRestStatusEnum portalRestStatusEnum = null;
606         expectedportalRestResponse.setStatus(portalRestStatusEnum.OK);
607         
608         Long appId = (long) 1;
609         
610         
611         
612         OnboardingApp newOnboardApp = new OnboardingApp();
613         //newOnboardApp.id = (long) 1;
614         newOnboardApp.name = "test";
615         newOnboardApp.url="test.com";
616         newOnboardApp.restUrl="test1.com";
617         newOnboardApp.myLoginsAppOwner="12";
618         newOnboardApp.restrictedApp=false;
619         newOnboardApp.isOpen=true;
620         newOnboardApp.isEnabled=true;
621         
622         
623         EPUser user = mockUser.mockEPUser();
624         user.setEmail("guestT@test.portal.onap.org");
625         user.setLoginPwd("pwd");
626         user.setLoginId("Test");
627         List<EPUser> expectedList = new ArrayList<EPUser>();
628         expectedList.add(user);
629         Mockito.when(EPUserUtils.getUserSession(mockedRequest)).thenReturn(user);
630         Mockito.when(userService.getUserByUserId(newOnboardApp.myLoginsAppOwner)).thenReturn(expectedList);
631         //Mockito.when(userService.saveNewUser(user, "Yes")).thenReturn(null);
632         Mockito.when(adminRolesService.isSuperAdmin(user)).thenReturn(true);
633
634         FieldsValidator expectedFieldValidator = new FieldsValidator();
635         expectedFieldValidator.setHttpStatusCode((long) 200);
636         expectedFieldValidator.setFields(null);
637         expectedFieldValidator.setErrorCode(null);
638         Mockito.when(appService.addOnboardingApp(newOnboardApp, user)).thenReturn(expectedFieldValidator);
639
640         PortalRestResponse<String> actualPortalRestResponse = appsControllerExternalRequest.postOnboardAppExternal(mockedRequest, mockedResponse,newOnboardApp);
641         assertEquals(actualPortalRestResponse, expectedportalRestResponse);
642         }
643         
644 }