public class XacmlPolicyUtils {
private static final Logger LOGGER = LoggerFactory.getLogger(XacmlPolicyUtils.class);
+ private static final String DOT_FILE_SUFFIX = ".file";
+ private static final String NOT_FOUND_MESSAGE = "NOT FOUND";
private XacmlPolicyUtils() {
super();
id++;
} else {
referencedPolicies.add(refId);
- properties.put(refId + ".file", refPolicyPath.toAbsolutePath().toString());
+ properties.put(refId + DOT_FILE_SUFFIX, refPolicyPath.toAbsolutePath().toString());
break;
}
}
boolean found = false;
Set<String> referencedPolicies = XACMLProperties.getReferencedPolicyIDs(properties);
for (String refPolicy : referencedPolicies) {
- String refPolicyFile = refPolicy + ".file";
+ String refPolicyFile = refPolicy + DOT_FILE_SUFFIX;
//
// If the key and value match, then it will return true
//
Set<String> rootPolicies = XACMLProperties.getRootPolicyIDs(properties);
logger.debug("Root Policies: {}", properties.getProperty(XACMLProperties.PROP_ROOTPOLICIES));
for (String root : rootPolicies) {
- logger.debug("{}", properties.getProperty(root + ".file", "NOT FOUND"));
+ logger.debug("{}", properties.getProperty(root + DOT_FILE_SUFFIX, NOT_FOUND_MESSAGE));
}
//
// Get the current set of referenced policy ids
Set<String> referencedPolicies = XACMLProperties.getReferencedPolicyIDs(properties);
logger.debug("Referenced Policies: {}", properties.getProperty(XACMLProperties.PROP_REFERENCEDPOLICIES));
for (String ref : referencedPolicies) {
- logger.debug("{}", properties.getProperty(ref + ".file", "NOT FOUND"));
+ logger.debug("{}", properties.getProperty(ref + DOT_FILE_SUFFIX, NOT_FOUND_MESSAGE));
}
}
}
Map<String, Object> resources = decisionRequest.getResource();
for (Entry<String, Object> entry : resources.entrySet()) {
- if (entry.getKey().equals("policy-id")) {
+ if ("policy-id".contentEquals(entry.getKey())) {
//
// TODO handle lists of policies
//
request.resource = entry.getValue().toString();
continue;
}
- if (entry.getKey().equals("policy-type")) {
+ if ("policy-type".contentEquals(entry.getKey())) {
//
// TODO handle lists of policies
//