waynedunican [Wed, 2 Jun 2021 10:57:55 +0000 (11:57 +0100)]
Fix build failure and remove unused imports
Issue-ID: POLICY-3339
Change-Id: I0c9bd25e63b24ba3ac7e38a77e963fcdbaa4d26a
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Tue, 1 Jun 2021 14:42:08 +0000 (14:42 +0000)]
Merge "support external configuration of pdp groups"
jhh [Thu, 27 May 2021 19:41:11 +0000 (14:41 -0500)]
support external configuration of pdp groups
- modify policy-pap.sh to optionally provision
a custom group if such a file is present.
Issue-ID: POLICY-3331
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib53bc14ee6b9471ab48f5a792b4283db3ed53b93
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
waynedunican [Mon, 10 May 2021 11:12:56 +0000 (12:12 +0100)]
Update PAP to check for deployed policies only
Have PAP compare the returned list against the delta deployment list instead of comparing against the full list of policies as is the current behaviour. Any references to "get" or "set" policies methods have also been removed
Issue-ID: POLICY-3263
Change-Id: I0efe03e835db3c4b2136f7e742bba0e78dc2ac44
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Signed-off-by: WayneDunican <wayne.dunican@est.tech>
Ram Krishna Verma [Thu, 13 May 2021 19:28:28 +0000 (15:28 -0400)]
Remove csit folder from policy/pap
The csit test files for all repos have been consolidated in policy/docker to maintain them at single place and allow us to trigger verify jobs in gerrit reviews.
Issue-ID: POLICY-3257
Change-Id: I8f80d6a8b56fd5c931f2ba1801c855c125d9704c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Thu, 6 May 2021 21:32:21 +0000 (17:32 -0400)]
Fix sonars in policy-pap
Fixed:
- use "var" instead of actual type
- remove unused parameter
- remove un-thrown exception from method declaration
- call isPresent() before Optional.get()
- check empty list before invoking doesNotContain()
Issue-ID: POLICY-3285
Change-Id: Ic90dccfd591c102ce29f14084f025b3ca69587dc
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Thu, 6 May 2021 19:30:11 +0000 (19:30 +0000)]
Merge "Query deployed policies by regex"
arkadiusz.adamski [Tue, 13 Apr 2021 10:23:28 +0000 (11:23 +0100)]
Query deployed policies by regex
- Query deployed policies by regex on the name, for a given policy type
Issue-ID: POLICY-2535
Signed-off-by: arkadiusz.adamski <aadamski@est.tech>
Change-Id: Ia2be683d044b22e4104ae14e2ce301882091c8ea
Ram Krishna Verma [Wed, 5 May 2021 16:55:29 +0000 (12:55 -0400)]
Remove deprecated robot methods in pap csit
Removing the deprecated methods from pap csit as they will be no longer supported by robot framework.
Issue-ID: POLICY-3257
Change-Id: I2aab85a6704ab12b732ef97e23db6acd60e0e7c0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Mon, 3 May 2021 21:34:46 +0000 (21:34 +0000)]
Merge "Remove GroupValidationResult"
Jim Hahn [Tue, 27 Apr 2021 14:30:14 +0000 (10:30 -0400)]
Remove GroupValidationResult
Removed GroupValidationResult, replacing it with BeanValidationResult.
Modified the ParameterGroup subclasses to use BeanValidator, adding
annotations where needed to trigger the validations that had been
automatically performed by GroupValidationResult.
Issue-ID: POLICY-2059
Change-Id: I9597dc84e8a81ac5b8954bb2ce4ad0d7e2a3a4a7
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Tue, 27 Apr 2021 15:51:45 +0000 (16:51 +0100)]
Fixing issue where PdpHeartbeats are incorrectly processed by PAP
The below 2 issues are fixed in this review:
1) When updating the policiesToBeUndeployed, the policies list in the
message itself was getting removed, which resulted in incorrect
processing. This was the reason for continuos UPDATE and STATE_CHANGE
messages from PAP to PDP.
2) In case if the policy list in heartbeat doesn't include one or more
policies that are supposed to be deployed(as per DB), the PAP should
send UPDATE messages to PDP asking to deploy them too. But this was
not working as the policiesToBeDeployed list was not getting
initialized properly before getting processed.
Change-Id: I06dbfd1d40bae8a510fc5500fbd38fb87c203c0d
Issue-ID: POLICY-3248
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Ram Krishna Verma [Fri, 16 Apr 2021 13:58:22 +0000 (13:58 +0000)]
Merge "Address plugin-not-found issues"
adheli.tavares [Thu, 15 Apr 2021 09:03:11 +0000 (10:03 +0100)]
Refactor PapCommandLineArguments class
CMD Args class to extend functionality from Common CMD class.
Issue-ID: POLICY-3129
Change-Id: Ia00cf7b0277e779811eaac556eebe11da95ed380
Signed-off-by: adheli.tavares <adheli.tavares@est.tech>
Jim Hahn [Thu, 15 Apr 2021 20:12:33 +0000 (16:12 -0400)]
Address plugin-not-found issues
Removed references to archetype-packaging and lifecycle-mapping, where
unnecessary due to pom inheritance.
Issue-ID: POLICY-3136
Change-Id: I7483ccd96876f9babb64c0899eb03d6cf0b195f2
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Wed, 7 Apr 2021 15:33:16 +0000 (15:33 +0000)]
Merge "Use sh instead of ash in PAP"
Jim Hahn [Tue, 6 Apr 2021 19:39:14 +0000 (15:39 -0400)]
Use sh instead of ash in PAP
Issue-ID: POLICY-3160
Change-Id: I79c41aa584efd3f4c617fd7c6de9ccf3862eb34d
Signed-off-by: Jim Hahn <jrh3@att.com>
Pamela Dragosh [Thu, 1 Apr 2021 12:08:23 +0000 (12:08 +0000)]
Merge "PAP S3P jmx file changes"
waynedunican [Tue, 30 Mar 2021 08:11:06 +0000 (09:11 +0100)]
PAP S3P jmx file changes
Issue-ID: POLICY-3110
Change-Id: I679dc16fedccda496e2030e8a0cc2e74b8787d9d
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Mon, 29 Mar 2021 20:31:23 +0000 (16:31 -0400)]
Validate parameters of REST calls
Added code to validate the parameters of the REST calls. As it turned
out, validation only needed to be added to one call.
Issue-ID: POLICY-2542
Change-Id: Ia9aabf75e06d6d5f996be9e3ed804218319f70c2
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Fri, 19 Mar 2021 15:51:59 +0000 (11:51 -0400)]
Delete keystores from pap
The Keystore is no longer needed in the tarball, as it is supplied
externally by the CSITs and Helm charts. Deleted that file.
Also modified the junits to use utils-test to generates keystores at
runtime, thus deleted the junit keystore file, too.
Issue-ID: POLICY-3143
Change-Id: I2b0c4868613e0923aad87844dd16f3ac236d4291
Signed-off-by: Jim Hahn <jrh3@att.com>
liamfallon [Thu, 18 Mar 2021 15:38:01 +0000 (15:38 +0000)]
Bump policy references to latest snapshot versions
Issue-ID: POLICY-3105
Change-Id: I81d6d343a22b2e27d1b7109d5a918e792ce674fb
Signed-off-by: liamfallon <liam.fallon@est.tech>
jhh [Tue, 16 Mar 2021 15:35:12 +0000 (10:35 -0500)]
Update policy-keystore with newer certificates
Issue-ID: POLICY-3139
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I728118f2eb691dddb93b36c832eb4c8a72e0d5af
liamfallon [Fri, 12 Mar 2021 09:28:34 +0000 (09:28 +0000)]
Bump PAP to 2.5.0-SNAPSHOT
Issue-ID: POLICY-3105
Change-Id: I558a09dcc5a28df1a978f760b5fe0eeee72aeb30
Signed-off-by: liamfallon <liam.fallon@est.tech>
Pamela Dragosh [Wed, 10 Mar 2021 18:00:14 +0000 (18:00 +0000)]
Merge "Bump pap to 2.4.2-SNAPSHOT"
waynedunican [Wed, 10 Mar 2021 17:11:28 +0000 (17:11 +0000)]
Bump pap to 2.4.2-SNAPSHOT
Issue-ID: POLICY-3127
Change-Id: I0949f9e03a538e3f9ba463697885b799fd0b2acb
Signed-off-by: waynedunican <wayne.dunican@est.tech>
waynedunican [Wed, 10 Mar 2021 16:24:54 +0000 (16:24 +0000)]
Release pap 2.4.1 docker
Issue-ID: POLICY-3127
Change-Id: I87b64768b13e376e38a670e3fb687b137050275b
Signed-off-by: waynedunican <wayne.dunican@est.tech>
waynedunican [Wed, 10 Mar 2021 15:10:55 +0000 (15:10 +0000)]
Release pap 2.4.1 maven artifacts
Issue-ID: POLICY-3127
Change-Id: I9ef1b95a8f2591f6cbdd8106142d015ccd507567
Signed-off-by: waynedunican <wayne.dunican@est.tech>
waynedunican [Wed, 10 Mar 2021 11:52:41 +0000 (11:52 +0000)]
Point to policy-models 2.4.1
Issue-ID: POLICY-3127
Change-Id: I97af3ae7c118cb5ec316a4b8bbb4c0bfff328f06
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Fri, 5 Mar 2021 21:01:42 +0000 (16:01 -0500)]
Use models 2.4.1-SNAPSHOT in PAP
Done to resolve EntityNotFoundException in windriver lab and in junit
tests.
Issue-ID: POLICY-3125
Change-Id: I5dbdf732154ee725ae9555722cde5d1f2008223c
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Wed, 24 Feb 2021 15:37:03 +0000 (10:37 -0500)]
Update info.yaml in pap
Issue-ID: POLICY-3028
Change-Id: Ic84724605ac2fc56c1391b0e0a2ad6f10e551545
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 23 Feb 2021 20:11:48 +0000 (15:11 -0500)]
Bump pap to 2.4.1-SNAPSHOT
Issue-ID: POLICY-3088
Change-Id: I74f23c31db609ca61592ec62b0594445bb8bf68c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 23 Feb 2021 18:19:37 +0000 (13:19 -0500)]
Release pap 2.4.0 docker image
Issue-ID: POLICY-3088
Change-Id: I1d7264a4808a787955f17537b4710f1585d92727
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 23 Feb 2021 17:15:13 +0000 (12:15 -0500)]
Release pap 2.4.0 version
Issue-ID: POLICY-3088
Change-Id: I7bbbb1008e74e8245c1ae0b31a204b2548913e8b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 23 Feb 2021 16:14:07 +0000 (11:14 -0500)]
Point to released version of jre
Issue-ID: POLICY-3088
Change-Id: I467866accd2d573478282560ebe81a7923f62dc9
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 23 Feb 2021 15:22:40 +0000 (10:22 -0500)]
Point to released version of dependencies
Issue-ID: POLICY-3088
Change-Id: Ie1cfd8b08a48881738966b1ce86f5f9c88a6e537
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
waynedunican [Wed, 10 Feb 2021 12:00:04 +0000 (12:00 +0000)]
Support Policy updates between PAP and PDPs
Change to send only the policies that need to be updated (deployed/undeployed)
rather than full of policies to DMaap via the PDP_UPDATE message
Issue-ID: POLICY-2112
Change-Id: I65f8bf46f230afb9d4b6937cb89af1d9f05d2fbd
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Mon, 22 Feb 2021 12:44:39 +0000 (12:44 +0000)]
Merge "Refactor Pap code to use Instant from Date"
rameshiyer27 [Wed, 17 Feb 2021 18:07:25 +0000 (18:07 +0000)]
Refactor Pap code to use Instant from Date
Issue-ID: POLICY-3069
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I0e1b8ccc41749cd53a299397c8399f833279df59
a.sreekumar [Thu, 18 Feb 2021 14:13:29 +0000 (14:13 +0000)]
Update Pdp policy status during registration or State change
The Pdp Policy Status is not updated during the pdp heartbeat
handling/registration flow, or during State change.
When a PDP goes down the pdppolicystatus gets cleared. But when the PDP
comes back online, PAP deploys the right policies into it, but the
deployment status was not getting updated.
Similarly, when the State is changed to PASSIVE, the status should be
undeployed, and when the state is changed back to ACTIVE, then the
status should be deployed for any active policies in any PDP.
These issues are fixed here.
Updating postman collection.
Also updating the csit test to check for 202 instead of 200 for the
deployment api response.
Change-Id: I1e05f22df23daaa8da8be1376413e995be2376f3
Issue-ID: POLICY-2526
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Thu, 18 Feb 2021 21:10:23 +0000 (16:10 -0500)]
Update PAP CSIT to check 202 response
Issue-ID: POLICY-2526
Change-Id: I3f4e1289fb4c8aeb4833d3e76b473cf36f907783
Signed-off-by: Jim Hahn <jrh3@att.com>
a.sreekumar [Mon, 15 Feb 2021 13:05:44 +0000 (13:05 +0000)]
Updating PAP deployment API to reflect actual status
Change-Id: I5281937fe5a742916c0c86983f71e280bbe126b2
Issue-ID: POLICY-2526
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Fri, 12 Feb 2021 12:46:30 +0000 (07:46 -0500)]
Fix sonars from dependency upgrade
The dependency upgrades in policy-parent caused some new sonars. In
particular, initMocks() has been deprecated - replaced with calls to the
Mockito Runner and one call to openMocks().
Issue-ID: POLICY-2911
Change-Id: I6f28af9af41a1e5c83dead2eabf580731ffb9526
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 10 Feb 2021 22:25:39 +0000 (17:25 -0500)]
More sonars in pap
Addressed the following issues:
- don't use eq() with verify()
Issue-ID: POLICY-2911
Change-Id: Idf08195e4e2fb74e5e0d0d30f31b9e630720f48f
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Mon, 8 Feb 2021 23:20:16 +0000 (23:20 +0000)]
Merge "Make filters on TOSCA entities generic"
liamfallon [Sun, 7 Feb 2021 15:23:31 +0000 (15:23 +0000)]
Make filters on TOSCA entities generic
The classes PolicyTypeFilter and PolicyFilter only work on Policy types
and policies. However they just filter on name/version/type/typeversion
so there is no reason that the filters could not be applied to other
entities.
This commit adapts the PolicyTypeFilter to EntityFilter and PolicyFilter
to TypedEntityFilter, so the filters can be applied to collections of
any ToscaEntity class.
Issue-ID: POLICY-2995
Change-Id: I7cc0ffa23fb12ab5b6e7617491dccd6f3289fa22
Signed-off-by: liamfallon <liam.fallon@est.tech>
Taka Cho [Fri, 5 Feb 2021 15:00:39 +0000 (10:00 -0500)]
move pap csit to policy repo
move pap csit plans/tests
to policy/pap repo
Issue-ID: POLICY-2895
Change-Id: I5a64f96d609f4aa39933ef0ca387fbd8dd5b468b
Signed-off-by: Taka Cho <takamune.cho@att.com>
Jim Hahn [Mon, 11 Jan 2021 15:53:54 +0000 (10:53 -0500)]
Make PAP stateless
Removed old code that tracked the status using a cache. Modified the
code to use the status found in the DB instead.
Issue-ID: POLICY-2648
Change-Id: I4f1f5201eff7b3352631f50d67c40349ac7f2014
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Thu, 14 Jan 2021 13:32:40 +0000 (08:32 -0500)]
Add class to manage policy deployment records
Issue-ID: POLICY-2648
Change-Id: Icbb9545e3df6942e6f9cf98689607c461f6c8cdd
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Wed, 13 Jan 2021 15:40:01 +0000 (10:40 -0500)]
Add notification tracking classes
When PAP is made stateless, a new mechanism will be needed to track and
generate notifications. Added some classes to facilitate that.
Issue-ID: POLICY-2648
Change-Id: Ib7b707f68a557e7b306dfdd1c6e6e9abd4671ec1
Signed-off-by: Jim Hahn <jrh3@att.com>
Ram Krishna Verma [Wed, 6 Jan 2021 18:58:10 +0000 (18:58 +0000)]
Merge "Changed identifiers to concept identifiers"
Taka Cho [Tue, 5 Jan 2021 20:09:40 +0000 (15:09 -0500)]
use jre base 2.2.0 - pap
use jre base 2.2.0
Issue-ID: POLICY-2917
Change-Id: Ic96af393c7c8689438c2072113ab53a647477d48
Signed-off-by: Taka Cho <takamune.cho@att.com>
liamfallon [Mon, 4 Jan 2021 13:35:29 +0000 (13:35 +0000)]
Changed identifiers to concept identifiers
The policy models tosca classes ToscaPolicyIdentifier and
ToscaPolicyIdentifierOptVersion can be used to identify any TOSCA
concept, not just TOSCA policies so they are renamed to
ToscaConceptIdentifier and ToscaCinceptIdentifierOptVersion
respectively.
The class ToscaPolicyTypeIdentifier is redundant and is replaced by
ToscaConceptIdentifier.
Issue-ID: POLICY-2900
Change-Id: I22bb3fdbaf2e237221a5c89afbf7898410603835
Signed-off-by: liamfallon <liam.fallon@est.tech>
liamfallon [Thu, 17 Dec 2020 16:37:22 +0000 (16:37 +0000)]
Update persistence.xml with new TOSCA classes
Issue-ID: POLICY-2900
Change-Id: I986074f69bef24ca894adc38eaf8b3ca4b4dc5a2
Signed-off-by: liamfallon <liam.fallon@est.tech>
a.sreekumar [Fri, 4 Dec 2020 10:22:17 +0000 (10:22 +0000)]
Fixing sonar issues in policy-pap
Change-Id: I0f81906098c310aa5c437a2c06b708ae27560af8
Issue-ID: POLICY-2911
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Taka Cho [Mon, 30 Nov 2020 18:50:21 +0000 (13:50 -0500)]
move all bash to ash shell scripts - pap
bash scripts convert to ash
Issue-ID: POLICY-2847
Change-Id: Icbe4afd9abe7d3634cce9cd7fb5b72dad38ecfcf
Signed-off-by: Taka Cho <takamune.cho@att.com>
Pamela Dragosh [Fri, 6 Nov 2020 13:17:54 +0000 (08:17 -0500)]
Fix upcoming checkstyle issues
When we upgrade to oparent, these will fail as oparent upgrades
to 8.37 of puppycrawl which fixes a few bugs that should have
flagged these previously.
Issue-ID: POLICY-2887
Change-Id: I7c04f58c683d6eb0322232790e0561b464c1696a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ram Krishna Verma [Tue, 27 Oct 2020 19:01:18 +0000 (15:01 -0400)]
Point to snapshot versions
Issue-ID: POLICY-2875
Change-Id: If28419f52f22944deb4e2c186463b6a6d45f3db8
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Tue, 27 Oct 2020 17:54:36 +0000 (13:54 -0400)]
Bump pap master to 2.4.0-SNAPSHOT
Issue-ID: POLICY-2875
Change-Id: Ibad95f08cb39adc285f9326dd1d590163ede5803
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
a.sreekumar [Thu, 22 Oct 2020 11:50:24 +0000 (12:50 +0100)]
Policy-PAP S3P jmx changes
Change-Id: Ie6e57eb0a5f2174cfa934b65db8e1badaad7fe85
Issue-ID: POLICY-2830
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Pamela Dragosh [Tue, 20 Oct 2020 14:53:26 +0000 (10:53 -0400)]
Bump pap 2.3.4 SNAPSHOT
Issue-ID: POLICY-2869
Change-Id: I3696c9c6cae59124f0269f1d2619b22b134b882c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 20 Oct 2020 14:25:42 +0000 (10:25 -0400)]
Release pap 2.3.3 docker
Issue-ID: POLICY-2869
Change-Id: I337d94f4aa953393ad427f360396e9b4a99a267e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 20 Oct 2020 13:56:00 +0000 (09:56 -0400)]
Release pap 2.3.3 java
Issue-ID: POLICY-2869
Change-Id: If162af7f6acaf918b8c7ed695a38974278d56e33
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Tue, 20 Oct 2020 12:06:09 +0000 (08:06 -0400)]
Point pap to models 2.3.5
Issue-ID: POLICY-2869
Change-Id: I32af99a8aea526f2f17637ac594171d356ad1de6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 7 Oct 2020 20:35:58 +0000 (16:35 -0400)]
Bump pap to 2.3.3 snapshot
Issue-ID: POLICY-2839
Change-Id: I37704935946a8c249e814bf4e515178528705cd6
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 7 Oct 2020 20:17:13 +0000 (16:17 -0400)]
Release pap 2.3.2 docker
Issue-ID: POLICY-2839
Change-Id: I373ce0158a98c9a015d90b39f83ee4d3cfe34da3
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 7 Oct 2020 19:49:16 +0000 (15:49 -0400)]
Release pap 2.3.2 java artifacts
Issue-ID: POLICY-2839
Change-Id: I1ce15389ccddf38abf59e6174f7b28e873bd8876
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Wed, 7 Oct 2020 19:15:10 +0000 (15:15 -0400)]
Point to models 2.3.2 release
Released models
Issue-ID: POLICY-2839
Change-Id: Ice732bdb5da24c82e60b8b6babc8737892b9d226
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ram Krishna Verma [Mon, 5 Oct 2020 18:59:48 +0000 (14:59 -0400)]
Remove legacy operational apex policy type from pap
The legacy operational policy type for apex has been removed in Guilin release.
Removing it fron pdpGroup config in PAP.
Issue-ID: POLICY-2857
Change-Id: Iddf2e6b6301dbab3addcbff4c806142f4cf8e6c6
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Wed, 30 Sep 2020 14:47:12 +0000 (10:47 -0400)]
Fix new sonars in policy/pap
Addressed the following sonar issues:
- too many assertions in test method
- extract common test method
- replace this null literal by an "Optional" object
Issue-ID: POLICY-2679
Change-Id: Ie80e5c5fdb94230a2773ea2931758cf54204ae86
Signed-off-by: Jim Hahn <jrh3@att.com>
jhh [Thu, 24 Sep 2020 20:08:48 +0000 (15:08 -0500)]
update default keystores
Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I95db673538947cccc39bb5a389ab3f544fa91af8
Ram Krishna Verma [Wed, 16 Sep 2020 14:53:17 +0000 (10:53 -0400)]
Remove base64 encoding of password from pap
Remove base64 encoding of db password from pap configuration.
Issue-ID: POLICY-2550
Change-Id: I08f25adbe75b9573ed58424d142895eb8353b3f0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Mon, 14 Sep 2020 22:05:11 +0000 (18:05 -0400)]
Use alpine base image 2.1.1
Issue-ID: POLICY-2819
Change-Id: I6d5b1d1356ec332cd0bdbe446ce7e8d48533ef71
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 8 Sep 2020 21:50:43 +0000 (17:50 -0400)]
Bump pap to 2.3.2
Issue-ID: POLICY-2789
Change-Id: Ie4d4df890c1faac0e09d78d3b0d0157d8ef95410
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 8 Sep 2020 21:02:52 +0000 (17:02 -0400)]
Release 2.3.1 pap docker images
Issue-ID: POLICY-2789
Change-Id: Ie1d30e816c7500b3a55f303638c85636dc98e8b9
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 8 Sep 2020 20:12:50 +0000 (16:12 -0400)]
Release 2.3.1 pap artifacts
Issue-ID: POLICY-2789
Change-Id: Ib7292ad66950839176b6ceb3822e1be3dade1692
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 8 Sep 2020 19:07:24 +0000 (15:07 -0400)]
Use released versions in pap
Issue-ID: POLICY-2789
Change-Id: Ib3d48a3cbfe83a33ea9483447dc26e051a44ab2e
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Fri, 4 Sep 2020 13:00:49 +0000 (09:00 -0400)]
point to 2.1.0 policy-alpine base - pap
In G-rel, using 2.1.0 base.
Issue-ID: POLICY-2789
Change-Id: Ib5d85477a0ffe844bf22a3d61d162c71a4319f5a
Signed-off-by: Taka Cho <takamune.cho@att.com>
Pamela Dragosh [Mon, 24 Aug 2020 19:59:57 +0000 (15:59 -0400)]
Add Match Policy Type to default group
Default group will now have match Policy Type.
Issue-ID: POLICY-2596
Change-Id: I53c07b417097dc8250191e6ee8d043488b02562d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 17 Aug 2020 20:44:39 +0000 (16:44 -0400)]
Add new guard filter to defaultGroup
New guard filter should be advertised by pap.
Issue-ID: POLICY-2590
Change-Id: I7652057d4d759e60c358ee9fad84a8c6a9af6898
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
a.sreekumar [Fri, 14 Aug 2020 15:49:40 +0000 (16:49 +0100)]
Using standard success/failure messages in PAP
Change-Id: If4613c0fc6f940bc82cf616aba2ba9cc03e1b599
Issue-ID: POLICY-2754
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Pamela Dragosh [Mon, 10 Aug 2020 14:45:19 +0000 (14:45 +0000)]
Merge "Changes to make PAP container crash with non zero exitCode"
a.sreekumar [Fri, 7 Aug 2020 14:24:10 +0000 (15:24 +0100)]
Changes to make PAP container crash with non zero exitCode
Make the application to return exitCode as 1 when the main process
terminates due to issues such as:
1) Any basic issue in the startup config file causing error and
terminates the main process, for e.g. a wrong name in parameterGroup.
2) Wrong info specified for database connectivity, say wrong username.
This doesn't impact a case where database isn't ready yet and PAP
container comes up first, such waiting is already handled by
initContainer in the oom chart. PAP pod waits for policy-mariadb pod to
be ready first, then only the main process is started and comes to this
point.
3) An invalid port number is specified and the rest server is not able
to start.
These are the some of the scenarios which already makes the main process
of PAP to terminate, and in these cases, an exception is thrown now which
returns the exitCode as 1.
Change-Id: Ie48726bcb36d7304eb60807fbaabbee8245e9c70
Issue-ID: POLICY-2754
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
Jim Hahn [Fri, 7 Aug 2020 13:47:58 +0000 (13:47 +0000)]
Merge "Fail component health check if PDP is down"
Ram Krishna Verma [Thu, 6 Aug 2020 22:06:17 +0000 (18:06 -0400)]
Fail component health check if PDP is down
Changing the policy component health check to fail if the required
PDP instances are down or not registered with PAP.
The check is performed by comparing the "currentInstanceCount"
& "desiredInstanceCount" fields of PdpSubGroup.
Issue-ID: POLICY-2718
Change-Id: Iad1075d0812f4ef166dfed4f110eff4d9e5f995e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Thu, 6 Aug 2020 20:24:13 +0000 (16:24 -0400)]
Remove legacy operational policy from pap
Issue-ID: POLICY-2763
Change-Id: I9701a80cca10b9fd49d8060ecb6601097ca5824d
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
jhh [Mon, 3 Aug 2020 20:18:59 +0000 (15:18 -0500)]
environment variables to support cert. store paths
Issue-ID: POLICY-2615
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I077bd1b8ff30b0d0ac620dab37a24cbe7776ca15
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Ram Krishna Verma [Thu, 30 Jul 2020 19:48:56 +0000 (15:48 -0400)]
Update info yaml in policy/pap
Issue-ID: POLICY-2738
Change-Id: Id0b6854fa4849f1a3e019fd76f875b29b8b5cf01
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Fri, 24 Jul 2020 17:09:36 +0000 (13:09 -0400)]
Add Ajith to policy/pap info
Issue-ID: POLICY-2738
Change-Id: Id71e48fd505ef529f3e710166f961f71d73665af
Signed-off-by: Jim Hahn <jrh3@att.com>
Taka Cho [Fri, 17 Jul 2020 15:30:31 +0000 (11:30 -0400)]
point to SNAPSHOT for pap
Issue-ID: POLICY-2695
Change-Id: If21e048fda0375ac03309f520a675a4fd505187d
Signed-off-by: Taka Cho <takamune.cho@att.com>
Ram Krishna Verma [Fri, 10 Jul 2020 13:52:29 +0000 (09:52 -0400)]
Bump pap to 2.3.1-SNAPSHOT
Issue-ID: POLICY-2695
Change-Id: I7f30fa9c89d7ad9ddc00644c170d8659f7ee3230
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Fri, 10 Jul 2020 02:07:39 +0000 (22:07 -0400)]
Release pap docker 2.3.0 artifacts
Issue-ID: POLICY-2695
Change-Id: I1109acd92121dfeb35e1da94da43f3eac43fcf75
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Thu, 9 Jul 2020 22:47:24 +0000 (18:47 -0400)]
Release pap maven 2.3.0 artifacts
Issue-ID: POLICY-2695
Change-Id: I80d696fac311018b23d24d4a82e4423544a4aafc
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Ram Krishna Verma [Thu, 9 Jul 2020 20:39:50 +0000 (16:39 -0400)]
Refer to released version in policy/pap
Issue-ID: POLICY-2695
Change-Id: I300a2aa7eede8dbeedf3ebafc9914a62cc47b34e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
Jim Hahn [Tue, 7 Jul 2020 16:50:56 +0000 (12:50 -0400)]
Add fetch timeout to PAP properties
When an error occurs fetching from DMaaP, PAP should not try again
immediately, but should wait a little bit before retrying. Added the
the fetch timeout property to prevent it from defaulting to -1 when
retrying.
Issue-ID: POLICY-2702
Change-Id: Ifeb9ca9dc51a5d2080c84ae877781b02c3041001
Signed-off-by: Jim Hahn <jrh3@att.com>
waynedunican [Wed, 1 Jul 2020 10:37:07 +0000 (11:37 +0100)]
Replace try/catch blocks with assertj - pap
Replaced try/catch blocks in policy/pap test cases with assertj
assertions
Issue-ID: POLICY-2451
Change-Id: Ic963558e812b59d321e12fa87e7285732d6761e5
Signed-off-by: waynedunican <wayne.dunican@est.tech>
Jim Hahn [Tue, 30 Jun 2020 19:47:12 +0000 (15:47 -0400)]
Point pap to snapshot versions
Issue-ID: POLICY-2391
Change-Id: I4b4239de3c840f0ecae82d1400a393bfdbbfa5ee
Signed-off-by: Jim Hahn <jrh3@att.com>
Jim Hahn [Tue, 30 Jun 2020 11:31:20 +0000 (07:31 -0400)]
Fix more sonars in pap
Somehow missed this sonar on one line of code:
- remove useless assignments
Apparently, sonar only complains about some useless assignments (perhaps
those that do more than copy a constant). Fixed one about which it did
not complain, which appeared immediately before the one about which it
DID complain.
At one point, sonar complained about creating ArrayLists without
specifying the initial size (when it was known). It didn't complain
about this one, but went ahead and fixed it anyway.
Issue-ID: POLICY-2679
Change-Id: I270341195634416db1f8152a95a5822c8d505803
Signed-off-by: Jim Hahn <jrh3@att.com>
Liam Fallon [Tue, 30 Jun 2020 07:36:30 +0000 (07:36 +0000)]
Merge "Fix issues in pap for new sonar rules"
Jim Hahn [Mon, 29 Jun 2020 15:53:42 +0000 (11:53 -0400)]
Fix issues in pap for new sonar rules
Addressed issues reported due to updates to the sonar rules:
- invoke only one method in a junit lambda
Issue-ID: POLICY-2679
Change-Id: I422856527b191a45b30a78bb8520f679ca2e7896
Signed-off-by: Jim Hahn <jrh3@att.com>
Code Review / policy / pap.git / log