Specify "Accept" header in A&AI requests 25/113725/1
authorJim Hahn <jrh3@att.com>
Fri, 9 Oct 2020 16:26:14 +0000 (12:26 -0400)
committerJim Hahn <jrh3@att.com>
Fri, 9 Oct 2020 16:27:30 +0000 (12:27 -0400)
Modified the A&AI superclass to specify application/json for the Accept
header.  Removed the header from the subclasses.

Issue-ID: POLICY-2863
Change-Id: I90974e305cb36ee2fa01999be4d79225a510e55b
Signed-off-by: Jim Hahn <jrh3@att.com>
models-interactions/model-actors/actor.aai/src/main/java/org/onap/policy/controlloop/actor/aai/AaiGetPnfOperation.java
models-interactions/model-actors/actor.aai/src/main/java/org/onap/policy/controlloop/actor/aai/AaiGetTenantOperation.java
models-interactions/model-actors/actor.aai/src/main/java/org/onap/policy/controlloop/actor/aai/AaiUtil.java
models-interactions/model-actors/actor.aai/src/test/java/org/onap/policy/controlloop/actor/aai/BasicAaiOperation.java

index d89d835..a4b3065 100644 (file)
@@ -26,7 +26,6 @@ import java.util.Map;
 import java.util.concurrent.CompletableFuture;
 import javax.ws.rs.client.Invocation.Builder;
 import javax.ws.rs.client.WebTarget;
-import javax.ws.rs.core.MediaType;
 import org.onap.policy.aai.AaiConstants;
 import org.onap.policy.common.endpoints.event.comm.Topic.CommInfrastructure;
 import org.onap.policy.common.endpoints.utils.NetLoggerUtil.EventType;
@@ -70,8 +69,6 @@ public class AaiGetPnfOperation extends AaiGetOperation {
     protected CompletableFuture<OperationOutcome> startOperationAsync(int attempt, OperationOutcome outcome) {
         Map<String, Object> headers = makeHeaders();
 
-        headers.put("Accept", MediaType.APPLICATION_JSON);
-
         StringBuilder str = new StringBuilder(getClient().getBaseUrl());
 
         String path = getPath() + URI_SEP + URLEncoder.encode(getTargetEntity(), StandardCharsets.UTF_8);
index fe11798..add9c64 100644 (file)
@@ -24,7 +24,6 @@ import java.util.Map;
 import java.util.concurrent.CompletableFuture;
 import javax.ws.rs.client.Invocation.Builder;
 import javax.ws.rs.client.WebTarget;
-import javax.ws.rs.core.MediaType;
 import org.onap.policy.aai.AaiConstants;
 import org.onap.policy.common.endpoints.event.comm.Topic.CommInfrastructure;
 import org.onap.policy.common.endpoints.utils.NetLoggerUtil.EventType;
@@ -65,9 +64,7 @@ public class AaiGetTenantOperation extends AaiGetOperation {
 
     @Override
     protected CompletableFuture<OperationOutcome> startOperationAsync(int attempt, OperationOutcome outcome) {
-        Map<String, Object> headers = makeHeaders();
-
-        headers.put("Accept", MediaType.APPLICATION_JSON);
+        final Map<String, Object> headers = makeHeaders();
 
         StringBuilder str = new StringBuilder(getClient().getBaseUrl());
 
index 14edc3a..c44e9d8 100644 (file)
@@ -22,6 +22,7 @@ package org.onap.policy.controlloop.actor.aai;
 
 import java.util.HashMap;
 import java.util.Map;
+import javax.ws.rs.core.MediaType;
 import org.onap.policy.controlloop.actorserviceprovider.parameters.ControlLoopOperationParams;
 
 /**
@@ -44,6 +45,7 @@ public class AaiUtil {
 
         headers.put("X-FromAppId", "POLICY");
         headers.put("X-TransactionId", params.getRequestId().toString());
+        headers.put("Accept", MediaType.APPLICATION_JSON);
 
         return headers;
     }
index 1f481ae..9479d06 100644 (file)
@@ -70,5 +70,6 @@ public abstract class BasicAaiOperation extends BasicHttpOperation {
     protected void verifyHeaders(Map<String, Object> headers) {
         assertEquals("POLICY", headers.get("X-FromAppId").toString());
         assertEquals(params.getRequestId().toString(), headers.get("X-TransactionId"));
+        assertEquals("application/json", headers.get("Accept").toString());
     }
 }