ONAP log files consolidation

Check in changes for pap,pdp,console,brmsgw,paplp and pdplp

Change-Id: I23525a44e0f269d04d9870c3eed18b6b8daacb2c
Issue-ID: POLICY-562
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>

Merge "JUnit additions for PDP,PDP-REST,SDK,XACML"

Merge "Fix a Bug on Checking Required Fields"

Fix a Bug on Checking Required Fields

Fix a bug in checking required fields if the object has include function

Issue-ID: POLICY-717
Change-Id: I766da50c9ac02081dd4e711b8c78be0f3c25e5bd
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>

Documentation edits

Fixing typos in modifying Release Template Page
-------------------------------------------------------------

Issue-ID: POLICY-536

Change-Id: I8334afe77761ae3fe5fbee35719957ec10af1c8f
Signed-off-by: Saryu Shah <ss3917@att.com>

Merge "Support CSIT tests for OOF Policy"

JUnit additions for PDP,PDP-REST,SDK,XACML

Issue-ID: POLICY-600
Change-Id: I8052451c3f66116f361f2963fcc2727c022dd4d9
Signed-off-by: bobbymander <bobby.mander@att.com>

Upgrade tomcat to resolve security issue

Tomcat resulted in 30+ CLM errors level 7-8.

Issue-ID: POLICY-507
Change-Id: If055426a9b3fd464063fb84f8105f35213e2701a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Documentation Update Release Template"

Support CSIT tests for OOF Policy

I added an INSERT to the sql upgrade file and some sonar fixes and
Junits

Change-Id: I37139d5a8ad78d9d46ee01f81c2edd052672712e
Issue-ID: POLICY-639
Signed-off-by: Michael Mokry <mm117s@att.com>

Documentation Update Release Template

Documentation Update Release Template
-------------------------------------------------------------

Change-Id: I827712a68820bccad0dcb1534cb96d5dd8bdb128
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>

JUnit additions for XACML,PAP-REST

Issue-ID: POLICY-605
Change-Id: I4b55a85eacf989ddb55743300e7f75e4b72882d0
Signed-off-by: bobbymander <bobby.mander@att.com>

POM fixes due to update in cadi-aaf

Issue-ID: POLICY-507
Change-Id: I493233f8e0e90eaf24e9c09c7433c6fb9fadb268
Signed-off-by: bobbymander <bobby.mander@att.com>

Merge "Fix a Bug in View Mode"

Merge "Removed checkstyle warnings"

Merge "JUnit additions for ONAP-REST"

Merge "Remove checkstyle warnings in policy/engine"

Fix a Bug in View Mode

To make MS template layout better for complex MS models and also add
parent level elments first in view mode.

Issue-ID: POLICY-714

Change-Id: If6bf472a504f15fd9bde05253e9369ba43bb082e
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>

Removed checkstyle warnings

Change-Id: I0701333d2b36a0796b592ce92b8015c1a56f8258
Issue-ID: POLICY-711
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>

Merge "Update docker tag convention"

JUnit additions for ONAP-REST

Issue-ID: POLICY-603
Change-Id: Ic8a20fc758927afb9200547d5919fcf70f15852b
Signed-off-by: bobbymander <bobby.mander@att.com>

Remove checkstyle warnings in policy/engine

Remove checkstyle warnings in policy/engine ONAP-PDP

Change-Id: Ibbe2d8c549c1f0c3ac8456c4d2de4c7d349dd171
Issue-ID: POLICY-713
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>

Update docker tag convention

Update docker scripts to comply with ONAP docker standard tag format

$VERSION-STAGING-YYYYMMDDTHHMMSSZ

Issue-ID: CIMAN-132
Change-Id: I28e2aea5425c614bf86b0a6f0e8fa0892ec018c3
Signed-off-by: mmis <michael.morris@ericsson.com>

Remove security issue xstream and plexus-utils

Some of these were ommitted from compile while others
were not completely ommitted.

Upgraded maven-compiler since it upgraded plexus-utils

Upgraded latest version of jackson-databind 2.9.5

Issue-ID: POLICY-507
Change-Id: If92ff4355329c48fbe76e0245d6c8344ebb8084d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Deployment documentation"

Merge "POM changes to centralize test scope deps"

Deployment documentation

Policy configuration of K8S
-------------------------------------------------------------

Change-Id: Ie9cfea697960c3cd6663527a65bb39645f337c19
Issue-ID: POLICY-536
Signed-off-by: Saryu Shah <ss3917@att.com>

POM changes to centralize test scope deps

Issue-ID: POLICY-600
Change-Id: I870317bbd125c6016818ec435ea7a406123c66c1
Signed-off-by: bobbymander <bobby.mander@att.com>

Remove ECOMP trademark

Issue-ID: POLICY-696
Change-Id: I8647740df0c38da93c8d918cae371890d7799052
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "ONAP code change for log files consolidation"

Merge "Documentation: Release Notes; Installation;"

ONAP code change for log files consolidation

Undo the change so this would not block other test activity

Change-Id: I4f7dd2e14f30034eefbf958be3c912af2962e8a2
Issue-ID: POLICY-562
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>

Documentation: Release Notes; Installation;

Included link for securites/vulnerabilities; Edit updates.
-------------------------------------------------------------

Change-Id: If37aceb8eb371fdcc8df43b7bff747236ae848f5
Issue-ID: POLICY-535
Signed-off-by: Saryu Shah <ss3917@att.com>

Merge "Remove checkstyle warnings in policy/engine"

Remove checkstyle warnings in policy/engine

Remove checkstyle warnings in policy/engine LogParser

Change-Id: Ia6ecc3ecbac51755262e5825a3f5ce8d89b79e4b
Issue-ID: POLICY-710
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>

JUnit additions and powermock pom fixes

Issue-ID: POLICY-602
Change-Id: I2484b47cc52a07413de69c1022a056fd0cf2d7d7
Signed-off-by: bobbymander <bobby.mander@att.com>

Change default argument path for logs directory

To align with the implementation

Change-Id: Ia32123e2bf87537e758ecc9fac8f14b6ca4ae562
Issue-ID: POLICY-533
Signed-off-by: Jorge Hernandez <jh1730@att.com>

Merge "Policy Installation documentation"

Policy Installation documentation

Updated Policy Installation documentation
-------------------------------------------------------------

Change-Id: I071c2c7fff7feb6a002ae9b753316c45864ed164
Issue-ID: POLICY-535
Signed-off-by: Saryu Shah <ss3917@att.com>

Merge "New Optimization Policy"

New Optimization Policy

This is the new Optimization Policy to support the Integration of
the OOF Policy Model into the Policy Platform.

Added changes from Frank Wang to fix the following issues with existing Model
Parser:
1. TOSCA Rendering issues
2. Matching Attributes support
3. ImportModelAPI to support TOSCA model upload via REST API

Running local Sonar tonight to start fixing Sonar issues

Added changes per review comments and fixed Sonar issues

Change-Id: Ia8ce09c28a718ce4460475e76a750caef774bd6b
Issue-ID: POLICY-622
Signed-off-by: Michael Mokry <mm117s@att.com>

Merge "ONAP code change for log files consolidation"

Merge "Fix final 10 vulnerabilities in policy/engine"

Merge "JUnit additions for PAP-REST,REST"

Merge "policy documentation links"

ONAP code change for log files consolidation

Code change for log files consolidation of PAP, PDP, BRMSGW, Console and db
script

Issue-ID: POLICY-562
Change-Id: I416ba7748b841bb2b1a31682e2b1631e279549e8
Signed-off-by: Chou, Joseph (JC2555) <jc2555@att.com>

policy documentation links

Included links
-------------------------------------------------------------

Change-Id: Id5d73e5b18d6c073ff2809b867e57cdda2b75ce7
Issue-ID: POLICY-535
Signed-off-by: Saryu Shah <ss3917@att.com>

Merge "Updated policy documentation"

Merge "Add database initialization to XACML PDP test"

JUnit additions for PAP-REST,REST

Issue-ID: POLICY-603
Change-Id: Id7d2c1a835d028e88337db67d55f139aa1764826
Signed-off-by: bobbymander <bobby.mander@att.com>

Updated policy documentation

Removed "Amsterdam"
-------------------

Change-Id: I713c5beb5759e2fc97d5244a644fa6ffd72b6eb5
Issue-ID: POLICY-535
Signed-off-by: Saryu Shah <ss3917@att.com>

Fix final 10 vulnerabilities in policy/engine

Code fixes for final 10 vulnerabilities in policy/engine

Change-Id: I234194b596bdacd5f3f9fd1becd4da9d6d0b5cf4
Issue-ID: POLICY-662
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>

Merge "Resolved the Policy Removal issue from PDP"

Add database initialization to XACML PDP test

This issue arose due to the order of execution of JUnit tests.

The tests in XACMLPAPTest failed becasue the database was not initialized.
Up till now, the @Before method in the test class
org.onap.policy.pap.ia.DbAuditCompareEntriesTesti initiated the database.
THis bug fix adds a similar @Before method to the XACMLPAPTest class
to initialize the database.

All other classes in the module were tested with both @Before methods
commented out to ensure that no other tests will fail due to this issue.

Issue-ID: POLICY-707
Change-Id: Ibce5fad5c006f7a92b3ef77bde4dc5ed6f7039ed
Signed-off-by: liamfallon <liam.fallon@ericsson.com>

Merge "Fix vulnerabilities and bugs in policy/engine"

Merge "JUnit additions for PDP-REST,REST,SDK-APP"

Resolved the Policy Removal issue from PDP

Issue-ID: POLICY-706
Change-Id: I2425e305ed660ea07662e0a26e713cc91ed92e72
Signed-off-by: rb7147 <rb7147@att.com>

Release Notes

Initial release notes for Beijing
-------------------------------------------------------------

Issue-ID: POLICY-535

Change-Id: Ia1da3b07fd305927a92c08225df452ee43d505f6
Signed-off-by: Saryu Shah <ss3917@att.com>

JUnit additions for PDP-REST,REST,SDK-APP

Issue-ID: POLICY-584
Change-Id: I3b16e2a957e67ecfe5c28d2afaa09771ae891216
Signed-off-by: bobbymander <bobby.mander@att.com>

Fix vulnerabilities and bugs in policy/engine

Code fixes for 1 bug and 17 vulnerabilities reported by Sonar in
policy/engine

Change-Id: I7b641795c790ec15418bd9ae3a414279e1b0f733
Issue-ID: POLICY-662
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>

Merge "JUnit additions for PAP-REST,REST,Utils"

Merge "Fix all bugs reported by Sonar in policy/engine"

JUnit additions for PAP-REST,REST,Utils

Issue-ID: POLICY-600
Change-Id: I9a432f9e8af43184d116d5eeb2fbbac65472564e
Signed-off-by: bobbymander <bobby.mander@att.com>

Add Matching Fields For MS Model

Fixed the missing function of matching fields for TOSCA Model

Issue-ID: POLICY-655
Change-Id: I41017a4cf01df7f4c36e086f76d169e3e216dc34
Signed-off-by: guangxingwang <gw1218@att.com>
Signed-off-by: Wang,Frank(gw1218) <gw1218@att.com>

Fix all bugs reported by Sonar in policy/engine

Code fixes for 27 bugs reported by Sonar in policy/engine

Change-Id: I96da96b38a2e2954ec549e5cdf6ed3ad1d76722c
Issue-ID: POLICY-662
Signed-off-by: eramkve <ram.krishna.verma@ericsson.com>

cookbook, updated architecture doc

policy documentation - cookbook, updated architecture
-------------------------------------------------------------

Issue-ID: POLICY-535

Change-Id: I7d13c145993692b8669f4855b0b23cc73eaa8142
Signed-off-by: Saryu Shah <ss3917@att.com>

Merge "JUnit additions for SDK-APP"

Merge "Fix Another Typo in dependency.json"

Merge "Policy Release Notes Updates"

Fix Another Typo in dependency.json

Unresolveable maven coordinates when building the rules jar caused by a
missing s in drools-applications.

Issue-ID: POLICY-660
Change-Id: I3e78fec9c9e58c10f2a9366d15447e8a3998d343
Signed-off-by: dc443y <dc443y@att.com>

Merge "Update oparent version to 1.1.0"

Policy Release Notes Updates

Updated Policy Release Notes for Amsterdam Maintenance Release
-------------------------------------------------------------

Change-Id: I748a9233fa1be1cf6ef729f3f78d39cba181d18c
Issue-ID: POLICY-486
Signed-off-by: Saryu Shah <ss3917@att.com>
(cherry picked from commit 374caf1b9b38893ee3efac301b5f81c2d64b1d08)

Fix type in dependency.json

The BRMSGW was unable to generate rules artifacts during docker
installation due to an unresolved dependency. A typo was discovered
in the problematic dependency which was causing the error.

Issue-ID: POLICY-660
Change-Id: If4dbe5e640f10d063fa5643112338b10fd29187d
Signed-off-by: Daniel Cruz <dc443y@att.com>

JUnit additions for SDK-APP

Issue-ID: POLICY-604
Change-Id: I2e2cdb3037a70af7d8d85a4a6274b3e361510bc1
Signed-off-by: bobbymander <bobby.mander@att.com>

Merge "Exclude httpclient to resolve CLM issue"

Merge "JUnit addition for SDK-APP"

Merge "Renamed policy-pe docker image"

JUnit addition for SDK-APP

Issue-ID: POLICY-604
Change-Id: I9abc8418ddab1f487385c38c0424db601f8746e2
Signed-off-by: bobbymander <bobby.mander@att.com>

Update oparent version to 1.1.0

Directive from ONAP project that all repos should be updated.
Change vierified with a build with .m2 /org/onap cleared.

The test cases are updated becasue changing the oparent version changed the
order of test execution and tests failed due to the static data in PAPServices
not being cleared. Clearing of PAPServices data in those test cases is now
done in an @After method.

The test case in the test below has a test dependency:
ONAP-PDP-REST/src/test/java/org/onap/policy/pdp/rest/notifications/test/NotificationTest.java
depends on com.att.aft.dme2 version 3.1.200-oss

That dependency was added to the POM of ONAP-PDP-REST

Issue-ID: POLICY-693
Change-Id: Ie070f9e94216f4a81f114380782a834ce8663fd5
Signed-off-by: liamfallon <liam.fallon@ericsson.com>

Exclude httpclient to resolve CLM issue

v4.5.1 is being ommitted via maven depedency resolution.
So we will exclude to help clear the CLM issue being
flagged.

Issue-ID: POLICY-507
Change-Id: I5636da0a8109fa66cf00eb9205d89d7437517955
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Policy:Blocker"

Renamed policy-pe docker image

Renamed from:
onap/policy/policy-pe
to
onap/policy-pe
to enable consistent naming across nexus3 and docker hub

Issue-ID: POLICY-674
Change-Id: I1ace3e6034a17afa1ed68198b367e17981ec388b
Signed-off-by: mmis <michael.morris@ericsson.com>

JUnit addition for SDK-APP

Issue-ID: POLICY-604
Change-Id: Ib48f22dfe0db68348cb820d4186e7d3a79864b3f
Signed-off-by: bobbymander <bobby.mander@att.com>

Policy:Blocker

Use try-with-resources to close this JarFile:L590 L617
Issue-ID: POLICY-688

Sonar link:https://sonar.onap.org/issues?myIssues=true&open=AWF91iXI8TZzbCgU6anv&resolved=false&severities=BLOCKER

Location:BRMSGateway\src\main\java\org\onap\policy\brmsInterface\BRMSPush.java

Change-Id: I11f07325e78d6c7a9760496db4685546d2910595
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>

Upgrade dmaap release 1.1.3

Dmaap released their artifact as the snapshot is no
longer available.

Issue-ID: POLICY-694
Change-Id: Iaeeed2266a00271967334cb33e79d4c42a33f90a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Upgrade to latest elasticsearch"

Merge "Upgrade log4j to clear security issue"

Merge "JUnit additions for PAP-REST,SDK-APP"

Merge "Fixed the SDK Junits and cleaned unused code"

Upgrade to latest elasticsearch

Will not clear any CLM issue but this for uses a version that is
using the latest lucene-queryparser. It is noted in the CVE for
lucene-queryparser that elasticsearch is not affected by the
issue. We will upgrade to keep up with the latest code.

Issue-ID: POLICY-507
Change-Id: I8580dbc704c48245faf298304b8aec76c9e773c4
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Upgrade log4j to clear security issue

Vulnerability id is CVE-2017-5645

Issue-ID: POLICY-507
Change-Id: Ifed6ae8991edfa1d0e9b8c38afe19f5b43cf0b46
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Policy:Blocker"

JUnit additions for PAP-REST,SDK-APP

Issue-ID: POLICY-600
Change-Id: Ie2a3257e26382f68d8cb008dc5ac512d6ac49c8b
Signed-off-by: bobbymander <bobby.mander@att.com>

Merge "Sonar Major"

Merge "Sonar Major"

Merge "Sonar Blocker"

Sonar Major

Move the api string literal on the left side of this string comparison
XACMLPapServlet.java:L1179

Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blOo25bp_wwmIUQnh&resolved=false&severities=MAJOR

Location:
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/XACMLPapServlet.java

Line Number:1179

Change-Id: I937caaca01107d2a11be4050ff7be5e5dc66acb6
Issue-ID: POLICY-690
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>

Sonar Major

Move the GUARD_BL_YAML string literal on the left side of this string comparison
DecisionPolicyController.java:L208

Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blO9u5bp_wwmIURef&resolved=false&severities=CRITICAL%2CMAJOR

Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java

Line Number:208

Change-Id: I04199190cbb4afd50bcfa0a2725e6f2fef8dddba
Issue-ID: POLICY-689
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>

Merge "Sonar Major"

Policy:Blocker

Use try-with-resources to close this JarFile:L264 L265
Issue-ID: POLICY-683

Link: https://sonar.onap.org/issues?myIssues=true&open=AWF91iwf8TZzbCgU6arv&resolved=false
Location:ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ActionPolicy.java

Change-Id: Ie9adb5b50dbb61c923bf73fa107fd19366f24304
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>