Sonar Major

Move the GUARD_BL_YAML string literal on the left side of this string comparison
DecisionPolicyController.java:L208

Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AV2blO9u5bp_wwmIURef&resolved=false&severities=CRITICAL%2CMAJOR

Location:
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java

Line Number:208

Change-Id: I04199190cbb4afd50bcfa0a2725e6f2fef8dddba
Issue-ID: POLICY-689
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>

diff --git a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
index 6f8eea8..5ff20b6 100644 (file)
--- a/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
+++ b/POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java
@@ -205,7 +205,7 @@ public class DecisionPolicyController extends RestrictedBaseController {
                                                                ApplyType decisionApply = (ApplyType) condition.getExpression().getValue();
                                                                decisionApply = (ApplyType) decisionApply.getExpression().get(0).getValue();
                                                                ruleAlgoirthmTracker = new LinkedList<>();
-                                                               if(policyAdapter.getRuleProvider()!=null && ("GUARD_YAML".equals(policyAdapter.getRuleProvider())||(policyAdapter.getRuleProvider().equals("GUARD_BL_YAML")))){
+                                                               if(policyAdapter.getRuleProvider()!=null && ("GUARD_YAML".equals(policyAdapter.getRuleProvider())||("GUARD_BL_YAML".equals(policyAdapter.getRuleProvider())))){
                                                                        YAMLParams yamlParams = new YAMLParams();
                                                                        for(int i=0; i<attributeList.size() ; i++){
                                                                                Map<String, String> map = (Map<String,String>)attributeList.get(i);