Pamela Dragosh [Tue, 27 Feb 2018 19:58:51 +0000 (19:58 +0000)]
Merge "Add Junit to policy/engine LogParser package"
Pamela Dragosh [Tue, 27 Feb 2018 19:57:34 +0000 (19:57 +0000)]
Merge "Policy:Major"
rb7147 [Mon, 26 Feb 2018 23:04:46 +0000 (18:04 -0500)]
Code Clean Up for Policy PAP-REST
Cleaned the duplicate code for all dictionary controllers and created
Utils class.
Issue-ID: POLICY-600
Change-Id: I65b8574d9f667758407515a5c55bc28f636be477
Signed-off-by: rb7147 <rb7147@att.com>
Manamohan Satapathy [Tue, 27 Feb 2018 10:49:19 +0000 (16:19 +0530)]
Policy:Major
Local variables should not shadow class field:L992 L1719
Issue-ID: POLICY-649
Link: https://sonar.onap.org/issues?myIssues=true&projectUuids=AV2blNLJ5bp_wwmIUP3L&resolved=false&severities=CRITICAL%2CMAJOR&types=CODE_SMELL
Location:POLICY-SDK-APP\src\main\java\org\onap\policy\controller\CreateDcaeMicroServiceController.java
Change-Id: I1d038829867c7d019473909650946a9539b5e736
Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
ramverma [Tue, 27 Feb 2018 09:55:18 +0000 (09:55 +0000)]
Add Junit to policy/engine LogParser package
Test cases to improve the coverage of LogParser to 72%
Change-Id: Idbf9dbbc7254d2ba4d6953852d7847b5070dd4d4
Issue-ID: POLICY-599
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
Pamela Dragosh [Mon, 26 Feb 2018 20:17:36 +0000 (20:17 +0000)]
Merge "Added junits to increase coverage"
MAGNUSEN [Mon, 26 Feb 2018 15:19:16 +0000 (09:19 -0600)]
Added junits to increase coverage
This commit adds some junits which touch several classes in the
notifications package in the ONAP-PDP-REST project.
Issue-ID: POLICY-602
Change-Id: Ie99ddd03841d4063aba64781bf08a38d2a25f0ed
Signed-off-by: Magnusen, Drew (dm741q) <dm741q@att.com>
bobbymander [Mon, 26 Feb 2018 18:11:34 +0000 (13:11 -0500)]
JUnit additions for BRMS,PDP-REST,REST
Issue-ID: POLICY-598
Change-Id: I397ed925bdb43a4b2f7a94cc4692b6506f650ede
Signed-off-by: bobbymander <bobby.mander@att.com>
bobbymander [Fri, 23 Feb 2018 19:14:15 +0000 (14:14 -0500)]
JUnit additions for PDP,PDP-REST
Issue-ID: POLICY-600
Change-Id: Ia5584011cbd42b9b49953d714efbeb5956b9b295
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Fri, 23 Feb 2018 19:48:14 +0000 (19:48 +0000)]
Merge "Fix Fortify Issue - External Entity Injection"
Jorge Hernandez [Fri, 23 Feb 2018 19:43:52 +0000 (19:43 +0000)]
Merge "Add JUnit tests policy/engine PolicyEngineAPI"
guangxingwang [Thu, 22 Feb 2018 21:13:17 +0000 (15:13 -0600)]
Fix Fortify Issue - External Entity Injection
Fix Fortify Issue by setting secure process of factory as true
Issue-ID: POLICY-551
Change-Id: I46890d2664d0ae9ed9540ba830d0f4b27136a6e9
Signed-off-by: guangxingwang <gw1218@att.com>
waqas.ikram [Fri, 23 Feb 2018 11:17:30 +0000 (11:17 +0000)]
Add JUnit tests policy/engine PolicyEngineAPI
Change-Id: I8d7a76836759b042c83349c2b875fb77085b531c
Issue-ID: POLICY-606
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
bobbymander [Thu, 22 Feb 2018 20:43:12 +0000 (15:43 -0500)]
JUnit small additions for PAP-REST,PDP-REST,XACML
Issue-ID: POLICY-600
Change-Id: I1b012dd1dbc49c10cd47b5f100e8ccef6c92f70b
Signed-off-by: bobbymander <bobby.mander@att.com>
Jorge Hernandez [Thu, 22 Feb 2018 19:36:06 +0000 (19:36 +0000)]
Merge "JUnit additions for ONAP-PAP-REST xacml.rest"
Jorge Hernandez [Thu, 22 Feb 2018 18:18:28 +0000 (18:18 +0000)]
Merge "Fix Fortify Path Manipulation Issue"
guangxingwang [Wed, 21 Feb 2018 20:09:04 +0000 (14:09 -0600)]
Fix Fortify Path Manipulation Issue
Fix Fortify path manipulation issue by adding a validation on dictionary
name.
Issue-ID: POLICY-541
Change-Id: I87492b0d80bf96bebfc029d7d164cdd20ca5ef0f
Signed-off-by: guangxingwang <gw1218@att.com>
bobbymander [Wed, 21 Feb 2018 19:59:04 +0000 (14:59 -0500)]
JUnit additions for ONAP-PAP-REST xacml.rest
Issue-ID: POLICY-600
Change-Id: Ia6ccc2904efd7c1e7ec206caaedd8552c83d92a5
Signed-off-by: bobbymander <bobby.mander@att.com>
rb7147 [Wed, 21 Feb 2018 15:40:47 +0000 (10:40 -0500)]
Updated the Policy Logging Pattern
Updated the logback.xml to save logs for 30 days.
Issue-ID: POLICY-644
Change-Id: I578570fa5a7f86ba464c37cddab43a2fabcdae7f
Signed-off-by: rb7147 <rb7147@att.com>
rb7147 [Wed, 21 Feb 2018 18:24:04 +0000 (13:24 -0500)]
Upgraded SDK version in Policy
Issue-ID: POLICY-645
Change-Id: Ie83b4c91c8186433e582cccadf5c3d32209a88f4
Signed-off-by: rb7147 <rb7147@att.com>
Jorge Hernandez [Wed, 21 Feb 2018 18:30:10 +0000 (18:30 +0000)]
Merge "Added Junits for POLICY-SDK-APP controllers"
Jorge Hernandez [Wed, 21 Feb 2018 18:28:11 +0000 (18:28 +0000)]
Merge "Fix Fortify Log Forging Issue"
Jorge Hernandez [Wed, 21 Feb 2018 17:50:16 +0000 (17:50 +0000)]
Merge "JUnit test for policy/engine PolicyEngineAPI"
uj426b [Tue, 20 Feb 2018 22:19:00 +0000 (17:19 -0500)]
Added Junits for POLICY-SDK-APP controllers
Issue-ID: POLICY-584
Change-Id: I306f3484f466accf11ca4fd59864a4b402dcb733
Signed-off-by: uj426b <uj426b@att.com>
guangxingwang [Wed, 21 Feb 2018 15:22:12 +0000 (09:22 -0600)]
Fix Fortify Log Forging Issue
Fix Fortify log forging issue by removing properties info from logging.
Issue-ID: POLICY-544
Change-Id: I6e7d39abe18698f864564844963d7bbddedd2e3b
Signed-off-by: guangxingwang <gw1218@att.com>
Pamela Dragosh [Wed, 21 Feb 2018 14:44:55 +0000 (14:44 +0000)]
Merge "JUnit additions for ONAP-PAP-REST"
bobbymander [Tue, 20 Feb 2018 20:20:27 +0000 (15:20 -0500)]
JUnit additions for ONAP-PAP-REST
Issue-ID: POLICY-600
Change-Id: I2e6d0d656a9be77b038a08568d43d1bb7efefe57
Signed-off-by: bobbymander <bobby.mander@att.com>
rb7147 [Mon, 19 Feb 2018 21:02:31 +0000 (16:02 -0500)]
Added Junits for Policy PAP-REST
Clenaed the unsued code.
Cleaned the duplication of code and moved to ONAP-REST.
Added Junits for PAP-REST
Issue-ID: POLICY-600
Change-Id: I56e6e8f2f547def9eaf8624a9e0dd52dc05ad136
Signed-off-by: rb7147 <rb7147@att.com>
Pamela Dragosh [Tue, 20 Feb 2018 18:36:48 +0000 (13:36 -0500)]
Fix for h2 missing from testing
First submit for re-organizing pom.xml dependencies. H2 is ONLY
used for testing and should be loaded otherwise. We removed it
from policy/common so that is affecting these test.
Issue-ID: POLICY-626
Change-Id: Iba86e89f2cb26581b2b465091e829d6bdd66a37b
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Tue, 20 Feb 2018 18:04:49 +0000 (18:04 +0000)]
Merge "Add Junit to policy/engine LogParser"
Jorge Hernandez [Tue, 20 Feb 2018 17:38:21 +0000 (17:38 +0000)]
Merge "Added Junits to ONAP-PDP-REST"
ramverma [Mon, 19 Feb 2018 17:12:19 +0000 (17:12 +0000)]
Add Junit to policy/engine LogParser
Junits to improve the coverage of LogParser to 55%
Change-Id: Icddecd7a2904d5a679910f7d5fcac891b3698c66
Issue-ID: POLICY-599
Signed-off-by: ramverma <ram.krishna.verma@ericsson.com>
waqas.ikram [Tue, 20 Feb 2018 15:44:50 +0000 (15:44 +0000)]
JUnit test for policy/engine PolicyEngineAPI
Change-Id: I31991245bb5cc877722f7ce14530222a102d6472
Issue-ID: POLICY-606
Signed-off-by: waqas.ikram <waqas.ikram@ericsson.com>
Pamela Dragosh [Tue, 20 Feb 2018 14:49:53 +0000 (14:49 +0000)]
Merge "Fix Fortify Scan Issue:"
Michael Mokry [Tue, 20 Feb 2018 13:57:41 +0000 (07:57 -0600)]
Added Junits to ONAP-PDP-REST
Junits to cover classes in the api/services package that were at 0%
coverage
Change-Id: Ic92b9db4a8beea827b9b85de826da909b02ea1bd
Issue-ID: POLICY-338
Signed-off-by: Michael Mokry <mm117s@att.com>
guangxingwang [Thu, 15 Feb 2018 17:13:18 +0000 (11:13 -0600)]
Fix Fortify Scan Issue:
1) Fix Fortify Header Manipulation issue by checking the format of the
message before adding it response header.
2) Fix Fortify Hardcoded Password issue by using encryption and decryption
Issue-ID: POLICY-543
Change-Id: I16b44b9b0670b1af75094c9ae9d1f7d352fa894a
Signed-off-by: guangxingwang <gw1218@att.com>
liamfallon [Wed, 14 Feb 2018 12:49:09 +0000 (12:49 +0000)]
Rename maven modules in drools-applications
All found references to drools-applications module names
changed to new names
Issue-ID: POLICY-238
Change-Id: I3cd453c91194699434a71c1a12d2dcccfa5df234
Signed-off-by: liamfallon <liam.fallon@ericsson.com>
Jim Hahn [Mon, 19 Feb 2018 16:53:40 +0000 (11:53 -0500)]
Fix compilation issue due to generic Exception
After modifying common to remove generic Exceptions, policy/engine would
no longer compile. Had to modify policy/engine to accomodate the
specific exception.
Change-Id: If339285235994119009a8dcf9484bc81016e2600
Issue-ID: POLICY-246
Signed-off-by: Jim Hahn <jrh3@att.com>
Jorge Hernandez [Sun, 18 Feb 2018 17:58:30 +0000 (17:58 +0000)]
Merge "Added Junis for Policy ONAP-REST"
rb7147 [Fri, 16 Feb 2018 18:46:06 +0000 (13:46 -0500)]
Added Junis for Policy ONAP-REST
Cleaned the unused constructors.
Cleaned the unused code.
Added Junits for all JPAS.
Renamed the Junit class names on removing classes.
Issue-ID: POLICY-603
Change-Id: I0709ccecd7a2f3ec49367ff85f5a6d273479493e
Signed-off-by: rb7147 <rb7147@att.com>
uj426b [Fri, 16 Feb 2018 18:26:53 +0000 (13:26 -0500)]
Resolved the POLICY-SDK-APP junit issue.
Issue-ID: POLICY-584
Change-Id: I90aaec29e908b742f0866d2754d426f75e1b8953
Signed-off-by: uj426b <uj426b@att.com>
Pamela Dragosh [Fri, 16 Feb 2018 17:34:00 +0000 (17:34 +0000)]
Merge "New JUnit for PolicyEngineAPI"
Pamela Dragosh [Fri, 16 Feb 2018 17:31:11 +0000 (17:31 +0000)]
Merge "JUnit test for policy/engine ONAP-XACML"
bobbymander [Fri, 16 Feb 2018 16:09:36 +0000 (11:09 -0500)]
New JUnit for PolicyEngineAPI
Issue-ID: POLICY-338
Change-Id: I711bb0c219534a537c3d35331b8ef8703423ad63
Signed-off-by: bobbymander <bobby.mander@att.com>
Pamela Dragosh [Fri, 16 Feb 2018 16:18:09 +0000 (11:18 -0500)]
Modify sonar settings to include all sub-modules
We are now including all the sub-modules coverage into one file.
This will now reflect correct statistics for any sub-module that
tests code located in another sub-module.
Issue-ID: POLICY-634
Change-Id: I1eeb52c893aea96b3b031fabceb92e3b07f6c02c
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
mmis [Fri, 16 Feb 2018 12:34:39 +0000 (12:34 +0000)]
JUnit test for policy/engine ONAP-XACML
Increased junits in package org.onap.policy.xacml.test.std.pap in policy/engine ONAP-XACML
Change-Id: Ifef6fcc36044039b2c3d0c0dbffecffd3e242434
Issue-ID: POLICY-605
Signed-off-by: mmis <michael.morris@ericsson.com>
Michael Mokry [Thu, 15 Feb 2018 13:23:11 +0000 (07:23 -0600)]
Adding Junits in ONAP-PDP-REST
- This commit adds one Junit for PAPServices
- I needed to make a minor modification to the PAPServices class in
order to set the PAPs
Change-Id: Ia54650307e8d9e96d40ce6e68ad18508d4030a4a
Issue-ID: POLICY-338
Signed-off-by: Michael Mokry <mm117s@att.com>
Jorge Hernandez [Wed, 14 Feb 2018 19:28:14 +0000 (19:28 +0000)]
Merge "Added Junits for Policy PAP-REST"
Swapnali Pode [Wed, 14 Feb 2018 07:05:30 +0000 (12:35 +0530)]
Make drlRuleAndUIParams transient or serializable
Make drlRuleAndUIParams transient or serializable
StdPAPPolicy.java:L72
Sonar Link:
https://sonar.onap.org/project/issues?assignees=swapnalipode&id=org.onap.policy.engine%3APolicyEngineSuite&open=AWF91ipr8TZzbCgU6aom&resolved=false
Location:
src/main/java/org/onap/policy/xacml/std/pap/StdPAPPolicy.java
Change-Id: I3524881e76c69518949a622a23084e0bc8ef26a2
Issue-ID: POLICY-631
Signed-off-by: Swapnali Pode <SP00501638@techmahindra.com>
rb7147 [Tue, 13 Feb 2018 23:17:22 +0000 (18:17 -0500)]
Added Junits for Policy PAP-REST
Cleaned the unnecessary constructors and methods in onap-rest.
Added Junits for JPA Classes in ONAP-REST.
Issue-ID: POLICY-338
Change-Id: I7e4f928342315475db96d89e9ad3adac5cb7eb00
Signed-off-by: rb7147 <rb7147@att.com>
Pamela Dragosh [Wed, 14 Feb 2018 00:30:16 +0000 (00:30 +0000)]
Merge "Fix a Bug on Editor Screen"
Jorge Hernandez [Tue, 13 Feb 2018 22:44:07 +0000 (22:44 +0000)]
Merge "Added Junits for Policy PAP-REST"
guangxingwang [Tue, 13 Feb 2018 19:25:42 +0000 (13:25 -0600)]
Fix a Bug on Editor Screen
On editor screen, sometimes click on + button only one click, it creates
more than text fields
Issue-ID: POLICY-629
Change-Id: I9acc95fa0a4a7df3828e579f994c06bfa3199eb5
Signed-off-by: guangxingwang <gw1218@att.com>
Jorge Hernandez [Tue, 13 Feb 2018 15:40:22 +0000 (15:40 +0000)]
Merge "Fix Fortify Scan Issue"
rb7147 [Tue, 13 Feb 2018 03:46:09 +0000 (22:46 -0500)]
Added Junits for Policy PAP-REST
Resolved the sonar issues.
Added JUnits for ONAP-PAP-REST and ONAP-REST Component.
Issue-ID: POLICY-338
Change-Id: Ibec2613f4f61e9ed426583af17c2a9d5b8c8d85d
Signed-off-by: rb7147 <rb7147@att.com>
guangxingwang [Fri, 9 Feb 2018 16:22:21 +0000 (10:22 -0600)]
Fix Fortify Scan Issue
Fix Fortify Header Manipulation Issue by checking the format of a string
before adding it to response header.
Issue-ID: POLICY-543
Change-Id: I6539d22d5f8933ea29932361b152d34dd4f8857a
Signed-off-by: guangxingwang <gw1218@att.com>
Pamela Dragosh [Sat, 10 Feb 2018 15:26:26 +0000 (15:26 +0000)]
Merge "Added Junits for ONAP-PAP-REST"
rb7147 [Fri, 9 Feb 2018 19:30:14 +0000 (14:30 -0500)]
Added Junits for ONAP-PAP-REST
Cleaned up unused imports.
Cleaned up unused code.
Added Junits for Dictionary controllers.
Issue-ID: POLICY-338
Change-Id: If29b934e95fdaf60dcf82300a95a23ac3c980419
Signed-off-by: rb7147 <rb7147@att.com>
Jorge Hernandez [Fri, 9 Feb 2018 15:53:13 +0000 (15:53 +0000)]
Merge "Upgrading XACML jar"
Jorge Hernandez [Fri, 9 Feb 2018 14:55:18 +0000 (14:55 +0000)]
Merge "Added JUNITS for ONAP-REST Component"
Pamela Dragosh [Fri, 9 Feb 2018 14:50:17 +0000 (09:50 -0500)]
Upgrading XACML jar
XACML was released with minor fixes for XML files with comments. Mainly
it contained upgrade to dependencies that had fixed security issues. One
still remains but will not be able to be fixed.
Issue-ID: POLICY-617
Change-Id: Ib143c87156ed6a15cf4f0fe0ecbedb2407ca5b0d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
rb7147 [Fri, 9 Feb 2018 05:04:44 +0000 (00:04 -0500)]
Added JUNITS for ONAP-REST Component
Added JUnits for all Pojo classes.
Issue-ID: POLICY-338
Change-Id: I0142903899f0793a8e147a01aeea83d467e49981
Signed-off-by: rb7147 <rb7147@att.com>
guangxingwang [Thu, 8 Feb 2018 23:11:34 +0000 (17:11 -0600)]
Remove Password from Logging
Fix Fortify logging issue
Issue-ID: POLICY-544
Change-Id: Ibfc7665dcab229a705ec3f999545b14675c24430
Signed-off-by: guangxingwang <gw1218@att.com>
Pamela Dragosh [Thu, 8 Feb 2018 17:55:25 +0000 (17:55 +0000)]
Merge "MS Model Input Validation"
rb7147 [Thu, 8 Feb 2018 17:31:44 +0000 (12:31 -0500)]
Downgraded the POLICY-SDK spring version
Issue-ID: POLICY-620
Change-Id: Ib7cf286f62e945edcf5720ce2c53957b8456126d
Signed-off-by: rb7147 <rb7147@att.com>
Jorge Hernandez [Thu, 8 Feb 2018 16:34:32 +0000 (16:34 +0000)]
Merge "Upgrade jackson-databind to fix security"
Pamela Dragosh [Thu, 8 Feb 2018 16:09:31 +0000 (11:09 -0500)]
Upgrade jackson-databind to fix security
Missed this, I should have earlier upgraded to 2.9.4
Issue-ID: POLICY-507
Change-Id: Ic75cfd2d5a265f4a728e59777eac287a3d0894d1
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Thu, 8 Feb 2018 15:22:15 +0000 (15:22 +0000)]
Merge "FFix the Bug of Missing fields on View Screen"
Michael Mokry [Mon, 5 Feb 2018 15:48:59 +0000 (09:48 -0600)]
MS Model Input Validation
- Provides validation for MS policy input content body that matches the GUI validations when create/update MS policy from API
- Added changes to satisfy review comments and updated copywright
headers for modified and new files
Change-Id: I02bfa639bffb48520badd0e4fa34eb36418547ae
Issue-ID: POLICY-377
Signed-off-by: Michael Mokry <mm117s@att.com>
Jorge Hernandez [Thu, 8 Feb 2018 03:48:24 +0000 (03:48 +0000)]
Merge "Upgrade dependencies to clear security issues"
guangxingwang [Wed, 7 Feb 2018 21:07:27 +0000 (15:07 -0600)]
FFix the Bug of Missing fields on View Screen
Missing extra fields added by clicking add buton if they are more than
10 on view screen
Issue-ID: POLICY-613
Change-Id: I9e718b62301f24b71a4f6506d3e63e6185e0b1ce
Signed-off-by: guangxingwang <gw1218@att.com>
Pamela Dragosh [Wed, 7 Feb 2018 20:41:30 +0000 (15:41 -0500)]
Upgrade dependencies to clear security issues
A bit of consolidation too - which could use a lot more work. These
were simple security upgrades for fixes identified by LF weekly LCM job.
Added some missing license headers.
Issue-ID: POLICY-507
Change-Id: If285b0f95d30a1084c9363bf6a41b48d52fb3aff
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Ankitkumar Patel [Wed, 7 Feb 2018 16:12:27 +0000 (11:12 -0500)]
Fixed the sonar issues in ONAP-REST.
Minor Sonar issues are fixed in the ONAP_REST module.
The copyright headers of the changed files are also updated.
Issue-ID: POLICY-476
Change-Id: I920d8bcdd7b855e3e1660a002fb0e4e8d1674e44
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
Jorge Hernandez [Wed, 7 Feb 2018 15:33:02 +0000 (15:33 +0000)]
Merge "Implement Encryption on Passwords"
Pamela Dragosh [Wed, 7 Feb 2018 14:10:21 +0000 (14:10 +0000)]
Merge "Adding JUNITs for ONAP-PAP-REST"
Pamela Dragosh [Wed, 7 Feb 2018 12:24:28 +0000 (12:24 +0000)]
Merge "Continue addressing technical debt for ONAP-XACML"
Jorge Hernandez [Tue, 6 Feb 2018 20:34:26 +0000 (20:34 +0000)]
Merge "Implement Encryption on Passwords"
uj426b [Tue, 6 Feb 2018 16:13:21 +0000 (11:13 -0500)]
Adding JUNITs for ONAP-PAP-REST
Issue-ID: POLICY-338
Change-Id: I123a92872a236b23144c59e87ea2dffc9ee7fc48
Signed-off-by: uj426b <uj426b@att.com>
Gao, Chenfei (cg287m) [Tue, 6 Feb 2018 17:42:50 +0000 (12:42 -0500)]
Continue addressing technical debt for ONAP-XACML
Fix all sonar issues that do not require code refactoring
Issue-ID: POLICY-475
Change-Id: Iefa91e0048b7041c96d47bce7ec99034d6fcc427
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
guangxingwang [Tue, 6 Feb 2018 15:36:25 +0000 (09:36 -0600)]
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password in properties file
Issue-ID: POLICY-542
Change-Id: Iea7b292c4dccf5f400320cd3f63309e955953f2d
Signed-off-by: guangxingwang <gw1218@att.com>
rb7147 [Tue, 6 Feb 2018 14:07:12 +0000 (09:07 -0500)]
Policy Resiliency Code Fixes
Resolved the issue on updating the configuration files when
rename/clone/export/move actions are done through GUI.
Fixed the PolicyManagerServlet code.
Added test cases for newly added files.
Issue-ID: POLICY-609
Change-Id: I9d14f19fe20bbc0e3b3844f85d81f26e34bb26ec
Signed-off-by: rb7147 <rb7147@att.com>
guangxingwang [Mon, 5 Feb 2018 20:01:00 +0000 (14:01 -0600)]
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password in properties file
Issue-ID: POLICY-542
Change-Id: Icefd4097dc2e20c0ec2b78c002599defb6034267
Signed-off-by: guangxingwang <gw1218@att.com>
Jorge Hernandez [Mon, 5 Feb 2018 21:39:47 +0000 (21:39 +0000)]
Merge "Fix last technical debt"
Jorge Hernandez [Mon, 5 Feb 2018 21:39:00 +0000 (21:39 +0000)]
Merge "Technical debt and fix JUnit test"
Jorge Hernandez [Mon, 5 Feb 2018 21:04:44 +0000 (21:04 +0000)]
Merge "Remove technical debt"
Pamela Dragosh [Mon, 5 Feb 2018 17:51:51 +0000 (12:51 -0500)]
Fix last technical debt
Last one that I dare to fix.
Issue-ID: POLICY-477
Change-Id: Ieb1c159b781fa2f0dd80f7dea92dcbf72c3e8364
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Mon, 5 Feb 2018 17:50:06 +0000 (12:50 -0500)]
Technical debt and fix JUnit test
* One statement per line
* private constructor for class with statics
* Fix silly JUnit test
Issue-ID: POLICY-474
Change-Id: Ie760826879febbbc4db4f03079ae1f847f2194dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
guangxingwang [Wed, 31 Jan 2018 02:18:31 +0000 (20:18 -0600)]
Implement Encryption on Passwords
Fix Fortify scan issue - hardcoded password
Issue-ID: POLICY-542
Change-Id: I722b9143fbddc48b67592bb35a44f36ed8b38aad
Signed-off-by: guangxingwang <gw1218@att.com>
Pamela Dragosh [Mon, 5 Feb 2018 14:38:29 +0000 (09:38 -0500)]
Remove technical debt
* String literals on the left
* Unnecessary initialization of variables
* Change ArrayList to using List
* Remove extra semicolons
* Empty Constructor comments
* Useless parenthesis
I also added a comment on some code that is suspicious. Not comfortable
with changing that code.
Issue-ID: POLICY-482
Change-Id: I89d889737d398d047fab4b25cb5d962ee1ecdd03
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Fri, 2 Feb 2018 20:26:43 +0000 (20:26 +0000)]
Merge "Technical debt reduction"
rb7147 [Thu, 1 Feb 2018 21:29:04 +0000 (16:29 -0500)]
Resolved Fortify System Information Leak issues
Issue-ID: POLICY-550
Change-Id: I2145ecb6de43b69d6faf44c6395b119134a9904f
Signed-off-by: rb7147 <rb7147@att.com>
Pamela Dragosh [Fri, 2 Feb 2018 14:43:33 +0000 (09:43 -0500)]
Technical debt reduction
* empty constructor
* Unnecessary imports
* try-with-resources
* missing @Override
* useless parens
* proper boolean detection
* useless imports
* Use Set vs HashSet
* moving statements to separate lines
Issue-ID: POLICY-477
Change-Id: I5fae9c5c8e7d30f731a1caefc8a5271cf382e0a0
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Pamela Dragosh [Thu, 1 Feb 2018 20:05:16 +0000 (15:05 -0500)]
Resolve LF license header issue
These were simple, we just forgot to remove the old license headers. Also
needed to add a missed fix for a JUnit test. Not sure how this made it past
verify.
Issue-ID: POLICY-552
Change-Id: I30610ba4f8440ee16d0a5c372985f50429d60a34
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Thu, 1 Feb 2018 19:43:13 +0000 (19:43 +0000)]
Merge "Included Policy GUI Enhancements and validations"
rb7147 [Thu, 1 Feb 2018 17:07:13 +0000 (12:07 -0500)]
Included Policy GUI Enhancements and validations
Added hover messages for all policy templates.
Resolved few sonar issues.
Added fixes for Policy GUI Validations.
Issue-ID: POLICY-597
Change-Id: I74abb92dd6ac8722d7869b6a316fad1d8db11d9c
Signed-off-by: rb7147 <rb7147@att.com>
Pamela Dragosh [Thu, 1 Feb 2018 17:22:30 +0000 (12:22 -0500)]
Reduce technical debt and add JUnit
* Addressed some very simple cyclic complexity
* Added simple JUnit tests and finished others
* Removed useless assignments
Issue-ID: POLICY-477
Change-Id: Ic919bbf78ad2732a430c32f1feb3c88678be710d
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Jorge Hernandez [Thu, 1 Feb 2018 17:20:09 +0000 (17:20 +0000)]
Merge "Reduce technical debt"
Jorge Hernandez [Thu, 1 Feb 2018 15:11:20 +0000 (15:11 +0000)]
Merge "Continue addressing technical debt for ONAP-XACML"
Gao, Chenfei (cg287m) [Wed, 31 Jan 2018 22:01:05 +0000 (17:01 -0500)]
Continue addressing technical debt for ONAP-XACML
Follow the list of acceptable fixes in POLICY-336 description
Issue-ID: POLICY-475
Change-Id: I67f46bb383db1ac4feecb0223df98d180733fc95
Signed-off-by: Gao, Chenfei (cg287m) <cgao@research.att.com>
Ankitkumar Patel [Tue, 30 Jan 2018 03:42:19 +0000 (22:42 -0500)]
Fixed the Sonar technical debt.
Fixed the sonar technical dept primarily for the POLICY-REST module, and
accordingly updated the other policy-engine modules for successful built.
Issue-ID: POLICY-476
Change-Id: I0e9bd7209a7f9af247fa409a1682683082f92698
Signed-off-by: Ankitkumar Patel <ankit@research.att.com>
Code Review / policy / engine.git / log