Merge "Resolved the Policy Removal issue from PDP"
authorJorge Hernandez <jh1730@att.com>
Fri, 23 Mar 2018 04:44:38 +0000 (04:44 +0000)
committerGerrit Code Review <gerrit@onap.org>
Fri, 23 Mar 2018 04:44:38 +0000 (04:44 +0000)
1  2 
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDao.java

@@@ -127,7 -127,7 +127,7 @@@ public class PolicyDBDao 
        public static final String duplicatePolicyId = "Somehow, more than one policy with the id ";
        public static final String foundInDB = " were found in the database";
        
 -      public static boolean isJunit = false;
 +      private static boolean isJunit = false;
  
        public static void setJunit(boolean isJunit) {
                PolicyDBDao.isJunit = isJunit;
                                        for(PDPPolicy policy : policies){
                                                try{
                                                        String[] stringArray = getNameScopeAndVersionFromPdpPolicy(policy.getId());
 +                                                      if(stringArray == null) {
 +                                                          throw new IllegalArgumentException("Invalid input - policyID must contain name, scope and version");
 +                                                      }
                                                        List<PolicyEntity> policyEntityList;
                                                        Query getPolicyEntitiesQuery = em.createNamedQuery("PolicyEntity.findByNameAndScope");
                                                        getPolicyEntitiesQuery.setParameter("name", stringArray[0]);
                                        policyId = policyName;
                                        policyQuery = em.createQuery("SELECT p FROM PolicyEntity p WHERE p.policyName=:name AND p.scope=:scope");
                                        policyQuery.setParameter("name", policyId);
-                                       policyQuery.setParameter(scope, scope);
+                                       policyQuery.setParameter("scope", scope);
                                } else{
                                        policyId = String.valueOf(policyID);
                                        policyQuery = em.createNamedQuery("PolicyEntity.FindById");