Fix technical debt and reduce lines 51/29651/1
authorPamela Dragosh <pdragosh@research.att.com>
Tue, 30 Jan 2018 13:28:25 +0000 (08:28 -0500)
committerPamela Dragosh <pdragosh@research.att.com>
Tue, 30 Jan 2018 13:32:10 +0000 (08:32 -0500)
Focused on iterating over entrySet along with more fixes for
dead stores, unnecessary exceptions. I'm also starting to work
on reducing the number of code lines.

* Iterate using entrySet
* Remove useless assignments
* Unnecessary exceptions
* Use StringBuilder instead of StringBuffer due to synchronization
* Potential null exceptions being thrown
* Returning a empty collection vs null

Issue-ID: POLICY-482
Change-Id: If6ac8e812237f37b2b10c534535df4090a5073dd
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

No differences found