Consolidate PolicyRestAdapter setup

[policy/engine.git] / ONAP-PAP-REST / src / test / java / org / onap / policy / pap / xacml / rest / handler / DeleteHandlerTest.java

diff --git a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/DeleteHandlerTest.java b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/DeleteHandlerTest.java
index 84f36aa..17967a4 100644 (file)
--- a/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/DeleteHandlerTest.java
+++ b/ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/DeleteHandlerTest.java
@@ -2,14 +2,14 @@
  * ============LICENSE_START=======================================================
  * ONAP-PAP-REST
  * ================================================================================
- * Copyright (C) 2018 AT&T Intellectual Property. All rights reserved.
+ * Copyright (C) 2018-2019 AT&T Intellectual Property. All rights reserved.
  * ================================================================================
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
  * You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -24,13 +24,25 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.fail;
-import static org.mockito.Mockito.when;
 import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.when;
+
+import com.mockrunner.mock.web.MockHttpServletRequest;
+import com.mockrunner.mock.web.MockHttpServletResponse;
+
+import java.util.Collections;
+import java.util.List;
+
+import org.hibernate.Session;
+import org.hibernate.SessionFactory;
+import org.hibernate.Transaction;
+import org.junit.Before;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.Mockito;
-import org.onap.policy.common.logging.ONAPLoggingContext;
+import org.onap.policy.common.logging.OnapLoggingContext;
 import org.onap.policy.pap.xacml.rest.XACMLPapServlet;
+import org.onap.policy.pap.xacml.rest.daoimpl.CommonClassDaoImpl;
 import org.onap.policy.pap.xacml.rest.elk.client.PolicyElasticSearchController;
 import org.onap.policy.rest.jpa.PolicyEntity;
 import org.onap.policy.xacml.api.pap.PAPPolicyEngine;
@@ -38,15 +50,20 @@ import org.onap.policy.xacml.std.pap.StdEngine;
 import org.powermock.api.mockito.PowerMockito;
 import org.powermock.core.classloader.annotations.PrepareForTest;
 import org.powermock.modules.junit4.PowerMockRunner;
-import com.mockrunner.mock.web.MockHttpServletRequest;
-import com.mockrunner.mock.web.MockHttpServletResponse;
-import java.sql.Connection;
-import java.util.Collections;
-import java.util.List;
-import javax.persistence.EntityManager;
 
 @RunWith(PowerMockRunner.class)
 public class DeleteHandlerTest {
+    @Before
+    public void setUp() {
+        SessionFactory mockedSessionFactory = Mockito.mock(SessionFactory.class);
+        Session mockedSession = Mockito.mock(Session.class);
+        Transaction mockedTransaction = Mockito.mock(Transaction.class);
+        Mockito.when(mockedSessionFactory.openSession()).thenReturn(mockedSession);
+        Mockito.when(mockedSession.beginTransaction()).thenReturn(mockedTransaction);
+        CommonClassDaoImpl.setSessionfactory(mockedSessionFactory);
+        new DeleteHandler(new CommonClassDaoImpl());
+    }
+
     @Test
     public void testGets() {
         DeleteHandler handler = new DeleteHandler();
@@ -79,36 +96,30 @@ public class DeleteHandlerTest {
         PolicyElasticSearchController controller = Mockito.mock(PolicyElasticSearchController.class);
         PowerMockito.whenNew(PolicyElasticSearchController.class).withNoArguments().thenReturn(controller);
 
-        // Mock entity manager
-        EntityManager em = Mockito.mock(EntityManager.class);
-
         // Test deletion from PAP
         MockHttpServletResponse response = new MockHttpServletResponse();
         try {
-            handler.doAPIDeleteFromPAP(request, response);
-        }
-        catch (Exception ex) {
+            handler.doApiDeleteFromPap(request, response);
+        } catch (Exception ex) {
             fail("Not expecting an exception: " + ex);
         }
 
         // Test deletion from PDP
-        ONAPLoggingContext loggingContext = Mockito.mock(ONAPLoggingContext.class);
+        OnapLoggingContext loggingContext = Mockito.mock(OnapLoggingContext.class);
         try {
-            handler.doAPIDeleteFromPDP(request, response, loggingContext);
-        }
-        catch (Exception ex) {
+            handler.doApiDeleteFromPdp(request, response, loggingContext);
+        } catch (Exception ex) {
             fail("Not expecting an exception: " + ex);
         }
 
         // Test delete entity
         PolicyEntity policyEntity = new PolicyEntity();
         policyEntity.setPolicyName("testVal");
-        String result = DeleteHandler.deletePolicyEntityData(em, policyEntity);
+        String result = DeleteHandler.deletePolicyEntityData(policyEntity);
         assertEquals(result, "success");
 
         // Test check entity
-        Connection con = null;
         List<?> peResult = Collections.emptyList();
-        assertEquals(DeleteHandler.checkPolicyGroupEntity(con, peResult), false);
+        assertEquals(DeleteHandler.checkPolicyGroupEntity(peResult), false);
     }
 }