gerrit.onap Code Review - policy/engine.git/commit

Code Review / policy / engine.git / commit

author	Pamela Dragosh <pdragosh@research.att.com>
	Tue, 22 Oct 2019 11:53:44 +0000 (07:53 -0400)
committer	Pamela Dragosh <pdragosh@research.att.com>
	Wed, 23 Oct 2019 17:33:56 +0000 (13:33 -0400)
commit	1e61676b77dd09659027b8984f050df7e8538526
tree	115053dba12b4b27a0f92de0e7648a672a66893a	tree \| snapshot
parent	f18fbfc026de9cf02126f57844c37abfee607394	commit \| diff

Consolidate PolicyRestAdapter setup

Put common code into PolicyEngineUtils that the controllers use to
populate the PolicyRestController.

Also some more sonar cleanup and formatting of XML files.

Shortened 120 line characters. Removed some trailing spaces
from comments.

Fixed up one JUnit.

Licenses.

Issue-ID: POLICY-2133
Change-Id: Id7d8ac3ab60331535f048ec0f26aeb17a099414e
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

155 files changed:

ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/ConsoleAndApiService.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/DataToNotifyPdp.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/DictionaryNames.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/Heartbeat.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/PAPRestConfig.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/UpdateOthersPAPS.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/UpdatePdpThread.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/XACMLPapServlet.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/adapters/SearchData.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/adapters/UpdateObjectData.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ActionPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ClosedLoopPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/ConfigPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBRMSRuleTemplate.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBrmsParamPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateBrmsRawPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateClosedLoopPerformanceMetrics.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewMicroServiceModel.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/CreateNewOptimizationModel.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/DecisionPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/FirewallConfigPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/HandleIncomingNotifications.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/MicroServiceConfigPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/NotifyOtherPaps.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/OptimizationConfigPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/Policy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDao.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTransaction.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/PolicyDbDaoTransactionInstance.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/components/SafePolicyBuilder.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/ActionPolicyDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/BRMSDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/ClosedLoopDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/DecisionPolicyDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/DescriptiveDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/DictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/FirewallDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/MicroServiceDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/OptimizationDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/PolicyScopeDictionaryController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/PushPolicyController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/SafePolicyController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/controller/package-info.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/daoimpl/CommonClassDaoImpl.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElasticSearchPolicyUpdate.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElkConnector.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/ElkConnectorImpl.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/Pair.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/PolicyElasticData.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/PolicyElasticSearchController.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/elk/client/PolicyLocator.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/APIRequestHandler.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/DeleteHandler.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/DictionaryHandler.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/DictionaryHandlerImpl.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/PushPolicyHandler.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/handler/SavePolicyHandler.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/model/RemoveGroupPolicy.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/model/package-info.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/policycontroller/PolicyCreation.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/policycontroller/package-info.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/service/DictionaryService.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/service/ImportService.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/service/MetricService.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/util/AbstractPolicyCreation.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/util/DictionaryUtils.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/util/JPAUtils.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/rest/util/JsonMessage.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/restAuth/AuthenticationService.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/restAuth/CheckPDP.java		diff \| blob \| history
ONAP-PAP-REST/src/main/java/org/onap/policy/pap/xacml/restAuth/PAPAuthenticationFilter.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/ia/DbAuditCompareEntriesTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/test/UpdateOthersPAPSTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/test/XACMLPAPTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/ConsoleAndApiServiceTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/PAPRestConfigTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/WebConfigTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/XACMLPapServletTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/adapters/SearchDataTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/adapters/UpdateObjectDataTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/ActionPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/BRMSPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/ClosedLoopPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/DecisionPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/FirewallConfigPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/HandleIncomingNotificationsTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/MicroServicePolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/OptimizationConfigPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/components/PolicyDBDaoTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/ActionPolicyDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/BRMSDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/ClosedLoopDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DecisionPolicyDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DescriptiveDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/DictionaryImportControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/FirewallDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/MicroServiceDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/OptimizationDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/PolicyScopeDictionaryControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/PushPolicyControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/controller/SafePolicyControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/ElasticSearchPolicyUpdateTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/ElkConnectorImplTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/PairTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/PolicyElasticDataTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/PolicyElasticSearchControllerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/elk/PolicyLocatorTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/DeleteHandlerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/DictionaryHandlerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/handler/PushPolicyHandlerTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/jpa/PolicyEntityTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/model/RemoveGroupPolicyTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/service/ImportServiceTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/service/MetricServiceTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/util/JPAUtilsTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/rest/util/JsonMessageTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/restAuth/AuthenticationServiceTest.java		diff \| blob \| history
ONAP-PAP-REST/src/test/java/org/onap/policy/pap/xacml/restAuth/PAPAuthenticationFilterTest.java		diff \| blob \| history
ONAP-REST/src/main/java/org/onap/policy/rest/adapter/PolicyRestAdapter.java		diff \| blob \| history
ONAP-REST/src/main/java/org/onap/policy/rest/jpa/MicroserviceHeaderdeFaults.java		diff \| blob \| history
ONAP-REST/src/main/java/org/onap/policy/rest/util/ParserException.java		diff \| blob \| history
ONAP-REST/src/test/java/org/onap/policy/rest/adapter/PolicyRestAdapterTest.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AdminTabController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/AutoPushController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSParamController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateBRMSRawController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateClosedLoopFaultController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateClosedLoopPMController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateDcaeMicroServiceController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateFirewallController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreateOptimizationController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/CreatePolicyController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DashboardController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/DecisionPolicyController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/ExportAndImportDecisionBlackListEntries.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PDPController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyExportAndImportController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyNotificationController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyRolesController.java		diff \| blob \| history
POLICY-SDK-APP/src/main/java/org/onap/policy/controller/PolicyValidationController.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/admin/PolicyManagerServletTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/admin/PolicyNotificationMailTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/controller/CreateDcaeMicroServiceControllerTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/controller/CreateOptimizationControllerTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/controller/CreatePolicyControllerTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/controller/DashboardControllerTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/java/org/onap/policy/controller/PolicyControllerTest.java		diff \| blob \| history
POLICY-SDK-APP/src/test/resources/xacml.admin.properties		diff \| blob \| history
PolicyEngineUtils/src/main/java/org/onap/policy/utils/AAFPolicyClient.java		diff \| blob \| history
PolicyEngineUtils/src/main/java/org/onap/policy/utils/PolicyUtils.java		diff \| blob \| history
PolicyEngineUtils/src/main/resources/META-INF/persistencePU.xml		diff \| blob \| history
PolicyEngineUtils/src/test/resources/META-INF/persistencePUtest.xml		diff \| blob \| history

-- Archived 06/09/2021

RSS Atom