Bump drools-apps to 1.7.6 SNAPSHOT

Issue-ID: POLICY-2890
Change-Id: I95691cc97a2a47ed27cfa55ee2d3cb85d6e0c718
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.5 docker

Issue-ID: POLICY-2890
Change-Id: Ic76a5f29bedb235a65e94c8e16f971ed5682c54f
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.5 artifacts

Includes bug fix for mixed case prov-status.

Issue-ID: POLICY-2890
Change-Id: I2e1c592b2d3cd83d285d8ce301413959c1d1a4c8
Signed-off-by: Jim Hahn <jrh3@att.com>

Allow mixed case in check of prov-status

Apparently SO/AAI in Frankfurt are setting the prov-status to "active"
instead of "ACTIVE".  Modified the code to ignore case when comparing.

Issue-ID: POLICY-2890-prov-status2
Change-Id: I9e868d320dadcb3ac51570718d10f33d0011ae47
Signed-off-by: Jim Hahn <jrh3@att.com>
(cherry picked from commit 21362791e6488bb36f543f0319b195e24f239dcb)

correct filename and restructure directories for s3p

move s3p jmx and shell script under resources
remove old jmx files from the previous release

Issue-ID: POLICY-2832
Change-Id: I2c1d4f2137655bc096b402b12625fa4add15ecf5
Signed-off-by: Taka Cho <takamune.cho@att.com>
(cherry picked from commit 91f91bb6181e0f7629f46aa6d8bb3816d1f63108)

Point drools-apps to guilin branch

Issue-ID: POLICY-2875
Change-Id: I7b786b1a11ec8a2a96caf7ea35208146d8ca8f5d
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-apps to 1.7.5 SNAPSHOT

Issue-ID: POLICY-2869
Change-Id: I627c5b1c4c5f946c1187a6966b30d3943825fa71
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.4 docker

Issue-ID: POLICY-2869
Change-Id: I84c5128e0b82c72cd81540174442ceb19407dd3d
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.4 artifacts

Issue-ID: POLICY-2869
Change-Id: Ib0d32f3c87bff3ce402a1435e2a4ef9e0dd01940
Signed-off-by: Jim Hahn <jrh3@att.com>

Use release versions in drools-apps

Issue-ID: POLICY-2869
Change-Id: Ie55fb49b22b7880575395f6fa7676a508f1f2a85
Signed-off-by: Jim Hahn <jrh3@att.com>

Point drools-apps to models 2.3.5

Issue-ID: POLICY-2869
Change-Id: Ideb10482ffd3e670e6237305ef8ff9d0a0143257
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

point to drool-pdp 1.7.4-SNAPSHOT

Issue-ID: POLICY-2864
Change-Id: I45fd53df2d143d1e082db477316b4378d8c5e6a0
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "bump drools-apps to 1.7.4-SNAPSHOT"

bump drools-apps to 1.7.4-SNAPSHOT

Issue-ID: POLICY-2839
Change-Id: Ie0bc82d0f8a09dc4d65e056dc7836870dae58835
Signed-off-by: Taka Cho <takamune.cho@att.com>

Release drools-apps 1.7.3 docker image

Issue-ID: POLICY-2863
Change-Id: I5a42abffe141febf35e03c227683515ae4870a5d
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.3 artifacts

Issue-ID: POLICY-2863
Change-Id: Ifef9714179ae4a19793c6599abe672a5191cc101
Signed-off-by: Jim Hahn <jrh3@att.com>

Use models 2.3.4 and drools-pdp 1.7.3 releases

Issue-ID: POLICY-2863
Change-Id: Iac66e5f4794e9d959490f205b4f00ccfa4c1d332
Signed-off-by: Jim Hahn <jrh3@att.com>

Use models and drools snapshots

Issue-ID: POLICY-2863
Change-Id: I7e436034dfaa1917b1fba050ab832b273730bb41
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-apps to 1.7.3 snapshot

Issue-ID: POLICY-2839
Change-Id: Iafbc4a301ee8bc2b5fb10f34677f752a87997879
Signed-off-by: Taka Cho <takamune.cho@att.com>

release drools-apps docker 1.7.2

Issue-ID: POLICY-2839
Change-Id: Id515d64554794677ab1c83626fe0f337856498cf
Signed-off-by: Taka Cho <takamune.cho@att.com>

release 1.7.2 drools-apps artifact

Change-Id: Ib135c94c5702dd24908e3251fae035a7894db6de

Issue-ID: POLICY-2839
Change-Id: Ie673f7c20f5a84bc7a1cdf053b51dfa373507ae6
Signed-off-by: Taka Cho <takamune.cho@att.com>

Point to model 2.3.2 and drools-pdp 1.7.2

Issue-ID: POLICY-2839
Change-Id: I2a405e42e81073a3862cf1a3e01a8c0deaccc36e
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Remove cds actor timeout"

Remove cds actor timeout

During testing we found that cds actor is picking up the timeout from policy configuration.
As discussed, adding a comment for now and we will remove it in next release alog with related code.

Issue-ID: POLICY-2843
Change-Id: I63b589bea344ad7f33e6fc0d34f0ab331411146b
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Merge "Fix new sonars in drools-apps"

Fix new sonars in drools-apps

Addressed the following sonars:
- too many assertions in test method
- rename test class
- use static method to modify static field
- use already defined constant
- code always returns the same value
- use assertNotSame
- use appropriate class name to access static method
- define a constant
- extract nested try block
- don't always return the same value
- use remove() instead of set(null) for thread-local-storage
- add @Override

Issue-ID: POLICY-2852
Change-Id: Icc62acd4ad57afa2d44ed4cdca504a3ac0810228
Signed-off-by: Jim Hahn <jrh3@att.com>

remove enable frankfurt controller

In G-Rel, we will use usecases controller.
only install frankfurt controller by default
keep disable for frankfurt controller

Issue-ID: POLICY-2849
Change-Id: I3f09a2920b2bf05af0389b56366ce7229d8113c2
Signed-off-by: Taka Cho <takamune.cho@att.com>

Release locks between junit tests

Tdjam junits were randomly failing.  Traced it down to the fact that the
locks were being released asynchronously and thus were not always
released when the next test cases requested them.
Also simplified logging for tdjam junit tests.
Fixed the property file so it isn't overwritten by the junit tests.

Changes per review comments:
- changed "Pattern" to "pattern" in logback xml

Issue-ID: POLICY-2789
Change-Id: I325ec69cf7affa531d3c575e3a34bc0b0e1edac7
Signed-off-by: Jim Hahn <jrh3@att.com>

bump snapshot version to 1.7.2-SNAPSHOT

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4335cf77bd4a228fe0bec2d5eb529789e8144406

docker release 1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Id0fc75b4c27ec1fdd4e33eb60c784e3c63e37952

maven release 1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iad1b751d39518eb7d38b25b37d02b57f665d24e7

disable TdjamTest junits

junits consistently fail in staging jobs

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I968bd9ec2c3e8278358ef3c487592c0b833cef36

delete guard dependency for tdjam

staging job fails as there is no guard dependency.

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I4d803e269c7199ddeb2ebb52df5368259e4f22cd

Update common/models/drools to 1.7.1/2.3.1/1.7.1

Issue-ID: POLICY-2789
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia78684b0f56007941ad6038d78b97bc70f9aa1bb
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Merge "update the toscapolicy in ruletest set"

Merge "Add guard filter properties to controller"

Merge "add feature-controlloop-tdjam to drools-apps docker"

Add guard filter properties to controller

Adding new properties to guard Decision call.

Issue-ID: POLICY-2590
Change-Id: Ie4a37990e062c76ac4d6dd1b904ad354736fd27a
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

update the toscapolicy in ruletest set

modelVersion has to be a string
instead an integer

Issue-ID: POLICY-2814
Change-Id: I31c89d69f96076d490c665f4912d25e3892d011a
Signed-off-by: Taka Cho <takamune.cho@att.com>

add feature-controlloop-tdjam to drools-apps docker

the feature-controlloop-tdjam will be installed in
docker, but disable by default

Issue-ID: POLICY-2415
Change-Id: I563a16bc698ce13eb1df0d8aa1cb7b7e7b8290b3
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "Allow guards to be dynamically enabled/disabled"

Allow guards to be dynamically enabled/disabled

Modified drools-apps so that guards can be dynamically enabled and
disabled.  Due to the current design, there are two properties that
control this:
- an actor-level property: when enabled, the DB connection is created,
  otherwise a stub connection is created.  This property is NOT dynamic
- an engine-level property: when enabled, the connection created by the
  actor is used, otherwise a stub connection is used.  This property IS
  dynamic

Issue-ID: POLICY-2748
Change-Id: I2a5baf908ce274f2eb46a6a3f01df1b3532038ff
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Add tdjam-controller"

Add tdjam-controller

the details is on wiki:

https://wiki.onap.org/display/DW/tdjam+Feature+for+Tosca-Driven+Control+Loops

Fixed some eclipse warnings.
Revised the interaction between a manager and its SerialWorkQueue to
address some threading issues.  The original code started processing
the event as soon as the manager was created, WHILE it was still being
added to the map.  During junit tests, the event responses came back,
within the same thread, which then attempted to remove the manager from
the map.  This resulted in a ConcurrentHashMap exception.

Issue-ID: POLICY-2415
Change-Id: I94a4152637be76e5b2aea2d869afd84dfb413a0e
Signed-off-by: Straubs, Ralph (rs8887) <rs8887@att.com>
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Signed-off-by: Taka Cho <takamune.cho@att.com>
Signed-off-by: Jim Hahn <jrh3@att.com>

Tweaks to drools-apps for new usecases controller

Made the following updates:
- modified feature-controlloop-utils to pull from the usecases
  controller instead of the frankfurt controller
- modified ONAPInstance in the xacml-pdp Decision request
- log Step2 property changes as info() instead of error()
- log Lock acquisition as info() instead of warn()

Issue-ID: POLICY-2748
Change-Id: I6b4b5877bbd6731acb761d09d0f0dec85561b163
Signed-off-by: Jim Hahn <jrh3@att.com>

Remove legacy policy from rules

Issue-ID: POLICY-2428
Change-Id: I87b66758c8984febcd5fb6e724fac3493f5d4cdf
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Use ToscaPolicy instead of legacy Policy"

Use ToscaPolicy instead of legacy Policy

Removed usage of policy-yaml and old targetType definition.

Switched to using TOSCA operational policy classes and new
definitions for Target type enum.

Issue-ID: POLICY-2428
Change-Id: I25d1c5219764df27bdae7f2cbeb7ada7bcef4e1e
Signed-off-by: Jim Hahn <jrh3@att.com>
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Move java code to rules

Added new usecases rules and feature.
Updates per review comments:
- kmodule.xml(s)

Issue-ID: POLICY-2748
Change-Id: I2f5cb05a4269f98a3b0a778730434955f0919b4a
Signed-off-by: Jim Hahn <jrh3@att.com>

Add Usecases-specific event manager

Created new "usecases" event manager.
Also fixed a couple of sonar issues in the new code.

Issue-ID: POLICY-2748
Change-Id: I17a2c41bbf4f4e8158adbd8aa5e32ef570daa9d3
Signed-off-by: Jim Hahn <jrh3@att.com>

Add Step classes for usecases controller

Add usecases-specific classes for managing preprocessor steps.

Issue-ID: POLICY-2748
Change-Id: I62a2bf8fbeb656a5017531a3f3de6a6dbad5a004
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Add "special" Operation classes for new usecases"

remove legacy operational policies support

Issue-ID: POLICY-2765
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I454365943465863b108ba8668b2bc4b201986959

Add "special" Operation classes for new usecases

Created place-holder for new "usecases" controller.  Note: as of yet,
this is still just a normal java project; it will be turned into a
full-fledged kie-based controller in a later review.
Added some Operation and a few other support classes that will be
needed.
Note: the detmTarget() method and it's various supporting methods,
detmXxx(), found in GetTargetEntityOperation2 were cloned from the
pre-existing ControlLoopOperationManager2 class, and modified to fit the
strategy of the new controller.  Likewise for the junit tests of those
methods.

Issue-ID: POLICY-2748
Change-Id: Idffa135a11a56bd6afdd2728706fd40168e80912
Signed-off-by: Jim Hahn <jrh3@att.com>

Add generic eventmanager classes

Added classes that are event-agnostic and support moving control from
java into rules.
Updates per review comments:
- removed policy scope

Issue-ID: POLICY-2748-event-mgr
Change-Id: Icf811cc25a3975543fc5c725766b7b9df2bb87b0
Signed-off-by: Jim Hahn <jrh3@att.com>

Remove legacy operational policy from drools-apps

Issue-ID: POLICY-2766
Change-Id: I1ff7bbc4e301cfe6fa746f38c839acf83f7584b6
Signed-off-by: Jim Hahn <jrh3@att.com>

Refactor BaseRuleTest for Drools apps

1, rename BaseRuleTest to BaseTest.
2, remove drools related code in BaseTest that would use
   for tdjam controller.
3, DroolsRuleTest extends BaseTest
   that would use for frankfurt controller for drools base.

Issue-ID: POLICY-2750
Change-Id: Ica9637a850de6e929f09532f077ae3e997aa2045
Signed-off-by: Taka Cho <takamune.cho@att.com>

Update INFO.yaml in policy-drools-apps

Verified with Jessica W that the "type" should still be "Addition",
even when updating the PTL.
Updated to Mature, per TSC.

Issue-ID: POLICY-2738
Change-Id: I6385e0474e1b48b3e4f1fa195062ecfc40e03ee7
Signed-off-by: Taka Cho <takamune.cho@att.com>

Add Ajith to policy/drools-apps info

Issue-ID: POLICY-2738
Change-Id: I94d9ff05a6124a36d24190c47c600efc39df58c5
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Remove m2 model from drools-apps"

Support vDNS RainyDay test Case.

Change-Id: I6d2b17c5379b19b04589da4d7bc4a7f6ebc4d23a
Issue-ID: POLICY-2432
Signed-off-by: uj426b <uj426b@att.com>

Remove m2 model from drools-apps

With the advent of the new Actor model, then m2 model is no longer needed
in drools-apps.

Issue-ID: POLICY-2725
Change-Id: I3aa43619391552c00bd4e138aee96ca5d5bd55a8
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "remove nexus function from entrypoint"

remove nexus function from entrypoint

Issue-ID: POLICY-2673
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ib1bce9a813435718e83a6671d3790c610c14b709
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>

Fix drools-apps CSIT

Saw this in the log:
java.lang.NoClassDefFoundError:
    org/onap/policy/models/decisions/concepts/DecisionRequest

Added decisions jar to the (hopefully correct) pom.

Issue-ID: POLICY-2558
Change-Id: I5a2796b3eda6b3b39b2844cd112f5a18acfa0cf8
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Update-config simulator prop. with mvn assembly."

Update-config simulator prop. with mvn assembly.

Change-Id: Ia91fad549dfba0b3caa623be18652b93d0bc7fce
Issue-ID: POLICY-2716
Signed-off-by: uj426b <uj426b@att.com>

Remove usecases and legacy actor code

Made the following changes to remove usescase and legacy actor
code:
- deleted the usecases controller and feature
- deleted code associated with legacy actors, with the exception
  of AaiManager, which is needed by RestControlLoopManager
- moved the contents of the "guard" project into the m2/guard project,
  as that is the only thing that still needs it
  - modified the m2/GuardContext to get the name of its persistence unit
    from the properties so it could be overridden by junit tests
  - used eclipselink constants

Also fixed a bug in the properties for the VFC actor.

Addressed review comment:
- removed usecases from Dockerfile

Issue-ID: POLICY-2558
Change-Id: I677d68c9efed9247c3d55773abdcc736b577a6b4
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump drools-apps to 1.7.1-SNAPSHOT

Issue-ID: POLICY-2695
Change-Id: Iec9af37a01ba35c5b5419399cfb3d3bc80093101
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.0 docker artifacts

Issue-ID: POLICY-2695
Change-Id: I98c17adf83d75c410dd29049b1a863564f2a7c33
Signed-off-by: Jim Hahn <jrh3@att.com>

Release drools-apps 1.7.0 maven artifacts

Issue-ID: POLICY-2695
Change-Id: If71c57ab3931aac65ccd6e0e1fb8ef3d8d837e01
Signed-off-by: Jim Hahn <jrh3@att.com>

Refer to released versions drools-apps

Issue-ID: POLICY-2695
Change-Id: I2127501c4ac5472409570a7182209eded5b0f644
Signed-off-by: Jim Hahn <jrh3@att.com>

FIX context URI and https to false.

Change-Id: Iffecc4655d22b507188ea266e82046f2a82751e8
Issue-ID: POLICY-2703
Signed-off-by: uj426b <uj426b@att.com>

modify jmx script to accommodate json changes

Issue-ID: POLICY-2705
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iea6ea806855f5887e9a6206aa966746d822c3679

fix complete the assertion

add isInstanceOf for assertThatThrownBy.

Issue-ID: POLICY-2616
Change-Id: If49255aec6004870d7d2acfeabe258def872c1fa
Signed-off-by: Taka Cho <takamune.cho@att.com>

Use new Actor names in drools-apps

Modified drools-apps to use XxxActor instead of XxxActorServiceProvider.
This is the second step of the rename.

Issue-ID: POLICY-2684
Change-Id: Iea60e92f914b7719ac765b086650479be9192d98
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Updating drools applications dependencies"

Updating drools applications dependencies

Issue-ID: POLICY-2387
Change-Id: I1c3ee615f0a72a9e7cec8ccc573e27a0cbe3f02c
Signed-off-by: RossC <ross.carter@est.tech>

sonar issue - drools apps

- elevate the visibility of readResolve
- test case without assertions

Issue-ID: POLICY-2616
Change-Id: Ifde4b8c5e1281f8625a1203858fbe0467defe353
Signed-off-by: Taka Cho <takamune.cho@att.com>

Fix build breakage in drools-apps due to pair

The Pair changes made in drools-pdp also broke drools-apps builds.
Replaced usage of drools.utils.Pair with apache Pair.

Issue-ID: POLICY-2202
Change-Id: I50aaad47c243637688602ae6cb680a929fe3edd9
Signed-off-by: Jim Hahn <jrh3@att.com>

controlloop m2 sonar fix

- remove some unused statement
- remove unnecessary check

Issue-ID: POLICY-2616
Change-Id: Ieb2c898a3c6ad7210642aef990b43c9a01fc15b3
Signed-off-by: Taka Cho <takamune.cho@att.com>

Fix build error from Pair changes

This is a quick fix to get around a build error in drools-applications
due to "Pair" changes made in policy-common and/or policy-models.

Issue-ID: POLICY-2202
Change-Id: If1cb60947e55d97ef7cfb1d05d69e07c54c71a05
Signed-off-by: Jim Hahn <jrh3@att.com>

m2 sonar fix

- "get" returns a string already
- to avoid sonar issue for duplicated strings
- formating

Issue-ID: POLICY-2616
Change-Id: I1fac65bba5ecb402c784dd585ebcd7992cf31545
Signed-off-by: Taka Cho <takamune.cho@att.com>

Use parent snapshot in drools-apps

Fixed checkstyle issues that were subsequently reported.
Also fixed a few eclipse warnings.
Also fixed some of the sonar issues in the files that were touched:
- use "{}" in logger calls
- camelcase method names
- use "<?>" instead of generics
- add serialization ID

Issue-ID: POLICY-2188
Change-Id: I5c94a2e26dd74a61a0a919e1c3da17ab02a5bc9d
Signed-off-by: Jim Hahn <jrh3@att.com>

Changes for checkstyle 8.32

Issue-ID: POLICY-2188
Change-Id: Ib90222c537c5440e0de52fa0acbaa99bbcc4772a
Signed-off-by: Jim Hahn <jrh3@att.com>

fix sonar for m2/base - 2

- unused import
- Hide Utility Class Constructor : Utility classes
  should not have a public or default constructor

Issue-ID: POLICY-2616
Change-Id: I338a739b6e9fb5f4b47898566362b8a87201dae3
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "m2 sonar issues"

m2 sonar issues

- unused import
- logger format
- Extract the assignment out of this expression
- Replace this if-then-else statement
  by a single return statement

Issue-ID: POLICY-2616
Change-Id: I2d04569a7070f79fc8979274bce2b87b4b2f3e24
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "fix sonar issue for m2/base"

m2/appclcm sonar issue fix

swap the arguments
use assertNull

Issue-ID: POLICY-2616
Change-Id: Id5bd0b7acd0914566dfdebdb42fdcaabf9eb3012
Signed-off-by: Taka Cho <takamune.cho@att.com>

fix sonar issue for m2/base

-using {} in logger in stead
-diamond operator (<>) to reduce
 the verbosity of generics code.
-rename this method name to match
 the regular expression '^[a-z][a-zA-Z0-9]*$'

Issue-ID: POLICY-2616
Change-Id: I8e722af52b08382ca53190a33a3a27ad1e7d4830
Signed-off-by: Taka Cho <takamune.cho@att.com>

Merge "change audit and metric formats in feature-controlloop-trans"

change audit and metric formats in feature-controlloop-trans

logging enhancement

Issue-ID: POLICY-2579
Change-Id: Id1e0230d3cd2ac6d921be86f127f3721c65f3e52
Signed-off-by: Joseph Chou <jc2555@att.com>

Remove deprecated actor properties

Now that the actor change has been merged, the deprecated properties
can be removed from drools-apps.  Done.

Issue-ID: POLICY-2632
Change-Id: If4dafc489c32da4dfccd6ebac97e8e7beac2454d
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Adjust properties in anticipation of actor changes"

Adjust properties in anticipation of actor changes

Issue-ID: POLICY-2632
Change-Id: I4d20fe6b46432298ba796fe978796d5d74e1eb14
Signed-off-by: Jim Hahn <jrh3@att.com>

Clean up to remove controlloop.simulator.env

Change-Id: Ic336eb24f1f3ecda359f07714e59f075596cc105
Issue-ID: POLICY-2555
Signed-off-by: uj426b <uj426b@att.com>

Merge "Remove deprecated properties for CDS and VFC"

Merge "sonar issue drools applications - 3"

Remove deprecated properties for CDS and VFC

Now that the changes to the Actors have been merged, the former properties
can be removed, too.
Also fixed guard operator/operation name since it changed from "Guard"
to "Decision".

Issue-ID: POLICY-2629
Change-Id: I1c8d4575be598a8cab12b1aa4ad9b1d3e1f12113
Signed-off-by: Jim Hahn <jrh3@att.com>