Update policy-keystore with newer certificates

Issue-ID: POLICY-3139
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Ia67cb1486a5625385a710c5f6c2b4325ca108820
(cherry picked from commit 84be367144149644c5090f72bc0e02d95ef5811c)

Add logs for REST request/response in APEX

Change-Id: Ibf2cf19a1ec91473d8c655b87a712aa8738848c8
Issue-ID: POLICY-3003
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
(cherry picked from commit de9bb70b25d498e844c2c6205061aa9e5e9d8d7a)

Add exception to logs

Fixing the comments from previous review - https://gerrit.onap.org/r/c/policy/apex-pdp/+/116833

Issue-ID: POLICY-2885
Change-Id: I85474b365d92771e6e1b56bba95bde6e319d4ec2
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
(cherry picked from commit 514e435b6ad37525d781b383081cd10c12c2ce46)

Avoiding unwanted logging in APEX during event processing

Change-Id: If0c93bfea08025c6c10e3f4572a14088990f415f
Issue-ID: POLICY-2885
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
(cherry picked from commit 5f233e2e307e5202bfe1f319185f0880d354cb67)

Merge "Prune superfluous log and exception messages" into guilin

Removing duplicate logging of single response event

Change-Id: I88c8f2eea9cb295e422d20222df21a46ef84cd4e
Issue-ID: POLICY-2885
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
(cherry picked from commit 65450784b137f50442fdf170a2358c3953560d1d)

Prune superfluous log and exception messages

Large volume exception messages should not be repeated in log messages
or in rethrown exceptions.

Link: https://jira.onap.org/browse/POLICY-2885
Issue-ID: POLICY-2885
Signed-off-by: gregory.hayes <gregory.hayes@est.tech>
Change-Id: I345531d3a7640cc5ad9dbfc367052b9c8cc19387
(cherry picked from commit a3979b8a14f6e67de406b29c3e0ad0c516c3bc54)

Bump apex-pdp guilin to 2.4.5-SNAPSHOT

Issue-ID: POLICY-2893
Change-Id: Iff8121d10d3603e2071bc2f0978208fb9617331a
Signed-off-by: Jim Hahn <jrh3@att.com>

Release apex-pdp 2.4.4 docker

Issue-ID: POLICY-2893
Change-Id: I63133f408d2c289d9e172d3b9a6dc51d4a226d15
Signed-off-by: Jim Hahn <jrh3@att.com>

Release apex-pdp 2.4.4 artifacts

Issue-ID: POLICY-2893
Change-Id: Ief5eed296b23b2f90edbfa1f6b453a5c12b4a1f5
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Update gRPC example for JSON Stringify" into guilin

Merge "Apex CLI editor closes standard input/output/error" into guilin

Apex CLI editor closes standard input/output/error

The Apex CLI editor closes its input and output when it completes. This is correct behaviour when the input and output are files. However, if the input and output are tied to standard input, output, and error then if there are subsequent actions in the JVM (Such as continuing to run Apex as we do in tests), then any output such as logging is lost.

This fix checks for standard input/output/error before closing the input
and output.

Issue-ID: POLICY-2897
Change-Id: Ifa20b62511f770197f30c4a817212a92876dd6a6
Signed-off-by: liamfallon <liam.fallon@est.tech>
(cherry picked from commit 17527ee82c63b8671224b3340e379e0bfcce6ba1)

Update vCPE example for JSON Stringify

The JSON.stringify() call in the Rhino Javascript interpreter is not
working correctly. A previous patch introduced a method into the Apex
execution context to provide an alternative method for stringifying
JSON.

This patch updates the vCPE example in apex to use that new method.

Issue-ID: POLICY-2463
Change-Id: I85cc33dc4633b1b6f4c4db3d5ad8579c66d7c18c
Signed-off-by: liamfallon <liam.fallon@est.tech>
(cherry picked from commit da12c1c622ebc2304965ff1f646dc9783c5363c6)

Update gRPC example for JSON Stringify

The JSON.stringify() call in the Rhino Javascript interpreter is not
working correctly. A previous patch introduced a method into the Apex
execution context to provide an alternative method for stringifying
JSON.

This patch updates the gRPC example in apex to use that new method.

Issue-ID: POLICY-2463
Change-Id: I7f789c000d53dec60020fda2a6fccd71ef18edc3
Signed-off-by: liamfallon <liam.fallon@est.tech>
(cherry picked from commit fd5ee076b2ecf9fc5151090cf8a9b49fac6cf055)

Add method to allow JSON conversion to execution context for logic

The Rhino JSON.Stringify() method does not work well. This patch allows
the user to call schema specific or generic JSON conversion using the
schema handling in Apex or not as the developer chooses.

Added a single argument stringify2Json() method.

Issue-ID: POLICY-2463
Change-Id: I9ec1e0dea2f6cd153b73b2eace63d8806674884d
Signed-off-by: liamfallon <liam.fallon@est.tech>
(cherry picked from commit 90bc246ffec30f7d97474d772d8bad73715cdd45)

Point to guilin branch

Issue-ID: POLICY-2875
Change-Id: I228c3301562d11a0ac7c894791a7a31ed132451e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Bump apex-pdp to 2.4.4-SNAPSHOT

Change-Id: I5e2cd92ee3620dea4070d9fa3aeb5ffd65f9412c
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Release apex-pdp 2.4.3 docker

Change-Id: I08f7984cbc4f3b00f1720f21f27b6d019f90490e
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Release apex-pdp 2.4.3 artifacts

Change-Id: I57e11b3993c2b97450ba8cd82872bcce466c2ee5
Issue-ID: POLICY-2869
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Point apex to models 2.3.5

Issue-ID: POLICY-2869
Change-Id: I9880a3571da66390999f174ea2101a5e93280ac2
Signed-off-by: Pamela Dragosh <pdragosh@research.att.com>

Merge "Remove apex asciidoc documents"

Remove apex asciidoc documents

Apex documentation has now all been ported to use the ONAP recommended
rst format. This review removes the old asciidoc documents.

Issue-ID: POLICY-2824
Change-Id: I562bd344cb7d6ff36e7d54bdb8f95e3b656468f8
Signed-off-by: liamfallon <liam.fallon@est.tech>

Bump apex-pdp to 2.4.3-SNAPSHOT

Issue-ID: POLICY-2839
Change-Id: Ia7c847b3dafd28958d5df209af95cac19fa480a0
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Release apex-pdp 2.4.2 docker artifacts

Issue-ID: POLICY-2839
Change-Id: I5b7ee8e97fd47896877e3eadc8ebb61e60b082fa
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Release apex-pdp 2.4.2 maven artifacts

Issue-ID: POLICY-2839
Change-Id: I003109f4b999efaf57aba8a880f1800438baddf6
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Point to models 2.3.2 release

Issue-ID: POLICY-2839
Change-Id: Icb05b2c63cf760f8b8e02731e235041d7430a06e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Remove legacy operational policy type from apex-pdp

The legacy operational policy type for apex has been removed in Guilin release.
Removing it fron supported policy type and other places in apex-pdp.

Issue-ID: POLICY-2857
Change-Id: I41d58bf7e82292e11ff752f61dbe9be96a8a7af4
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Fixing APEX eventName handling to avoid duplicate requests

Change-Id: I6ee50fb455424ae1f241b7a12d1cdbf0e6ee4011
Issue-ID: POLICY-2815
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

update default keystores

Issue-ID: POLICY-2827
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I7cde8197621ccc3d366baab952243c7b7894a29b

Cleanup related to removal of legacy format support in APEX

This review basically just removes all "policyModelFileName" occurences
which are not used anymore.

Change-Id: Ibac8ec776dd989a5d677ff27a99eb7a36110773f
Issue-ID: POLICY-2835
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Use alpine base image 2.1.1

Issue-ID: POLICY-2819
Change-Id: I28b4c8acdef0302b6419a07c4445d60c398c4f73
Signed-off-by: Jim Hahn <jrh3@att.com>

Bump APEX version to 2.4.2-SNAPSHOT

Change-Id: Idde5050b425eb1bebe312e80e795c21513367a1b
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Release APEX docker 2.4.1

Change-Id: Ief1025869ee480fe0d43063c2590d74c6de2c77d
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Release APEX maven 2.4.1

Change-Id: I50a84d9abbb8563d1886f1ef199a79f1cc99b4ff
Issue-ID: POLICY-2789
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Delete apex-client from packaging

The "stage-release" failed due to:
  18:51:12 [ERROR] Failed to execute goal
  org.apache.maven.plugins:maven-dependency-plugin:3.1.1:copy
  (copy-fat-jars) on project apex-pdp-package-full: Unable to
  find/resolve artifact. Could not find artifact
  org.onap.policy.apex-pdp.client:apex-client-full:jar:full:2.4.1
  in release-mirror (https://nexus.onap.org/content/repositories/public/)
  -> [Help 1]

Removed it from the package, as it is no longer part of apex-pdp.

Issue-ID: POLICY-2789
Change-Id: I4089096ab9668af33e885c70e140ce8fc1f51939
Signed-off-by: Jim Hahn <jrh3@att.com>

Remove deleted dependency from apex-pdp

One of the poms refers to core-deployment, which has been deleted from
apex-pdp.  Deleted it from the pom.

Issue-ID: POLICY-2789
Change-Id: Ie9d9265ad61808ca0d5dbf8ea3e772ac7348edbb
Signed-off-by: Jim Hahn <jrh3@att.com>

Pointing to released common & models

Issue-ID: POLICY-2789
Change-Id: Ibaaf533f79cf2bc98090b2933392945ef8bb06ef
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

APEX standalone support for ToscaPolicy format

Legacy format support is removed, and Tosca format support is added.

Change-Id: I3cfc181ccb5471a5d224c0162af18c1fa0fdbc70
Issue-ID: POLICY-2812
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Merge "Remove client code from apex-pdp"

point to 2.1.0 policy-alpine base - apex

In G-rel, using 2.1.0 base.

Issue-ID: POLICY-2789
Change-Id: Ieff7433ab0c85abca218032a0a3c91bb42081a80
Signed-off-by: Taka Cho <takamune.cho@att.com>

Remove client code from apex-pdp

Removal of the deployment and monitoring client from the apex-pdp as
the functionality is replaced by the Policy Framework deployment using
PAP and the Policy Framework monitoring GUI.

Code in the engine proper that was used to administer apex-pdp over the
Web Socket port is also removed, as this code was only used by the
apex-pdp legacy GUIs.

Issue-ID: POLICY-2621
Change-Id: Ib9fc4a667a4bc79377bb7b82fae6a2bd520a3e3d
Signed-off-by: liamfallon <liam.fallon@est.tech>

Merge "Sonar Bug fixes"

Sonar Bug fixes

Removal of remaining bugs in apex-pdp

Issue-ID: POLICY-2774
Change-Id: I370796e7c8a41c116155155c33176512e9e0cd91
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Clean up warnings and SONAR issues

Issue-ID: POLICY-2654
Change-Id: Ifd391ea9141d37cfd3ca4110d66c667962230ae1
Signed-off-by: liamfallon <liam.fallon@est.tech>

Sonar Build Fix

Issue-ID: POLICY-2611
Change-Id: I125e2e4be8e8f3f5e8bb67b282c134a51f1cd255
Signed-off-by: waynedunican <wayne.dunican@est.tech>

JavaScript Sonar Coverage setup

Sonar properties added to apex-pdp in order to pick up JavaScript
coverage in SonarCloud

Issue-ID: POLICY-2611
Change-Id: Ia9c5837bc18a34722437b2b299e85c6a8a67088d
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Update apex JRuby joni dependency for security

Issue-ID: POLICY-2799
Change-Id: Ifdc16e99093995665db61329f61455fc0f327386
Signed-off-by: liamfallon <liam.fallon@est.tech>

Correct directory permission check in apex

Apex checked if the current directory is writable when it starts, it is corrected
to just check that the directory is readable and executable.

Issue-ID: POLICY-2791
Change-Id: I794f836cabfde0f6f78392b3c9e1de364d76e5f6
Signed-off-by: liamfallon <liam.fallon@est.tech>

Merge "SONAR fixes - assert dissimiliar types"

Merge "Changes to make APEX container crash with non zero exitCode"

Merge "Remove apex policy editor gui"

Changes to make APEX container crash with non zero exitCode

Change-Id: I1d36c28cfb07881ebede1cf918140397b076512c
Issue-ID: POLICY-2753
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

SONAR fixes - assert dissimiliar types

Fix for assertions comparing dissimiliar types.

Issue-ID: POLICY-2761
Change-Id: I1b2b8afa3e6308cda887d73a4ee079709847d054
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Remove apex policy editor gui

The apex policy editor has been moved to policy-gui. This review removes
the code from the apex-pdp repo.

Issue-ID: POLICY-2621
Change-Id: Ib5b90386d0da8af6eec8870fbcaf01b94975d5c6
Signed-off-by: liamfallon <liam.fallon@est.tech>

SONAR fixes - log formatting

Fixed the sonar issues relating to Printf format being used for logging
instead of String concatenation

Issue-ID: POLICY-2773
Change-Id: I38db8d1df077fd7102f6c4f9b33685f2914bd624
Signed-off-by: waynedunican <wayne.dunican@est.tech>

SONAR cleanup

Removed the "result != null" checks

Issue-ID: POLICY-2768
Change-Id: Ibf174fbbb99512b1847b319931bc17a984fb8cc0
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Merge "Handling apex-pdp multi policy deployment failure:"

Merge "Sonar Fixes"

SONAR assertion cleanup

Replaced assertions to not have the same actual and expected expression
in apex-pdp

Issue-ID: POLICY-2761
Change-Id: I2bf45a3cc4411bd39f93f9d0b8c8e56dd318281e
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Handling apex-pdp multi policy deployment failure:

1.Include the list of duplicate parameters in the logs for easier troubleshooting
2.Also fix 4 Sonar blockers in ApexMainTest.java

Issue-ID: POLICY-2712
Signed-off-by: puthuparambil.aditya <aditya.puthuparambil@bell.ca>
Change-Id: I145a7e03f76f880f8e3cbde97284748468b354a5

Sonar Fixes

Replace the type specification in this constructor call with the diamond operator
and other small fixes

Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Issue-ID: POLICY-2760
Change-Id: I83821859a4a1dbbffbaeae15281abac2de3b5712

change shebang bash line

The shebang line does not take flags causing container
intialization problems.

Issue-ID: POLICY-2615
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: Iac66922873ded0684232c23e3fa2ac6747a959ae

environment variables to support cert. store paths

Issue-ID: POLICY-2615
Signed-off-by: jhh <jorge.hernandez-herrero@att.com>
Change-Id: I746f1be50f7a85c0febddc9a92576bb2dbcd9a06

Update info yaml in policy/apex-pdp

Issue-ID: POLICY-2738
Change-Id: I36b0180ce0eeab793b62af857d55f27c50b3d012
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Fixing intermittent test failures in APEX

Here the intermittent test failures are fixed by providing a latch to
wait until the DeploymentClient is started. This may need improvement,
but all these deployment classes will be removed soon, hence not worth
the effort.

Change-Id: I1090e991c0448b42af1d9cbd16d96ae1cb5774fd
Issue-ID: POLICY-2654
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Merge "APEX changes to support policy disable/enable and some improvements"

Merge "SONAR assertions apex-pdp"

SONAR assertions apex-pdp

Ensure assertions are present in test cases

Issue-ID: POLICY-2706
Change-Id: I3673a7668564401d2136450b0bdd7a013605dd7c
Signed-off-by: waynedunican <wayne.dunican@est.tech>

APEX changes to support policy disable/enable and some improvements

1) Do not stop all the marshallers/unmarshallers while updating the
engine. Stop and remove only those that are part of the policies that
are undeployed.
2) Do not reinitilaize any marshaller/unmarshaller that is already
initilaized as part of the policies which were already deployed.
Initialize only the ones as part of any newly deployed policy.
3) EngineParameters could be different in different policies. Aggregate
these parameters and make it available in the engine for any running policy.
4) Enable support for running policies with same model and different
configurations.

Change-Id: If74807a0515a741ef4e53bd0a93e43b05872f6b5
Issue-ID: POLICY-2536
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>

Merge "Fix replaceAll SONAR issues in apex-pdp"

Fix replaceAll SONAR issues in apex-pdp

Change replaceAll() with repalce() in apex-pdp

Issue-ID: POLICY-2722
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: I8a15b99f02399addfc8f0e25349e3022d8b8c9f1

Add Ajith to apex-pdp info

Also made changes required by changes to rules that process the yaml file.

Issue-ID: POLICY-2738
Change-Id: I1976f711b7f278c4e5a5b1d7338f451e81c42075
Signed-off-by: Jim Hahn <jrh3@att.com>

Merge "Fix assertTrue in apex-pdp/model"

Merge "Fix replaceAll SONAR issues in apex-pdp"

Fix assertTrue in apex-pdp/model

Replace assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp/model

Issue-ID: POLICY-2690
Change-Id: Ifd435a4ea69d8f682407c2a70d5e8119f017ae9f
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>

Merge "Remove try/catch blocks with assertj - apex-pdp"

Remove try/catch blocks with assertj - apex-pdp

Removed try/catch blocks in apex-pdp and replaced with assertj
assertions Part III

Issue-ID: POLICY-2451
Change-Id: I1e6ede1c256c5bcf7899e1af130add71fdf1381c
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Fix replaceAll SONAR issues in apex-pdp

Change replaceAll() with repalce() in apex-pdp/plugins and
apex-pdp/testsuites

Issue-ID: POLICY-2722
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>
Change-Id: Ib9d5256c050197b06f9df9c4cbb7562be081283c

Merge "Fix assertTrue in apex-pdp/model apex-pdp/plugins, apex-pdp/services and apex-pdp/testsuites"

Fix assertTrue in apex-pdp/model apex-pdp/plugins, apex-pdp/services and apex-pdp/testsuites

Replace assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp/model, apex-pdp/plugins, apex-pdp/services
and apex-pdp/testsuites

Issue-ID: POLICY-2690
Change-Id: If088371cf012d5648e04ade2aa4d49b38945f6d2
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>

Replace try/catch with assertj - apex-pdp

Replaced try/catch blocks apex-pdp with assertj assertions. Part III of
changes.

Issue-ID: POLICY-2451
Change-Id: I77ee4140cdfc2066f463459f92163677c3e34ef2
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Merge "Refer to snapshot versions"

Merge "Replace try/catch with assertj - apex-pdp"

Merge "Fix assertTrue SONAR issues in apex-pdp/model"

Refer to snapshot versions

Issue-ID: POLICY-2695
Change-Id: I97ab109ee7a3a80cb44890f2586407d9a32c8bd7
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>

Merge "Fix double initiation error on EngineServiceFacade"

Fix assertTrue SONAR issues in apex-pdp/model

Replace assertTrue with assertEquals and assertFalse with
assertNotEquals in apex-pdp/model

Issue-ID: POLICY-2690
Change-Id: Id37989ea8a6ad7b3156e13851cc072ce6c53c03e
Signed-off-by: JvD_Ericsson <jeff.van.dam@est.tech>

Replace try/catch with assertj - apex-pdp

Replaced try/catch blocks in apex-pdp with assertj assertions. Part II
of changes

Issue-ID: POLICY-2451
Change-Id: I29823054fbeb6d1a287d1234859aaf2d4609ef6d
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Fix double initiation error on EngineServiceFacade

The engineServiceFacade allows it's init() method to be called twice,
the second call should return that the facade is already initialized.

Issue-ID: POLICY-2720
Change-Id: Id241e232163a8812a72f92841ce7b11f59358d45
Signed-off-by: liamfallon <liam.fallon@est.tech>

Merge "Renaming password variables to match with oom"

Merge "Replaced try/catch blocks with assertj - apex-pdp"

Merge "Replace try/catch with assertj"

Renaming password variables to match with oom

Issue-ID: POLICY-2633
Change-Id: If5df0e82ab4154f5e32cdc3a5080cb13264830aa
Signed-off-by: RossC <ross.carter@est.tech>

Replace try/catch with assertj

Replaced try/catch blocks with assertj assertions in apex-pdp. Last
batch of changes

Issue-ID: POLICY-2451
Change-Id: I39bd02fdbd8389818dcf1b786189c1e344ddcea5
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Replaced try/catch blocks with assertj - apex-pdp

Removed try/catch blocks in apex-pdp with assertj assertions Part IV

Issue-ID: POLICY-2451
Change-Id: I4b6accb9f944195db9ccf8a5de165b169301ac7f
Signed-off-by: waynedunican <wayne.dunican@est.tech>

Merge "Fix assertTrue SONAR issues in apex-pdp/examples and apex-pdp/model"

Merge "Remove old documentation from build"

Merge "Fix assertTrue SONAR issues in apex-pdp/contex and apex-pdp/core"

Merge "Allowing configuration of truststore password"