policy/apex-pdp.git
20 months agoFix minor warnings in code 90/130990/1
liamfallon [Fri, 16 Sep 2022 19:09:11 +0000 (20:09 +0100)]
Fix minor warnings in code

Issue-ID: POLICY-4045
Change-Id: I6e3a73e243614108cfd9ea6a6967cb983a006ee4
Signed-off-by: liamfallon <liam.fallon@est.tech>
20 months agoRemove inactive committers from INFO.yaml 28/130828/1
liamfallon [Fri, 9 Sep 2022 09:23:07 +0000 (10:23 +0100)]
Remove inactive committers from INFO.yaml

Remove inactive committers from INFO.yaml

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4354
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ia0ab0e2b497f6fff2f035a4adbfdb5613d7044cb

20 months agoAllow setting external dockerfile for apex-pdp 36/130636/1
danielhanrahan [Thu, 1 Sep 2022 13:55:46 +0000 (14:55 +0100)]
Allow setting external dockerfile for apex-pdp

If building with an external dockerfile, e.g. using
 mvn clean install -Pdocker -DdockerFile=/path/to/dockerfile
docker will look for project files in the same directory as the
new dockerfile. A new property is added for setting the context
path, to allow using existing project files in src/main/docker.

Issue-ID: POLICY-4334
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I52606f85b720449e8ed9b532e55200c9f825e3cd

20 months agoAdd example policy for AC element microservice test 93/130393/5
FrancescoFioraEst [Fri, 19 Aug 2022 11:09:51 +0000 (12:09 +0100)]
Add example policy for AC element microservice test

Issue-ID: POLICY-4307
Change-Id: I0275bbacb3d2689f50f93eef541cd43601aab8ef
Signed-off-by: FrancescoFioraEst <francesco.fiora@est.tech>
21 months agoMerge "Remove Kafka version, reference from integration"
Liam Fallon [Sun, 31 Jul 2022 18:33:50 +0000 (18:33 +0000)]
Merge "Remove Kafka version, reference from integration"

21 months agoRemove Kafka version, reference from integration 57/130057/2
Sirisha_Manchikanti [Thu, 28 Jul 2022 14:14:17 +0000 (15:14 +0100)]
Remove Kafka version, reference from integration

Issue-ID: POLICY-4313
Signed-off-by: Sirisha_Manchikanti <sirisha.manchikanti@est.tech>
Change-Id: Ia07c5e9cb4ef29ac0110106228f0c1fa3df947a8

21 months agoUpdate docker base image to snapshot 70/130070/1
liamfallon [Fri, 29 Jul 2022 14:28:29 +0000 (15:28 +0100)]
Update docker base image to snapshot

Update docker base image to snapshot

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4287
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: If5d65a14fb695e2de6ec9031017e026b5dbdf089

21 months agoUpdate APEX example to use JSON Schema plugin 21/130021/4
a.sreekumar [Mon, 25 Jul 2022 09:46:57 +0000 (10:46 +0100)]
Update APEX example to use JSON Schema plugin

Change-Id: Ic8b412ce0ca71b4452d67b1e4445e423b0ec5b54
Issue-ID: POLICY-4292
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
21 months agoMerge "Support MetadataSet generation in APEX CLI Editor"
Liam Fallon [Fri, 22 Jul 2022 09:13:05 +0000 (09:13 +0000)]
Merge "Support MetadataSet generation in APEX CLI Editor"

21 months agoAdding JSON Schema support in APEX-PDP 76/129976/6
a.sreekumar [Tue, 19 Jul 2022 10:49:57 +0000 (11:49 +0100)]
Adding JSON Schema support in APEX-PDP

More details can be found here:
https://wiki.onap.org/display/DW/JSON+Schema+support+in+APEX-PDP

A separate review will be raised as part of POLICY-4292 with a reference
example on how to use the JSON Schema.

Change-Id: I903d48969c6c5a24c63b8465b2412ed0b75b9351
Issue-ID: POLICY-4291
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
21 months agoSupport MetadataSet generation in APEX CLI Editor 36/129836/3
rameshiyer27 [Fri, 8 Jul 2022 11:29:25 +0000 (12:29 +0100)]
Support MetadataSet generation in APEX CLI Editor

In addition to the existing capabilities of CLI editor, new arguments added for generating
Tosca policy template excluding the policy model entity.
Also generates independent json file for node template comprising the policy model data.

Issue-ID: POLICY-4084
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: I7c6a9570846e3ebfaa3f4ebc8d60faa94b533240

22 months agoRemove debian packaging from apex-pdp build 10/129910/2
danielhanrahan [Wed, 13 Jul 2022 13:51:10 +0000 (14:51 +0100)]
Remove debian packaging from apex-pdp build

Issue-ID: POLICY-4285
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I599d05d19d97c70c5339c554d469c4c79b4c420e

22 months agoReduce size of docker images for APEX-PDP 01/129901/1
danielhanrahan [Fri, 1 Jul 2022 14:11:06 +0000 (15:11 +0100)]
Reduce size of docker images for APEX-PDP

Avoid creating extra layers when extracting tarball
Remove redundant chown/chmod commands
Reduce size of Alpine image by 25% (853MB to 638MB)
Reduce size of OpenSuse image by 27% (826MB to 606MB)

Issue-ID: POLICY-4272
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iebcad1d0b0f784b85a7d1e96c7b8edfd45b27060

22 months agoUpgrade OpenSuse version to 15.4 for apex-pdp 68/129868/1
danielhanrahan [Mon, 11 Jul 2022 14:35:12 +0000 (15:35 +0100)]
Upgrade OpenSuse version to 15.4 for apex-pdp

Issue-ID: POLICY-4278
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Ida486b651aa9d7ec9dde96668d33b3f0b73936f3

22 months agoOCI image spec labels for APEX-PDP 08/129708/1
danielhanrahan [Tue, 28 Jun 2022 10:45:15 +0000 (11:45 +0100)]
OCI image spec labels for APEX-PDP

Issue-ID: POLICY-4255
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: Iedd26861fe66d5cd11d168c9e6534a7c04676a42

23 months agoAdd Ramesh Murugan Iyer as a committer 49/129449/1
liamfallon [Wed, 1 Jun 2022 12:21:12 +0000 (13:21 +0100)]
Add Ramesh Murugan Iyer as a committer

Issue-ID: POLICY-4228
Change-Id: Iab473d9b9fceb45cb3329e8964f78ef298df2835
Signed-off-by: liamfallon <liam.fallon@est.tech>
23 months agoOpenSuse docker file for APEX-PDP 01/129401/2
danielhanrahan [Tue, 24 May 2022 09:06:56 +0000 (10:06 +0100)]
OpenSuse docker file for APEX-PDP

Create OpenSuse docker file
Add build profile for OpenSuse docker image

Issue-ID: POLICY-4190
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I2a2635a0353ff4e402e8c9049245b947fe5781d3

2 years agoAPEX-PDP S3P changes for Jakarta 44/129044/2
danielhanrahan [Wed, 27 Apr 2022 17:45:57 +0000 (18:45 +0100)]
APEX-PDP S3P changes for Jakarta

Update credentials for healthcheck/policyadmin
Use JMeter user defined variables in policies for SIM_HOST,
 DMAAP_PORT and CDS_PORT

Issue-ID: POLICY-4010
Signed-off-by: danielhanrahan <daniel.hanrahan@est.tech>
Change-Id: I4f44b4721c24b70ef5dac24b8300350a2e34ed5f

2 years agoSet snapshot and/or references of policy/apex-pdp for new release 53/129053/1
liamfallon [Tue, 3 May 2022 16:22:02 +0000 (17:22 +0100)]
Set snapshot and/or references of policy/apex-pdp for new release

policy/apex-pdp updated to its latest own and reference snapshots

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4073
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I36c398ac9f30480b55e7ad15b3fb4161d8999206
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoUpdate snapshot and/or references of policy/apex-pdp to latest snapshots 76/128976/1
liamfallon [Thu, 28 Apr 2022 15:00:38 +0000 (16:00 +0100)]
Update snapshot and/or references of policy/apex-pdp to latest snapshots

policy/apex-pdp updated to its latest own and reference snapshots

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: If859b088c5975c8dda67c34f335658c98341be57

2 years agoRelease docker images for policy/apex-pdp: 2.7.3 68/128968/1
liamfallon [Thu, 28 Apr 2022 14:32:41 +0000 (15:32 +0100)]
Release docker images for policy/apex-pdp: 2.7.3

This commit releases docker images for repo policy/apex-pdp.

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ie9867ce1f7c26e596f3ce0214971a2ecc70d9403

2 years agoRelease policy/apex-pdp: 2.7.3 56/128956/1
liamfallon [Thu, 28 Apr 2022 13:40:24 +0000 (14:40 +0100)]
Release policy/apex-pdp: 2.7.3

This commit releases repo policy/apex-pdp.

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I2e79f4fda47b2982ad8f04e89960720246a4c518

2 years agoupdate references in policy/apex-pdp pom 20/128920/1
liamfallon [Wed, 27 Apr 2022 19:55:33 +0000 (20:55 +0100)]
update references in policy/apex-pdp pom

updated references in the policy/apex-pdp pom

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Id4f807154fa39b33e1f3316998f45952473156ce

2 years agoUpgrade dependencies for JRuby for security 88/128788/1
liamfallon [Fri, 22 Apr 2022 10:12:12 +0000 (11:12 +0100)]
Upgrade dependencies for JRuby for security

Issue-ID: POLICY-4070
Change-Id: I7ad7c3f6a98e7e3cac83cbe06a8111173a6bffe2
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoUpdate dependencies for security 81/128581/1
liamfallon [Wed, 13 Apr 2022 17:22:11 +0000 (18:22 +0100)]
Update dependencies for security

Secure versions of Hazelcast and activeMQ are available.

Issue-ID: POLICY-4070
Change-Id: I78ccef19af1e1cc212c3327a26ef44259c49ff90
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoUpdate snapshot and/or references of policy/apex-pdp to latest snapshots 32/128532/1
liamfallon [Tue, 12 Apr 2022 20:35:01 +0000 (21:35 +0100)]
Update snapshot and/or references of policy/apex-pdp to latest snapshots

policy/apex-pdp updated to its latest own and reference snapshots

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ida537dd5acbd299893f3e30bac84146e134d3a0f

2 years agoRelease docker images for policy/apex-pdp: 2.7.2 20/128520/1
liamfallon [Tue, 12 Apr 2022 18:47:13 +0000 (19:47 +0100)]
Release docker images for policy/apex-pdp: 2.7.2

This commit releases docker images for repo policy/apex-pdp.

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ifd249e3056583bb0469f5c1b0799a03544586f2b

2 years agoRelease policy/apex-pdp: 2.7.2 13/128513/1
liamfallon [Tue, 12 Apr 2022 18:23:13 +0000 (19:23 +0100)]
Release policy/apex-pdp: 2.7.2

This commit releases repo policy/apex-pdp.

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I7b07c7ad1a04c0f84ea02dede5edada3fc8cdb53

2 years agoupdate references in policy/apex-pdp pom 08/128508/1
liamfallon [Tue, 12 Apr 2022 17:41:39 +0000 (18:41 +0100)]
update references in policy/apex-pdp pom

updated references in the policy/apex-pdp pom

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-4089
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Id62dfd01928b8f46d7365a350fe5299b43f1f7e8

2 years agoFix wrong APEX-PDP behaviour during state change 00/128400/1
a.sreekumar [Fri, 8 Apr 2022 15:22:17 +0000 (16:22 +0100)]
Fix wrong APEX-PDP behaviour during state change

When a policy is deployed & undeployed, and then on doing
PDP_STATE_CHANGE to passive and then active, previously undeployed
policies are taken from memory and tried to be deployed. Any undeployed
policies should be cleared from the engine memory.
This is fixed here.

Change-Id: I8f6fbc64d29bd8d89e906376d0770d375ffd8b82
Issue-ID: POLICY-4087
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoRemove unused dependencies 73/128373/1
liamfallon [Thu, 7 Apr 2022 15:33:06 +0000 (16:33 +0100)]
Remove unused dependencies

Issue-ID: POLICY-4070
Change-Id: I2138dc4adb10227add14f22275427340fb71c426
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoBug fixes for APEX PDP metrics 34/128234/2
Rashmi Pujar [Thu, 31 Mar 2022 15:52:53 +0000 (11:52 -0400)]
Bug fixes for APEX PDP metrics

1. APEX engine metrics were being initialized to 0 in the
constructor which caused them to reset to 0. Hence, initialization
is removed, and updates are done to metrics only upon:
engineStart/Stop, executionEnter/Exit stages.
2. APEX engine Uptime was only updated when engine stopped,
hence always 0. Also, uptime is redundant since it can be derived
from lastStart timestamp and hence is removed as a metric.
3. Fixed a corner case bug which occurs when all
policies are undeployed the counters are not correct.
4. Fix Unit tests

Issue-ID: POLICY-4044
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I4d875ff288cf8c242a1851eb105e56dc69b97883

2 years agoAccount for batch deploy/undeploy in apex app metrics 20/128020/3
Rashmi Pujar [Wed, 23 Mar 2022 16:16:21 +0000 (12:16 -0400)]
Account for batch deploy/undeploy in apex app metrics

Batch deploy/undeploy operations will now increment
pdpa_policy_deployments_total counter by the total
number of policies as present in the request.

Issue-ID: POLICY-4043
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I9ea34d11f5952213b9e72d121ab85dcbd0b8dfc9

2 years agoUpdate snapshot and/or references of policy/apex-pdp to latest snapshots 15/127715/1
liamfallon [Fri, 11 Mar 2022 18:03:00 +0000 (18:03 +0000)]
Update snapshot and/or references of policy/apex-pdp to latest snapshots

policy/apex-pdp updated to its latest own and reference snapshots

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-3982
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I838a8d4d6365de1df2feda9d7ba7ffefbfd82c4f

2 years agoRelease docker images for policy/apex-pdp: 2.7.1 02/127702/1
liamfallon [Fri, 11 Mar 2022 14:12:19 +0000 (14:12 +0000)]
Release docker images for policy/apex-pdp: 2.7.1

This commit releases docker images for repo policy/apex-pdp.

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-3982
Change-Id: I4e07720786470b2247139b2a27b1793987f165fc
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoRelease policy/apex-pdp: 2.7.1 94/127694/1
liamfallon [Fri, 11 Mar 2022 12:07:40 +0000 (12:07 +0000)]
Release policy/apex-pdp: 2.7.1

This commit releases repo policy/apex-pdp.

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-3982
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I9790e4cf6a4e53e320f58ce4bbb3c79206e44eee

2 years agoRemove bad dependency in apex POM 85/127685/1
liamfallon [Fri, 11 Mar 2022 11:19:37 +0000 (11:19 +0000)]
Remove bad dependency in apex POM

Eclipselink and direct persistence was removed from Apex in Jakarta.

Issue-ID: POLICY-3982
Change-Id: I5f6d2a31b51688d78662d6a30208a96a61869555
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoRemove bad dependency in apex POM 84/127684/1
liamfallon [Fri, 11 Mar 2022 10:28:14 +0000 (10:28 +0000)]
Remove bad dependency in apex POM

Websocket carrier, which used jax-rs was removed in Jakarta.

Issue-ID: POLICY-3982
Change-Id: Ia8a3919968166a52e802f5d04c9c2a984208a338
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "Remove bad dependency in apex POM"
Liam Fallon [Fri, 11 Mar 2022 10:06:08 +0000 (10:06 +0000)]
Merge "Remove bad dependency in apex POM"

2 years agoRemove bad dependency in apex POM 71/127671/2
liamfallon [Thu, 10 Mar 2022 20:59:57 +0000 (20:59 +0000)]
Remove bad dependency in apex POM

XML event protocol was removed as jax-rs dependencies were removed in
Jakarta.

Issue-ID: POLICY-3982
Change-Id: I5e8881ae8062fd46b46a1ec655e1210b8ccf2fbf
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "Remove bad dependency in apex POM"
Ajith Sreekumar [Thu, 10 Mar 2022 18:29:51 +0000 (18:29 +0000)]
Merge "Remove bad dependency in apex POM"

2 years agoRemove bad dependency in apex POM 69/127669/1
liamfallon [Thu, 10 Mar 2022 18:16:01 +0000 (18:16 +0000)]
Remove bad dependency in apex POM

The Apex model modules were all collapsed into a single module in
Jakarta.

Issue-ID: POLICY-3982
Change-Id: Ibeebb7c89ca6057ce2f9333d14183e9da75e11a1
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "Remove bad dependency in apex POM"
Ajith Sreekumar [Thu, 10 Mar 2022 17:55:35 +0000 (17:55 +0000)]
Merge "Remove bad dependency in apex POM"

2 years agoRemove bad dependency in apex POM 67/127667/1
liamfallon [Thu, 10 Mar 2022 17:36:22 +0000 (17:36 +0000)]
Remove bad dependency in apex POM

The Apex core modules were all collapsed into a single module in
Jakarta.

Issue-ID: POLICY-3982
Change-Id: I76e039fa58d4338d03331aa818ee44ea58451930
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "Remove bad dependeny in apex POM"
Ajith Sreekumar [Thu, 10 Mar 2022 16:56:41 +0000 (16:56 +0000)]
Merge "Remove bad dependeny in apex POM"

2 years agoRemove bad dependeny in apex POM 66/127666/3
liamfallon [Thu, 10 Mar 2022 16:24:21 +0000 (16:24 +0000)]
Remove bad dependeny in apex POM

The apex models utils module has been collapsed in tho the apex models
module.

Issue-ID: POLICY-3982
Change-Id: I0563034c87d30d3b73af74647ba15f47aaf98cde
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoupdate references in policy/apex-pdp pom 17/127617/2
liamfallon [Thu, 10 Mar 2022 09:12:37 +0000 (09:12 +0000)]
update references in policy/apex-pdp pom

updated references in the policy/apex-pdp pom

*** This commit is generated by a PF release script ***

Issue-ID: POLICY-3982
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I908f81ff66d652ce97f82763887ad08034de6900
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoAdd support for retrieving apex-policyModel from metadata 63/127263/1
rameshiyer27 [Wed, 23 Feb 2022 19:07:28 +0000 (19:07 +0000)]
Add support for retrieving apex-policyModel from metadata

Apex policyModel had been provided under policy properties for apex-pdp.
Additional support included to retrieve the policyModel from metadata if PAP supplied it
as metadataSet.

Issue-ID: POLICY-3834
Signed-off-by: zrrmmua <ramesh.murugan.iyer@est.tech>
Change-Id: Ic810d78cf01c507c5b4d167f28ae6f7729132238

2 years agoRemove apex-pdp unused core modules 72/127072/1
liamfallon [Fri, 11 Feb 2022 00:43:14 +0000 (00:43 +0000)]
Remove apex-pdp unused core modules

This is the final review in the refactoring of the model code in
apex-pdp.

The core-messaging and core-infrastructure modules are unused in
apex-pdp except for websocket communication. Websocket communication is
also not used in any deployment.

This review:
- removes the core-mesaging module, which had an apex-specific websocket
  implementation, except for the MessageException class, which is moved
  to the base core module
- removes the core-infrastructure module, except for the ThreadUtils
  class, which is moved to the base core module
- removes the websocket event protocol, which used core-messaging but is
  not used in any deployment
- collapses all three "core" submodules into a single module
- Updates dependencies where needed

Issue-ID: POLICY-1820
Change-Id: Ieae30063e99570e61943372d3fa23b77a211462c
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoCollapse apex-pdp maven model submodules 51/127051/3
liamfallon [Thu, 10 Feb 2022 12:06:25 +0000 (12:06 +0000)]
Collapse apex-pdp maven model submodules

This review collapses all the code in six podel submodules into a single
model module. There are no code changes, just files moved around.

This change reduces the complexity of the code structure and speeds up
the build.

Issue-ID: POLICY-1820
Change-Id: Ifb644e8ec85ae6d0987378f4616fbc8a8858a9a8
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "rename metrics as per global constants for prometheus"
Liam Fallon [Thu, 10 Feb 2022 13:18:43 +0000 (13:18 +0000)]
Merge "rename metrics as per global constants for prometheus"

2 years agorename metrics as per global constants for prometheus 88/126788/5
Rashmi Pujar [Thu, 27 Jan 2022 03:39:11 +0000 (22:39 -0500)]
rename metrics as per global constants for prometheus

Issue-ID: POLICY-3760
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I0fb59e8d9c95fd81a1754bb769705ef753b9022d

2 years agoMerge "Remove JAXB and XML, use GSON for JSON"
Jorge Hernandez [Wed, 9 Feb 2022 19:04:25 +0000 (19:04 +0000)]
Merge "Remove JAXB and XML, use GSON for JSON"

2 years agoRemove JAXB and XML, use GSON for JSON 24/127024/1
liamfallon [Mon, 7 Feb 2022 17:56:44 +0000 (17:56 +0000)]
Remove JAXB and XML, use GSON for JSON

This review converst apex-pdp to use GSON for JSON handling. In order to
preserve backward compatibility with the JAXB format of JSON, custom
handling of maps was required. Therefore, the policy-common
StandardCoder could not be used.

There are a lot of small changes, removing annotations from concepts and
tweaking of test data. However, this cleans up the code base so it is
worth doing.

Issue-ID: POLICY-1820
Change-Id: I213fa64f6d7f3f1df8d10f111d9fbedbe80f9fe0
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoExpose APEX policy execution metrics 62/126762/9
Rashmi Pujar [Tue, 25 Jan 2022 23:08:09 +0000 (18:08 -0500)]
Expose APEX policy execution metrics

Testing of these metrics will be covered in CSIT.

Issue-ID: POLICY-3845
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I8aed49d113f071ab33691f8cf1df624f3358386a

2 years agoRemove JPA annotations from apex-pdp code 66/126966/1
liamfallon [Fri, 4 Feb 2022 10:34:28 +0000 (10:34 +0000)]
Remove JPA annotations from apex-pdp code

This review is part of a series of reviews to move the apex-pdp state
machine model to use the base model types in policy models.

Persistence of policies for apex-pdp is now implemented in PAP and API.
The historic direct load and save functionality for APEX policy state
machine models to and from databases is no longer used and no longer
supported.

This commit removes JPA annotations form apex-pdp code.

Subsequent reviews will mvoe the mdoel across to use the policy models
base model types.

Issue-ID: POLICY-1820
Change-Id: I91a45a0ca6c88f9ba4b201bad920065f95ffb31e
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoRemove direct DB Load/Save from apex-pdp 43/126943/1
liamfallon [Thu, 3 Feb 2022 12:01:57 +0000 (12:01 +0000)]
Remove direct DB Load/Save from apex-pdp

This review is part of a series of reviews to move the apex-pdp state
machine model to use the base model types in policy models.

Persistence of policies for apex-pdp is now implemented in PAP and API.
The historic direct load and save functionality for APEX policy state
machine models to and from databases is no longer used and no longer
supported.

This revmoves the DAO code from apex-pdp and the associated handling
and test code.

The next review will remove the JPA annotations.
Subsequent reviews will mvoe the mdoel across to use the policy models
base model types.

Issue-ID: POLICY-1820
Change-Id: Iabf034b40a413d32fe62091fe3446f52ec30d3af
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoRemove references to MariaDB from resource files 89/126789/3
waynedunican [Tue, 16 Nov 2021 08:44:43 +0000 (08:44 +0000)]
Remove references to MariaDB from resource files

Issue-ID: POLICY-2086
Change-Id: If38af6a319211c96f8be94f32551dc00b91d6ed1
Signed-off-by: Wayne Dunican <wayne.dunican@est.tech>
2 years agoMerge "Fix intermittent build test error"
Liam Fallon [Wed, 26 Jan 2022 09:52:27 +0000 (09:52 +0000)]
Merge "Fix intermittent build test error"

2 years agoFix intermittent build test error 54/126754/1
saul.gill [Tue, 25 Jan 2022 13:40:27 +0000 (13:40 +0000)]
Fix intermittent build test error

Error visible intermittently in CLM builds
Changed running order of assertions to fix
Intermittent error no loger observed

Issue-ID: POLICY-3893
Change-Id: I27e2c33f298e10f8b9dda85a015258db105043b7
Signed-off-by: saul.gill <saul.gill@est.tech>
2 years agoMerge "Add TOSCA policy status header field to APEX event create CLI"
Liam Fallon [Tue, 25 Jan 2022 14:13:11 +0000 (14:13 +0000)]
Merge "Add TOSCA policy status header field to APEX event create CLI"

2 years agoAdd TOSCA policy status header field to APEX event create CLI 15/126715/3
Rashmi Pujar [Sat, 22 Jan 2022 05:37:28 +0000 (00:37 -0500)]
Add TOSCA policy status header field to APEX event create CLI

In order to expose the processing status of a TOSCA policy
to APEX-PDP, a new header field for APEX concept "event"
has been introduced to track this within an APEX policy
implementation. This field will be leveraged to extract
the TOSCA policy execution metrics. Note, that the field is
marked as optional for backward compatibility.
Unit tests have been augmented to test for the field wherever
applicable and the default empty value is retained for the others.

"example-grpc" module has been updated to include this field.
Exposing the TOSCA policy execution metrics is outside the
scope of this patch since the current changes are already
very large owing to the atomic nature of the change introduced.

Issue-ID: POLICY-3845
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: Ief6d70f9abcfc8414e10aa51a27815ee9028e4c8

2 years agoUpdate to SECCOM recommended dependencies 28/126628/1
liamfallon [Tue, 18 Jan 2022 10:39:06 +0000 (10:39 +0000)]
Update to SECCOM recommended dependencies

SECCOM has issued a directive on which dependencies should be used, see
this wiki page:
https://wiki.onap.org/display/SV/Jakarta+Policy

This is the policy parent review to comply with the SECCOM directive.

Zookeeper is added as a test dependency, it is no longer pulled in as a
transitive dependency by Kafka.

Issue-ID: POLICY-3849
Change-Id: Id504b308cd4e806e9e2e9489842abf1a7f93b9dc
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoAdd newline to end of POM file 78/126578/2
liamfallon [Wed, 12 Jan 2022 16:36:45 +0000 (16:36 +0000)]
Add newline to end of POM file

If the new line is not there, then it breaks the release scripts because
the line count is off.

Issue-ID: POLICY-3835
Change-Id: Ie18070c844d8138b7c6eb4dd74b1c46cfe132846
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "Prometheues metrics for APEX engine stats"
Liam Fallon [Wed, 12 Jan 2022 09:06:24 +0000 (09:06 +0000)]
Merge "Prometheues metrics for APEX engine stats"

2 years agoPrometheues metrics for APEX engine stats 01/126501/4
Rashmi Pujar [Fri, 7 Jan 2022 06:38:40 +0000 (01:38 -0500)]
Prometheues metrics for APEX engine stats

Issue-ID: POLICY-3846
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
Change-Id: I385446683372548f3fed6d609a9e85633ec2916d

2 years agoExclude log4j test dependency 90/126490/1
liamfallon [Thu, 6 Jan 2022 14:32:33 +0000 (14:32 +0000)]
Exclude log4j test dependency

There is a transitive test dependency in apex-pdp on log4j, doesn't show
up in the CLM reports (because it is a test dependency). Removing the
dependency.

Issue-ID: POLICY-3862
Change-Id: Ic9121cf4405678efcf805f711ccb9f36269178d3
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoMerge "Prometheus metrics for policy deploy/undeploy requests for APEX"
Liam Fallon [Fri, 3 Dec 2021 11:23:42 +0000 (11:23 +0000)]
Merge "Prometheus metrics for policy deploy/undeploy requests for APEX"

2 years agoUpdate snapshot and/or references of policy/apex-pdp to latest snapshots 33/126033/1
liamfallon [Thu, 2 Dec 2021 15:54:04 +0000 (15:54 +0000)]
Update snapshot and/or references of policy/apex-pdp to latest snapshots

*** This commit is generated by a PF release script ***

policy/apex-pdp updated to its latest own and reference snapshots

Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: Ifbca56e3e4f3d166e633a2c56f55615aa4bfec6b

2 years agoPrometheus metrics for policy deploy/undeploy requests for APEX 43/125943/4
Rashmi Pujar [Fri, 26 Nov 2021 12:44:23 +0000 (07:44 -0500)]
Prometheus metrics for policy deploy/undeploy requests for APEX

Added counters for:
- Policy deploy/undeploy requests total
- Policy deploy/undeploy successful requests total
- Policy deploy/undeploy failed requests total
Cleaned up unused method resetAllStatistics.
Fixed some checkstyle warnings
Update to latest snapshot for parent, and common modules

Depends on https://gerrit.onap.org/r/c/policy/parent/+/125974 for build to pass.

Issue-ID: POLICY-3760
Change-Id: I4a9447c9caea7a018dba86057b9dae3871910709
Signed-off-by: Rashmi Pujar <rashmi.pujar1@bell.ca>
2 years agoUpdate snapshot of policy/apex-pdp to 2.7.1-SNAPSHOT 61/125961/1
liamfallon [Mon, 29 Nov 2021 11:33:31 +0000 (11:33 +0000)]
Update snapshot of policy/apex-pdp to 2.7.1-SNAPSHOT

*** This commit is generated by a PF release script ***

policy/apex-pdp is update from 2.7.0-SNAPSHOT to 2.7.1-SNAPSHOT

Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I334dda447490f6c3e848be7b58f4a5119ae70ead

2 years agoRelease docker images for policy/apex-pdp: 2.7.0 37/125937/1
liamfallon [Fri, 26 Nov 2021 12:07:42 +0000 (12:07 +0000)]
Release docker images for policy/apex-pdp: 2.7.0

*** This commit is generated by a PF release script ***

This commit releases the docker images for repo policy/apex-pdp.

Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I97c7fdc4118f24c1f72b1028b7d734ccffd5ad7b

2 years agoRelease policy/apex-pdp: 2.7.0 28/125928/1
liamfallon [Fri, 26 Nov 2021 10:41:47 +0000 (10:41 +0000)]
Release policy/apex-pdp: 2.7.0

*** Release Phase 8: This commit is generated by a PF release script ***

This is the eigth phase in releasing images, it releases policy/apex-pdp.

Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I4df10a4c1331f0f2309282743af8455001c8af9f

2 years agoUpdate parent,common.models and docker references 20/125920/1
liamfallon [Thu, 25 Nov 2021 15:50:38 +0000 (15:50 +0000)]
Update parent,common.models and docker references

*** Release Phase 7: This commit is generated by a PF release script ***

This is the seventh release phase, it updates parent, common and models
references in policy/apex-pdp.

Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I501aab4ddf6dbf2ed6700f2ecbf7da80ecaadf3d

2 years agoUpdate parent and common references 13/125913/1
liamfallon [Thu, 25 Nov 2021 11:41:13 +0000 (11:41 +0000)]
Update parent and common references

*** Release Phase 7: This commit is generated by a PF release script ***

This is the seventh release phase, it updates parent, common and models
references in policy/apex-pdp.

Issue-ID: POLICY-3827
Signed-off-by: liamfallon <liam.fallon@est.tech>
Change-Id: I78c4e212e6c330d8a1549038f4c1ec47d6f2b4df

2 years agoPoint to snapshot dependency 42/125342/1
Ram Krishna Verma [Mon, 25 Oct 2021 22:12:16 +0000 (18:12 -0400)]
Point to snapshot dependency

Issue-ID: POLICY-3788
Change-Id: Ia18be8148b1565dff8cb240026ac0ccf280df169
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2 years agoHTTP code filter for RestClientProducer 93/125093/3
lapentafd [Mon, 18 Oct 2021 09:06:31 +0000 (10:06 +0100)]
HTTP code filter for RestClientProducer

RestClient producer can now consider 2xx response status as success

Issue-ID: POLICY-3743
Change-Id: I40c4dce01b437ea6b9f9bbc317835657cb7ebc8a
Signed-off-by: lapentafd <francesco.lapenta@est.tech>
2 years agoBump policy/apex-pdp to Jakarta 2.7.0-SNAPSHOT 64/124964/1
a.sreekumar [Thu, 14 Oct 2021 10:15:57 +0000 (11:15 +0100)]
Bump policy/apex-pdp to Jakarta 2.7.0-SNAPSHOT

Change-Id: I8ead26be4968b94980dcafd269c7ab32022b34d0
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoBump policy/apex-pdp to 2.6.2-SNAPSHOT 50/124950/1
a.sreekumar [Thu, 14 Oct 2021 09:24:25 +0000 (10:24 +0100)]
Bump policy/apex-pdp to 2.6.2-SNAPSHOT

Change-Id: I0db6ab5efb0595cba86ce9cbaaafab88349818ff
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoRelease apex-pdp 2.6.1 docker artifacts 45/124945/1
a.sreekumar [Thu, 14 Oct 2021 08:55:16 +0000 (09:55 +0100)]
Release apex-pdp 2.6.1 docker artifacts

Change-Id: I9cca081a9274922b79c87a1b0e8a96e66d9c4154
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoRelease apex-pdp 2.6.1 maven artifacts 15/124915/1
a.sreekumar [Wed, 13 Oct 2021 17:46:11 +0000 (18:46 +0100)]
Release apex-pdp 2.6.1 maven artifacts

Change-Id: Id9ab217d3623f0726840895e31cb0b1c8fd7fbc7
Issue-ID: POLICY-3696
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoUpdate parent/common/models/docker references 00/124900/1
liamfallon [Wed, 13 Oct 2021 14:29:52 +0000 (15:29 +0100)]
Update parent/common/models/docker references

Issue-ID: POLICY-3696
Change-Id: If4c5290890639fdf99de37501a134f820c92696b
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoAPEX-PDP S3P changes for Istanbul 62/124762/3
a.sreekumar [Fri, 8 Oct 2021 10:57:13 +0000 (11:57 +0100)]
APEX-PDP S3P changes for Istanbul

Change-Id: I58f564ef19df39f2c0fff64a72c9f083faf88556
Issue-ID: POLICY-3655
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoBump apex-pdp to 2.6.1-SNAPSHOT 23/124223/1
a.sreekumar [Wed, 15 Sep 2021 11:05:24 +0000 (12:05 +0100)]
Bump apex-pdp to 2.6.1-SNAPSHOT

Change-Id: Ie39d324e02a302b882318d46735a727322ce409d
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoRelease apex-pdp 2.6.0 docker image 21/124221/1
a.sreekumar [Wed, 15 Sep 2021 10:24:23 +0000 (11:24 +0100)]
Release apex-pdp 2.6.0 docker image

Change-Id: I499837227ddf4ad3df0366763d4aa73c489db78a
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoRelease apex-pdp 2.6.0 maven artifacts 19/124219/1
a.sreekumar [Wed, 15 Sep 2021 09:44:47 +0000 (10:44 +0100)]
Release apex-pdp 2.6.0 maven artifacts

Change-Id: I9a5887991442b40865be818fb876acea104de776
Issue-ID: POLICY-3587
Signed-off-by: a.sreekumar <ajith.sreekumar@bell.ca>
2 years agoUse released common and models 86/124086/1
liamfallon [Mon, 13 Sep 2021 15:43:19 +0000 (16:43 +0100)]
Use released common and models

Issue-ID: POLICY-3587
Change-Id: I11a84934a1a0fc515bf0ae9af9105ba7df19549e
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoRemove blank line from INFO.yaml 10/124010/1
liamfallon [Thu, 9 Sep 2021 20:52:29 +0000 (21:52 +0100)]
Remove blank line from INFO.yaml

Issue-ID: POLICY-3587
Change-Id: If2a9cffb84f8b3d8117a4a9cb338cb1b8964b6cf
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoPoint at released policy-parent 03/124003/1
liamfallon [Thu, 9 Sep 2021 15:05:31 +0000 (16:05 +0100)]
Point at released policy-parent

Issue-ID: POLICY-3587
Change-Id: Iea42a1c281ffd3578a05e3601c0db9836c9d6dfc
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoUpdate INFO.yaml 55/123955/1
liamfallon [Wed, 8 Sep 2021 11:56:48 +0000 (12:56 +0100)]
Update INFO.yaml

Update the INFO.yaml file with latest information.

Issue-ID: POLICY-3552
Change-Id: Ic6842a0325f2f9d45fa769b75baefb0960e872e1
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoUse managed version of commons-codec 28/123928/2
liamfallon [Tue, 7 Sep 2021 14:40:54 +0000 (15:40 +0100)]
Use managed version of commons-codec

apex-pdp was using a very old version of commons-codec. This change
enables it to use the version of commons-codec managed from policy
parent.

Issue-ID: POLICY-3590
Change-Id: Ic29e46b61107719df5aaad00ee923de056fe7bac
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoFix sonar security issues in apex-pdp 53/123853/1
Jim Hahn [Thu, 2 Sep 2021 17:27:40 +0000 (13:27 -0400)]
Fix sonar security issues in apex-pdp

Fixed sonar security issues:
- set permissions of temporary files

Issue-ID: POLICY-3093
Change-Id: I1dfc87f22975fa950cfcfc47196fad55d6cbf277
Signed-off-by: Jim Hahn <jrh3@att.com>
2 years agoFix sonars in apex-pdp #3 69/123769/1
Jim Hahn [Wed, 1 Sep 2021 15:45:05 +0000 (11:45 -0400)]
Fix sonars in apex-pdp #3

Fixed:
- use "var"
- use assertEquals instead of assertTrue(xxx.equals())
- separate assertions

Issue-ID: POLICY-3093
Change-Id: Id4db62626948681cd267e68a56dda65fa355c6f8
Signed-off-by: Jim Hahn <jrh3@att.com>
2 years agoFix sonar issues in apex-pdp 72/123672/5
Ram Krishna Verma [Fri, 27 Aug 2021 20:53:11 +0000 (16:53 -0400)]
Fix sonar issues in apex-pdp

Issue-ID: POLICY-3077
Change-Id: Id5e7c2ddada2bac3b73fe543f9adade6f9b83e6c
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>
2 years agoMerge "Fix sonars in apex-pdp #2"
Jim Hahn [Mon, 30 Aug 2021 15:03:16 +0000 (15:03 +0000)]
Merge "Fix sonars in apex-pdp #2"

2 years agoUse latest policy-parent snapshot 89/123689/1
liamfallon [Mon, 30 Aug 2021 13:26:22 +0000 (14:26 +0100)]
Use latest policy-parent snapshot

The parent snapshot enables the latest version of netty.

Issue-ID: POLICY-3590
Change-Id: I273c7e25988f6190d761ba4300eb56c9f02e3cee
Signed-off-by: liamfallon <liam.fallon@est.tech>
2 years agoFix sonars in apex-pdp #2 69/123669/2
Jim Hahn [Fri, 27 Aug 2021 19:24:06 +0000 (15:24 -0400)]
Fix sonars in apex-pdp #2

plugins-events thru plugins-persistence-jpa-eclipselink

Fixed:
- use "var"
- disambiguate method parameter types
- rename parameter

Issue-ID: POLICY-3093
Change-Id: Ife5897015be495403e731754d5862b803a217c87
Signed-off-by: Jim Hahn <jrh3@att.com>
2 years agoAddress more sonars in apex-pdp 68/123668/2
Jim Hahn [Fri, 27 Aug 2021 18:49:41 +0000 (14:49 -0400)]
Address more sonars in apex-pdp

Fixed services-engine thru utilities.

Fixed:
- use "var"
- use Files.delete()
- only one method call in assert()

Issue-ID: POLICY-3093
Change-Id: I6f62108c770c15e8b84bc51746066fefa409e0fc
Signed-off-by: Jim Hahn <jrh3@att.com>
2 years agoAddress eclipse warnings in apex-pdp 61/123661/2
Jim Hahn [Fri, 27 Aug 2021 15:14:36 +0000 (11:14 -0400)]
Address eclipse warnings in apex-pdp

Fixed:
- deprecated mockito methods
- unused mocks

Issue-ID: POLICY-3093
Change-Id: I20d9aebb2a6390b2a3c95ae9ccc59b710b9e58ce
Signed-off-by: Jim Hahn <jrh3@att.com>
2 years agoFix sonar issues 44/123644/1
Ram Krishna Verma [Thu, 26 Aug 2021 20:22:12 +0000 (16:22 -0400)]
Fix sonar issues

Issue-ID: POLICY-3077
Change-Id: I480b97984754ec4b69c6cde6481510fbbf62252e
Signed-off-by: Ram Krishna Verma <ram_krishna.verma@bell.ca>